- 23 Dec, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b360239..ce4fbca Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d7d7892..7c1d51b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2e63407..2cf76f5 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7e89de601758ee51241e6266f4f8b25437026337 Reviewed-on: https://chromium-review.googlesource.com/c/1390197Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#58456}
-
- 22 Dec, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b61a4fb..b360239 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/0e1cbc4..7d88270 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2f6c18c..d7d7892 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/58649e3..db0055d Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/4685377..2e63407 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I2a4c071fb173e4eb124037d8c4699f65fc79435b Reviewed-on: https://chromium-review.googlesource.com/c/1389775Reviewed-by:
-
- 21 Dec, 2018 37 commits
-
-
Bill Budge authored
- Removes ModuleCompiledCallback typedef and Set function. - Adds WasmStreaming::Client abstraction and Set function. Bug: chromium:719172 Change-Id: I8a207b628394a7660bda73cde560da1e461248a7 Reviewed-on: https://chromium-review.googlesource.com/c/1377450Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#58454}
-
Adam Klein authored
Presumably this was obsoleted when this functionality moved to the BytecodeGenerator. Change-Id: I691fdaa01610ea050511825b5ad1f3ba4963421c Reviewed-on: https://chromium-review.googlesource.com/c/1387991Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#58453}
-
Adam Klein authored
Change-Id: Id4f99539b8583cef56fd33d2e939a2d6024384f9 Reviewed-on: https://chromium-review.googlesource.com/c/1387989Reviewed-by:
-
Sathya Gunasekaran authored
A computed property can never be a private field. That's a SyntaxError. Change the check to a DCHECK. Bug: v8:5368 Change-Id: I6701b60f3193639f3ccffacda25074d32d5de5b8 Reviewed-on: https://chromium-review.googlesource.com/c/1385267Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#58451}
-
Adam Klein authored
Change-Id: I8292b10afd2494199b5db11a5e3d64912cff919b Reviewed-on: https://chromium-review.googlesource.com/c/1387988Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#58450}
-
Adam Klein authored
NATIVE_CONTEXT_IMPORTED_FIELDS are no longer different from other NATIVE_CONTEXT_FIELDS, so this CL joins them together. While doing so, removed the OBJECT_VALUE_OF slot, which is not referenced anywhere. Change-Id: I79c46e6e6cc92c90e90e68165cf7b0ae31e8151d Reviewed-on: https://chromium-review.googlesource.com/c/1387631Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#58449}
-
Adam Klein authored
%AddNamedProperty was only used by regression tests, and is easily replaced by Object.defineProperty (or deleted, in the case of a cctest that was designed to test it directly). %AddElement was unused (probably due to the death of array.js). Bug: v8:7624 Change-Id: Icc17fd7a7419aa649275414a351f176f104040e2 Reviewed-on: https://chromium-review.googlesource.com/c/1387990Reviewed-by:
-
Adam Klein authored
Change-Id: I8283ddf96dc178f12e52d9412db1858acfe46650 Reviewed-on: https://chromium-review.googlesource.com/c/1387966Reviewed-by:
-
Maya Lekova authored
This reverts commit 3411e7c3. Reason for revert: Breaks test expecations - https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/260731 Original change's description: > [parser] Create arrow function scopes while parsing the head > > This simplifies NextArrowFunctionInfo, allows us to Scope::Snapshot::Reparent > directly rather than moving it, and allows us to skip reparenting in the simple > parameter arrow function cases. > > This CL additionally fixes arrow function name inferring. > > Change-Id: Ie3e5ea778f3d7b84b2a10d4f4ff73931cfc9384a > Reviewed-on: https://chromium-review.googlesource.com/c/1386147 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58405} TBR=ishell@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I8f31b96f844f0673364bf435fa6c809e40d62fa3 Reviewed-on: https://chromium-review.googlesource.com/c/1388541Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#58446}
-
Toon Verwaest authored
Always pass in the target scope for the body, and check whether we're in LexicalVariableMode instead to distinguish for(let/const from for(var. Change-Id: Idf59423466f45eebe7c9d716f8eb6ccd92235abc Reviewed-on: https://chromium-review.googlesource.com/c/1388534Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#58445}
-
Sigurd Schneider authored
This CL makes both absolute address and opcode literal (byte sequence of the instruction) display optional, which improves readability. Additionally, jump offsets are parsed and can now once again be clicked. TBR=neis@chromium.org Bug: v8:7327 Notry: true Change-Id: I709f44540b32f6d4afabdd1e5eb27e932208e7fc Reviewed-on: https://chromium-review.googlesource.com/c/1388540 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58444}
-
Jakob Gruber authored
This changes a few bits about how continuation counters are handled. It introduces a new mechanism that allows removal of a continuation range after it has been created. If coverage is enabled, we run a first post-processing pass on the AST immediately after parsing, which removes problematic continuation ranges in two situations: 1. nested continuation counters - only the outermost stays alive. 2. trailing continuation counters within a block-like structure are removed if the containing structure itself has a continuation. R=bmeurer@chromium.org, jgruber@chromium.org, yangguo@chromium.org Bug: v8:8381, v8:8539 Change-Id: I6bcaea5060d8c481d7bae099f6db9f993cc30ee3 Reviewed-on: https://chromium-review.googlesource.com/c/1339119Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58443}
-
George Wort authored
Ensure that GetUnusedRegister is always called before acquiring the scratch register in case it is needed for spilling the value of the used register. Bug: v8:6600, chromium:910824 Change-Id: I93ae684ad504584807dfa6227b6af14609c6bcf5 Reviewed-on: https://chromium-review.googlesource.com/c/1387498Reviewed-by:
-
Camillo Bruni authored
- Use overflow-proof HasRemainingBytes - Add DCHECK to catch index_ OOB in RemainingBytes Change-Id: I65c47c42438c93c9b4673f09fed4b8ef4685f257 Reviewed-on: https://chromium-review.googlesource.com/c/1388535Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#58441}
-
Jakob Gruber authored
This CL does two things: 1. It introduces Call/JumpCodeObject as the bottleneck for all calls to non-heap-constant Code objects; and 2. it dispatches directly to the off-heap entry point for all embedded code. Codegen at runtime remains unchanged to preserve the shorter, branch-less calling sequence. Bug: v8:7777 Change-Id: I15fdcb51625209904c6a56737f085a23219319b9 Reviewed-on: https://chromium-review.googlesource.com/c/1382461 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#58440}
-
Ulan Degenbaev authored
Since code serializer also serializers descriptor arrays, the clearing has to be done in deserializer. Bug: v8:8486 Change-Id: Ic2c5848e5add80176a6f7191c56e7af9e9a6019f Reviewed-on: https://chromium-review.googlesource.com/c/1388532Reviewed-by:
-
Ulan Degenbaev authored
This also adjusts debug printing of descriptor arrays and adds a check to the code serializer. Bug: v8:8617 Tbr: mlippautz@chromium.org Change-Id: Ic04f01abf9f7ed5a310b9e51a22c04fda108f563 Reviewed-on: https://chromium-review.googlesource.com/c/1387501 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This is a reland of f63a657e Original change's description: > [deoptimizer] Refactor GenerateDeoptimizationEntries > > This reduces preprocessor-expanded source size by 64,359 from > > gen ( 21 files): 71,570 to 1,613,100 ( 23x) > src ( 624 files): 367,830 to 52,964,659 ( 144x) > test ( 392 files): 490,924 to 37,360,916 ( 76x) > third_party ( 432 files): 239,085 to 9,547,902 ( 40x) > total ( 1521 files): 1,184,093 to 102,461,098 ( 87x) > > to > > gen ( 21 files): 71,570 to 1,613,100 ( 23x) > src ( 624 files): 367,837 to 52,919,005 ( 144x) > test ( 392 files): 490,924 to 37,342,211 ( 76x) > third_party ( 432 files): 239,085 to 9,547,902 ( 40x) > total ( 1521 files): 1,184,100 to 102,396,739 ( 86x) > > Bug: v8:8562 > Change-Id: Iee474e22ababa1e080b8d6359af4d0076903e59a > Reviewed-on: https://chromium-review.googlesource.com/c/1384091 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58424} TBR=jarin@chromium.org,ulan@chromium.org Bug: v8:8562 Change-Id: I7a8a350414941f49c6155ff43e36e0cb0b2006e5 Reviewed-on: https://chromium-review.googlesource.com/c/1387497Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58437}
-
Maya Lekova authored
This reverts commit 2963f1b2. Reason for revert: Speculative revert, possibly causing timeout in layout test https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Linux%20Trusty%20MSAN/11631 Original change's description: > [parser] Simplify ParseFunctionBody > > - Merge is_simple branches at the top > - Remove block around inner_body parsing. Always merge fully at the end. > - Remove conditional inner block adding to outer body. Simply add it to the > inner body making merge push it to the parent. > > Change-Id: I1f062918a7abac354b949136463517bd0440984f > Reviewed-on: https://chromium-review.googlesource.com/c/1386111 > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58390} TBR=ishell@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I0ab903df5caaadff56625e9b46b03981c8a9b930 Reviewed-on: https://chromium-review.googlesource.com/c/1388524Reviewed-by:
-
Clemens Hammacher authored
Before computing the merge state, compute the list of free registers. This list is used when we need a register for ensuring single register use. It avoids picking a register which is in use by a not-yet-visited merge slot, which would then have to be moved to another register or to the stack. On epic, this saves ~10.5% generated code size in Liftoff. R=herhut@chromium.org Bug: v8:8423 Change-Id: If9fac24abbfe2273bf18d9cb287c7c05a59b2118 Reviewed-on: https://chromium-review.googlesource.com/c/1387488 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#58435}
-
Mike Stanton authored
It's nice to have a quick way to get stable results on the local machine for the classic d8 benchmarks. CSuite revitalizes an old tool called BSuite which offers multiple averaged runs, and a nice ascii display of results. Sample usage: ./csuite.py octane baseline ~/src/v8/out/d8 ./csuite.py octane compare ~/src/v8/out-mine/d8 benchmark: score | master | % | ===================================================+==========+========+ Richards: 26201.0 | 26568.0 | -1.4 | DeltaBlue: 55744.0 | 58309.0 | -4.4 | Crypto: 31831.0 | 31815.0 | | RayTrace: 73481.0 | 73185.0 | 0.4 | ............<snip>............................ Octane: 36388.0 | 35741.0 | 1.8 | ---------------------------------------------------+----------+--------+ See README.md for more documentation. Change-Id: I182490506ca07fab1240bd485bd1d7a8920db893 Reviewed-on: https://chromium-review.googlesource.com/c/1387487 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58434}
-
Jakob Gruber authored
This defines V8_JITLESS_MODE if the v8_enable_lite_mode build-time option is enabled. Jitless mode will thus be tested by existing lite bots. The build-time option for jitless mode will only be needed temporarily and is expected to be removed again in the near future. Bug: v8:7777 Change-Id: I556ba5069dbd0810a6d7376601d8f7d498fef8c9 Reviewed-on: https://chromium-review.googlesource.com/c/1387499Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58433}
-
Toon Verwaest authored
That way we can drop PatternRewriter::scope_ and just use parser_->scope() instead. Change-Id: I66137d3ff8e7b805afc7108fd2d55537f69f11e6 Reviewed-on: https://chromium-review.googlesource.com/c/1387500Reviewed-by:
-
Maya Lekova authored
This reverts commit b3c85c9e. Reason for revert: Causing Check failures on Android - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Android%20Arm64%20-%20N5X/2391 Original change's description: > [tools] Pass large_output to avoid re-running tests that generate lots of output > > R=machenbach@chromium.org > > Bug: chromium:893593 > Change-Id: Ic3a3612fc557b1f35b4632cfab553b4492ec6222 > Reviewed-on: https://chromium-review.googlesource.com/c/1382734 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58399} TBR=machenbach@chromium.org,sergiyb@chromium.org Change-Id: I8ac42d1b53ce5840e80071625466135999a3c42c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:893593 Reviewed-on: https://chromium-review.googlesource.com/c/1387502Reviewed-by:
-
Clemens Hammacher authored
This silences the new presubmit check for the whole src/wasm directory. This change uncovered that MSVC is a bit behind with noexcept annotations on standard containers. This makes all implicit constructors and assignment operators noexcept(false) if the class contains any standard container. Thus disable noexcept on MSVC for now. R=tebbi@chromium.org CC=marja@chromium.org Bug: v8:8616, v8:7999 Change-Id: Ica86ac84a5b8a835dcea9b783c7987d9b850241a Reviewed-on: https://chromium-review.googlesource.com/c/1386869 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#58430}
-
Clemens Hammacher authored
This replaces another use of std::vector. Stack states (consisting of locals plus operand stack) are also typically small, thus optimize for those cases. Using StackVector as part of CacheState requires the definition of move constructors and copy constructors, plus a few other methods. R=tebbi@chromium.org Bug: v8:8423 Change-Id: I5d39c1ebc4d6d65e4849dd06c556114cd2cd36ff Reviewed-on: https://chromium-review.googlesource.com/c/1380053 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Camillo Bruni authored
- Mark Serialize method as non-virtual - Use simple scheme to mask out bytes when de-/serializing Uint32 - Improve ByteArray::ByteArrayPrint method Drive-by-fix: Change-Id: I9a6779587c0a031bcf23e4f431d17026b83a808d Reviewed-on: https://chromium-review.googlesource.com/c/1387493Reviewed-by:
-
Toon Verwaest authored
Change-Id: I9446a73bb47b11e2d161a4678638b7618ce52b9a Reviewed-on: https://chromium-review.googlesource.com/c/1387490Reviewed-by:
-
Igor Sheludko authored
Bug: v8:8477, v8:8562 Change-Id: I28a8244ef22035db85b520d86aa6d5578c7c7f5d Reviewed-on: https://chromium-review.googlesource.com/c/1384309 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This reverts commit f63a657e. Reason for revert: breaks compile on lite mode: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8926535782549686576/+/steps/build/0/steps/compile/0/stdout Original change's description: > [deoptimizer] Refactor GenerateDeoptimizationEntries > > This reduces preprocessor-expanded source size by 64,359 from > > gen ( 21 files): 71,570 to 1,613,100 ( 23x) > src ( 624 files): 367,830 to 52,964,659 ( 144x) > test ( 392 files): 490,924 to 37,360,916 ( 76x) > third_party ( 432 files): 239,085 to 9,547,902 ( 40x) > total ( 1521 files): 1,184,093 to 102,461,098 ( 87x) > > to > > gen ( 21 files): 71,570 to 1,613,100 ( 23x) > src ( 624 files): 367,837 to 52,919,005 ( 144x) > test ( 392 files): 490,924 to 37,342,211 ( 76x) > third_party ( 432 files): 239,085 to 9,547,902 ( 40x) > total ( 1521 files): 1,184,100 to 102,396,739 ( 86x) > > Bug: v8:8562 > Change-Id: Iee474e22ababa1e080b8d6359af4d0076903e59a > Reviewed-on: https://chromium-review.googlesource.com/c/1384091 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58424} TBR=ulan@chromium.org,jarin@chromium.org,sigurds@chromium.org Change-Id: I06e6f95255a3cea6a428713e9e841781425dffe8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8562 Reviewed-on: https://chromium-review.googlesource.com/c/1387494Reviewed-by:
-
Sigurd Schneider authored
This reduces preprocessor-expanded source size by 64,359 from gen ( 21 files): 71,570 to 1,613,100 ( 23x) src ( 624 files): 367,830 to 52,964,659 ( 144x) test ( 392 files): 490,924 to 37,360,916 ( 76x) third_party ( 432 files): 239,085 to 9,547,902 ( 40x) total ( 1521 files): 1,184,093 to 102,461,098 ( 87x) to gen ( 21 files): 71,570 to 1,613,100 ( 23x) src ( 624 files): 367,837 to 52,919,005 ( 144x) test ( 392 files): 490,924 to 37,342,211 ( 76x) third_party ( 432 files): 239,085 to 9,547,902 ( 40x) total ( 1521 files): 1,184,100 to 102,396,739 ( 86x) Bug: v8:8562 Change-Id: Iee474e22ababa1e080b8d6359af4d0076903e59a Reviewed-on: https://chromium-review.googlesource.com/c/1384091Reviewed-by:
-
Sigurd Schneider authored
Disassembly selections now work even if no origin node is associated with the disassembly code range that the user selects. TBR=neis@chromium.org Bug: v8:7327 Change-Id: Ib5bfcaded66deb65314fde7d3cb9ed2c3c4f6fe9 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/1387492Reviewed-by:
-
Maya Lekova authored
This reverts commit d045f666. Reason for revert: Probably causing a timeout on Android bots - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Android%20Arm64%20-%20N5X/2393 Original change's description: > [tools] Push files using high-level device.PushChangedFiles method > > R=machenbach@chromium.org > > No-Try: true > Bug: chromium:893593 > Change-Id: I11cce7694eb7755ccee42c9a342fc1aa22663d85 > Reviewed-on: https://chromium-review.googlesource.com/c/1382468 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58407} TBR=machenbach@chromium.org,sergiyb@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: I23b0a5ef9fb6c1cca56e4b4bfe44fdfe4b80a390 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:893593 Reviewed-on: https://chromium-review.googlesource.com/c/1387489Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7327 Notry: true Change-Id: Ia1c2164269d3d656b951d46debe42a811a6d9c89 Reviewed-on: https://chromium-review.googlesource.com/c/1386494Reviewed-by:
-
Clemens Hammacher authored
Since FallThruTo is often followed by PopControl, we can save a few cache state copy operations in Liftoff by merging the two. On epic workloads, this saves ~18% of Steal operations and ~22% of Split operations. R=herhut@chromium.org Bug: v8:8423 Change-Id: I99900eaa49ae14ead6a0c08b69da2175730e077e Reviewed-on: https://chromium-review.googlesource.com/c/1384093Reviewed-by:
-
Jakob Gruber authored
This is a reland of 0e22ec73 Original change's description: > [regexp] Escape newlines when setting [[OriginalSource]] > > This escapes LineTerminator characters in a regexp pattern when > creating the string that will be stored in the [[OriginalSource]] slot. > > As an example, the source property for all following objects will equal > "\n" (a '\' character followed by 'n'): > > /\n/ > new RegExp("\n") > new RegExp("\\n") > > Bug: v8:1982, chromium:855009 > Change-Id: I3b539497a0697e3d51ec969cae49308b0b312a19 > Reviewed-on: https://chromium-review.googlesource.com/c/1384316 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58387} Bug: v8:1982, chromium:855009 Change-Id: I1ba22395477ec37e8e8c944000f9beade1e3250b Reviewed-on: https://chromium-review.googlesource.com/c/1386495Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4f828d0..b61a4fb Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7d95d86..2f6c18c Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/2cc6e25..58649e3 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c8e8d67..4685377 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib98360f93dd1f94beff56fca3f37e687c65748ca Reviewed-on: https://chromium-review.googlesource.com/c/1387998Reviewed-by:
-
- 20 Dec, 2018 1 commit
-
-
Ulan Degenbaev authored
This fixes a bug from 0400fc20, which assumed that we can set the markbits and the marked descriptors counter independently. This does not work because the Scavenger skips slots recording for non-black promoted objects. The fix is to mark the descriptor array black whenever we change the marked descriptors counter. Bug: v8:8617, v8:8618, v8:8486 Tbr: mlippautz@chromium.org Change-Id: I80f3488061fa648b6c81963ba802ef045d92bcc6 Reviewed-on: https://chromium-review.googlesource.com/c/1387486 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
