Commits · acc4edead2755f71192915f5bfd6cc24e134f857 · Linshizhi / V8

13 Jul, 2012 9 commits

MIPS: Defer creating Handles for HConstants to the code generation phase. · acc4edea

sanjoy@chromium.org authored Jul 13, 2012

Port r12048 (b4b20305)

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10692193
Patch from Akos Palfi <palfia@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12080 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

acc4edea

Handle setters on the prototype chain efficiently by default. · 65e7a149

svenpanne@chromium.org authored Jul 13, 2012

Note that changes on the prototype chain should already be handled by
StubCompiler::CheckPrototypes, if not, it is a bug there and not in
LookupForWrite. Furthermore, neither test262 nor WebKit layout tests hint at a
compability issue, so it should be safe to remove a redundant check.

The good point about this CL: It improves Box2D's performance by 22%.

Review URL: https://chromiumcodereview.appspot.com/10695197

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12079 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

65e7a149

Incorporate constness into inferred interfaces · ec042177

rossberg@chromium.org authored Jul 13, 2012

(in preparation for handling imports).

R=svenpanne@chromium.org
BUG=v8:1569
TEST=

Review URL: https://chromiumcodereview.appspot.com/10698167

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12078 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ec042177

Fix Mac build warning (very rightful) · 58c4e6ce

peter.rybin@gmail.com authored Jul 13, 2012

Review URL: https://chromiumcodereview.appspot.com/10702201

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12077 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

58c4e6ce

MIPS: Ensure that all descriptors have a valid enumeration index, and replace... · d51b6826

verwaest@chromium.org authored Jul 13, 2012

MIPS: Ensure that all descriptors have a valid enumeration index, and replace NextEnumIndex with LastAdded.

Port r12042 (ce65764e)

Original commit message:
The LastAdded points to the descriptor that was last added to the array. From the descriptor we can deduce the NextEnumerationIndex. This allows us to quickly find the property that we are transitioning to, which is necessary for transition-intensive code, eg JSON parsing.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10690178
Patch from Akos Palfi <palfia@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12076 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d51b6826

MIPS: Swap bitfield3 and backpointer. · e8753060

verwaest@chromium.org authored Jul 13, 2012

Port r12034 (f17b84c0)

Original commit message:
Bitfield3 now has its own field, while the backpointer shares the field with the descriptor array; which will become the transition array.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10692192
Patch from Akos Palfi <palfia@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12075 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e8753060

Don't miss error message in 'restart frame' debug action · ed371d48

peter.rybin@gmail.com authored Jul 13, 2012

Review URL: https://chromiumcodereview.appspot.com/10693095

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12074 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ed371d48

MIPS: Fixed mistake in condition for Nan fixups from snapshot. · 45d86e48

yangguo@chromium.org authored Jul 13, 2012

The commit r11871 caused quiet NaN related errors to
appear on Loongson and Sigma platforms when snapshot
is used. This commit fixes those issues.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10735080
Patch from Akos Palfi <palfia@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12073 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

45d86e48

Added Crankshaft support for setters. · 43e87a65

svenpanne@chromium.org authored Jul 13, 2012

Refactored ComputeLoadStoreField a bit on the way to clarify a bit what it
actually does.

Review URL: https://chromiumcodereview.appspot.com/10692187

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12072 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

43e87a65

12 Jul, 2012 14 commits

Renamed ConvertDescriptorToFieldAndMapTransition to... · 70a61830

verwaest@chromium.org authored Jul 12, 2012

Renamed ConvertDescriptorToFieldAndMapTransition to ConvertTransitionToMapTransition, and let it replace the transition in-place rather than copy the transition array.

Review URL: https://chromiumcodereview.appspot.com/10694155

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12071 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

70a61830

Revert 12069: Implements a new API to set a function entry hook for profiling · 30569cba

danno@chromium.org authored Jul 12, 2012

Reverted due to waterfall failures

TBR=mstarzinger@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10704189

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12070 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

30569cba

Implements a new API to set a function entry hook for profiling. · d6edbdd4

danno@chromium.org authored Jul 12, 2012

Exposes a new API; V8::SetFunctionEntryHook.
If a non-NULL function entry hook is set, the code generator(s) will invoke on the entry hook at the very start of each generated function.

Review URL: https://chromiumcodereview.appspot.com/10706002
Patch from Sigurður Ásgeirsson <siggi@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12069 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d6edbdd4

Install guards for new invariants required for parallel compilation. · 2b0f88cc

sanjoy@chromium.org authored Jul 12, 2012

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10700185

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12068 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2b0f88cc

Rename LChunkBase to LChunk, LChunk to LPlatformChunk and remove some unneeded... · 31027880

sanjoy@chromium.org authored Jul 12, 2012

Rename LChunkBase to LChunk, LChunk to LPlatformChunk and remove some unneeded explicit constructor attributes.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10701157

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

31027880

Couple the enumeration index of a property to the size of the descriptor array... · 812bc1db

verwaest@chromium.org authored Jul 12, 2012

Couple the enumeration index of a property to the size of the descriptor array where it first appeared.

Review URL: https://chromiumcodereview.appspot.com/10692185

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12066 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

812bc1db

When we find an accessor pair as TRANSITION, we are sure it doesn't contain an accessor yet. · 1068916b

verwaest@chromium.org authored Jul 12, 2012

Review URL: https://chromiumcodereview.appspot.com/10704185

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12065 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1068916b

Break Crankshaft into phases. · c1ee1b45

sanjoy@chromium.org authored Jul 12, 2012

Crankshaft now runs by calling CreateGraph on the HGraphBuilder, then
calling Optimize and Codegen on the HGraph.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10700115

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12064 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c1ee1b45

Always return failure when we didn't manage to add transitions. · 1132b27e

verwaest@chromium.org authored Jul 12, 2012

Review URL: https://chromiumcodereview.appspot.com/10704183

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12063 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1132b27e

Splitting DescriptorArray::CopyInsert into CopyInsert, CopyAdd and CopyReplace. · 0a41b8c2

verwaest@chromium.org authored Jul 12, 2012

Review URL: https://chromiumcodereview.appspot.com/10743003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12060 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0a41b8c2

Do not enter the debugger when debugger is not active. · 8ce1ebb5

yangguo@chromium.org authored Jul 12, 2012

R=mstarzinger@chromium.org
BUG=
TEST=test-debug/DebuggerCreatesContextIffActive

Review URL: https://chromiumcodereview.appspot.com/10702166

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12059 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8ce1ebb5

Prepare push to trunk. Now working on version 3.12.12. · b6a6ef9a

rossberg@chromium.org authored Jul 12, 2012

R=svenpanne@chromium.org
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10703164

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12056 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b6a6ef9a

Perform HasFastProperties check on prototypes when computing call targets in Crankshaft, part 2. · b8a7abd1

svenpanne@chromium.org authored Jul 12, 2012

The previous fix was for "real" calls, this one is for getters. It is a bit
unfortunate that this has to be fixed twice: We should really break up
Call::ComputeTarget into a predicate and 1 or 2 getters, so code can be reused.

The regression test has been modified a bit to make things more uniform.

Review URL: https://chromiumcodereview.appspot.com/10702164

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12053 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b8a7abd1

Fix bug in CompilationHandlescope constructor. · e26128ac

sanjoy@chromium.org authored Jul 12, 2012

This will never be triggered in the state v8 is currently in, but will crash v8 when multiple DeferredHandles are queued up during parallel compilation.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10696178

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12050 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e26128ac

11 Jul, 2012 14 commits

Unbreak MSVC build by respecting explicit FmtElm constructor. This is · caef7f10

sanjoy@chromium.org authored Jul 11, 2012

a real bug caught by MSVC but not g++.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10700162

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12049 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

caef7f10

Defer creating Handles for HConstants to the code generation phase. · 5765fa25

sanjoy@chromium.org authored Jul 11, 2012

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10544196

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12048 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5765fa25

MIPS: Rename "mips" arch to "mipsel" in the GYP build. · 2f43f5e9

jkummerow@chromium.org authored Jul 11, 2012

In the traditional MIPS naming scheme, "mips" is used for
big-endian mips and "mipsel" is used for little-endian mips.
In V8 the "mips" build is little-endian, so the "mips" target is
renamed to "mipsel" to be compliant with the traditional MIPS
naming scheme.

This change is also required for supporting the Chromium project on MIPS.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10695114

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12047 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2f43f5e9

Add missing --allow-natives-syntax flag to test case · 0c4cc038

jkummerow@chromium.org authored Jul 11, 2012

R=rossberg@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10698152

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12046 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0c4cc038

Remove duplicated LChunk code. · 951b64d5

sanjoy@chromium.org authored Jul 11, 2012

Divide the LChunk class into an arch-independent LChunkBase and an
arch-dependent LChunk which inherits from LChunkBase.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10701141

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12045 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

951b64d5

Refactor copying of maps and descriptor arrays. · ef701cb7

verwaest@chromium.org authored Jul 11, 2012

Mainly ensure we don't copy descriptor arrays we'll throw away immediately afterwards.

Review URL: https://chromiumcodereview.appspot.com/10700160

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12044 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ef701cb7

Perform HasFastProperties check on prototypes when computing call targets in Crankshaft. · 432576b7

jkummerow@chromium.org authored Jul 11, 2012

BUG=125148
TEST=mjsunit/regress/regress-crbug-125148

Review URL: https://chromiumcodereview.appspot.com/10735054

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12043 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

432576b7

Ensure that all descriptors have a valid enumeration index, and replace... · b008d99b

verwaest@chromium.org authored Jul 11, 2012

Ensure that all descriptors have a valid enumeration index, and replace NextEnumIndex with LastAdded.

The LastAdded points to the descriptor that was last added to the array. From the descriptor we can deduce the NextEnumerationIndex. This allows us to quickly find the property that we are transitioning to, which is necessary for transition-intensive code, eg JSON parsing.

Review URL: https://chromiumcodereview.appspot.com/10695120

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12042 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b008d99b

Turn off es5_readonly again: still causes ~370 WebKit regressions. · dcf83a21

rossberg@chromium.org authored Jul 11, 2012

R=mstarzinger@chromium.org
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10693145

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12041 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dcf83a21

Do not use user-defined __lookupGetter__ when generating stack trace. · 2a819667

yangguo@chromium.org authored Jul 11, 2012

BUG=v8:1591
TEST=regress-1591.js

Review URL: https://chromiumcodereview.appspot.com/10736030

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12040 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2a819667

Fix compile errors in Visual C++ 2008. · 5b2a27aa

danno@chromium.org authored Jul 11, 2012

R=danno@chromium.org
BUG=None
TEST=ARM compiles on VC 2008.

Review URL: https://chromiumcodereview.appspot.com/10690111
Patch from Sigurður Ásgeirsson <siggi@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12039 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5b2a27aa

Turn on es5[2] features by default. · 2ce9624d

rossberg@chromium.org authored Jul 11, 2012

R=mstarzinger@chromium.org
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10689156

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12038 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2ce9624d

Re-land "Removed one copy-n-paste clone of HGraphBuilder::BuildStoreNamed." · b3422df4

svenpanne@chromium.org authored Jul 11, 2012

The previous CL used the wrong map in some cases, leading to a wrong decision
regarding monomorphic usage and therefore some performance regressions.

Review URL: https://chromiumcodereview.appspot.com/10694129

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12037 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b3422df4

Sync preparser and parser wrt syntax error in switch..case. · b2f1c412

yangguo@chromium.org authored Jul 11, 2012

R=jkummerow@chromium.org
BUG=v8:2210
TEST=test-parsing/ParserSync

Review URL: https://chromiumcodereview.appspot.com/10701116

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12036 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b2f1c412

10 Jul, 2012 3 commits

Port r11344 (Try aligning unboxed double array backing store in allocation or · 299a0ab1

danno@chromium.org authored Jul 10, 2012

scavenge promotion.) to ARM.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10696097
Patch from Rodolph Perfetta <rodolph.perfetta@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

299a0ab1

Swap bitfield3 and backpointer. · 45419ee1

verwaest@chromium.org authored Jul 10, 2012

Bitfield3 now has its own field, while the backpointer shares the field with the descriptor array; which will become the transition array.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10692130

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12034 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

45419ee1

Update .gitignore for Windows/Visual Studio/GYP. · 1c62d72a

danno@chromium.org authored Jul 10, 2012

BUG=None
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10701115
Patch from Sigurður Ásgeirsson <siggi@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12033 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1c62d72a