1. 23 May, 2019 1 commit
  2. 22 May, 2019 1 commit
  3. 21 May, 2019 1 commit
  4. 20 May, 2019 1 commit
  5. 17 May, 2019 2 commits
  6. 29 Apr, 2019 1 commit
    • Clemens Hammacher's avatar
      [cleanup] Use Vector::begin instead of Vector::start · 4b0f9c85
      Clemens Hammacher authored
      Our {Vector} template provides both {start} and {begin} methods. They
      return exactly the same value. Since the {begin} method is needed for
      iteration, and is also what standard containers provide, this CL
      switches all uses of the {start} method to use {begin} instead.
      
      Patchset 1 was auto-generated by using this clang AST matcher:
          callExpr(
              callee(
                cxxMethodDecl(
                  hasName("start"),
                  ofClass(hasName("v8::internal::Vector")))
              ),
              argumentCountIs(0))
      
      Patchset 2 was created by running clang-format. Patchset 3 then
      removes the now unused {Vector::start} method.
      
      R=jkummerow@chromium.org
      TBR=mstarzinger@chromium.org,yangguo@chromium.org,verwaest@chromium.org
      
      Bug: v8:9183
      Change-Id: Id9f01c92870872556e2bb3f6d5667463b0e3e5c6
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587381Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61081}
      4b0f9c85
  7. 20 Mar, 2019 1 commit
  8. 15 Feb, 2019 1 commit
  9. 08 Dec, 2018 1 commit
  10. 13 Nov, 2018 1 commit
  11. 11 Oct, 2018 1 commit
  12. 21 Sep, 2018 1 commit
  13. 03 Aug, 2018 1 commit
  14. 16 Jul, 2018 3 commits
    • Leszek Swirski's avatar
      [sfi] Remove SFI function literal id field (reland^2) · 5dee5ade
      Leszek Swirski authored
      SharedFunctionInfos store their original function literal's id. This is
      also their index in the Script's SFI list.
      
      The function literal id is only needed for lazy compilation and live edit,
      and access only has to be fast in the former. So, we can move the SFI
      function literal id field to UncompiledData, and if patching with live
      edit, or discarding compiled code, we can perform a slower linear search
      through the Script's SFI list.
      
      This is a reland of
       1) https://chromium-review.googlesource.com/1082480 and
       2) https://chromium-review.googlesource.com/1128854
      the differences being:
       1) caching the literal id on UncompiledData rather than always linearly
          searching the SFI list, and removing the unused runtime-liveedit.cc
          file instead of fixing it to support this change.
       2) clearing padding on UncompiledData now that it has 3 int32 fields,
          making its end unaligned on x64.
      
      TBR=yangguo@chromium.org,marja@chromium.org,ulan@chromium.org,cbruni@chromium.org
      
      Bug: chromium:818642
      Change-Id: I58dcb12a2a60a680f662568da428e01189c62638
      Reviewed-on: https://chromium-review.googlesource.com/1138325Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54473}
      5dee5ade
    • Sigurd Schneider's avatar
      Revert "[sfi] Remove SFI function literal id field" · 58578584
      Sigurd Schneider authored
      This reverts commit 1d4a1172.
      
      Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/21989
      
      Original change's description:
      > [sfi] Remove SFI function literal id field
      > 
      > SharedFunctionInfos store their original function literal's id. This is
      > also their index in the Script's SFI list.
      > 
      > The function literal id is only needed for lazy compilation and live edit,
      > and access only has to be fast in the former. So, we can move the SFI
      > function literal id field to UncompiledData, and if patching with live
      > edit, or discarding compiled code, we can perform a slower linear search
      > through the Script's SFI list.
      > 
      > This is a reland of
      > https://chromium-review.googlesource.com/c/v8/v8/+/1082480
      > but caching the literal id on UncompiledData rather than always linearly
      > searching the SFI list. Also, removes the unused runtime-liveedit.cc file
      > instead of fixing it to support this change.
      > 
      > Bug: chromium:818642
      > Change-Id: I977bcca0dc72903ca476a7079d156cc8bbe88fde
      > Reviewed-on: https://chromium-review.googlesource.com/1128854
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Marja Hölttä <marja@chromium.org>
      > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#54464}
      
      TBR=ulan@chromium.org,marja@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,cbruni@chromium.org,leszeks@chromium.org,verwaest@chromium.org
      
      Change-Id: Icee5ee3ab7688b93e2963f91debed65a58164534
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:818642
      Reviewed-on: https://chromium-review.googlesource.com/1138276Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
      Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54466}
      58578584
    • Leszek Swirski's avatar
      [sfi] Remove SFI function literal id field · 1d4a1172
      Leszek Swirski authored
      SharedFunctionInfos store their original function literal's id. This is
      also their index in the Script's SFI list.
      
      The function literal id is only needed for lazy compilation and live edit,
      and access only has to be fast in the former. So, we can move the SFI
      function literal id field to UncompiledData, and if patching with live
      edit, or discarding compiled code, we can perform a slower linear search
      through the Script's SFI list.
      
      This is a reland of
      https://chromium-review.googlesource.com/c/v8/v8/+/1082480
      but caching the literal id on UncompiledData rather than always linearly
      searching the SFI list. Also, removes the unused runtime-liveedit.cc file
      instead of fixing it to support this change.
      
      Bug: chromium:818642
      Change-Id: I977bcca0dc72903ca476a7079d156cc8bbe88fde
      Reviewed-on: https://chromium-review.googlesource.com/1128854Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
      Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54464}
      1d4a1172
  15. 09 Jul, 2018 1 commit
  16. 05 Jul, 2018 1 commit
  17. 03 Jul, 2018 1 commit
  18. 23 Jun, 2018 1 commit
  19. 07 Jun, 2018 1 commit
    • Leszek Swirski's avatar
      Revert "[sfi] Remove SFI function literal id field" · b6888b63
      Leszek Swirski authored
      This reverts commit ceb9c812.
      
      Reason for revert: Tanks compile time
      
      Original change's description:
      > [sfi] Remove SFI function literal id field
      > 
      > SharedFunctionInfos store their original function literal's id. This is
      > also their index in the Script's SFI list.
      > 
      > Since the function literal id is only needed for lazy compilation and live
      > edit, we can calculate it on-the-fly by linear search in the Script SFI list,
      > and save a field on the SFI.
      > 
      > If this regresses compile performance, we could alternatively store the
      > function literal id on the preparsed scope data as future work.
      > 
      > Bug: chromium:818642
      > Change-Id: I5468cea0e115921f1c864d94e567d749a4349882
      > Reviewed-on: https://chromium-review.googlesource.com/1082480
      > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      > Reviewed-by: Hannes Payer <hpayer@chromium.org>
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#53523}
      
      TBR=hpayer@chromium.org,leszeks@chromium.org,verwaest@chromium.org
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: chromium:818642
      Bug: chromium:850417
      Change-Id: If2fd21331b7062532c04004a51e705f7e9d0a151
      Reviewed-on: https://chromium-review.googlesource.com/1090494Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53573}
      b6888b63
  20. 05 Jun, 2018 1 commit
    • Leszek Swirski's avatar
      [sfi] Remove SFI function literal id field · ceb9c812
      Leszek Swirski authored
      SharedFunctionInfos store their original function literal's id. This is
      also their index in the Script's SFI list.
      
      Since the function literal id is only needed for lazy compilation and live
      edit, we can calculate it on-the-fly by linear search in the Script SFI list,
      and save a field on the SFI.
      
      If this regresses compile performance, we could alternatively store the
      function literal id on the preparsed scope data as future work.
      
      Bug: chromium:818642
      Change-Id: I5468cea0e115921f1c864d94e567d749a4349882
      Reviewed-on: https://chromium-review.googlesource.com/1082480
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarHannes Payer <hpayer@chromium.org>
      Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53523}
      ceb9c812
  21. 03 Jun, 2018 1 commit
  22. 31 May, 2018 1 commit
  23. 28 May, 2018 1 commit
  24. 06 Apr, 2018 1 commit
  25. 27 Mar, 2018 1 commit
  26. 22 Mar, 2018 3 commits
  27. 20 Mar, 2018 2 commits
  28. 16 Mar, 2018 1 commit
  29. 23 Feb, 2018 1 commit
    • jgruber's avatar
      Remove unused runtime functions · 1ee80eba
      jgruber authored
      The list of runtime function use counts was generated with:
      
      $ grep -o '^ *F(\w*' src/runtime/runtime.h | sed 's/^ *F(//' | sort | while read f; do USE_COUNT=$(git grep "\(Runtime::k\|Runtime::kInline\|%\|%_\)$f" | wc -l); echo $USE_COUNT $f; done
      
      This reduces libv8.so size by 59K on an x64 release build.
      
      Bug: v8:7310
      Change-Id: Ib4d097e63ed065f41bf73e9529e4354575be5229
      Reviewed-on: https://chromium-review.googlesource.com/934272Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#51526}
      1ee80eba
  30. 22 Feb, 2018 1 commit
    • Benedikt Meurer's avatar
      [cleanup] Introduce a dedicated FeedbackCell. · aff1f378
      Benedikt Meurer authored
      This is preparatory cleanup work for eventually tracking the functions
      (rather than concrete closures) in the CALL_IC, also for builtins like
      the default PromiseCapability [[Resolve]] and [[Reject]] functions. It
      adds a new FeedbackCell type, which is used by JSFunctions consistently
      now to reference the feedback vector (or undefined if not the function
      is not compiled yet or is a native/asm.js function).
      
      This also changes the calling convention for FastNewClosure builtin and
      the JSCreateClosure operator in TurboFan to carry the FeedbackCell here
      instead of the parent FeedbackVector and the slot index. In addition we
      eliminate the now unused %InterpreterNewClosure runtime function.
      
      Bug: v8:2206, v8:7253, v8:7310
      Change-Id: Ib4ce456e276e0273e57c163dcdd0b33abf863656
      Reviewed-on: https://chromium-review.googlesource.com/928403
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#51474}
      aff1f378
  31. 19 Dec, 2017 1 commit
  32. 28 Nov, 2017 1 commit
  33. 27 Oct, 2017 1 commit
  34. 28 Sep, 2017 1 commit