- 23 Jun, 2017 1 commit
-
-
jgruber authored
This piggy-backs on top of existing precise and best-effort coverage to expose block coverage through the inspector protocol. Coverage collection now implicitly reports block-granularity coverage when available. A new 'isBlockCoverage' property on Inspector's FunctionCoverage type specifies the granularity of reported coverage. For now, only count-based block coverage is supported, but binary block coverage should follow soon. Support is still gated behind the --block-coverage flag. Bug: v8:6000 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I9c4d64e1d2a098e66178b3a68dcee800de0081af Reviewed-on: https://chromium-review.googlesource.com/532975 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#46157}
-
- 28 Apr, 2017 1 commit
-
-
kozyatinskiy authored
This roll includes: - [inspector_protocol] added StringUtil::toDouble method as requirement [1] [1] https://codereview.chromium.org/2843223005/ BUG=chromium:712610 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2846673005 Cr-Commit-Position: refs/heads/master@{#44954}
-
- 24 Feb, 2017 2 commits
-
-
kozyatinskiy authored
We don't call any of v8::Debug methods in src/inspector codebase and should use debug-interface.h instead. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2710243002 Cr-Original-Commit-Position: refs/heads/master@{#43398} Committed: https://chromium.googlesource.com/v8/v8/+/838b1a8841aba0c421b413c01b0fbd3c024c2249 Review-Url: https://codereview.chromium.org/2710243002 Cr-Commit-Position: refs/heads/master@{#43420}
-
machenbach authored
Revert of [inspector] removed unused #include "include/v8-debug.h" (patchset #2 id:20001 of https://codereview.chromium.org/2710243002/ ) Reason for revert: breaks presubmit on CI which runs checkdeps Original issue's description: > [inspector] removed unused #include "include/v8-debug.h" > > We don't call any of v8::Debug methods in src/inspector codebase and should use debug-interface.h instead. > > BUG=none > R=dgozman@chromium.org > > Review-Url: https://codereview.chromium.org/2710243002 > Cr-Commit-Position: refs/heads/master@{#43398} > Committed: https://chromium.googlesource.com/v8/v8/+/838b1a8841aba0c421b413c01b0fbd3c024c2249 TBR=dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review-Url: https://codereview.chromium.org/2719433002 Cr-Commit-Position: refs/heads/master@{#43404}
-
- 23 Feb, 2017 2 commits
-
-
kozyatinskiy authored
We don't call any of v8::Debug methods in src/inspector codebase and should use debug-interface.h instead. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2710243002 Cr-Commit-Position: refs/heads/master@{#43398}
-
bradnelson authored
Adding a full run of checkdeps to tools/presubmit.py so that we keep checkdeps green. PRESUBMIT.py checks only incremental changes. Temporarily disabling a check rule that's broker in the inspector, pending owners fix. BUG= R=machenbach@chromium.org,dgozman@chromium.org,eholk@chromium.org Review-Url: https://codereview.chromium.org/2705333005 Cr-Commit-Position: refs/heads/master@{#43397}
-
- 24 Jan, 2017 1 commit
-
-
kozyatinskiy authored
V8 has internal mechanism to ignore steps and breaks inside internal scripts, in this CL it's reused for blackboxing implementation. Advantages: - much faster blackboxing implementation (before we at least wrap and collect current call stack for each step), - get rid of StepFrame action and potential pause in blackboxed code after N StepFrame steps, - simplification of debugger agent logic. Disadvtanges: - currently when user was paused in blackboxed code (e.g. on breakpoint) and then makes step action, debugger ignores blackboxed state of the script and allows to use step actions as usual - this behavior is regressed, we still able to support it on frontend side. Current state and proposed changes for blackboxing: https://docs.google.com/document/d/1hnzaXPAN8_QC5ENxIgxgMNDbXLraM_OXT73rAyijTF8/edit?usp=sharing BUG=v8:5842 R=yangguo@chromium.org,dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2633803002 Cr-Commit-Position: refs/heads/master@{#42614}
-
- 29 Nov, 2016 1 commit
-
-
kozyatinskiy authored
V8 internally uses conversions.h to convert number to string, we can use these methods too instead of slow std::stringstream with std::locale. BUG=chromium:661497,v8:5551 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2534013002 Cr-Commit-Position: refs/heads/master@{#41334}
-
- 18 Oct, 2016 1 commit
-
-
kozyatinskiy authored
debug-interface.h contains part of v8-debug.h that is used by src/inspector. BUG=v8:5510 R=dgozman@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/2423713003 Cr-Commit-Position: refs/heads/master@{#40404}
-
- 14 Oct, 2016 2 commits
-
-
alph authored
It will allow timeline to show JS profile on code evaluated from console. BUG=chromium:655430 Committed: https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172 Review-Url: https://codereview.chromium.org/2413943002 Cr-Original-Commit-Position: refs/heads/master@{#40289} Cr-Commit-Position: refs/heads/master@{#40323}
-
machenbach authored
Revert of [inspector] Record EvaluateScript trace event upon console evaluation (patchset #2 id:20001 of https://codereview.chromium.org/2413943002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10647 See also: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [inspector] Record EvaluateScript trace event upon console evaluation > > It will allow timeline to show JS profile on code evaluated from console. > > BUG=chromium:655430 > > Committed: https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172 > Cr-Commit-Position: refs/heads/master@{#40289} TBR=caseq@chromium.org,paulirish@chromium.org,dgozman@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:655430 Review-Url: https://codereview.chromium.org/2416213002 Cr-Commit-Position: refs/heads/master@{#40299}
-
- 13 Oct, 2016 1 commit
-
-
alph authored
It will allow timeline to show JS profile on code evaluated from console. BUG=chromium:655430 Review-Url: https://codereview.chromium.org/2413943002 Cr-Commit-Position: refs/heads/master@{#40289}
-
- 15 Sep, 2016 1 commit
-
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2340763003 Cr-Commit-Position: refs/heads/master@{#39453}
-
- 13 Sep, 2016 2 commits
-
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2336023002 Cr-Commit-Position: refs/heads/master@{#39363}
-
kozyatinskiy authored
Going forward we may relax this, but it is a conscious decision to be made. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2337523003 Cr-Commit-Position: refs/heads/master@{#39362}
-