- 23 Jun, 2020 6 commits
-
-
Jakob Gruber authored
Following up on previous changes for unary ops: https://crrev.com/c/2246576 Bug: v8:8888 Change-Id: Ie4dd9a307fb0415e93babf412e3d8d9e86791761 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2257227 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#68479}
-
Daniel Clifford authored
This change enables automatic generation of Cast<> operators for classes that are defined in Torque. * Cast<> macros are generated for all classes that are defined in Torque code that are neither shapes nor marked with a new @doNotGenerateCast annotation. * Implicitly generated Cast macros simply call through to an internally-defined "DownCastForTorqueClass" macro that implements the cast using one of three strategies for efficiency. If the class has subclasses (i.e. a range of instance types including subtypes), the DownCastForTorqueClass checks for inclusion in the instance type range. If the class has a single instance type (i.e. no subclasses), then either 1) a map check is used if the class has a globally- defined map constant or 2) an equality check for the instance type is used. * Added new intrinsics to introspect class information, e.g. fetching instance type ranges for a class, accessing the globally-defined map for a class. * Removed a whole pile of existing explicit Cast<> operators that are no longer needed because of the implicitly generated Cast<> macros. * Added tests for the new Cast<> implementations. Bug: v8:7793 Change-Id: I3aadb0c62b720e9de4e7978b9ec4f05075771b8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2250239 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#68478}
-
Jakob Gruber authored
This extends the opcode macro lists to include both the long name (e.g.: JSAdd) and short name (Add) to reduce duplication. The change is only for JS operators for now but can be extended to others in the future. Drive-by: Base more predicates off the macro lists for robustness. Bug: v8:8888 Change-Id: I10debdf86166dbe9dac63a6df57938820a8af8d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2255468 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Just a test for now to document how trailing space after async functions is not removed by SourceRangeAstVisitor. Bug: v8:10628 Change-Id: I40f0d911c59540ea835c807a2be5b0d1488291d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2259852 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#68476}
-
Marja Hölttä authored
Clarify when we should use PostTask vs PostNonNestableTask. Change-Id: I2b69dc4d4b6de4079dcab05e8b5c3b1f77cbbe2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253852 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#68475}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2dc7c7a..55ed8e6 Rolling v8/third_party/aemu-linux-x64: UoYLOT0X6577j70eB9nPqYQs9Z3Nh5lA4I-pRtTchO0C..9BRSdHdrFCgATXOmmzV2ZGGbnwMtrcVLFMfGvaddyxcC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/95c1f42..80948d0 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/35c6274..b7db183 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/42b285f..84ce13e TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I76672f783411c3cc8a5043e0d5a18a97d1f24492 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2259195Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68474}
-
- 22 Jun, 2020 27 commits
-
-
Ng Zhi An authored
This implements I32x4DotI16x8S for arm64. Bug: v8:10583 Change-Id: Id55c57715b4050d54bbcdc18fc443f2332291651 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2231032Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68473}
-
Ulan Degenbaev authored
Chrome may send memory measurement requests to multiple renderer processes at the same time. This may lead to multiple GC happening at the same time if the processes are idle. Randomization spreads out the GCs over time to reduce the load on the system. Bug: chromium:1049093 Change-Id: I5aa67fb07f8a55d0ba769bf823168b35cb3c23cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208861 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#68472}
-
Ng Zhi An authored
This changes the use of "sane" to "sensible" or "valid". I tried to be sensible in my choice of replacement, by trying to read the comments or code to see which word matches the intention closest. Referenced https://fuchsia.dev/fuchsia-src/contribute/best-practices/respectful_code?hl=en#what_are_examples_of_terminology_to_be_avoided. Bug: v8:10619 Change-Id: Id957b2e6ff11e95270e1372005e1006d8cf1008d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2254483 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Prototype f32x4.floor on ARM for both ARM v7 and ARM v8. ARM v8 has support for vrintm, and for ARM v7 we fallback to runtime. Since ARM v8 uses vrintm, which is the same instruction used for F32 Floor (scalar), wasm-compiler reuses the Float32RoundDown check. Bug: v8:10553 Change-Id: I540e82a156131821f732cd427df2e5c68f4094d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252541Reviewed-by:
-
Z Nguyen-Huu authored
For better Turbofan debugging. Change-Id: I79010632b1355e2a4c1a017d64db5ccbb97fa776 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252539 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#68469}
-
Deepti Gandluri authored
Adjust atomics.wait, atomics.notify semantics for when they are used with non-shared Wasm memory to mirror the spec change introduced in: https://github.com/WebAssembly/threads/pull/147. This does not need to be gated by the flag here, as this will only decode if the flag is enabled. Bug: v8:9921 Change-Id: I7f2e018fed6bd131ad4c386def1e838626c28a4d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2256863Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#68468}
-
Ng Zhi An authored
Bug: v8:9909 Change-Id: Icb4dd53f02bcd3b38511bb028768d276e3bfebaf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2251041 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68467}
-
Georg Neis authored
Change-Id: Id2192cb62d6e0920420a3e988593759f5892a0b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2254026 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#68466}
-
Georg Neis authored
Let's see if this is still flaky after almost 5 years. Bug: v8:4573 Change-Id: I4cd2779b2c4aefc7bb20597db2fccc0e7e7c39c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2255467Reviewed-by:
-
Dan Elphick authored
This changes black/white list to block/allow list. Bug: v8:10619 Change-Id: Id55d72f90891670ca57b62dfeb6b3251025927dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2257228Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#68464}
-
Almothana Athamneh authored
Bug: v8:10445 Change-Id: I4d08b77466029d248cae5cfae4a113842129675b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2254027 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
There is a case where a TransitionArray shrinks during insertion. If that's the case, we need to compute the index to insert again. However, we can use the knowledge that already didn't appear in the array, and after shrinking it shouldn't appear. Change-Id: I3a742c5d37659064f143db1c4f345b0df35d0d42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238029Reviewed-by:
-
Clemens Backes authored
This addresses a review comment from https://github.com/WebAssembly/spec/pull/1214. R=ahaas@chromium.org Change-Id: Icd473aa16bbf35839556b052271489a2889fe0fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2257229Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68461}
-
Jakob Kummerow authored
No-Try: true Bug: v8:10619 Change-Id: I5c428bf47f2f6923aa88a8407d62d9480aa954fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2257222 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
Intent to Ship thread on blink-dev: https://groups.google.com/a/chromium.org/g/blink-dev/c/K4-P5rq7FbY Spec repository: https://github.com/WebAssembly/multi-value/ WebAssembly multi-value is ready to ship. The proposal is now merged into the core WebAssembly spec, and is implemented in both TurboFan and Liftoff. R=ecmziegler@chromium.org Bug: chromium:1097717 Change-Id: Id53ee318cacae1bc9dd9d9611f9223de594a99b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2257225Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#68459}
-
Jakob Gruber authored
... when jitless is enabled to fix fuzzers that pass random flag combinations. Bug: chromium:1096168,v8:7777 Change-Id: Ia78c4d9e1256e44c10df2200ecc32067a617d777 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2257220 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Anton Bikineev authored
This allows the implementation of different stack scanning mechanisms in V8 (e.g. conservative scanning) while re-using the stack walking API. Change-Id: I9b9c3b8ffe5d527ca3f7105776821776b509b187 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238194 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#68457}
-
Clemens Backes authored
We already have specialized logic for unops and binops, and the generic {BuildSimpleOperator} implementation (based on a signature) was reimplementing these two cases. This CL avoids the switch since we only need to handle exactly two cases, and redirects to the existing methods for implementing them. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: I8eb5c768f0fa59e48503c108498b334a0ae9037a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2249859Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68456}
-
Michael Lippautz authored
Mutable references are allowed by the style guide and the linter has been adjusted. Bug: v8:10624, chromium:1056170 Change-Id: I8a7dc06da5758f5c714a5e61d75378c2a13ffb9b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252192 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68455}
-
Dan Elphick authored
Add nullptr guard for the return value of AllocateBasicChunk. Bug: chromium:1097502 Change-Id: Ia4642151a119ccabe58d7084077808aac93e5d1c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2257221Reviewed-by:
-
Andreas Haas authored
R=adamk@chromium.org Bug: v8:7741 Change-Id: Icf7247825bd10048cd198b910b8bd976a0a0b3d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2241516 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#68453}
-
Nico Hartmann authored
Change-Id: I23a0a4811d8c42f09bbbc5460902ee7138f9b1ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2255469 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Clemens Backes authored
This is a follow-up to https://crrev.com/c/2249928. The arguments for {SubVector} are {from, to}, not {from, size}. R=jkummerow@chromium.org Bug: chromium:1097442 Change-Id: I3c5571ff7f0c6b8e235ecf4164591630dbd05739 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2255465Reviewed-by:
-
Maya Lekova authored
Bug: v8:9993 Change-Id: I06428edd7f01805d08927718e4711298c731d2e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253844 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Michael Lippautz authored
As of May 2020 the Google C++ Style Guide suggests using references for out paramters. Adjust V8's presubmit checks to allow mutable reference parameters. Bug: v8:10624 Change-Id: Idcd027892916a14f91ca3bfcb5eba48757cab523 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252185Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68449}
-
Jakob Gruber authored
In native context independent code we cannot embed the (native context dependent) feedback vector as a constant. Instead, we will load it from the JSFunction once and pass it to all users. This CL makes this change for all unary operators. All other {binary,compare} operators will need similar work in the future. Bug: v8:8888 Change-Id: I4d49a6e0effc84dcdf3599814e5c2708b16bcc44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246576Reviewed-by: -
Kim-Anh Tran authored
This check skips inserting a breakpoint into the BreakPointInfo if it has already been inserted before. Change-Id: Ic773fe1d6b2351bf6069fa0ff002737bd0b03293 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253851Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/master@{#68447}
-
- 21 Jun, 2020 1 commit
-
-
Milad Farazmand authored
Change-Id: I70fa23a2491186d2bf94b26a292163efa1c23d61 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2255503Reviewed-by:
-
- 20 Jun, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3591130..2dc7c7a Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/4ac015d..95c1f42 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/2410c84..35c6274 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/eaf99a4..02daed1 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia2219c9b1aeaff06fb06c29e2d08089d22c63ed4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2255501Reviewed-by:
-
- 19 Jun, 2020 5 commits
-
-
Ng Zhi An authored
This implements I32x4DotI16x8S for ia32. Also fixes instruction-selector for SIMD ops, they should all set operand1 to be a register, since we do not have memory alignment yet. Bug: v8:10583 Change-Id: Id273816efd5eea128580f3f7bde533a8e1b2435d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2231031 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I9af885e4c33541a8e065082ae7f07804bd11807a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252190 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Refer to "Advanced SIMD two registers misc", ARM DDI 0487F.b F4-4228. Also moved the method down to the section with all the NEON instructions, matching where the declaration in assembler-arm.h is. Bug: v8:10553 Change-Id: I450edbfc3eafead4aad419299c93e43bd9d83133 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252764Reviewed-by:
-
Almothana Athamneh authored
Bug: v8:10445 Change-Id: I45b142bd1f4330dc07d06f89dc9daf7db127aaaa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253958Reviewed-by:
-
Clemens Backes authored
Replace by "consistency check", or "validity check", or more specific wording as appropriate. R=ecmziegler@chromium.org Bug: v8:10619 Change-Id: Ifd7852d8f703d5b784d53671b82d65db15722ede Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253855Reviewed-by:
-
