- 14 Nov, 2019 1 commit
-
-
Santiago Aboy Solanes authored
Allows the use of PageUp and PageDown in sequence and schedule phases. Since graphmultiview had a tabindex of 0, it was sitting on top of sequence and schedule. This blocked the use of PageUp and PageDown to scroll in these phases. Bug: v8:7327 Change-Id: I4fc129cd9d5ea82e469cd4b67c12a455ec920317 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914207Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64947}
-
- 07 Nov, 2019 1 commit
-
-
Santiago Aboy Solanes authored
Bug: v8:7327 Change-Id: I79c55d93b8a9f05b81fcbb1897d946cb56e99370 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1901270Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#64833}
-
- 04 Nov, 2019 1 commit
-
-
Santiago Aboy Solanes authored
PR wasn't defined correctly and it was causing issues. Added prettify to the npm packages, and removed the (not needed) explicit prettify.css. Bug: v8:7327 Change-Id: Ieb8999d63df6764354dd628516e0ed9270b8a862 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1893344 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64726}
-
- 30 Oct, 2019 1 commit
-
-
Santiago Aboy Solanes authored
In the case where we fail on the 'before register allocation' phase, we will have the instructions to print, but turbolizer will fail to show them because it will look for the non-existent offsets. Bug: v8:7327 Change-Id: I52e520dcb662fe9931f1bb29cd2c16cd62913158 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1889883Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#64650}
-
- 21 Oct, 2019 2 commits
-
-
Santiago Aboy Solanes authored
Before this change, the activeElement used to be the body and not multiview. Then, the EventListener wasn't triggering. Bug: v8:7327 Change-Id: I9782159ffd510c9a7afd83695f20ede9e774ac20 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868624 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64422}
-
Sigurd Schneider authored
Since the resizers (the handles used to resize the panes) were getting bigger when selected, they obscured part of the scrollbar making the scrollbar too hard to select. Also, when they were snapped, the right resizer totally obscured the scrollbar. Bug: v8:7327 Change-Id: I04f3df00181df2265890ef54706091b3bc36f23e Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869191Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64421}
-
- 17 Oct, 2019 1 commit
-
-
Santiago Aboy Solanes authored
The top bar was being scrolled down since the whole viewpane was scrollable. It will now work in the way the "Dissasembly" tab works: the content is scrollable, but not the pane. This change makes Schedule and Sequence consistent within the other panels. As a drive-by fix, remove some unused constants. Bug: v8:7327, v8:9517 Notry: true Change-Id: I22f8abb6524cb297f43930fc8036b36b7ce59751 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863203 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64347}
-
- 16 Oct, 2019 3 commits
-
-
Santiago Aboy Solanes authored
Mainly updating '@types/d3' Change-Id: Ia3df5f4c29c4bf7cfe167a8b03ab20a2ad532cde Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863195Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64327}
-
Santiago Aboy Solanes authored
They have no function and are confusing to first time users, who think that you have to click that to upload a file. It would be better to not add them at all, but the logic searches for 'li.last-tab' and it seems hard to unravel. Bug: v8:7327 Notry: true Change-Id: I07e903947e15ccc0d5431488a4c4fcded999f91d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863194 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64325}
-
Santiago Aboy Solanes authored
It's already on the 'Graph view' section and fits better there. Bug: v8:7327 Notry: true Change-Id: Ie7024f1db02c5cf6b451f5f5401fd01195996848 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863192 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64319}
-
- 23 Aug, 2019 2 commits
-
-
Sigurd Schneider authored
Change-Id: I9988ea2dfeccbfaa9e0197920703ab430a43acb7 Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1674026 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#63375}
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: Ia8e5d51b12cc86734523860af88d4c3948e0f0c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660614 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#63371}
-
- 09 Aug, 2019 1 commit
-
-
Santiago Aboy Solanes authored
Bug: v8:9396 Change-Id: Ic5082b91cc61a286bd6a440009bf18202e853339 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1730997Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#63141}
-
- 09 Jul, 2019 1 commit
-
-
Pierre Langlois authored
The info tab says that 'i' reveals outputs and 'o' reveals inputs, it should be the opposite. Bug: v8:7327 Change-Id: I1bf96653129e14ef315a01dc2c7a3083c9caa5bb Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1692929 Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Auto-Submit: Pierre Langlois <pierre.langlois@arm.com> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#62603}
-
- 26 Jun, 2019 1 commit
-
-
Sigurd Schneider authored
Also show constant for ArchNops that encode assigning from a constant. Change-Id: I84590005dda62ebf445aada57f826f5ffcd5a802 Bug: v8:7327 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1672943 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#62388}
-
- 07 Jun, 2019 3 commits
-
-
Santiago Aboy Solanes authored
It was hiding the nodes, but never showing them. Therefore it wasn't 'toggling'. Change-Id: I6fe57860f44ba05abac0f1575678a494f9d07ae8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649557Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#62057}
-
Santiago Aboy Solanes authored
Some of the tooltips had the wrong text on them when hovering over with the mouse. Change-Id: I4d1ba37b0fad276356b76d16710a5dba7dedc6ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649556Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#62056}
-
Sigurd Schneider authored
Change-Id: Ia7d37e72b16123e98b2f2e4d4e5d614f9b8c8d9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649558 Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#62053}
-
- 18 Mar, 2019 2 commits
-
-
Pierre Langlois authored
Bug: v8:7327 Change-Id: I2a140cf79d3be83a34401f5e4a8033fd9d89568b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526011 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60306}
-
Sigurd Schneider authored
Change-Id: I8fee653d2e331c2e796115b4cb88a2138e456177 Bug: v8:7327 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528730Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60305}
-
- 28 Feb, 2019 2 commits
-
-
Sigurd Schneider authored
after previous change, which moved icons to .png format and to subdirectory img/. Bug: v8:7327 Notry: true Change-Id: Iebbbe175cc65ed1f2e505084344a2b55864732e7 Reviewed-on: https://chromium-review.googlesource.com/c/1494009 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#59940}
-
Sigurd Schneider authored
Change-Id: I19abd54f3c7825a99cbebd370092259cf8c21945 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1494007Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59939}
-
- 15 Jan, 2019 3 commits
-
-
Sigurd Schneider authored
Notry: true Bug: v8:7327 Change-Id: I9cdea29db2b409d773a16e3d6c29ef4325257162 Reviewed-on: https://chromium-review.googlesource.com/c/1409437 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58815}
-
Sigurd Schneider authored
This allows to reset the layout to the the inital layout of the graph, which only contains the control nodes. Change-Id: I7ab9fb1615057df99983369cd0fcdd42a68e1924 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1409436 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58814}
-
Sigurd Schneider authored
This enables per-phase toolbox items, which makes the toolbar easier to understand and use. Change-Id: I1b44d28595c118f0ba55dd64eea54415b51b93aa Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1409435Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58813}
-
- 14 Jan, 2019 8 commits
-
-
Sigurd Schneider authored
The URL must not have a leading slash, and the file needs to be included in the deployment script. TBR=neis@chromium.org Change-Id: Idd3fc25c052cb720d4956f630a8ddca7e5d36a1a Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1409432Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58799}
-
Sigurd Schneider authored
This is a first step towards support for opening more than one turbolizer json file at once. Change-Id: Id51ce47c59492ba63de03eceb0163fa1701ea500 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1407057 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58790}
-
Sigurd Schneider authored
..as mentioned in the info tab. Change-Id: I9ddbe1ad7eb3242ad7839650aecc7305a902fb0d Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1407056 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58789}
-
Sigurd Schneider authored
..instead of wrongly keeping the location from the previous view if the selection became empty after attaching it. Change-Id: I606010ad86034c2ec06e00c82143a22ca2d88274 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1407055 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58788}
-
Sigurd Schneider authored
..and display them in the extended node title (on hover). Notry: true Bug: v8:7327 Change-Id: Ic9cd6207269686edb42ecf1bee8f7ef7b6caa035 Reviewed-on: https://chromium-review.googlesource.com/c/1407054 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58783}
-
Sigurd Schneider authored
Drive-by: Make label of checkboxes in disassembly view clickable. Notry: true Bug: v8:7327 Change-Id: I29478c5cb2bd4152df7943f9dfbba487f3b8bddb Reviewed-on: https://chromium-review.googlesource.com/c/1407053 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58782}
-
Sigurd Schneider authored
Notry: true Bug: v8:7327 Change-Id: I440578b6b790f7f5f4cb41147572f32459fb59e5 Reviewed-on: https://chromium-review.googlesource.com/c/1407052 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58781}
-
Sigurd Schneider authored
Notry: true Bug: v8:7327 Change-Id: I2592d921905ad361f09ff6d99c0b0d64617543c4 Reviewed-on: https://chromium-review.googlesource.com/c/1407051 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58780}
-
- 12 Jan, 2019 3 commits
-
-
Sigurd Schneider authored
- 'let' instead of 'var', and prefer 'const' - Prefer for-of over indexed interation - Variable names should be 'camel-case' or all-caps snake-case. - Only one variable declaration per line Change-Id: I645dd2333d6d9a993f24c29121f5f156249f1b71 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1405320 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58761}
-
Sigurd Schneider authored
Change-Id: I8e147bcb5d1e0b8e16874f0593a8ce4338dfc201 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1405319 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58760}
-
Sigurd Schneider authored
- Ban T[] array syntax - Format arrow function arguments consistently Bug: v8:7327 Notry: true Change-Id: I072a352ec9009948392a6bb5dd4381d4993af7be Reviewed-on: https://chromium-review.googlesource.com/c/1405317 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58759}
-
- 09 Jan, 2019 1 commit
-
-
Sigurd Schneider authored
Change-Id: Iffd68156515948254e4ce38021c511596acc5788 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1400849 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58681}
-
- 08 Jan, 2019 1 commit
-
-
Sigurd Schneider authored
Graph width is now managed by the Graph instead of the GraphView, which simplifies some interfaces. Change-Id: If78bc9a469cc8369bc75695a6612627103036bc8 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1398227Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58618}
-
- 07 Jan, 2019 2 commits
-
-
Sigurd Schneider authored
This CL removes the graph between phase changes. This prevents incorrect path layouting after changing from a phase where a path is displayed that is not a correct path in the phase we change to. Change-Id: Iad80f49efc8d8c71600ad51432981c3a206ef9cb Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1397710Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58592}
-
Sigurd Schneider authored
This CL simplifies the keydown handling code and fixes several issues: - Input to the search box was not reliably working, because the SVG keydown handler was attached to the window and its repeat-key detection was supressing key events. - Selecting the input of a node via keys 1-9 did not select the input, but always enabled the corresponding input node. 1-9 now select the input node, and CTRL+1 through CTRL+9 can be used to toggle the input edge. Bug: v8:7327 Notry: true Change-Id: Ifedc8b703f6552e101ad00fee2f3c50f29b325b5 Reviewed-on: https://chromium-review.googlesource.com/c/1397666 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58579}
-