- 11 Apr, 2016 1 commit
-
-
ssanfilippo authored
When FLAG_trace_ignition_dispatches is enabled, a dispatch counter is kept for each pair of source-destination bytecode handlers. Each counter saturates at max uintptr_t value. Counters are dumped as a JSON-encoded object of objects, such that each key on the top level object is a source bytecode name, and each key on the corresponding value is a destination bytecode name, with the associated counter as value. The output file name can be controlled with the FLAG_trace_ignition_dispatches_output_file flag. The JSON file may be written by calling Interpreter::WriteDispatchCounters(), which is done for d8 in Shell::OnExit, if FLAG_trace_ignition_dispatches is enabled. BUG=v8:4899 LOG=N Review URL: https://codereview.chromium.org/1828633003 Cr-Commit-Position: refs/heads/master@{#35380}
-
- 05 Apr, 2016 1 commit
-
-
yangguo authored
R=neis@chromium.org BUG=v8:4887 LOG=N Review URL: https://codereview.chromium.org/1857263002 Cr-Commit-Position: refs/heads/master@{#35270}
-
- 31 Mar, 2016 1 commit
-
-
yangguo authored
We only use it to store the Stringify function to format REPL output. This is overkill and introduces issues with security tokens. R=jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/1845833002 Cr-Commit-Position: refs/heads/master@{#35158}
-
- 15 Mar, 2016 1 commit
-
-
adamk authored
Modules already have a separate entrypoint into the engine (at the moment, this is v8::ScriptCompiler::CompileModule, though that will change to something like ParseModule). This meant that requiring a commandline flag simply added an extra complexity burden on embedders. By removing the v8 flag, this lets embedders use their own flagging mechanism (such as d8's "--module", or Blink's RuntimeEnabledFeatures) to control whether modules are to be used. Also remove old modules tests that were being skipped (since they test very old, pre-ES2015 modules syntax). R=littledan@chromium.org BUG=v8:1569, chromium:594639 LOG=y Review URL: https://codereview.chromium.org/1804693002 Cr-Commit-Position: refs/heads/master@{#34764}
-
- 10 Mar, 2016 1 commit
-
-
rossberg authored
R=mstarzinger@chromium.org,bmeurer@chromium.org,adamk@chromium.org BUG=v8:3956 LOG=Y Review URL: https://codereview.chromium.org/1773653002 Cr-Commit-Position: refs/heads/master@{#34669}
-
- 08 Mar, 2016 1 commit
-
-
cbruni authored
BUG=chromium:589679 LOG=N Review URL: https://codereview.chromium.org/1771323003 Cr-Commit-Position: refs/heads/master@{#34595}
-
- 01 Mar, 2016 1 commit
-
-
fmeawad authored
This should land after the chromium CL that starts using the new AddTraceEvent lands (https://codereview.chromium.org/1742603004/) BUG=4565 LOG=N Review URL: https://codereview.chromium.org/1744733002 Cr-Commit-Position: refs/heads/master@{#34412}
-
- 26 Feb, 2016 1 commit
-
-
fmeawad authored
This patch adds the newly added support for contexts in V8 Tracing, as well as use it to mark all the entry points for a V8 Isolate. Update for reland: The current tracing interface needs to be updated (AddTraceEvent), but the embedders need to migrate to the new version before removing the old version. (Reland of: https://codereview.chromium.org/1686233002) The revert happened because the 2 signatures of the old and new AddTraceEvent where different so it threw an overload-virtual error on cross arm debug. This issue is temporary, and to solve it, I added an implementation of the old and new everywhere until the embedder implements the new. BUG=v8:4565 LOG=N R=jochen@chromium.org Review URL: https://codereview.chromium.org/1704253002 Cr-Commit-Position: refs/heads/master@{#34332}
-
- 21 Feb, 2016 1 commit
-
-
ben authored
Embedders don't use d8.cc. Move gdbjit initialization to api.cc. BUG= Review URL: https://codereview.chromium.org/1710253002 Cr-Commit-Position: refs/heads/master@{#34180}
-
- 17 Feb, 2016 2 commits
-
-
machenbach authored
Revert of Add Scoped Context Info (Isolate) to V8 Traces (patchset #5 id:80001 of https://codereview.chromium.org/1686233002/ ) Reason for revert: [Sheriff] Breaks arm cross-compile: https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builder/builds/7825/ Original issue's description: > Add Scoped Context Info (Isolate) to V8 Traces > > This patch adds the newly added support for contexts in V8 Tracing, as well > as use it to mark all the entry points for a V8 Isolate. > > BUG=v8:4565 > LOG=N > > Committed: https://crrev.com/44823c3c6965966c63b7e2e2361d0f2a58d196ea > Cr-Commit-Position: refs/heads/master@{#34092} TBR=jochen@chromium.org,fmeawad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4565 Review URL: https://codereview.chromium.org/1710573002 Cr-Commit-Position: refs/heads/master@{#34095}
-
fmeawad authored
This patch adds the newly added support for contexts in V8 Tracing, as well as use it to mark all the entry points for a V8 Isolate. BUG=v8:4565 LOG=N Review URL: https://codereview.chromium.org/1686233002 Cr-Commit-Position: refs/heads/master@{#34092}
-
- 16 Feb, 2016 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1696333002 Cr-Commit-Position: refs/heads/master@{#34035}
-
- 12 Feb, 2016 1 commit
-
-
mstarzinger authored
Reland of [interpreter] Make d8's TryCatch block be verbose. (patchset #1 id:1 of https://codereview.chromium.org/1694523003/ ) Reason for revert: No fix needed, original CL was perfectly fine! Original issue's description: > Revert of [interpreter] Make d8's TryCatch block be verbose. (patchset #3 id:40001 of https://codereview.chromium.org/1691723002/ ) > > Reason for revert: > [Sheriff] Speculative revert. Breaks > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/3944 > > Somehow https://chromium.googlesource.com/v8/v8/+/3a2fbc3a4ed2802b52659df2209b930200d63b29 seems to hide it again and then https://chromium.googlesource.com/v8/v8/+/699e1081a658ff62df6df1efe7db2b250111dedd lets it show up again. > > Reproduced locally. > > Original issue's description: > > [interpreter] Make d8's TryCatch block be verbose. > > > > This changes "d8" to no longer report exceptions as being "caught" when > > it comes to the catch prediction mechanism in our debugger. This treats > > scripts as being truly top-level when it comes to exception handling and > > will allow us to properly test the catch prediction mechanism using just > > mjsunit tests alone. > > > > R=yangguo@chromium.org > > BUG=v8:4674 > > LOG=n > > > > Committed: https://crrev.com/fb1de271a6bc2c89a1682db8c151cf5fcda86c45 > > Cr-Commit-Position: refs/heads/master@{#33898} > > TBR=yangguo@chromium.org,mstarzinger@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4674 > > Committed: https://crrev.com/f9eef1f33d2e5cde8cb948424e7ebf509090aa59 > Cr-Commit-Position: refs/heads/master@{#33921} TBR=yangguo@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4674 Review URL: https://codereview.chromium.org/1692133002 Cr-Commit-Position: refs/heads/master@{#33931}
-
- 11 Feb, 2016 2 commits
-
-
machenbach authored
Revert of [interpreter] Make d8's TryCatch block be verbose. (patchset #3 id:40001 of https://codereview.chromium.org/1691723002/ ) Reason for revert: [Sheriff] Speculative revert. Breaks https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/3944 Somehow https://chromium.googlesource.com/v8/v8/+/3a2fbc3a4ed2802b52659df2209b930200d63b29 seems to hide it again and then https://chromium.googlesource.com/v8/v8/+/699e1081a658ff62df6df1efe7db2b250111dedd lets it show up again. Reproduced locally. Original issue's description: > [interpreter] Make d8's TryCatch block be verbose. > > This changes "d8" to no longer report exceptions as being "caught" when > it comes to the catch prediction mechanism in our debugger. This treats > scripts as being truly top-level when it comes to exception handling and > will allow us to properly test the catch prediction mechanism using just > mjsunit tests alone. > > R=yangguo@chromium.org > BUG=v8:4674 > LOG=n > > Committed: https://crrev.com/fb1de271a6bc2c89a1682db8c151cf5fcda86c45 > Cr-Commit-Position: refs/heads/master@{#33898} TBR=yangguo@chromium.org,mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4674 Review URL: https://codereview.chromium.org/1694523003 Cr-Commit-Position: refs/heads/master@{#33921}
-
mstarzinger authored
This changes "d8" to no longer report exceptions as being "caught" when it comes to the catch prediction mechanism in our debugger. This treats scripts as being truly top-level when it comes to exception handling and will allow us to properly test the catch prediction mechanism using just mjsunit tests alone. R=yangguo@chromium.org BUG=v8:4674 LOG=n Review URL: https://codereview.chromium.org/1691723002 Cr-Commit-Position: refs/heads/master@{#33898}
-
- 29 Dec, 2015 1 commit
-
-
cbruni authored
BUG= Review URL: https://codereview.chromium.org/1550113002 Cr-Commit-Position: refs/heads/master@{#33055}
-
- 17 Dec, 2015 1 commit
-
-
fmeawad authored
This is based on the Skia Implementation. More on the project can be found here: https://docs.google.com/a/chromium.org/document/d/1_4LAnInOB8tM_DLjptWiszRwa4qwiSsDzMkO4tU-Qes/edit#heading=h.p97rw6yt8o2j The V8 Tracing platform will replace the isolate->event_logger(). But since the current embedders (namely chromium) currently use the isolate->event_logger, I made the default implementation (event-tracer) call into isolate->event_logger if an event_logger was set. Once the embedders properly implement the interface (for example in chromium it would look like this: https://codereview.chromium.org/707273005/), the default implementation will be doing nothing. Once the embedders side is fixed, we will change how V8 uses the tracing framework beyond the call from Logger:CallEventLogger. (which would also include a d8 implementation) BUG=v8:4560 LOG=N Review URL: https://codereview.chromium.org/988893003 Cr-Commit-Position: refs/heads/master@{#32959}
-
- 01 Dec, 2015 1 commit
-
-
yangguo authored
Native scripts must not accidentally pollute the global object. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1490783002 Cr-Commit-Position: refs/heads/master@{#32469}
-
- 30 Nov, 2015 1 commit
-
-
jochen authored
R=vogelheim@chromium.org LOG=n BUG=v8:2487 Review URL: https://codereview.chromium.org/1474353002 Cr-Commit-Position: refs/heads/master@{#32389}
-
- 12 Nov, 2015 1 commit
-
-
ishell authored
This CL fixes several sources of non-predictability by making Platform::MonotonicallyIncreasingTime() the only bottleneck for all time-querying functions and providing PredictablePlatform implementation. Review URL: https://codereview.chromium.org/1415383004 Cr-Commit-Position: refs/heads/master@{#31959}
-
- 12 Oct, 2015 2 commits
-
-
machenbach authored
Revert of Don't compile functions in a context the caller doesn't have access to (patchset #1 id:1 of https://codereview.chromium.org/1393713006/ ) Reason for revert: [Sheriff] Breaks layout tests. Please add needsmanualrebaseline upstream first if intended. E.g.: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/2263 (one of them is a timeout that only happens with this commit) Original issue's description: > Don't compile functions in a context the caller doesn't have access to > > Instead, just return undefined. > > A side effect of this is that it's no longer possible to compile > functions in a detached context. > > Based on https://codereview.chromium.org/294073002 but taking access > check callbacks into account > > BUG=chromium:541703 > R=verwaest@chromium.org > LOG=y > > Committed: https://crrev.com/9a5e2f512c4aa90563eb575605c2a8c2a92ac9f4 > Cr-Commit-Position: refs/heads/master@{#31208} TBR=verwaest@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:541703 Review URL: https://codereview.chromium.org/1395583004 Cr-Commit-Position: refs/heads/master@{#31212}
-
jochen authored
Instead, just return undefined. A side effect of this is that it's no longer possible to compile functions in a detached context. Based on https://codereview.chromium.org/294073002 but taking access check callbacks into account BUG=chromium:541703 R=verwaest@chromium.org LOG=y Review URL: https://codereview.chromium.org/1393713006 Cr-Commit-Position: refs/heads/master@{#31208}
-
- 28 Sep, 2015 1 commit
-
-
jkummerow authored
Replacing it with SMI_ACCESSORS. This change makes accesses to Smi fields in objects more regular (the accessors now always consume/return an int rather than a Smi*), which avoids a bunch of manual Smi::FromInt() and Smi::value() conversions, and is a step on the way towards being able to generate objects-inl.h. Review URL: https://codereview.chromium.org/1371893002 Cr-Commit-Position: refs/heads/master@{#30975}
-
- 27 Aug, 2015 1 commit
-
-
titzer authored
R=mstarzinger@chromium.org,yangguo@chromium.org BUG= Review URL: https://codereview.chromium.org/1319003002 Cr-Commit-Position: refs/heads/master@{#30416}
-
- 18 Aug, 2015 4 commits
-
-
Ben Smith authored
TBR=adamk@chromium.org Review URL: https://codereview.chromium.org/1302593002 . Cr-Commit-Position: refs/heads/master@{#30231}
-
binji authored
BUG=chromium:518748 R=mstarzinger@chromium.org LOG=n Review URL: https://codereview.chromium.org/1284683004 Cr-Commit-Position: refs/heads/master@{#30230}
-
binji authored
Don't use exit(), use Shell::Exit() (which calls _exit() instead). This won't run C++ static destructors, atexit() functions, etc., which can occasionally cause flaky failures. BUG=v8:4279 R=machenbach@chromium.org LOG=n Review URL: https://codereview.chromium.org/1294913005 Cr-Commit-Position: refs/heads/master@{#30229}
-
bradnelson authored
Place a copy of the v8-native-prototype in third_party/wasm. GYP_DEFINES='v8_wasm=1' gclient runhooks BUG=None TEST=None R=titzer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1294543006 Cr-Commit-Position: refs/heads/master@{#30225}
-
- 14 Aug, 2015 1 commit
-
-
vogelheim authored
- Make the API look like v8::V8::InitializeICU. (That is: A static method call, not an object to be created on the stack.) - Fix path separator on Windows, by calling base::OS::isPathSeparator. - Move into API, so that it can be called by hello-world & friends. - Actually call it from hello-world and friends. R=jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/1292053002 Cr-Commit-Position: refs/heads/master@{#30174}
-
- 11 Aug, 2015 1 commit
-
-
binji authored
BUG=chromium:518747 R=mstarzinger@chromium.org LOG=n Review URL: https://codereview.chromium.org/1277543006 Cr-Commit-Position: refs/heads/master@{#30099}
-
- 04 Aug, 2015 2 commits
-
-
binji authored
BUG=4399 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1260813008 Cr-Commit-Position: refs/heads/master@{#30016}
-
vogelheim authored
The race occurred when Workers were used. Since Workers call Shell::ExecuteString from a different thread, TSAN (correctly) flags this as a racy write. Solution would be to either synchronize the writes, or to 'lift' the write higher up in the call stack and only write the flag from the main thread. This implements this latter solution. These methods call Shell::ExecuteString, but do *not* set script_executed: - ExecuteInThread: Can only occur is JS has already been executed. - Shell::Load: Callback for JS; so JS has already been executed when we get there. - Shell::RunShell: Interactive shell. We no longer need script_executed once we're here. BUG=v8:4330 LOG=N Review URL: https://codereview.chromium.org/1258303004 Cr-Commit-Position: refs/heads/master@{#30003}
-
- 03 Aug, 2015 1 commit
-
-
binji authored
BUG=chromium:514081 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1264723002 Cr-Commit-Position: refs/heads/master@{#29982}
-
- 30 Jul, 2015 2 commits
-
-
binji authored
script_executed and last_run are read/written by multiple threads. Also externalized_shared_contents_ is modified by multiple threads. BUG=4306 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1252623003 Cr-Commit-Position: refs/heads/master@{#29912}
-
binji authored
When the main thread terminates, it forcibly terminates all Worker threads. When this happens, the threads objects were only half-created; they had a JavaScript Worker object, but not a C++ worker object. This CL fixes that bug, as well as some other fixes: * Signatures on Worker methods * Use SetAlignedPointerFromInternalField instead of using an External. * Remove state_ from Worker. Simplify to atomic bool running_. BUG=chromium:511880 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1255563002 Cr-Commit-Position: refs/heads/master@{#29911}
-
- 23 Jul, 2015 3 commits
-
-
Adam Klein authored
TBR=yangguo@chromium.org Review URL: https://codereview.chromium.org/1246983004 . Cr-Commit-Position: refs/heads/master@{#29824}
-
yangguo authored
Nobody seems to use it. A good alternative is rlwrap. R=jochen@chromium.org Review URL: https://codereview.chromium.org/1250223002 Cr-Commit-Position: refs/heads/master@{#29810}
-
yangguo authored
The code is unmaintained and full of errors... but this CL wipes them all away. Nobody seems to use it anyways. R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1243213004 Cr-Commit-Position: refs/heads/master@{#29801}
-
- 20 Jul, 2015 2 commits
-
-
jochen authored
R=yangguo@chromium.org BUG=chromium:511988 LOG=n Review URL: https://codereview.chromium.org/1246643002 Cr-Commit-Position: refs/heads/master@{#29757}
-
jochen authored
Original issue's description: > BUG=v8:4134 > LOG=n > R=yangguo@chromium.org > > Review URL: https://codereview.chromium.org/1239053004 BUG=v8:4134 LOG=n R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1235603004 Cr-Commit-Position: refs/heads/master@{#29742}
-