- 16 Apr, 2021 1 commit
-
-
Camillo Bruni authored
- This is a reland of d435eaa5 - Fix vtunedomain Original change's description: > [api] Add v8::Isolate::ThrowError helper > > Add a ThrowError helper to encourage throwing full Error objects > instead of just v8::Strings. > > Bug: v8:11195 > Change-Id: I15d75b1d39b817de3b9026a836b57a70d7c16a28 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2811738 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Dan Elphick <delphick@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73958} Bug: v8:11195 Change-Id: I3cffaa4f122d74705476c3f8791b549f85d8c87b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826534Reviewed-by: Dan Elphick <delphick@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#73993}
-
- 14 Apr, 2021 2 commits
-
-
Maya Lekova authored
This reverts commit d435eaa5. Reason for revert: Breaks compilation on the vtunejit bot, see https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20vtunejit/41247/overview Original change's description: > [api] Add v8::Isolate::ThrowError helper > > Add a ThrowError helper to encourage throwing full Error objects > instead of just v8::Strings. > > Bug: v8:11195 > Change-Id: I15d75b1d39b817de3b9026a836b57a70d7c16a28 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2811738 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Dan Elphick <delphick@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73958} Bug: v8:11195 Change-Id: I2773d8ca7d73e7952d274381e2e0a2e5733a83da No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826533 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73959}
-
Camillo Bruni authored
Add a ThrowError helper to encourage throwing full Error objects instead of just v8::Strings. Bug: v8:11195 Change-Id: I15d75b1d39b817de3b9026a836b57a70d7c16a28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2811738 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73958}
-
- 14 Jan, 2021 1 commit
-
-
Ben Noordhuis authored
Remove the ambient dependency on the currently entered isolate, let the embedder pass it in explicitly. Bug: v8:11287 Change-Id: I03690390a308a59e2c6ea5c6ae268780d836b717 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2608209Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#72105}
-
- 28 Nov, 2020 1 commit
-
-
Camillo Bruni authored
Bug: v8:11195 Change-Id: I19211af9e440940f85351fb38920eb620c222213 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2555010Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71465}
-
- 10 Jun, 2020 1 commit
-
-
Camillo Bruni authored
Change-Id: I4e9a70339a59845c33432fe6a8dcaacebd2046a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237631Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#68278}
-
- 09 Mar, 2020 1 commit
-
-
Dan Elphick authored
String::NewFromLiteral is a templated function that takes a char[N] argument that can be used as an alternative to String::NewFromUtf8 and returns a Local<String> rather than a MaybeLocal<String> reducing the number of ToLocalChecked() or other checks. Since the string length is known at compile time, it can statically assert that the length is less than String::kMaxLength, which means that it can never fail at runtime. This also converts all found uses of NewFromUtf8 taking a string literal or a variable initialized from a string literal to use the new API. In some cases the types of stored string literals are changed from const char* to const char[] to ensure the size is retained. This API does introduce a small difference compared to NewFromUtf8. For a case like "abc\0def", NewFromUtf8 (using length -1 to infer length) would treat this as a 3 character string, whereas the new API will treat it as a 7 character string. As a drive-by fix, this also fixes all redundant uses of v8::NewStringType::kNormal when passed to any of the String::New* functions. Change-Id: Id96a44bc068d9c4eaa634aea688e024675a0e5b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2089935 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#66622}
-
- 14 Nov, 2017 1 commit
-
-
Andreas Haas authored
With this CL, {CreateDefaultPlatform} returns a unique_ptr to indicate that the caller owns the returned memory. We had several memory leaks where the memory of the DefaultPlatform did not get deallocated. In addition, the {TracingController} of the {DefaultPlatform} also gets received as a unique_ptr. Thereby we document that the {DefaultPlatform} takes ownership of the {TracingController}. Note that the memory of the {TracingController} was already owned by the {DefaultPlatform}, but it was not documented in the interface, and it was used incorrectly in tests. This CL fixes the asan issues in https://chromium-review.googlesource.com/c/v8/v8/+/753583 ([platform] Implement TaskRunners in the DefaultPlatform) R=rmcilroy@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I0d1a6d3b22bb8289dc050b1977e4f58381cec675 Reviewed-on: https://chromium-review.googlesource.com/755033Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#49349}
-
- 28 Aug, 2017 1 commit
-
-
Mateusz Czeladka authored
As part of J2V8 development (https://github.com/eclipsesource/J2V8), we realized that we had a subtle bug in how Isolate scope was created and it's lifetime managed, see: https://github.com/eclipsesource/J2V8/issues/313. Mentioned above bug was fixed, however, what we also noticed is that V8 API has been constantly and slowly moving to such an API, in which one has to pass Isolate explicitly to methods and/or constructors. We found two more places that might have been overlooked. This contribution adds passing of Isolate pointer explicitly to constructors of String::Utf8Value and String::Value classes. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I61984285f152aba5ca922100cf3df913a9cb2cea Reviewed-on: https://chromium-review.googlesource.com/593309 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47656}
-
- 29 Jun, 2016 1 commit
-
-
jochen authored
BUG=none R=ulan@chromium.org Review-Url: https://codereview.chromium.org/2101413002 Cr-Commit-Position: refs/heads/master@{#37365}
-
- 08 Jun, 2016 1 commit
-
-
machenbach authored
This allows using icu data, bundled in the icudtl.dat file, to be loaded automatically from a default location side-by-side with the executable. The v8 stand-alone default is still to use statically linked ICU data, but this will be switched in a separate follow-up CL. BUG=chromium:616033 LOG=y Review-Url: https://codereview.chromium.org/2042253002 Cr-Commit-Position: refs/heads/master@{#36823}
-
- 20 Oct, 2015 1 commit
-
-
jochen authored
BUG=chromium:534746 R=vogelheim@chromium.org LOG=n Review URL: https://codereview.chromium.org/1410333004 Cr-Commit-Position: refs/heads/master@{#31414}
-
- 14 Aug, 2015 1 commit
-
-
vogelheim authored
- Make the API look like v8::V8::InitializeICU. (That is: A static method call, not an object to be created on the stack.) - Fix path separator on Windows, by calling base::OS::isPathSeparator. - Move into API, so that it can be called by hello-world & friends. - Actually call it from hello-world and friends. R=jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/1292053002 Cr-Commit-Position: refs/heads/master@{#30174}
-
- 15 Jul, 2015 1 commit
-
-
epertoso authored
R=jochen@chromium.org LOG=y BUG= Review URL: https://codereview.chromium.org/1209403005 Cr-Commit-Position: refs/heads/master@{#29680}
-
- 02 Jul, 2015 1 commit
-
-
jochen authored
BUG=v8:4134 R=vogelheim@chromium.org LOG=n Review URL: https://codereview.chromium.org/1219133004 Cr-Commit-Position: refs/heads/master@{#29452}
-
- 28 May, 2015 1 commit
-
-
jochen authored
BUG=4134 R=vogelheim@chromium.org LOG=n Review URL: https://codereview.chromium.org/1154423004 Cr-Commit-Position: refs/heads/master@{#28678}
-
- 29 Apr, 2015 1 commit
-
-
jochen authored
We shouldn't have shared state between isolates by default. The embedder is free to pass the same allocator to all isolates it creates. BUG=none R=dcarney@chromium.org LOG=y Review URL: https://codereview.chromium.org/1116633002 Cr-Commit-Position: refs/heads/master@{#28127}
-
- 28 Apr, 2015 1 commit
-
-
bmeurer authored
Currently only the Win64 bots report this warnings, which adds quite some overhead to the development process. With this flag we also get compiler warnings about implicit 64bit to 32bit truncations when building with clang on Linux/x64 and Mac/x64. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/1111733002 Cr-Commit-Position: refs/heads/master@{#28093}
-
- 02 Feb, 2015 1 commit
-
-
cwhan.tunz authored
BUG=v8:3850 LOG=N Review URL: https://codereview.chromium.org/892083002 Cr-Commit-Position: refs/heads/master@{#26375}
-
- 21 Nov, 2014 1 commit
-
-
yangguo authored
R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/750543002 Cr-Commit-Position: refs/heads/master@{#25464}
-
- 19 Nov, 2014 1 commit
-
-
Benedikt Meurer authored
Revert "Forward declaration for Isolate / Platform in libplatform.h." and "Fixes d8 on windows following.". This reverts commit 0f57ce8f. and 3245b8cb for breaking Chromium compile. TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/743533003 Cr-Commit-Position: refs/heads/master@{#25411}
-
- 18 Nov, 2014 1 commit
-
-
bulach authored
Reduces dependencies on #include files, making it easier for other build systems to include this library. BUG= Review URL: https://codereview.chromium.org/740493002 Cr-Commit-Position: refs/heads/master@{#25408}
-
- 19 Sep, 2014 1 commit
-
-
jochen@chromium.org authored
> We also initialize the Isolate on creation. > > This should allow for getting rid of the last remaining default isolate > traces. Also, it'll speed up several isolate related operations that no > longer require locks. > > Embedders that relied on v8::Isolate to return an uninitialized Isolate > (so they can set ResourceConstraints for example, or set flags that > modify the way the isolate is created) should either do the setup before > creating the isolate, or use the recently added CreateParams to pass e.g. > ResourceConstraints. > > BUG=none > LOG=y > R=svenpanne@chromium.org > > Review URL: https://codereview.chromium.org/469783002 BUG=none LOG=y TBR=svenpanne@chromium.org Review URL: https://codereview.chromium.org/583153002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Sep, 2014 2 commits
-
-
jochen@chromium.org authored
LOG=n TBR=svenpanne@chromium.org BUG=none Review URL: https://codereview.chromium.org/582953002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24055 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
We also initialize the Isolate on creation. This should allow for getting rid of the last remaining default isolate traces. Also, it'll speed up several isolate related operations that no longer require locks. Embedders that relied on v8::Isolate to return an uninitialized Isolate (so they can set ResourceConstraints for example, or set flags that modify the way the isolate is created) should either do the setup before creating the isolate, or use the recently added CreateParams to pass e.g. ResourceConstraints. BUG=none LOG=y R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/469783002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24052 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jul, 2014 2 commits
-
-
jochen@chromium.org authored
TBR=yangguo@chromium.org LOG=n BUG=none Review URL: https://codereview.chromium.org/367293002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22181 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
Also remove the "use default platform" compile flag. Instead, the embedder has to provide the platform. Change all binaries to use the default platfrom from libplatform. Unless --job-based-sweeping is passed, nothing uses the platform yet, so nothing will break for embedders (yet). BUG=none R=jkummerow@chromium.org LOG=y Review URL: https://codereview.chromium.org/345903004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22180 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Jun, 2014 2 commits
-
-
mstarzinger@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/333013002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21894 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yurys@chromium.org authored
Replaced Message::GetResourceName with GetScriptOrigin().ResourceName(). Now, GetScriptOrigin().ResourceName() function returns the resource name or sourceURL (from //# sourceURL=) for the script from where the function causing the error originates. Method GetScriptResourceName() deprecated. Use GetScriptOrigin()->ResourceName() instead. Function used in Blink: https://codereview.chromium.org/260513004/ R=yangguo@chromium.org, yurys@chromium.org Review URL: https://codereview.chromium.org/265593002 Patch from Alexey Kozyatinskiy <kozyatinskiy@google.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21893 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 May, 2014 1 commit
-
-
svenpanne@chromium.org authored
R=yangguo@chromium.org Review URL: https://codereview.chromium.org/290453003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21320 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 May, 2014 1 commit
-
-
svenpanne@chromium.org authored
Removed a related TODO in d8.cc on the way. BUG=v8::3318 LOG=y R=dcarney@chromium.org Review URL: https://codereview.chromium.org/275463002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21195 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Apr, 2014 2 commits
-
-
svenpanne@chromium.org authored
This reverts commit r20876, it broke non-snapshot tests. TBR=bmeurer@chromium.org git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20879 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
This implies that one better has a v8::V8::Initialize when v8::V8::Dispose is used. BUG=359977 LOG=y R=jochen@chromium.org Review URL: https://codereview.chromium.org/238353015 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20876 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Mar, 2014 1 commit
-
-
marja@chromium.org authored
- Distinguish between context bound scripts (Script) and context unbound scripts (UnboundScript). - Add ScriptCompiler (which will later contain functions for async compilation). This is a breaking change, in particular, Script::New no longer exists (it is replaced by ScriptCompiler::CompileUnbound). Script::Compile remains as a backwards-compatible shorthand for ScriptCompiler::Compile. Passing CompilerOptions with produce_data_to_cache = true doesn't do anything yet; the only way to generate the data to cache is the old preparsing API. (To be fixed in the next version.) This is a fixed version of https://codereview.chromium.org/186723005/ BUG= R=dcarney@chromium.org Review URL: https://codereview.chromium.org/199063003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19925 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Mar, 2014 2 commits
-
-
marja@chromium.org authored
This reverts revision 19881. Reason: WebKit build failure (will commit a fixed version shortly). BUG= Review URL: https://codereview.chromium.org/196793013 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19882 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
- Distinguish between context bound scripts (Script) and context unbound scripts (UnboundScript). - Add ScriptCompiler (which will later contain functions for async compilation). This is a breaking change, in particular, Script::New no longer exists (it is replaced by ScriptCompiler::CompileUnbound). Script::Compile remains as a backwards-compatible shorthand for ScriptCompiler::Compile. Passing CompilerOptions with produce_data_to_cache = true doesn't do anything yet; the only way to generate the data to cache is the old preparsing API. (To be fixed in the next version.) BUG= R=dcarney@chromium.org Review URL: https://codereview.chromium.org/186723005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19881 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Jan, 2014 1 commit
-
-
svenpanne@chromium.org authored
LOG=y BUG=324225 R=ulan@chromium.org Review URL: https://codereview.chromium.org/124943004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18478 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Dec, 2013 1 commit
-
-
svenpanne@chromium.org authored
LOG=y R=dcarney@chromium.org Review URL: https://codereview.chromium.org/108063003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18342 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Nov, 2013 1 commit
-
-
jochen@chromium.org authored
Also turn on deprecation warnings for samples BUG=v8:3023 R=dcarney@chromium.org, svenpanne@chromium.org LOG=n Review URL: https://codereview.chromium.org/83313002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18007 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Sep, 2013 1 commit
-
-
dcarney@chromium.org authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/24538002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16955 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-