- 24 Feb, 2020 3 commits
-
-
Jakob Kummerow authored
Make sure the "initial pages" memory limit is enforced correctly and throws a CompileError when exceeded. Bump the "maximum pages" memory limit to 65536. The --wasm-max-mem-pages flag now controls the "initial pages" limit; the "maximum pages" limit is always 65536 as spec'ed. This CL depends on https://github.com/WebAssembly/spec/pull/1121. Bug: v8:7881, v8:8633 Change-Id: I68d07cef56633b8b8ce3b3d047c14e1096daf547 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2035876Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#66400}
-
Igor Sheludko authored
... in order to ensure that the serialized data is reusable between ptr-compr and full-ptr V8s having the same version number. Bug: chromium:1054248 Change-Id: Ibf793755fd7e2bab79ed707a3e63dbfb8c89c519 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066980 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#66399}
-
Joyee Cheung authored
Fixes: https://github.com/nodejs/node/issues/31905 Change-Id: Ie802e2592364640cc55555894e586ef33a2c8b6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069397 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#66398}
-
- 23 Feb, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bc497ad..49d87d5 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I524a369fac23f095d2c88a7dd744d4909702c849 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2068980Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#66397}
-
- 22 Feb, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/295ae0d..bc497ad Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/713b351..feb2d0c Rolling v8/buildtools/linux64: git_revision:97cc440d84f050f99ff0161f9414bfa2ffa38f65..git_revision:4166e9fbc1fa5ceab69b69710a0f8b430c50127b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/4a3fef3..672b17e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7aa6824..1773f37 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ib8215dff29ba7d5b8c279d9da66611e19c8d9cff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2068565Reviewed-by:
-
- 21 Feb, 2020 16 commits
-
-
Frank Tang authored
Move functions into anonymous namespce. Remove dead code. Move GetCaseFirst into JSCollator Move HourCycle, ToHourCycle and GetHourCycle into JSDateTimeFormat Change-Id: Ie6089e7f33677dd40169c56198b52d87ba490b20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2067689 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#66395}
-
Frank Tang authored
Bug: v8:10224 Change-Id: I852d3b1e3468086b36e357aceeb0167951205bcc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2067695 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Lei Zhang authored
GCC emits a stringop-truncation warning because set_name() uses the entire buffer for strncpy(). This looks potentially unsafe, though set_name() does the right thing and add a NUL terminator immediately after strncpy() finishes. To make GCC happy, reduce the number of characters copied by 1. Change-Id: I151ba3ac67e82f5ffc092a49a94e4e1769479c71 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2067514Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#66393}
-
Frank Tang authored
Type is usually not used by Intl.v8BreakIterator unless resolvedOptions() is called. Therefore we can save memory by removing it from the object and using a slow test from the iterator to find out the type when needed. Bug: v8:10252 Change-Id: I7a8dfdc8310eab0d1c90278fbadfbae48e49668e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2067694 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Mike Stanton authored
Relanding the Fast C API code with fix for UBSan undefined behavior issue. Design doc: http://doc/1SAHn7d8M7CoazTd1laVF8gduFC_ikZWiYuytrR9c4Oc/ This CL implements basic API with integer and pointer types marshaling. What is not supported yet: - sequences - annotations - floating point arguments - 64-bit arguments - exception handling - InstanceOf checks for the pointer types - functions with non-void return type Bug: chromium:1052746 TBR=yangguo@chromium.org,mvstanton@chromium.org,neis@chromium.org,leszeks@chromium.org,verwaest@chromium.org,mslekova@chromium.org Change-Id: Ifca9de3156cf18c9dac0d14c19f8d6a7004cad83 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066971Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#66391}
-
Wouter Vermeiren authored
After support for ARCH_PPC was dropped, it became a subset of ARCH_PPC64. If you compile for ppc64, then you set the ARCH_PPC64 define which also sets the ARCH_PPC define. To be able to again support ppc (32 bit) those defines should be split up again. This commit only splits up the defines but does not introduce a working ARCH_PPC variant. Bug: v8:10102 Change-Id: I64e0749f8e5a7dc078ee7890d92e57b82706a849 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1989826 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
-
Dominik Inführ authored
Let --trace-gc now also emit whether the GC is a memory reducing GC or not. Change-Id: If0efd9e9a52d9cb861ca9692a2c93812effeabaa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2064220Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#66389}
-
Michael Lippautz authored
Jitless mode does not allocate executable memory, so we can avoid reserving memory in such configurations. Bug: v8:10033 Change-Id: Ie6a943084e3bade85848e3219cb4d8779ed34830 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981505 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Nico Hartmann authored
Bug: v8:10155 Change-Id: I032b27ad7c71d240453e33bef33a447a1530ace9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2060005 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#66387}
-
Nico Hartmann authored
Bug: chromium:1034449 Change-Id: Id121b60af0c8c8621464f15aa754056cecb04595 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2064985 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Clemens Backes authored
The atomics.wait implementations need to reset the "thread in wasm" flag during their execution, as they might handle interrupts, at which point we assume (and occasionally check) that the "thread in wasm" flag is not set. Also for security it's better to reset the flag as soon as we leave wasm code. R=ahaas@chromium.org Bug: chromium:1054507 Change-Id: Iad03a54819d271968568505445890fde732e6844 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066967Reviewed-by:
-
Clemens Backes authored
This extends the debug side table test to check that the two methods {ExecuteLiftoffCompilation} and {GenerateLiftoffDebugSideTable} return the same debug side table. This is important, because for code without breakpoints, we generate the debug side table lazily via the {GenerateLiftoffDebugSideTable} method, and it needs to match the code generated previously via {ExecuteLiftoffCompilation}. R=thibaudm@chromium.org Bug: v8:10147 Change-Id: I267f599beb3fe39a1ccf22840a9d0a7f9bc5143e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066957Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66384}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/448b7bc..295ae0d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/a657f87..4a3fef3 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/56c9bd5..7aa6824 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ide0328aad4c9f1e0926e81d115584051b24fbb2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2067878Reviewed-by:
-
Ng Zhi An authored
The AVX versions of pabsb, pabsw, and pabsd have an incorrect function signature, they should only have two operands. So, extract them into another macro list. And separately generate the right signatures and implementations. Also update the disasm and tests. Bug: v8:10233 Change-Id: I95ee0bf12bb285d10324ecedcec28e941f64d2dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2063199Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#66382}
-
Ng Zhi An authored
Define macros to identify constant shift values, we can emit better codegen in these cases. Otherwise we need to mask the shift value before shifting. We also need separate cases for left and right shifts, since right shifts require the shift value to be negated. Bug: v8:10115 Change-Id: I307051b0bcc3c05ebc5cbbf423fb7d068ea9b196 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2061658Reviewed-by:
-
Ng Zhi An authored
Implements lowering for: - i16x8.load8x8_s - i16x8.load8x8_u - i32x4.load16x4_s - i32x4.load16x4_u As before, i64x2 is not implemented since 64-bit lowering and scalar lowering don't work together yet. Bug: v8:9886 Change-Id: I3728d009e053acf82baacbcf1c6c08ea636ef241 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2044546Reviewed-by:
-
- 20 Feb, 2020 19 commits
-
-
Paolo Severini authored
This is the first piece of the wasm debugging prototype (besides the changes to add/remove breakpoints in WasmModuleObject made with https://chromium.googlesource.com/v8/v8.git/+/e699f39caed9a23f8e20bd3a0386a3236e272737). This changelist adds the infrastructure for a GDB-remote stub that will be used to manage debugging sessions via the gdb-remote protocol. It enables the creation and termination of debugging sessions over TCP connections that are managed in a separate thread. The logic to actually send, receive and decode GDB-remote packets will be part of a future changelist. Build with: v8_enable_wasm_gdb_remote_debugging = true Run with: --wasm-gdb-remote Enables Wasm debugging with LLDB (default: false) --wasm-gdb-remote-port TCP port to be used for debugging (default: 8765) --wasm-pause-waiting-for-debugger Pauses the execution of Wasm code waiting for a debugger (default: false) --trace-wasm-gdb-remote Enables tracing of Gdb-remote packets (default: false) Note that most of this code is "borrowed" from the code of the Chromium NaCL GDB-remote stub (located in Chromium in src\native_client\src\trusted\debug_stub). Implementation details: - class GdbServer acts as a singleton manager for the gdb-remote stub. It is instantiated as soon as the first Wasm module is loaded in the Wasm engine. - class GdbServerThread spawns the worker thread for the TCP connection. - class Transport manages the socket connection, in a portable way. - class Session represents a remote debugging session. - class Target represents a debugging target and it’s the place where the debugging packets will be processed and will implement the logic to debug a Wasm engine. Bug: chromium:1010467 Change-Id: Ib2324e5901f5ae1d855b96b99ef0995d407322b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1923407Reviewed-by:
-
Leszek Swirski authored
Bug: chromium:1011762 Change-Id: I58284d50acaf349ed5c56654972e2c2bcece1ec3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2061550 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#66378}
-
Michael Achenbach authored
TBR=mathias@chromium.org Bug: chromium:1054390 Change-Id: I9533a0ca0faa0afa7032aa7dde144df48408c9d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066958Reviewed-by:
-
Michael Lippautz authored
Delaying marking requires tasks to be scheduled. Bug: chromium:1054398 Change-Id: Ib92a0f5541f0e37cbbabfb3dd8185b56680d0142 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066977Reviewed-by:
-
Toon Verwaest authored
An enum cache can only be referenced together with the map that owns the entries that are needed. Otherwise the entires can be trimmed away if the map dies because of transitions. Bug: chromium:1050046 Change-Id: I5bc9dd65ca092c3d5ebc08ce553f6f1dc980d41b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066959 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#66375}
-
Clemens Backes authored
This refactors the debug side table such that we can easily add register information later. In particular - vectors for types and stack offsets are combined into one; - constants are stored in the same vector; - locals and operand stack values are stored in the same vector. A follow-up CL will extend the DebugSideTable to also encode locals or operand stack values held in registers. R=thibaudm@chromium.org Bug: v8:10147, v8:10222 Change-Id: I97adb56b31afdb22896530c7ba2e8a24b5d31da9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2062405 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Dan Elphick authored
This fully tnodifies TryHasOwnProperty, TryLookupProperty, CheckPrototypeEnumCache, CheckEnumCache and ExtractFixedDoubleArrayFillingHoles. CopyElementsOnWrite is also converted except for parameters passed with ParameterMode. Also fixes the type of TryLookupProperty, which fails tests if the object parameter is actually forced to be JSReceiver. Bug: v8:10155 Change-Id: I3a925f1fd3f8a1b610d63d08a49af48ef6da505c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2064979 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#66373}
-
Michael Lippautz authored
Bug: chromium:1054345 Change-Id: Ic26cacfff024fada079b72a0bd26a49dfd0ef709 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2064984 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Frank Tang authored
Skip setting 'latn' numberingSystem and depend on it as default to speed up the performance. Fix ~10% of the regression Bug: chromium:1052751 Change-Id: I8255fefd95476270e14981f1ffe1fd0da71223ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2065334Reviewed-by:
-
Clemens Backes authored
Different loggers had different logic to handle unnamed wasm functions. This CL makes sure that we always set a reasonable name when logging wasm code, and removes handling for unnamed code in individual loggers. Since logging only happens on user action, the code is not optimized for performance (i.e. we always just write to a {std::string}, even if the length of the string is known to be limited). R=jkummerow@chromium.org Bug: chromium:863205 Change-Id: I941f7e8050c97dc938afd7883aaeb3b6347b762d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2064977Reviewed-by: -
Toon Verwaest authored
Change-Id: I1499b15c18fde43193a5e6312b71b29892dad70b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2049849 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#66369}
-
Pierre Langlois authored
Every simulator supports this flag except for Arm64 so let's add it. The ExecuteInstruction() loop being performance sensitive, we avoid updating a counter on a every loop unless the flag is set. Change-Id: I5d40e9f3f03b743b4f354e31e9bfda32789ec098 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2061555Reviewed-by:
-
Leszek Swirski authored
Bug: v8:10244 Change-Id: I868f664f8398e08fee41a868669e71e40f963fc9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2064973 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:10245 Change-Id: If99608d12034c241c37e8b0b345e92dce8847b9f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2064976 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Michael Achenbach authored
No-Try: true Bug: v8:10243 Change-Id: Ief8ef4b39bffbfa30abf32010eb3ae25c05e25f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2064972Reviewed-by:
-
Clemens Backes authored
If multiple code spaces are created, each of them currently gets its own jump table (on 64 bit platforms). Since we try to allocate new code spaces right after existing ones, this is often not necessary. We could instead reuse the existing jump table(s). This saves code space for the unneeded jump tables and avoid the cost of patching the redundant jump tables when we replace code objects. This CL implements this by checking whether an existing jump table (or pair of far jump table and (near) jump table) fully covers a new code space, and reuses the existing jump table in that case. R=ahaas@chromium.org Change-Id: Id8751b9c4036cf8f85f9baa2b0be8b2cfb5716ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2043846Reviewed-by:
-
Kim-Anh Tran authored
Add a test case to ensure that a wasm stack trace prints the source url if it is available. Bug: v8:9762 Change-Id: If44f440529d6017d08e477aa03328c9f40f4244c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2064215Reviewed-by:
-
Shiyu Zhang authored
This can speed up the below micro-bench by 3x and improve JetStream2-tagcloud-SP case by ~2%. Object.prototype.foo = function() {}; let array = ['a','b','c','d','e']; let start = Date.now(); for (let i = 0; i < 1e5; i++) { for (let j in array) {} } console.log(Date.now() - start); Contributed by tao.pan@intel.com Change-Id: I44c948c2e4c28b8e42192f36802a5ea0f82bbe25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2049903Reviewed-by: -
Zhao Jiazhong authored
Port e56a7edb https://crrev.com/c/2002547 Port e15f5ba1 https://crrev.com/c/2011829 Port bc436ed7 https://crrev.com/c/2030731 Original Commit Message: The instruction selector assumed for Word32AtomicPair{Load, Binops, CompareExchange} nodes that if there exists a Projection(1) user, then there also exists a Projection(0) user. This, however, is not the case, because TurboFan eliminates unreachable nodes. The missing projection node lead to a failed DCHECK in the register allocator. Change-Id: I498f751c0c0a4a609f0016d17269eab8f6727229 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056886Reviewed-by:
-
