- 21 Nov, 2016 1 commit
-
-
thestig authored
Instead of directly using v8_enable_inspector_override from build_overrides/v8.gni in all the GN configs, set a v8_enable_inspector variable based on v8_enable_inspector_override and use that everywhere. This is the more common pattern seen in over projects, and reduces the need to include //build_overrides/v8.gni in many files. Review-Url: https://codereview.chromium.org/2520683002 Cr-Commit-Position: refs/heads/master@{#41156}
-
- 14 Nov, 2016 1 commit
-
-
Miran.Karic authored
In component build, unittests did not link with icu libraries, which caused errors. By adding icu libraries to dependencies unittests links correctly. BUG= TEST=unittests/* Review-Url: https://codereview.chromium.org/2479863002 Cr-Commit-Position: refs/heads/master@{#40955}
-
- 12 Oct, 2016 3 commits
-
-
kozyatinskiy authored
This location is used at least in Chromium. BUG=chromium:635948 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2405303002 Cr-Commit-Position: refs/heads/master@{#40225}
-
machenbach authored
BUG=v8:5412 Review-Url: https://codereview.chromium.org/2409133002 Cr-Commit-Position: refs/heads/master@{#40208}
-
machenbach authored
BUG=chromium:635948 Review-Url: https://codereview.chromium.org/2393863002 Cr-Commit-Position: refs/heads/master@{#40194}
-
- 28 Jul, 2016 1 commit
-
-
machenbach authored
The isolate_driver automatically adds referenced shared libraries. They don't need to be listed explicitly. The hard-coded location blocks the GN transition as the library location is different in GYP and GN. BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2190543003 Cr-Commit-Position: refs/heads/master@{#38113}
-
- 27 Jul, 2016 3 commits
-
-
hablich authored
Revert of [gn] Don't use PIE for host executables (patchset #2 id:20001 of https://codereview.chromium.org/2179303003/ ) Reason for revert: Breaks roll: https://codereview.chromium.org/2182043004/ Original issue's description: > [gn] Don't use PIE for host executables > > Using PIE switches on ASLR. With mksnapshot, this can lead > to non-deterministic snapshots. > > BUG=v8:5233 > > Committed: https://crrev.com/4ca39b53245619d94a80a93939613774e68e4649 > Cr-Commit-Position: refs/heads/master@{#38084} TBR=jochen@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5233 Review-Url: https://codereview.chromium.org/2187613003 Cr-Commit-Position: refs/heads/master@{#38092}
-
machenbach authored
Using PIE switches on ASLR. With mksnapshot, this can lead to non-deterministic snapshots. BUG=v8:5233 Review-Url: https://codereview.chromium.org/2179303003 Cr-Commit-Position: refs/heads/master@{#38084}
-
yangguo authored
Review-Url: https://codereview.chromium.org/2175193003 Cr-Commit-Position: refs/heads/master@{#38081}
-
- 22 Jul, 2016 1 commit
-
-
mark authored
This reverts commit 31388627. BUG=chromium:630629 Review-Url: https://codereview.chromium.org/2171373002 Cr-Commit-Position: refs/heads/master@{#37986}
-
- 21 Jul, 2016 1 commit
-
-
jochen authored
R=machenbach@chromium.org BUG= Review-Url: https://codereview.chromium.org/2167723004 Cr-Commit-Position: refs/heads/master@{#37924}
-
- 20 Jul, 2016 2 commits
-
-
jochen authored
That way, backtraces should work BUG= R=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2168593002 Cr-Commit-Position: refs/heads/master@{#37905}
-
machenbach authored
This prepares for relanding: https://codereview.chromium.org/2058033002/ All toplevel variables are visible in files including v8.gni. This works around potential name clashes. BUG=chromium:616034 Review-Url: https://codereview.chromium.org/2169443002 Cr-Commit-Position: refs/heads/master@{#37896}
-
- 15 Jul, 2016 2 commits
-
-
dpranke authored
This change makes the architecture that we target generated v8 code for a property of the current toolchain, rather than a global setting that applies to every toolchain. This will allow us to properly build two snapshots for two different architectures in a single build, which is needed for android webview/monochrome builds. R=brettw@chromium.org, jochen@chromium.org, michaelbai@chromium.org BUG=625383 Review-Url: https://codereview.chromium.org/2116913002 Cr-Commit-Position: refs/heads/master@{#37805}
-
machenbach authored
This uses the same compiler flag as the chrome executable does for better performance comparison. BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2152853004 Cr-Commit-Position: refs/heads/master@{#37798}
-
- 12 Jul, 2016 2 commits
-
-
machenbach authored
Revert of [gn] Experiment: Reset -O3 to -O2. (patchset #1 id:1 of https://codereview.chromium.org/2135313002/ ) Reason for revert: Data collected Original issue's description: > [gn] Experiment: Reset -O3 to -O2. > > Temporary commit to see performance data. Will be reverted > shortly after. > > BUG=chromium:622332 > TBR=vogelheim, jochen > NOTRY=true > > Committed: https://crrev.com/bbb61d8aea732457e1d5a0c9abdd79eacf1622ae > Cr-Commit-Position: refs/heads/master@{#37667} TBR=vogelheim@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:622332 Review-Url: https://codereview.chromium.org/2141113002 Cr-Commit-Position: refs/heads/master@{#37690}
-
machenbach authored
Temporary commit to see performance data. Will be reverted shortly after. BUG=chromium:622332 TBR=vogelheim, jochen NOTRY=true Review-Url: https://codereview.chromium.org/2135313002 Cr-Commit-Position: refs/heads/master@{#37667}
-
- 06 Jul, 2016 3 commits
-
-
machenbach authored
Reland of [gn] Switch more linux32 bots to gn (patchset #1 id:1 of https://codereview.chromium.org/2128493002/ ) Reason for revert: Should be fixed after https://codereview.chromium.org/2123223002/ Original issue's description: > Revert of [gn] Switch more linux32 bots to gn (patchset #3 id:40001 of https://codereview.chromium.org/2122933002/ ) > > Reason for revert: > Breaks test isolation on shared library bot. > > Original issue's description: > > [gn] Switch more linux32 bots to gn > > > > This switches nosnap and shared library bots to gn. > > > > This also unsets external startup data if no snapshot is > > used. > > > > BUG=chromium:474921 > > NOTRY=true > > > > Committed: https://crrev.com/ab4d8fc07d9d35e6fc129098f42aa0317a02244a > > Cr-Commit-Position: refs/heads/master@{#37546} > > TBR=vogelheim@chromium.org,jochen@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:474921 > > Committed: https://crrev.com/a5fa2984257a50ee9440914c7d1a199f64a86194 > Cr-Commit-Position: refs/heads/master@{#37548} TBR=vogelheim@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2126843002 Cr-Commit-Position: refs/heads/master@{#37558}
-
machenbach authored
Revert of [gn] Switch more linux32 bots to gn (patchset #3 id:40001 of https://codereview.chromium.org/2122933002/ ) Reason for revert: Breaks test isolation on shared library bot. Original issue's description: > [gn] Switch more linux32 bots to gn > > This switches nosnap and shared library bots to gn. > > This also unsets external startup data if no snapshot is > used. > > BUG=chromium:474921 > NOTRY=true > > Committed: https://crrev.com/ab4d8fc07d9d35e6fc129098f42aa0317a02244a > Cr-Commit-Position: refs/heads/master@{#37546} TBR=vogelheim@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2128493002 Cr-Commit-Position: refs/heads/master@{#37548}
-
machenbach authored
This switches nosnap and shared library bots to gn. This also unsets external startup data if no snapshot is used. BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2122933002 Cr-Commit-Position: refs/heads/master@{#37546}
-
- 04 Jul, 2016 1 commit
-
-
machenbach authored
BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2109293004 Cr-Commit-Position: refs/heads/master@{#37492}
-
- 30 Jun, 2016 3 commits
-
-
machenbach authored
BUG=chromium:474921 Committed: https://crrev.com/3cfc9f209ed0c173319659114859b7e848812fd7 Review-Url: https://codereview.chromium.org/2105353002 Cr-Original-Commit-Position: refs/heads/master@{#37414} Cr-Commit-Position: refs/heads/master@{#37425}
-
machenbach authored
Revert of [gn] Fix valgrind config (patchset #1 id:1 of https://codereview.chromium.org/2109403002/ ) Reason for revert: Breaks... Original issue's description: > [gn] Fix valgrind config > > BUG=chromium:474921 > NOTRY=true > NOTREECHECKS=true > TBR=vogelheim@chromium.org, jochen@chromium.org > > Committed: https://crrev.com/e97c990a2b1fd0b5b90832a7f182daa25fee8291 > Cr-Commit-Position: refs/heads/master@{#37418} TBR=vogelheim@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2109423002 Cr-Commit-Position: refs/heads/master@{#37419}
-
machenbach authored
BUG=chromium:474921 NOTRY=true NOTREECHECKS=true TBR=vogelheim@chromium.org, jochen@chromium.org Review-Url: https://codereview.chromium.org/2109403002 Cr-Commit-Position: refs/heads/master@{#37418}
-
- 21 Jun, 2016 1 commit
-
-
dpranke authored
The GN configs for different optimization levels are confusing and should probably be reworked, but for now we add a special config specifically so that we can compile with -O3 when appropriate. R=brettw@chromium.org, machenbach@chromium.org BUG=616031, 618678, 621335 Review-Url: https://codereview.chromium.org/2076403002 Cr-Commit-Position: refs/heads/master@{#37158}
-
- 17 Jun, 2016 1 commit
-
-
dpranke authored
R=jochen@chromium.org, machenbach@chromium.org, thakis@chromium.org BUG=chromium:619503 Review-Url: https://codereview.chromium.org/2074003002 Cr-Commit-Position: refs/heads/master@{#37048}
-
- 15 Jun, 2016 1 commit
-
-
machenbach authored
Fix after: https://codereview.chromium.org/2042253002/ https://codereview.chromium.org/2049743002/ Using the data file is the default now and it shouldn't be overridden in v8's build_overrides. Also the isolate logic now needs to include the gni file specifying the flag. BUG=chromium:616033 TBR=jochen@chromium.org, vogelheim@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2062363002 Cr-Commit-Position: refs/heads/master@{#36998}
-
- 14 Jun, 2016 1 commit
-
-
machenbach authored
This moves common configs used by all v8 targets into common templates. This also fixes using v8_optimized_debug correctly in executables and components. BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2054803003 Cr-Commit-Position: refs/heads/master@{#36956}
-
- 07 Jun, 2016 1 commit
-
-
machenbach authored
BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2041303002 Cr-Commit-Position: refs/heads/master@{#36774}
-
- 06 Jun, 2016 1 commit
-
-
machenbach authored
This makes the isolate-driver script rebase all paths to be relative to the isolate-file location. This is an assumption of the go binaries and is needed for batcharchive to work. In gyp, actions were executed relative to the gyp file that specified them, while in gn it's relative to the product dir. BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2039873002 Cr-Commit-Position: refs/heads/master@{#36746}
-
- 03 Jun, 2016 2 commits
-
-
machenbach authored
This adds corresponding *_run targets for all swarming isolate actions existing in gyp. This also wires all targets together under gn_all. BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2033813004 Cr-Commit-Position: refs/heads/master@{#36714}
-
machenbach authored
BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2034633004 Cr-Commit-Position: refs/heads/master@{#36694}
-
- 24 May, 2016 2 commits
-
-
machenbach authored
This moves setting the v8_target_arch default to the shared v8.gni, so that it's available in build_overrides for stand-alone mode. BUG=chromium:605732, chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2006213002 Cr-Commit-Position: refs/heads/master@{#36465}
-
machenbach authored
There are bots on the chromium.lkgr waterfall that need to be able to set v8_target_arch to "arm" while the rest of the target build is "x86". This CL makes that argument a declare_arg(), so that we can do that. BUG=chromium:605732,chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2007843002 Cr-Commit-Position: refs/heads/master@{#36464}
-