Commits · a8443629377531c28151b10d1c9f3b0c6a5b0df9 · Linshizhi / V8

13 Sep, 2013 15 commits

Fix heap verifier for partially constructed arrays when allocation folding is off. · a8443629

hpayer@chromium.org authored Sep 13, 2013

BUG=
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/23934008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16713 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a8443629

Don't update ICs when the receiver has a deprecated map. · 3824d596

verwaest@chromium.org authored Sep 13, 2013

R=ulan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23658047

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16712 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3824d596

remove OS::StackWalk · cb490c99

dcarney@chromium.org authored Sep 13, 2013

R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23703013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16711 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cb490c99

remove getcurrent from stubs · 564a9a68

dcarney@chromium.org authored Sep 13, 2013

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23756009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16710 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

564a9a68

Use regular map-checks to guard string-length loading. · ea77a8ed

verwaest@chromium.org authored Sep 13, 2013

R=ulan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23702039

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16709 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ea77a8ed

Handlify JSObject::DeepCopy method. · 50b05676

mstarzinger@chromium.org authored Sep 13, 2013

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/22934006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16708 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

50b05676

ARM: Improve SeqStringSetChar implementation. · 85401293

bmeurer@chromium.org authored Sep 13, 2013

TEST=/test/mjsunit/lithium/SeqStringSetChar.js
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23890007

Patch from Rodolph Perfetta <rodolph.perfetta@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16707 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

85401293

Revert "Every place where AllocationMemento is initialized with an" · c29295e8

mvstanton@chromium.org authored Sep 13, 2013

This reverts r16705 for breaking Windows build.

R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/23447031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16706 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c29295e8

Every place where AllocationMemento is initialized with an · 25c4f763

mvstanton@chromium.org authored Sep 13, 2013

AllocationSite is now checked to be sure a valid Site goes in.
This is temporary code to diagnose chromium bug 284577.

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23622029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16705 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

25c4f763

Array "splice" changeRecords should be emitted after the performChange has completed (per spec) · 94c4c596

rossberg@chromium.org authored Sep 13, 2013

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23434008

Patch from Rafael Weinstein <rafaelw@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16704 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

94c4c596

Allow implicit conversion of acceptList values to string during Object.observe · f99298bf

rossberg@chromium.org authored Sep 13, 2013

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23464058

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16703 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f99298bf

Use xorps to break the cvtsi2sd unnecessary dependence due to its partially written · e4c179e2

yangguo@chromium.org authored Sep 13, 2013

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/23654026

Patch from Weiliang Lin <weiliang.lin2@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16702 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e4c179e2

Prepare push to trunk. Now working on version 3.21.16. · 8650fae5

dslomov@chromium.org authored Sep 13, 2013

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/23437033

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16699 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8650fae5

MIPS: Bugfix: array constructors that expect a type feedback cell that points... · 2cec3754

palfia@homejinni.com authored Sep 13, 2013

MIPS: Bugfix: array constructors that expect a type feedback cell that points to an AllocationSite were being passed the undefined object in some cases. Clearly separate the cases where we have an AllocationSite and where we don't in the general ArrayConstructorStub.

Port r16693 (0852d4ab)

BUG=
R=gergely@homejinni.com

Review URL: https://codereview.chromium.org/23451057

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16698 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2cec3754

MIPS: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1. · 617f7546

palfia@homejinni.com authored Sep 13, 2013

Port r16688 (fcae0bcf)

Original commit message:
The goal is to unify PropertyCallbackInfo and FunctionCallbackInfo so that they
contain the same fields.

The field order will be:
holder
isolate
return value default value
return value
data
this

This step 1 reorders the PropertyCallbackInfo fields.

BUG=
R=gergely@homejinni.com

Review URL: https://codereview.chromium.org/23513045

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16697 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

617f7546

12 Sep, 2013 25 commits

Reland Handle non-JSObject heap objects using slow-path IC stub guarded by the map. · e9c4a498

verwaest@chromium.org authored Sep 12, 2013

R=mstarzinger@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23578030

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16696 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e9c4a498

MIPS: Improve code generation for the HRandom instruction. · 4f09f428

palfia@homejinni.com authored Sep 12, 2013

Port r16684 (e0f70aa)

Original commit message:
Since the per-context random number generator is now
properly seeded upon context creation, we do not need
to check for lazy-initialization anymore, and so we
can implement the HRandom instruction w/o having to
call into the C function (which means we don't need
to MarkAsCall anymore).

TEST=cctest/test-random
BUG=
R=gergely@homejinni.com

Review URL: https://codereview.chromium.org/23851028

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16695 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4f09f428

MIPS: Fix of r16681 · 705d8132

palfia@homejinni.com authored Sep 12, 2013

Use v0 for return value.

BUG=
R=gergely@homejinni.com

Review URL: https://codereview.chromium.org/23437032

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16694 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

705d8132

Bugfix: array constructors that expect a type feedback cell that points · 5521e2e8

mvstanton@chromium.org authored Sep 12, 2013

to an AllocationSite were being passed the undefined object in some
cases. Clearly separate the cases where we have an AllocationSite and
where we don't in the general ArrayConstructorStub.

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23477071

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16693 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5521e2e8

Revert "Handle non-JSObject heap objects using slow-path IC stub guarded by the map." · ff412d8c

verwaest@chromium.org authored Sep 12, 2013

TBR=mstarzinger@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23475039

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16692 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ff412d8c

Reland "Clean up after r16292 (disable optimization for StringWrappers)." · cb10ceb1

yangguo@chromium.org authored Sep 12, 2013

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/23619036

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16691 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cb10ceb1

NumberUntagD is faster when untagging in a temp register · 5a0d1ba8

olivf@chromium.org authored Sep 12, 2013

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/23684056

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16690 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5a0d1ba8

Handle non-JSObject heap objects using slow-path IC stub guarded by the map. · f375e051

verwaest@chromium.org authored Sep 12, 2013

BUG=chromium:280632
R=mstarzinger@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23691056

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16689 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f375e051

Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1. · 34edb733

mstarzinger@chromium.org authored Sep 12, 2013

The goal is to unify PropertyCallbackInfo and FunctionCallbackInfo so that they
contain the same fields.

The field order will be:
holder
isolate
return value default value
return value
data
this

This step 1 reorders the PropertyCallbackInfo fields.

BUG=
R=dcarney@chromium.org, mstarzinger@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=16673

Review URL: https://codereview.chromium.org/23620036

Patch from Marja Hölttä <marja@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16688 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

34edb733

Snapshot i18n Javascript code · c5b3ce06

jochen@chromium.org authored Sep 12, 2013

The previous attempt used Boolean instead of $Boolean.

BUG=v8:2745
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23622028

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16687 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c5b3ce06

Use trampoline or handlified JSObject::SetLocalPropertyIgnoreAttributes. · 6c18fbc2

mstarzinger@chromium.org authored Sep 12, 2013

R=verwaest@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=16642

Review URL: https://codereview.chromium.org/24093002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16686 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6c18fbc2

Fix compile error with CLANG. · a33f273c

titzer@chromium.org authored Sep 12, 2013

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23475038

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16685 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a33f273c

Improve code generation for the HRandom instruction. · 0bdbadcf

bmeurer@chromium.org authored Sep 12, 2013

Since the per-context random number generator is now
properly seeded upon context creation, we do not need
to check for lazy-initialization anymore, and so we
can implement the HRandom instruction w/o having to
call into the C function (which means we don't need
to MarkAsCall anymore).

TEST=cctest/test-random
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/23478031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16684 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0bdbadcf

First implementation of HUnique<T> and HUniqueSet<T>, which is supposed to replace UniqueValueId. · dc901fae

titzer@chromium.org authored Sep 12, 2013

BUG=
R=rossberg@chromium.org, verwaest@chromium.org

Review URL: https://codereview.chromium.org/23609020

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16683 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dc901fae

Reland "Fix phis for non-sse2 double values" · bd5fa9c9

olivf@chromium.org authored Sep 12, 2013

Remove VerifyX87StackDepth from non-debug code.

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/23621038

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16682 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bd5fa9c9

Simplify installing concurrently recompiled code. · 151e5149

yangguo@chromium.org authored Sep 12, 2013

Instead of overwriting the code entry of the function, we trigger
an interrupt to install the code on the main thread.

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23542029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16681 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

151e5149

Revert "Fix phis for non-sse2 double values" · 599f42f0

olivf@chromium.org authored Sep 12, 2013

Need to investigate box2d regression.

BUG=
TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/23437028

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16680 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

599f42f0

Revert "Clean up after r16292 (disable optimization for StringWrappers)." · ad25a296

yangguo@chromium.org authored Sep 12, 2013

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23600040

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16679 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ad25a296

Implement in-place rehashing of HashTable. · 0e8e0030

ulan@chromium.org authored Sep 12, 2013

The algorithm puts elements into correct positions in multiple iterations.
On the first iteration it tries to put elements at entries specified by
their first hash probe. On the second iteration -- by the second
hash probe, and so on. Overall it does O(k*n) memory accesses, where
k is the maximum number of probes required for an element and n is the
capacity of the hash table. The expectation is that k will be small.

R=mstarzinger@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23658031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16678 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0e8e0030

Clean up after r16292 (disable optimization for StringWrappers). · 996813cc

yangguo@chromium.org authored Sep 12, 2013

R=jochen@chromium.org
BUG=v8:2855

Review URL: https://codereview.chromium.org/22891028

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16677 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

996813cc

ARM: remove the regexp specific literal pool. · 6a558d10

rodolph.perfetta@gmail.com authored Sep 12, 2013

It is replaced by a mov_label_offset(Register, Label*) instruction.

BUG=none
TEST=test/cctest/test-assembler-arm.cc
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23515007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6a558d10

Revert "Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1." · e6d10e42

mstarzinger@chromium.org authored Sep 12, 2013

TBR=marja@chromium.org

Review URL: https://codereview.chromium.org/23431019

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16675 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e6d10e42

Unnecessay SSE2 check on x64 · fa2ad975

yangguo@chromium.org authored Sep 12, 2013

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/23619033

Patch from Weiliang Lin <weiliang.lin2@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16674 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fa2ad975

Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1. · 541840f8

mstarzinger@chromium.org authored Sep 12, 2013

The goal is to unify PropertyCallbackInfo and FunctionCallbackInfo so that they
contain the same fields.

The field order will be:
holder
isolate
return value default value
return value
data
this

This step 1 reorders the PropertyCallbackInfo fields.

BUG=
R=dcarney@chromium.org, mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23620036

Patch from Marja Hölttä <marja@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16673 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

541840f8

Fix phis for non-sse2 double values · 553d73a2

olivf@chromium.org authored Sep 12, 2013

Since hydrogen will try to merge phi-inputs using registers, even if
the values are spilled, we cannot mark LGoto as double clobbering
instruction.

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/23068038

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16671 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

553d73a2