- 04 Feb, 2020 1 commit
-
-
Natalie Silvanovich authored
Bug: chromium:1048354 Change-Id: Ib37c33f918e96b100926b8247a2ca034482fb978 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2028840 Commit-Queue: Natalie Silvanovich <natashenka@google.com> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#66092}
-
- 24 May, 2019 1 commit
-
-
Yang Guo authored
TBR=mvstanton@chromium.org,neis@chromium.org,ahaas@chromium.org Bug: v8:9247 Change-Id: I5433c863a54f3412d73df0d38aba3fdbcfac7ebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627973 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61830}
-
- 18 Jan, 2019 1 commit
-
-
Caitlin Potter authored
v8::Isolate::kAttemptOverrideReadOnlyOnPrototypeSloppy and v8::Isolate::kAttemptOverrideReadOnlyOnPrototypeStrict are no longer incremented. BUG=v8:8175 R=gsathya@chromium.org, littledan@chromium.org Change-Id: Ia5f8f9226a54d88c15a3c3b4a5941d774eb1834a Reviewed-on: https://chromium-review.googlesource.com/c/1417381Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#58934}
-
- 06 Dec, 2018 1 commit
-
-
Jakob Gruber authored
A spec change to simplify IsRegExp has been proposed: https://github.com/tc39/ecma262/pull/1318 This CL adds use counters for cases in which the spec change would alter behavior: 1. o[@@match] is trueish but o is not a JSRegExp 2. o[@@match] is falseish (but not undefined) and o is a JSRegExp This is the V8 side of required changes. The Chromium-side CL: https://crrev.com/c/1360730 Drive-by: TNodeify IsRegExp. Tbr: yangguo@chromium.org Bug: v8:8522 Change-Id: I3766e02977f256a80d0e59472d3bafa9c692af9e Reviewed-on: https://chromium-review.googlesource.com/c/1360630Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58064}
-
- 02 Dec, 2018 1 commit
-
-
Mathias Bynens authored
The `readonly: true` key-value pair is redundant since it gets ignored anyhow. This patch removes it. Also, `configurable: false` is implied when using `Object.defineProperty` (just like `enumerable: false` and `writable: false`). Therefore, specifying only `configurable` but not `enumerable` and `writable` gave the impression that configurability was somehow the deciding factor for this test. Instead, the only important data property for this test is `writable: false`. This patch lists all four data property attributes explicitly, making it clear that only `writable` has a “special” value. Bug: v8:8175, v8:8238 Change-Id: Icfc6262f246712a64cdfcffff7b648f5681a711e Reviewed-on: https://chromium-review.googlesource.com/c/1357048Reviewed-by: Caitlin Potter <caitp@igalia.com> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#57986}
-
- 16 Oct, 2018 1 commit
-
-
Caitlin Potter authored
Adds 2 counts to see how often this occurs on the web, both the throwing version (strict mode), and the no-op sloppy mode case, to help determine if the proposal at https://github.com/tc39/ecma262/pull/1307 is web compatible. This is the V8 side of required changes. The Chromium-side CL: https://crrev.com/c/1280618 BUG=v8:8175 R=littledan@chromium.org, cbruni@chromium.org, jkummerow@chromium.org, yangguo@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Id12336c2e566093bb554b6d4624c9301fbc4a0f7 Reviewed-on: https://chromium-review.googlesource.com/c/1255549 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#56706}
-
- 20 Sep, 2018 1 commit
-
-
Sathya Gunasekaran authored
Previously, Atomics.notify was just an alias to Atomics.wake, which doesn't quite let us add a use counter for these individual builtins. This patch refactors the existing Atomics.wake into a separate function that is called from two separate builtins. Bug: v8:7883 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: If54c8f769b7949d88d327cfb2f70db394f32a0b7 Reviewed-on: https://chromium-review.googlesource.com/1234581 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#56105}
-
- 06 Jan, 2018 1 commit
-
-
Adam Klein authored
As noted in the attached bug, accurately counting this would require significant changes to the parser and is thus infeasible. Bug: v8:7211 Change-Id: I61f14c948f50e0f97e596a9696d72a3570ad588a Reviewed-on: https://chromium-review.googlesource.com/853214Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#50393}
-
- 17 Nov, 2017 1 commit
-
-
Adam Klein authored
It was shipped in Chrome 62. Bug: v8:5070 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I77119540411d1fe15691d40012cb96f4e2e45048 Reviewed-on: https://chromium-review.googlesource.com/776154Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#49434}
-
- 31 Oct, 2017 1 commit
-
-
Natalie Silvanovich authored
Change-Id: I7e833c3b06cfb3ff9eda663c2bee4981013744b0 Adding index accessor counter Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ic353c11fa0f430537819387d17eedeec5466d9cc Bug: Reviewed-on: https://chromium-review.googlesource.com/741169Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Natalie Silvanovich <natashenka@google.com> Cr-Commit-Position: refs/heads/master@{#49061}
-
- 13 Oct, 2017 1 commit
-
-
Mathias Bynens authored
New code should use nullptr instead of NULL. This patch updates existing use of NULL to nullptr where applicable, making the code base more consistent. BUG=v8:6928,v8:6921 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I4687f5b96fcfd88b41fa970a2b937b4f6538777c Reviewed-on: https://chromium-review.googlesource.com/718338 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48557}
-
- 21 Sep, 2017 1 commit
-
-
Mostyn Bramley-Moore authored
By adding a per test source file namespace, we can avoid a lot of symbol collisions in jumbo builds. While we're at it, let's remove some "using" statements that also cause trouble. Bug: chromium:746958 Change-Id: I6f8a723e1ba5905888638e0687b23193f3f012ca Reviewed-on: https://chromium-review.googlesource.com/676803Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com> Cr-Commit-Position: refs/heads/master@{#48102}
-
- 04 Aug, 2017 1 commit
-
-
Adam Klein authored
This was suggested by bmeurer after running into the confusing example of: x => {x:x} which might appear to be an arrow function that returns an object literal containing its argument, but instead is an arrow function that does nothing. While it's unclear whether the language would change to make this probable programmer error an actual syntax error, we can at least gather some data on the question of whether we see any such code in the wild. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I08202039ecf7a7a4c71ad95ecd839436b4ec2af8 Reviewed-on: https://chromium-review.googlesource.com/600888 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#47171}
-
- 02 Aug, 2017 1 commit
-
-
Adam Klein authored
This behavior has been staged successfully without a bug report, and has been shipped in the latest versions of Firefox and Safari. Bug: v8:5070 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I084cae2cc303d6a213bd6789297b91656e162d6b Reviewed-on: https://chromium-review.googlesource.com/595129Reviewed-by: Daniel Ehrenberg <littledan@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47098}
-
- 27 Dec, 2016 1 commit
-
-
bakkot authored
This syntax was formerly legal per ECMAScript, but has been a SyntaxError for some time now. V8 deviates from spec in that it is instead a runtime error; we'd like to know if we can get away with removing it (at least in sloppy mode) or if the spec should be changed. c.f. https://github.com/tc39/ecma262/issues/257#issuecomment-195106880 Also add self to authors file BUG=v8:4480 Review-Url: https://codereview.chromium.org/2599253002 Cr-Commit-Position: refs/heads/master@{#41960}
-
- 24 Jun, 2016 1 commit
-
-
bakkot authored
We deviate from spec in that, in our implementation, __defineGetter__ on non- configurable properties returns false instead of throwing a TypeError. This commit adds a use counter to track how often we would be throwing an error we currently avoid, to determine if we can change to align with spec or if the spec is not implementable. BUG=v8:5070 Review-Url: https://codereview.chromium.org/2089533002 Cr-Commit-Position: refs/heads/master@{#37259}
-