1. 04 Feb, 2020 1 commit
  2. 24 May, 2019 1 commit
  3. 18 Jan, 2019 1 commit
  4. 06 Dec, 2018 1 commit
  5. 02 Dec, 2018 1 commit
    • Mathias Bynens's avatar
      [cctest] Clarify OverrideReadOnlyPropertyOnPrototype setup · e000fa36
      Mathias Bynens authored
      The `readonly: true` key-value pair is redundant since it gets
      ignored anyhow. This patch removes it.
      
      Also, `configurable: false` is implied when
      using `Object.defineProperty` (just like `enumerable: false`
      and `writable: false`). Therefore, specifying only `configurable`
      but not `enumerable` and `writable` gave the impression that
      configurability was somehow the deciding factor for this test.
      Instead, the only important data property for this test is
      `writable: false`. This patch lists all four data property
      attributes explicitly, making it clear that only `writable` has
      a “special” value.
      
      Bug: v8:8175, v8:8238
      Change-Id: Icfc6262f246712a64cdfcffff7b648f5681a711e
      Reviewed-on: https://chromium-review.googlesource.com/c/1357048Reviewed-by: 's avatarCaitlin Potter <caitp@igalia.com>
      Commit-Queue: Mathias Bynens <mathias@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57986}
      e000fa36
  6. 16 Oct, 2018 1 commit
  7. 20 Sep, 2018 1 commit
  8. 06 Jan, 2018 1 commit
  9. 17 Nov, 2017 1 commit
  10. 31 Oct, 2017 1 commit
  11. 13 Oct, 2017 1 commit
  12. 21 Sep, 2017 1 commit
  13. 04 Aug, 2017 1 commit
    • Adam Klein's avatar
      [parsing] Add a UseCounter for labeled expression statements · 946f78a0
      Adam Klein authored
      This was suggested by bmeurer after running into the confusing
      example of:
      
        x => {x:x}
      
      which might appear to be an arrow function that returns an object
      literal containing its argument, but instead is an arrow function
      that does nothing.
      
      While it's unclear whether the language would change to make this
      probable programmer error an actual syntax error, we can at least
      gather some data on the question of whether we see any such code
      in the wild.
      
      Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I08202039ecf7a7a4c71ad95ecd839436b4ec2af8
      Reviewed-on: https://chromium-review.googlesource.com/600888
      Commit-Queue: Adam Klein <adamk@chromium.org>
      Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#47171}
      946f78a0
  14. 02 Aug, 2017 1 commit
  15. 27 Dec, 2016 1 commit
  16. 24 Jun, 2016 1 commit
    • bakkot's avatar
      add use counters for __defineGetter__ failing · b2ce1fa2
      bakkot authored
      We deviate from spec in that, in our implementation, __defineGetter__ on non-
      configurable properties returns false instead of throwing a TypeError. This commit
      adds a use counter to track how often we would be throwing an error we currently
      avoid, to determine if we can change to align with spec or if the spec is not
      implementable.
      
      BUG=v8:5070
      
      Review-Url: https://codereview.chromium.org/2089533002
      Cr-Commit-Position: refs/heads/master@{#37259}
      b2ce1fa2