- 27 Feb, 2017 1 commit
-
-
Daniel Cheng authored
This will randomly break compilation units that don't happen to #define DCHECK before v8-util.h is included. BUG=chromium:688155 Change-Id: I7abdaf87c8bb7aca995d9e6e7ef8b4faff0dc50c Reviewed-on: https://chromium-review.googlesource.com/447002Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#43455}
-
- 04 Nov, 2016 1 commit
-
-
mlippautz authored
API was highly experimental. Embedders should use V8::RegisterExternalReference instead. BUG=chromium:468240 R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2474163002 Cr-Commit-Position: refs/heads/master@{#40769}
-
- 28 Sep, 2016 1 commit
-
-
hlopko authored
This cl introduces reporter to the embedder heap tracer. Heap tracer uses reporter to report reachable objects from embedder heap. This refactoring is a step towards being able to take heap snapshots with wrapper tracing. LOG=no BUG=468240 Review-Url: https://codereview.chromium.org/2371733002 Cr-Commit-Position: refs/heads/master@{#39824}
-
- 06 May, 2016 1 commit
-
-
ulan authored
This removes: - PersistentBase::SetWeak that takes WeakCallbackData. The embedders should use the version that takes WeakCallbackInfo. - PersistentBase::SetPhantom. The embedders should SetWeak that takes WeakCallbackInfo. Functions in DefaultPersistentValueMapTraits are changed to accept WeakCallbackInfo instead of WeakCallbackData. BUG=chromium:609808 LOG=NO Review-Url: https://codereview.chromium.org/1953263002 Cr-Commit-Position: refs/heads/master@{#36079}
-
- 15 Apr, 2016 1 commit
-
-
hlopko authored
PersistentValueMap is used to hold per-world wrappers in the blink. Currently, when we trace wrappers, we visit wrappers in all worlds via this PersistentValueMap. This cl introduces convenient (and faster) way of registering these external references. BUG=468240 LOG=no Review URL: https://codereview.chromium.org/1883043003 Cr-Commit-Position: refs/heads/master@{#35523}
-
- 03 Sep, 2015 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1318863004 Cr-Commit-Position: refs/heads/master@{#30554}
-
- 15 Jul, 2015 1 commit
-
-
epertoso authored
R=jochen@chromium.org LOG=y BUG= Review URL: https://codereview.chromium.org/1209403005 Cr-Commit-Position: refs/heads/master@{#29680}
-
- 22 Apr, 2015 1 commit
-
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/1104463002 Cr-Commit-Position: refs/heads/master@{#27994}
-
- 10 Apr, 2015 1 commit
-
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/1074153002 Cr-Commit-Position: refs/heads/master@{#27750}
-
- 26 Mar, 2015 1 commit
-
-
dcarney authored
R=jochen@chromium.org, erikcorry@chromium.org BUG= Review URL: https://codereview.chromium.org/998253006 Cr-Commit-Position: refs/heads/master@{#27475}
-
- 24 Mar, 2015 1 commit
-
-
dcarney authored
additionally, add a drive by fix to WeakCallbackInfo R=jochen@chromium.org, erikcorry@chromium.org BUG= Review URL: https://codereview.chromium.org/1026283004 Cr-Commit-Position: refs/heads/master@{#27407}
-
- 09 Mar, 2015 1 commit
-
-
dcarney authored
since the old style weakness is slated for removal, we might as well reuse the name to limit confusion. additionally I simplified the callback type to a enum to either get internal field values or not this should be a non-breaking change with the exception of PhantomPersistentValueMap, which is unused. R=jochen@chromium.org, erikcorry@chromium.org BUG= Review URL: https://codereview.chromium.org/989153003 Cr-Commit-Position: refs/heads/master@{#27084}
-
- 23 Jan, 2015 1 commit
-
-
erikcorry authored
R=dcarney@chromium.org BUG= Review URL: https://codereview.chromium.org/863443005 Cr-Commit-Position: refs/heads/master@{#26246}
-
- 10 Jun, 2014 1 commit
-
-
svenpanne@chromium.org authored
No clue why this seems to be an issue only for me, though... R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/321123002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21735 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 May, 2014 1 commit
-
-
vogelheim@chromium.org authored
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN The bug: The code assumed that a weak Persistent whose weak callback is being called would still be weak. That isn't true since the persistent is un-weakened by the garbage collector before calling the weak callback. [1] Specifically, PersistentValueMap would funnel all 'remove' actions through its Release method, which uses PersistentBase::ClearWeak to obtain the callback data. [2] For 'removes' caused by the weak callback, ClearWeak always returns a NULL-pointer since by that time the weak persistent was already un-weakend. The result was a memory leak in the test, since the code to delete the weak callback data would delete NULL. The fix: I explicity call Traits::DisposeCallbackData from the weak callback with the data obtained from the v8::WeakCallbackData. To avoid invalid calls to DisposeCallbackData, I also check whether this instance is (still) weak before calling it. (That check could easily be elided if it's expensive, for the price of having two 'remove' code paths.) Severety: Probably low. At least in Chromium, noone uses the API in a way to trigger this; only the test does. [1] https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/global-handles.cc&q=global-handles.cc&sq=package:chromium&type=cs&l=231 [2] https://code.google.com/p/chromium/codesearch#chromium/src/v8/include/v8-util.h&sq=package:chromium&l=332-345 R=dcarney@chromium.org, dcarney BUG= Review URL: https://codereview.chromium.org/297193004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21514 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 May, 2014 1 commit
-
-
ishell@chromium.org authored
1) runtime/references checks temporarily disabled (56 items left) 2) other errors fixed R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/277913002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Apr, 2014 1 commit
-
-
vogelheim@chromium.org authored
(These have been causing compilation problems on some platforms. For VS, V8_INLINE turns into 'force inline', which will then cause a problem when the compiler won't actually inline. Search for "C4714 warning" for details.) BUG= R=jochen@chromium.org Review URL: https://codereview.chromium.org/212693006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20432 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Apr, 2014 1 commit
-
-
jochen@chromium.org authored
BUG= R=jochen@chromium.org Review URL: https://codereview.chromium.org/217123004 Patch from Daniel Vogelheim <vogelheim@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20412 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 31 Mar, 2014 1 commit
-
-
dcarney@chromium.org authored
BUG= R=dcarney@chromium.org Review URL: https://codereview.chromium.org/216973002 Patch from Daniel Vogelheim <vogelheim@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20341 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Mar, 2014 1 commit
-
-
marja@chromium.org authored
- Use the surrounding map (instead of Traits::Impl) for weak callback. - Provide for a fast reference to a mapped value. - Restructure Traits to accomondate for the first point above. [Why?] As discussed, I proceeded to replace Impl with the map. The problem I encountered with that version is that now the Traits class depends on itself: The weak-related methods require the map type in their signature. But the map type includes the Traits class and hence the Traits class method signatures depend on the specific Traits class. That makes them practically un-derivable: While you can derive a Traits class from another one, since the compiler now expects methods with a different signature. To accommodate, I pulled the dispose traits into the weak traits class. I also removed the Impl*/MapType* parameter from the Dispose call, since no implementation seems to need it. R=dcarney@chromium.org BUG= Review URL: https://codereview.chromium.org/212893007 Patch from Daniel Vogelheim <vogelheim@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20326 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Mar, 2014 1 commit
-
-
dcarney@chromium.org authored
Re-try of issue 201643003. This caused linker errors on Win64, since the linker insists on seeing the StrongMapTrait method implementations even though they are never used. This will provide default implementations for them. R=dcarney@chromium.org BUG= Review URL: https://codereview.chromium.org/204343006 Patch from Daniel Vogelheim <vogelheim@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20084 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Mar, 2014 2 commits
-
-
yangguo@chromium.org authored
This reverts r20038. TBR=vogelheim@chromium.org Review URL: https://codereview.chromium.org/203553002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20042 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
BUG= R=dcarney@chromium.org Review URL: https://codereview.chromium.org/201643003 Patch from Daniel Vogelheim <vogelheim@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20038 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Mar, 2014 1 commit
-
-
dcarney@chromium.org authored
of v8.h. R=dcarney@chromium.org BUG= Review URL: https://codereview.chromium.org/195793024 Patch from Daniel Vogelheim <vogelheim@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19936 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-