Commits · a68d89d099a3703a000d10a91e27838adeb7b5ac · Linshizhi / V8

17 Sep, 2013 6 commits

ARM: Add tests for CopyBytes. · a68d89d0

ulan@chromium.org authored Sep 17, 2013

TEST=cctest/test-macro-assembler-arm.cc

R=ulan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23480027

Patch from Bangfu Tao <bangfu.tao@samsung.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16751 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a68d89d0

Fix handling of Integer32 in HLoadNamedField and HStoreNamedField on x64. · 8e285060

bmeurer@chromium.org authored Sep 17, 2013

The current implementation of Integer32 named loads and stores
is broken on x64.

R=danno@chromium.org

Review URL: https://codereview.chromium.org/23548039

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16750 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8e285060

Use icu_gyp_path variable to reference ICU gyp file · b3310c3a

jochen@chromium.org authored Sep 17, 2013

That way, embedders can put the icu sources whereever they want and
aren't forced to put them under third_party/gyp

BUG=none
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/23598011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16749 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b3310c3a

revert 16744 for breaking build · c09d00d1

dcarney@chromium.org authored Sep 17, 2013

TBR=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/24196002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16746 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c09d00d1

Refactoring only: Make it clear that MOD is special. · 87ff987f

svenpanne@chromium.org authored Sep 17, 2013

LArithmeticD should really be 5 different instructions... :-/

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23800005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16745 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

87ff987f

add context save for GenerateFastApiCall · 0020146f

dcarney@chromium.org authored Sep 17, 2013

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23461039

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16744 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0020146f

16 Sep, 2013 20 commits

MIPS: Orthogonalize Lithium binary op instructions. · 29d0f52a

palfia@homejinni.com authored Sep 16, 2013

Port r16739 (cd8e4a21)

BUG=
R=gergely@homejinni.com

Review URL: https://codereview.chromium.org/23494054

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16743 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

29d0f52a

Chromium 284577 needs a mitigation CL added. There is a TODO to remove · 61a3605a

mvstanton@chromium.org authored Sep 16, 2013

the mitigation when the cause of the bug is discovered.

BUG=
R=hpayer@chromium.org, mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23606032

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16742 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

61a3605a

Fix compile error. · 1d07d315

yangguo@chromium.org authored Sep 16, 2013

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23651012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16741 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1d07d315

Add mutex when accessing concurrent recompilation output queue. · ea5ab721

yangguo@chromium.org authored Sep 16, 2013

Also small refactorings.

R=mstarzinger@chromium.org
BUG=291236

Review URL: https://codereview.chromium.org/23902033

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16740 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ea5ab721

Orthogonalize Lithium binary op instructions. · 42879d10

olivf@chromium.org authored Sep 16, 2013

BUG=
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23703014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16739 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

42879d10

HeapProfiler: compile fix for win x64. · 849815fa

loislo@chromium.org authored Sep 16, 2013

BUG=none
TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/24178003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16738 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

849815fa

Don't lookup the cache for the result of Function::New · be8621a4

mstarzinger@chromium.org authored Sep 16, 2013

Since isFunctionCached condition is wrong, we lookup the cache even if
doNotCache is true. As a result, Function::New always returns null
except for the first time.

BUG=272579
R=dcarney@chromium.org, mstarzinger@chromium.org, yhirano@chromium.org

Review URL: https://codereview.chromium.org/23513048

Patch from Yusuke Suzuki <yusukesuzuki@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16737 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

be8621a4

Revert "Add flags to force or prevent setting of isolate.is_memory_constrained." · bf345f02

svenpanne@chromium.org authored Sep 16, 2013

It introduces static initializers for the new "MAYBE_BOOL" kind of
flags, which is a no-no for Chrome. This has to be done differently.

TBR=danno@chromium.org

Review URL: https://codereview.chromium.org/23621044

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16736 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bf345f02

In the case of shift amounts with two constants and if their sum is equal 32,... · 8ed9b08e

svenpanne@chromium.org authored Sep 16, 2013

In the case of shift amounts with two constants and if their sum is equal 32, then shift can also be replaced with bit rotate.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/24095002

Patch from Bangfu Tao <bangfu.tao@samsung.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16735 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8ed9b08e

HeapSnapshot: replace O(N*ln(N)) algorithm of sorting with O(N) one. · 0daf224c

loislo@chromium.org authored Sep 16, 2013

We have HashMap for the strings. They got id sequentially. So we could use index sort.

BUG=none
R=alph@chromium.org, yangguo@chromium.org

Review URL: https://codereview.chromium.org/24174002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16734 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0daf224c

Add flags to force or prevent setting of isolate.is_memory_constrained. · f30a7343

svenpanne@chromium.org authored Sep 16, 2013

Also enable MAYBE_BOOL flags for when you want to only do something if the flag was explicitly set to true or false.

BUG=None
R=hpayer@chromium.org, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23890027

Patch from Ross McIlroy <rmcilroy@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16733 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f30a7343

Make HValue::ActualValue() traverse all idefs. · af87218f

titzer@chromium.org authored Sep 16, 2013

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23691064

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16732 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

af87218f

Tweak HConstant::EmitAtUses() to eliminate useless constant generation · d5d7b1d9

danno@chromium.org authored Sep 16, 2013

BUG=2881
R=danno@chromium.org

Review URL: https://codereview.chromium.org/23811011

Patch from Weiliang Lin <weiliang.lin2@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16731 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d5d7b1d9

Make HCompareNumericAndBranch safe for snapshots on ia32. · 73b03b89

bmeurer@chromium.org authored Sep 16, 2013

R=danno@chromium.org

Review URL: https://codereview.chromium.org/24078012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16730 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

73b03b89

Fixed shared_library build on Windows. · 7b41d6d4

svenpanne@chromium.org authored Sep 16, 2013

BUG=v8:2879
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/24054008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16729 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7b41d6d4

Remove unused context parameter from AddIncrementCounter(). · 8588b744

bmeurer@chromium.org authored Sep 16, 2013

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/23622033

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16728 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8588b744

ARM: Tweak the integer division operation. · 39f0ccc2

rodolph.perfetta@gmail.com authored Sep 16, 2013

BUG=none
TEST=test/mjsunit/lithium/DivI.js
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23536045

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16727 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

39f0ccc2

Rename StubType MAP_TRANSITION to TRANSITION. · 223ac69f

verwaest@chromium.org authored Sep 16, 2013

R=mvstanton@chromium.org

Review URL: https://chromiumcodereview.appspot.com/24120007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16726 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

223ac69f

HeapProfiler: replace pointer based matching algorithm with string matching... · 2abe14b8

loislo@chromium.org authored Sep 16, 2013

HeapProfiler: replace pointer based matching algorithm with string matching algorithm for strings_ member.

pros: decreased snapshot size.
cons: increased serialization time.

I've tested the implementation on gmail 90mb heap.
I saw no speed degradation on the serialization step.
The snapshot size lost ~3% of its size. 100Mb -> 97Mb.

BUG=none
R=alph@chromium.org, yangguo@chromium.org

Review URL: https://codereview.chromium.org/24120006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16725 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2abe14b8

Prepare push to trunk. Now working on version 3.21.17. · 043abcd3

mvstanton@chromium.org authored Sep 16, 2013

R=machenbach@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23437040

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16722 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

043abcd3

13 Sep, 2013 14 commits

MIPS: remove getcurrent from stubs. · 6d3b3255

plind44@gmail.com authored Sep 13, 2013

Port r16710 (c5203f8)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/23710046

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16721 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6d3b3255

MIPS: Improve SeqStringSetChar implementation. · 23fc6218

plind44@gmail.com authored Sep 13, 2013

Port r16707 (a25d669)

TEST=/test/mjsunit/lithium/SeqStringSetChar.js
BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/23484043

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16720 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

23fc6218

Every place where AllocationMemento is initialized with an · 516339cb

mvstanton@chromium.org authored Sep 13, 2013

AllocationSite is now checked to be sure a valid Site goes in.

This is temporary code to diagnose chromium bug 284577.

(This is a second attempt, the first attempt ran into the problem of undefined ordering of function calls in Windows and Mac optimized builds, see the fixes in code-stubs-hydrogen.cc).

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23440035

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16719 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

516339cb

revert 16717 for breaking everything · 31105962

dcarney@chromium.org authored Sep 13, 2013

TBR=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23708039

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16718 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

31105962

line up crashing with chrome · bbaf775d

dcarney@chromium.org authored Sep 13, 2013

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23868025

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16717 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bbaf775d

Add Contains(), at(), and a constructor with raw addresses to UniqueSet<T> and Unique<T>. · 25372ac1

titzer@chromium.org authored Sep 13, 2013

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/23872027

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16716 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

25372ac1

Add missing factory method for HDebugBreak. · fe9f9e20

bmeurer@chromium.org authored Sep 13, 2013

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/23619052

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16715 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fe9f9e20

Intel: Branch reordering and port arm EmitNumberUntagD() Improvement · 81425a20

olivf@chromium.org authored Sep 13, 2013

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23872026

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16714 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

81425a20

Fix heap verifier for partially constructed arrays when allocation folding is off. · a8443629

hpayer@chromium.org authored Sep 13, 2013

BUG=
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/23934008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16713 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a8443629

Don't update ICs when the receiver has a deprecated map. · 3824d596

verwaest@chromium.org authored Sep 13, 2013

R=ulan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23658047

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16712 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3824d596

remove OS::StackWalk · cb490c99

dcarney@chromium.org authored Sep 13, 2013

R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23703013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16711 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cb490c99

remove getcurrent from stubs · 564a9a68

dcarney@chromium.org authored Sep 13, 2013

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23756009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16710 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

564a9a68

Use regular map-checks to guard string-length loading. · ea77a8ed

verwaest@chromium.org authored Sep 13, 2013

R=ulan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23702039

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16709 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ea77a8ed

Handlify JSObject::DeepCopy method. · 50b05676

mstarzinger@chromium.org authored Sep 13, 2013

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/22934006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16708 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

50b05676