- 12 Jan, 2017 1 commit
-
-
hablich authored
Revert of Pull define for version out into v8-version.h and separate build target (patchset #1 id:1 of https://codereview.chromium.org/2621983002/ ) Reason for revert: Blocks roll: https://codereview.chromium.org/2633463002/ Original issue's description: > Pull define for version out into v8-version.h and separate build target > > This is part of removing the dependency of the Chromium browser DLL on > Windows on V8. > > R=jochen@chromium.org > BUG=chromium:581766 > > Review-Url: https://codereview.chromium.org/2621983002 > Cr-Commit-Position: refs/heads/master@{#42243} > Committed: https://chromium.googlesource.com/v8/v8/+/45938454177f53fa24cfc08ad97ccbc162c3ba6d TBR=jochen@chromium.org,machenbach@chromium.org,scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:581766 Review-Url: https://codereview.chromium.org/2627713008 Cr-Commit-Position: refs/heads/master@{#42257}
-
- 11 Jan, 2017 1 commit
-
-
scottmg authored
This is part of removing the dependency of the Chromium browser DLL on Windows on V8. R=jochen@chromium.org BUG=chromium:581766 Review-Url: https://codereview.chromium.org/2621983002 Cr-Commit-Position: refs/heads/master@{#42243}
-
- 10 Jan, 2017 2 commits
-
-
hablich authored
Revert of [build] Introduce an embedder version string (patchset #2 id:20001 of https://codereview.chromium.org/2619213002/ ) Reason for revert: Seems to break the Chromium build: https://codereview.chromium.org/2619193005/ Message: [1832/9671] CXX obj/v8/v8_base/version.o FAILED: obj/v8/v8_base/version.o /b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/v8/v8_base/version.o.d -DV8_DEPRECATION_WARNINGS -DDCHECK_ALWAYS_ON=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=289944-2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DV8_I18N_SUPPORT -DENABLE_HANDLE_ZAPPING -DV8_USE_EXTERNAL_STARTUP_DATA -DV8_TARGET_ARCH_X64 -DDEBUG -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../.. -Igen -I../../v8 -I../../v8/include -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -fdebug-prefix-map=/b/c/b/linux/src=. -m64 -march=x86-64 -pthread -g1 --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Werror -Wall -Wno-unused-variable -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wsign-compare -Winconsistent-missing-override -Wshorten-64-to-32 -O3 -fno-ident -fdata-sections -ffunction-sections -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -Wno-deprecated -c ../../v8/src/version.cc -o obj/v8/v8_base/version.o ../../v8/src/version.cc:42:34: error: use of undeclared identifier 'V8_EMBEDDER_STRING' const char* Version::embedder_ = V8_EMBEDDER_STRING; ^ 1 error generated. Original issue's description: > [build] Introduce an embedder version string > > Sometimes, the embedder might want to merge a fix to an abandoned branch > or to a supported branch but the fix is not relevant to Chromium. > This adds a new version string that the embedder can set on compile time > and that will be appended to the official V8 version. > The separator must be provided in the string. For instance, to have a > full version string like "5.5.372.37.custom.1", the embedder must set > V8_EMBEDDER_STRING to ".custom.1". > > Related Node.js issue: https://github.com/nodejs/node/pull/9754 > > BUG=v8:5740 > R=machenbach@chromium.org,hablich@chromium.com,ofrobots@google.com > > Review-Url: https://codereview.chromium.org/2619213002 > Cr-Commit-Position: refs/heads/master@{#42175} > Committed: https://chromium.googlesource.com/v8/v8/+/fc86d4329b253bf21c1dd85469f1ef4b6e5ba01a TBR=hablich@chromium.com,machenbach@chromium.org,ofrobots@google.com,mic.besace@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5740 Review-Url: https://codereview.chromium.org/2621033002 Cr-Commit-Position: refs/heads/master@{#42182}
-
mic.besace authored
Sometimes, the embedder might want to merge a fix to an abandoned branch or to a supported branch but the fix is not relevant to Chromium. This adds a new version string that the embedder can set on compile time and that will be appended to the official V8 version. The separator must be provided in the string. For instance, to have a full version string like "5.5.372.37.custom.1", the embedder must set V8_EMBEDDER_STRING to ".custom.1". Related Node.js issue: https://github.com/nodejs/node/pull/9754 BUG=v8:5740 R=machenbach@chromium.org,hablich@chromium.com,ofrobots@google.com Review-Url: https://codereview.chromium.org/2619213002 Cr-Commit-Position: refs/heads/master@{#42175}
-
- 17 Nov, 2016 1 commit
-
-
vogelheim authored
BUG= TBR=machenbach@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2515443002 Cr-Commit-Position: refs/heads/master@{#41080}
-
- 06 Oct, 2016 1 commit
-
-
hablich authored
TBR=machenbach@chromium.org NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2397153002 Cr-Commit-Position: refs/heads/master@{#40037}
-
- 25 Aug, 2016 1 commit
-
-
hablich authored
TBR=jochen@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2282453002 Cr-Commit-Position: refs/heads/master@{#38908}
-
- 30 Jun, 2016 1 commit
-
-
hablich authored
R=machenbach@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2113663002 Cr-Commit-Position: refs/heads/master@{#37443}
-
- 19 May, 2016 1 commit
-
-
hablich authored
R=machenbach@chromium.org Review-Url: https://codereview.chromium.org/1994923002 Cr-Commit-Position: refs/heads/master@{#36367}
-
- 11 Apr, 2016 1 commit
-
-
hablich authored
R=machenbach@chromium.org Review URL: https://codereview.chromium.org/1876723002 Cr-Commit-Position: refs/heads/master@{#35375}
-
- 28 Feb, 2016 1 commit
-
-
hablich authored
TBR=machenbach@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1744823002 Cr-Commit-Position: refs/heads/master@{#34347}
-
- 17 Feb, 2016 1 commit
-
-
hablich authored
R=machenbach@chromium.org TBR=danno@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1706753002 Cr-Commit-Position: refs/heads/master@{#34076}
-
- 15 Jan, 2016 1 commit
-
-
hablich authored
TBR=danno@chromium.org,machenbach@chromium.org Review URL: https://codereview.chromium.org/1590283002 Cr-Commit-Position: refs/heads/master@{#33333}
-
- 13 Nov, 2015 1 commit
-
-
hablich authored
TBR=machenbach@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1443673002 Cr-Commit-Position: refs/heads/master@{#31985}
-
- 03 Oct, 2015 1 commit
-
-
Michael Hablich authored
TBR=machenbach@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1387763002 . Cr-Commit-Position: refs/heads/master@{#31093}
-
- 21 Aug, 2015 1 commit
-
-
Michael Hablich authored
BUG= TBR=vogelheim@chromium.org,yangguo@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1304203002 . Cr-Commit-Position: refs/heads/master@{#30302}
-
- 10 Jul, 2015 1 commit
-
-
hablich authored
BUG= TBR=machenbach@chromium.org,vogelheim@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1235573002 Cr-Commit-Position: refs/heads/master@{#29569}
-
- 17 May, 2015 1 commit
-
-
hablich authored
BUG= TBR=machenbach@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1123393006 Cr-Commit-Position: refs/heads/master@{#28435}
-
- 06 Apr, 2015 1 commit
-
-
hablich authored
BUG= TBR=machenbach@chromium.org,vogelheim@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1059433002 Cr-Commit-Position: refs/heads/master@{#27604}
-
- 26 Feb, 2015 1 commit
-
-
machenbach authored
Side note: tools/v8-info.sh seems to have been broken ever since the move to git. At least it's not more broken now. BUG=v8:3075 LOG=y TEST=./script_test.py Review URL: https://codereview.chromium.org/959713003 Cr-Commit-Position: refs/heads/master@{#26873}
-