- 11 Nov, 2016 1 commit
-
-
mlippautz authored
BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2493803002 Cr-Commit-Position: refs/heads/master@{#40935}
-
- 10 Nov, 2016 1 commit
-
-
mlippautz authored
Also remove the flag scavenge_reclaim_unmodified_objects which has been defaulted to true for quite some time now. BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2486173002 Cr-Commit-Position: refs/heads/master@{#40878}
-
- 09 Nov, 2016 1 commit
-
-
mlippautz authored
The distinction didn't provide any benefits. BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2492433002 Cr-Commit-Position: refs/heads/master@{#40853}
-
- 21 Oct, 2016 1 commit
-
-
ulan authored
BUG= Review-Url: https://chromiumcodereview.appspot.com/2442693002 Cr-Commit-Position: refs/heads/master@{#40497}
-
- 17 Oct, 2016 1 commit
-
-
jochen authored
R=machenbach@chromium.org,titzer@chromium.org,bmeurer@chromium.org,jgruber@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_win_dbg,v8_mac_dbg;master.tryserver.chromium.android:android_arm64_dbg_recipe Review-Url: https://codereview.chromium.org/2416243002 Cr-Commit-Position: refs/heads/master@{#40350}
-
- 14 Oct, 2016 1 commit
-
-
jochen authored
R=ulan@chromium.org,cbruni@chromium.org,rmcilroy@chromium.org BUG=v8:5215 Review-Url: https://codereview.chromium.org/2413243002 Cr-Commit-Position: refs/heads/master@{#40295}
-
- 11 Oct, 2016 1 commit
-
-
ulan authored
BUG=chromium:652721 Review-Url: https://codereview.chromium.org/2408093003 Cr-Commit-Position: refs/heads/master@{#40179}
-
- 05 Oct, 2016 1 commit
-
-
mlippautz authored
BUG=chromium:652721 R=hpayer@chromium.org Review-Url: https://codereview.chromium.org/2395563002 Cr-Commit-Position: refs/heads/master@{#39986}
-
- 28 Sep, 2016 1 commit
-
-
ulan authored
This patch replaces cumulative counters with the counters for the current GC cycle. It also replaces the ring buffer of record incremental marking speeds with a single variable. Review-Url: https://codereview.chromium.org/2361563004 Cr-Commit-Position: refs/heads/master@{#39826}
-
- 27 Sep, 2016 1 commit
-
-
ulan authored
The same information can be obtained by processing --trace-gc-nvp output or using trace event and GC metric of catapult in Chrome. BUG= Review-Url: https://codereview.chromium.org/2361073002 Cr-Commit-Position: refs/heads/master@{#39780}
-
- 07 Sep, 2016 1 commit
-
-
ulan authored
Now callers of Heap::CollectGarbage* functions need to specify the reason as an enum value instead of a string. Subsequent CL will add stats counter for GC reason. BUG= Review-Url: https://codereview.chromium.org/2310143002 Cr-Commit-Position: refs/heads/master@{#39239}
-
- 30 Aug, 2016 2 commits
-
-
ulan authored
Now incremental marking tracing outputs isolate and timestamp: [41894:0x21efec0] 17253 ms: [IncrementalMarking] Start (old space step) This patch also adds walltime duration of incremental marking to GC trace output. BUG= Review-Url: https://codereview.chromium.org/2293883002 Cr-Commit-Position: refs/heads/master@{#39016}
-
mlippautz authored
R=ulan@chromium.org BUG= Review-Url: https://codereview.chromium.org/2292073002 Cr-Commit-Position: refs/heads/master@{#39013}
-
- 25 Aug, 2016 1 commit
-
-
mlippautz authored
Record details, such as cumulative duration, number of steps, and longest steps in IncrementalMarkingDetails which get populated at a single callsite (AddScopeSample). Remove member fields that thus become obsolete (unfortunately not all of them). Additional remove some dead code and refactor printing. Printing in a single statement allows for using logcat on Android. This should also address the regression in chromium:640524. BUG=chromium:639818,chromium:640524 R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2269093002 Cr-Commit-Position: refs/heads/master@{#38912}
-
- 23 Aug, 2016 3 commits
-
-
mlippautz authored
Before this patch all tracing scopes in incremental marking would be reset during a gc tracer start/stop cycle. This patch handles scopes the same way it does other incremental marking metrics. Also: - Align finalization metric with regular marking metric. - Smaller cleanups BUG=chromium:639818 Review-Url: https://codereview.chromium.org/2273673002 Cr-Commit-Position: refs/heads/master@{#38834}
-
mlippautz authored
Revert of [heap] Tracer: Handle incremental marking scopes (patchset #4 id:100001 of https://codereview.chromium.org/2264033002/ ) Reason for revert: Unittest fails on win32 debug: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/4188/steps/Check/logs/GCTracerTest.Incremen.. Original issue's description: > [heap] Tracer: Handle incremental marking scopes > > Before this patch all tracing scopes in incremental marking would be reset > during a gc tracer start/stop cycle. This patch handles scopes the same way it > does other incremental marking metrics. > > Also: > - Align finalization metric with regular marking metric. > - Smaller cleanups > > BUG=chromium:639818 > R=jochen@chromium.org > > Committed: https://crrev.com/300a8f97472b88ff2f94eb977c36b4bf1bedabf1 > Cr-Commit-Position: refs/heads/master@{#38822} TBR=jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:639818 Review-Url: https://codereview.chromium.org/2275583002 Cr-Commit-Position: refs/heads/master@{#38827}
-
mlippautz authored
Before this patch all tracing scopes in incremental marking would be reset during a gc tracer start/stop cycle. This patch handles scopes the same way it does other incremental marking metrics. Also: - Align finalization metric with regular marking metric. - Smaller cleanups BUG=chromium:639818 R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2264033002 Cr-Commit-Position: refs/heads/master@{#38822}
-
- 20 May, 2016 1 commit
-
-
mlippautz authored
- Move usable functions into proper heap-utils.h/.cc files and remove utils-inl.h file - Fix assumptions accross the board relying on certain behavior that is not invariant This is a requirement for modifying page size. BUG=chromium:581412 LOG=N R=ulan@chromium.org Review-Url: https://codereview.chromium.org/1999753002 Cr-Commit-Position: refs/heads/master@{#36410}
-
- 29 Apr, 2016 1 commit
-
-
ulan authored
This will allow us to enable GC events without enabling IC events. Telemetry currently cannot handle huge number of IC events in a trace. BUG= Review-Url: https://codereview.chromium.org/1924333003 Cr-Commit-Position: refs/heads/master@{#35902}
-
- 14 Apr, 2016 1 commit
-
-
mlippautz authored
- Get rid of fixing up pointers on the main thread - Get rid of sweeping on the main thread Instead: - Record (and process afterwards) slots in parallel - Add the pages to the concurrent sweeper as pointers have already been fixed This reverts commit 6df04b29. BUG=chromium:581412 LOG=N TEST=cctest/test-compaction/* Review URL: https://codereview.chromium.org/1891683002 Cr-Commit-Position: refs/heads/master@{#35485}
-
- 12 Apr, 2016 1 commit
-
-
jfb authored
The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. - Uses it appropriately. - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). - Fixes a bunch of incorrect formats. Original CL: https://codereview.chromium.org/1869433004 Reverted in: https://codereview.chromium.org/1867383002 Reverted again in: https://codereview.chromium.org/1877823003 Reverts due to non-CQ bots: - First: v8_win_dbg, v8_win64_dbg, v8_mac_dbg - Second: gc mole (added to v8_linux_rel_ng for this patch) R= jochen@chromium.org TBR= ahaas@chromium.org,bmeurer@chromium.org,yangguo@chromium.org Review URL: https://codereview.chromium.org/1872203005 Cr-Commit-Position: refs/heads/master@{#35423}
-
- 11 Apr, 2016 2 commits
-
-
https://codereview.chromium.org/1877453002/machenbach authored
Reason for revert: Breaks gc mole: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/9421 Original issue's description: > Fix printf formats > > The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: > > - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. > - Uses it appropriately. > - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). > - Fixes a bunch of incorrect formats. > > Original CL: https://codereview.chromium.org/1869433004 > Reverted in: https://codereview.chromium.org/1867383002 > > R= jochen@chromium.org > TBR= bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org > > Committed: https://crrev.com/bf505329288e1b75bab0e6800371a9aac40fa5cc > Cr-Commit-Position: refs/heads/master@{#35394} TBR=jochen@chromium.org,ahaas@chromium.org,bmeurer@chromium.org,yangguo@chromium.org,jfb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1877823003 Cr-Commit-Position: refs/heads/master@{#35396}
-
jfb authored
The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. - Uses it appropriately. - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). - Fixes a bunch of incorrect formats. Original CL: https://codereview.chromium.org/1869433004 Reverted in: https://codereview.chromium.org/1867383002 R= jochen@chromium.org TBR= bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org Review URL: https://codereview.chromium.org/1877453002 Cr-Commit-Position: refs/heads/master@{#35394}
-
- 08 Apr, 2016 2 commits
-
-
jfb authored
Revert of Fix printf formats (patchset #8 id:140001 of https://codereview.chromium.org/1869433004/ ) Reason for revert: One small issue easily fixed here: https://codereview.chromium.org/1867333003/ But it looks like MSVS 2013 doesn't like some of the formats and exists with the unhelpful: Stderr: f:\dd\vctools\crt\crtw32\stdio\output.c(1125) : Assertion failed: ("Incorrect format specifier", 0) It's easier to revert for now, I'll dig more into the docs: https://msdn.microsoft.com/en-us/library/56e442dc(v=vs.120).aspx https://msdn.microsoft.com/en-us/library/tcxf1dw6(v=vs.120).aspx And then resubmit, making sure I run these bots. Original issue's description: > Fix printf formats > > The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: > > - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. > - Uses it appropriately. > - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). > - Fixes a bunch of incorrect formats. > > R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org > > Committed: https://crrev.com/6ebf9fbb93d31f9be41156a3325d58704ed4933d > Cr-Commit-Position: refs/heads/master@{#35365} TBR=jochen@chromium.org,bmeurer@chromium.org,yangguo@chromium.org,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1867383002 Cr-Commit-Position: refs/heads/master@{#35366}
-
jfb authored
The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. - Uses it appropriately. - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). - Fixes a bunch of incorrect formats. R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org Review URL: https://codereview.chromium.org/1869433004 Cr-Commit-Position: refs/heads/master@{#35365}
-
- 04 Apr, 2016 1 commit
-
-
ulan authored
BUG=chromium:597310 LOG=NO Review URL: https://codereview.chromium.org/1851103002 Cr-Commit-Position: refs/heads/master@{#35233}
-
- 29 Mar, 2016 4 commits
-
-
ulan authored
This avoids redundant casts, loss of precision, and potential overflows. BUG=chromium:597310 LOG=NO Review URL: https://codereview.chromium.org/1841043002 Cr-Commit-Position: refs/heads/master@{#35113}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1836013004 Cr-Commit-Position: refs/heads/master@{#35107}
-
ulan authored
Now instead of saving all event details in the ring buffer, we save only the bytes and duration. This reduces the GCTracer size from 20K to 3K and simplifies code. BUG=chromium:597310 LOG=NO Review URL: https://codereview.chromium.org/1830723004 Cr-Commit-Position: refs/heads/master@{#35104}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1839993002 Cr-Commit-Position: refs/heads/master@{#35100}
-
- 23 Mar, 2016 4 commits
-
-
ulan authored
BUG=chromium:597310 LOG=NO Review URL: https://codereview.chromium.org/1828743002 Cr-Commit-Position: refs/heads/master@{#35042}
-
machenbach authored
Reland of [counters] adding runtime call timers for GC (patchset #1 id:1 of https://codereview.chromium.org/1827563003/ ) Reason for revert: Reverting doesn't help here :/ Will disable the test. Original issue's description: > Revert of [counters] adding runtime call timers for GC (patchset #4 id:60001 of https://codereview.chromium.org/1825093002/ ) > > Reason for revert: > [Sheriff] ASAN bot is really badass today: > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/10844 > > Original issue's description: > > [counters] adding runtime call timers for GC > > > > Adding an additional timer for the GC to make the other runtime call counters > > more stable. > > > > BUG= > > > > Committed: https://crrev.com/9ec649638d553a891b0356155f4f15f3a260c1af > > Cr-Commit-Position: refs/heads/master@{#35033} > > TBR=ulan@chromium.org,cbruni@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/a1521c90d54bf4cdaaf4c6ae549d297d5779ac08 > Cr-Commit-Position: refs/heads/master@{#35034} TBR=ulan@chromium.org,cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1826833002 Cr-Commit-Position: refs/heads/master@{#35035}
-
machenbach authored
Revert of [counters] adding runtime call timers for GC (patchset #4 id:60001 of https://codereview.chromium.org/1825093002/ ) Reason for revert: [Sheriff] ASAN bot is really badass today: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/10844 Original issue's description: > [counters] adding runtime call timers for GC > > Adding an additional timer for the GC to make the other runtime call counters > more stable. > > BUG= > > Committed: https://crrev.com/9ec649638d553a891b0356155f4f15f3a260c1af > Cr-Commit-Position: refs/heads/master@{#35033} TBR=ulan@chromium.org,cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1827563003 Cr-Commit-Position: refs/heads/master@{#35034}
-
cbruni authored
Adding an additional timer for the GC to make the other runtime call counters more stable. BUG= Review URL: https://codereview.chromium.org/1825093002 Cr-Commit-Position: refs/heads/master@{#35033}
-
- 22 Mar, 2016 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1806283004 Cr-Commit-Position: refs/heads/master@{#34980}
-
- 17 Mar, 2016 1 commit
-
-
mlippautz authored
BUG=chromium:524425 LOG=N Review URL: https://codereview.chromium.org/1807923004 Cr-Commit-Position: refs/heads/master@{#34861}
-
- 11 Dec, 2015 1 commit
-
-
ulan authored
BUG=chromium:568495 LOG=NO Review URL: https://codereview.chromium.org/1515503006 Cr-Commit-Position: refs/heads/master@{#32791}
-
- 09 Dec, 2015 2 commits
-
-
ulan authored
Compaction of the array with maps happens lazily upon adding new maps. BUG= Review URL: https://codereview.chromium.org/1481953002 Cr-Commit-Position: refs/heads/master@{#32717}
-
mvstanton authored
It's expensive to walk all shared function infos during the gc atomic pause. Instead, use WeakCells to implement this structure without manual clearing. Reland due to a bug when reusing entries in the optimized code map. BUG= Review URL: https://codereview.chromium.org/1508703002 Cr-Commit-Position: refs/heads/master@{#32696}
-
- 08 Dec, 2015 1 commit
-
-
ulan authored
Instead of iterating the whole map space to find dead transitions, look in weak cell list and transition array list. Simple transitions are in the weak cell list. Full transitions are in the transitions array list. BUG=chromium:554488 LOG=NO Review URL: https://codereview.chromium.org/1488593003 Cr-Commit-Position: refs/heads/master@{#32684}
-