1. 08 Jan, 2020 1 commit
  2. 13 Aug, 2019 1 commit
  3. 23 May, 2019 4 commits
  4. 22 May, 2019 1 commit
  5. 21 May, 2019 1 commit
  6. 17 May, 2019 1 commit
  7. 16 May, 2019 2 commits
  8. 01 May, 2019 1 commit
  9. 29 Apr, 2019 1 commit
    • Clemens Hammacher's avatar
      [cleanup] Use Vector::begin instead of Vector::start · 4b0f9c85
      Clemens Hammacher authored
      Our {Vector} template provides both {start} and {begin} methods. They
      return exactly the same value. Since the {begin} method is needed for
      iteration, and is also what standard containers provide, this CL
      switches all uses of the {start} method to use {begin} instead.
      
      Patchset 1 was auto-generated by using this clang AST matcher:
          callExpr(
              callee(
                cxxMethodDecl(
                  hasName("start"),
                  ofClass(hasName("v8::internal::Vector")))
              ),
              argumentCountIs(0))
      
      Patchset 2 was created by running clang-format. Patchset 3 then
      removes the now unused {Vector::start} method.
      
      R=jkummerow@chromium.org
      TBR=mstarzinger@chromium.org,yangguo@chromium.org,verwaest@chromium.org
      
      Bug: v8:9183
      Change-Id: Id9f01c92870872556e2bb3f6d5667463b0e3e5c6
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587381Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61081}
      4b0f9c85
  10. 09 Apr, 2019 1 commit
  11. 12 Mar, 2019 1 commit
  12. 06 Feb, 2019 1 commit
  13. 25 Jan, 2019 1 commit
  14. 23 Jan, 2019 1 commit
  15. 21 Jan, 2019 1 commit
  16. 18 Jan, 2019 1 commit
  17. 14 Jan, 2019 1 commit
    • Camillo Bruni's avatar
      Reland "[parser] Inline byte scope data into PreparseData object" · a6f44629
      Camillo Bruni authored
      This is a reland of e2d44ede
      
      Original change's description:
      > [parser] Inline byte scope data into PreparseData object
      > 
      > Each PreparseData object had at least one pointer to a PodArray for its
      > serialized scope data. These objects usually have only tens of bytes of
      > payload. By inlining the byte data we save 3 words per PreparseData object.
      > This optimization saves 140KB of data on cnn.com.
      > 
      > 
      > - Store data_length and inner_length as int32 saving a words on 64bit
      > - Inline store byte data into PreparseData
      > - OnHeapConsumedPreparseData directly uses the PreparseData object
      > - get_inner, set_inner no longer allow Null sentinels
      > 
      > Change-Id: I1f62154d05ea2f98a6574efa738b32a8a84319d5
      > Reviewed-on: https://chromium-review.googlesource.com/c/1406673
      > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#58751}
      
      Change-Id: I1f0a22c641d0d67f435b01c82daf8da7f144bff4
      Reviewed-on: https://chromium-review.googlesource.com/c/1407066Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58785}
      a6f44629
  18. 11 Jan, 2019 2 commits
    • Maya Lekova's avatar
      Revert "[parser] Inline byte scope data into PreparseData object" · 1ec1712c
      Maya Lekova authored
      This reverts commit e2d44ede.
      
      Reason for revert: Breaks GC stress tests - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/23527
      
      Original change's description:
      > [parser] Inline byte scope data into PreparseData object
      > 
      > Each PreparseData object had at least one pointer to a PodArray for its
      > serialized scope data. These objects usually have only tens of bytes of
      > payload. By inlining the byte data we save 3 words per PreparseData object.
      > This optimization saves 140KB of data on cnn.com.
      > 
      > 
      > - Store data_length and inner_length as int32 saving a words on 64bit
      > - Inline store byte data into PreparseData
      > - OnHeapConsumedPreparseData directly uses the PreparseData object
      > - get_inner, set_inner no longer allow Null sentinels
      > 
      > Change-Id: I1f62154d05ea2f98a6574efa738b32a8a84319d5
      > Reviewed-on: https://chromium-review.googlesource.com/c/1406673
      > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#58751}
      
      TBR=ulan@chromium.org,cbruni@chromium.org,leszeks@chromium.org
      
      Change-Id: I39d92ee7bd2864e1b0c3a8fed4a11b68b3e14d58
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/c/1407073Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
      Commit-Queue: Maya Lekova <mslekova@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58753}
      1ec1712c
    • Camillo Bruni's avatar
      [parser] Inline byte scope data into PreparseData object · e2d44ede
      Camillo Bruni authored
      Each PreparseData object had at least one pointer to a PodArray for its
      serialized scope data. These objects usually have only tens of bytes of
      payload. By inlining the byte data we save 3 words per PreparseData object.
      This optimization saves 140KB of data on cnn.com.
      
      
      - Store data_length and inner_length as int32 saving a words on 64bit
      - Inline store byte data into PreparseData
      - OnHeapConsumedPreparseData directly uses the PreparseData object
      - get_inner, set_inner no longer allow Null sentinels
      
      Change-Id: I1f62154d05ea2f98a6574efa738b32a8a84319d5
      Reviewed-on: https://chromium-review.googlesource.com/c/1406673Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58751}
      e2d44ede
  19. 09 Jan, 2019 1 commit
  20. 07 Jan, 2019 1 commit
  21. 21 Dec, 2018 1 commit
  22. 18 Dec, 2018 1 commit
  23. 28 Nov, 2018 1 commit
  24. 27 Nov, 2018 1 commit
  25. 24 Nov, 2018 1 commit
  26. 14 Nov, 2018 1 commit
  27. 13 Nov, 2018 2 commits
  28. 09 Oct, 2018 1 commit
  29. 25 Sep, 2018 2 commits
    • Ross McIlroy's avatar
      Reland "[Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher" · dc204cc6
      Ross McIlroy authored
      This is a reland of 31228a69
      
      TBR=yangguo@chromium.org,verwaest@chromium.org
      
      Original change's description:
      > [Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher
      >
      > Splits background compilation data out of ScriptStreamingData and into
      > BackgroundCompileTask. Also makes BackgroundCompileTask no longer a sub-class
      > of ScriptStreamingTask, and instead have ScriptStreamingTask delegate to a
      > BackgroundCompileTask.
      >
      > As part of this change, we now create the CharacterStream on the main thread,
      > and therefore have to set the (thread-local) runtime_call_stats on the already
      > created CharacterStream when the BackgroundCompileTask is run on the background
      > thread. As such, changes to CharacterStream were needed to feed the
      > runtime_call_stats through appropriately.
      >
      > Deprecates Source::GetCachedData and StreamedSource::GetCachedData since they are
      > no longer used, and the streamed source never has cached data (streaming is
      > suppressed if cached data is available). Also removes Utf8ChunkedStream which
      > is dead code.
      >
      > BUG=v8:8041, v8:8015
      > TBR=yangguo@chromium.org
      >
      > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      > Change-Id: Ifcc723ebf930a1dc01135fcb70929d6168471cb3
      > Reviewed-on: https://chromium-review.googlesource.com/1236353
      > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#56182}
      
      Bug: v8:8041, v8:8015
      Change-Id: Ied5132c537d4c25c6e355f289c2a9cc1f8ff98e9
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/1242097
      Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
      Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56201}
      dc204cc6
    • Maya Lekova's avatar
      Revert "[Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher" · 875480d2
      Maya Lekova authored
      This reverts commit 31228a69.
      
      Reason for revert: Introduces new pretty consistent flakes on Linux sanitizers, one of which block LKGR. Please see https://crbug.com/v8/8219
      
      Original change's description:
      > [Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher
      > 
      > Splits background compilation data out of ScriptStreamingData and into
      > BackgroundCompileTask. Also makes BackgroundCompileTask no longer a sub-class
      > of ScriptStreamingTask, and instead have ScriptStreamingTask delegate to a
      > BackgroundCompileTask.
      > 
      > As part of this change, we now create the CharacterStream on the main thread,
      > and therefore have to set the (thread-local) runtime_call_stats on the already
      > created CharacterStream when the BackgroundCompileTask is run on the background
      > thread. As such, changes to CharacterStream were needed to feed the
      > runtime_call_stats through appropriately.
      > 
      > Deprecates Source::GetCachedData and StreamedSource::GetCachedData since they are
      > no longer used, and the streamed source never has cached data (streaming is
      > suppressed if cached data is available). Also removes Utf8ChunkedStream which
      > is dead code.
      > 
      > BUG=v8:8041, v8:8015
      > TBR=yangguo@chromium.org
      > 
      > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      > Change-Id: Ifcc723ebf930a1dc01135fcb70929d6168471cb3
      > Reviewed-on: https://chromium-review.googlesource.com/1236353
      > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#56182}
      
      TBR=rmcilroy@chromium.org,yangguo@chromium.org,verwaest@chromium.org
      
      Change-Id: Ib05bcbde2e9a588bd4008d2155f75cdac5cc47f5
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8041, v8:8015
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/1241958Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
      Commit-Queue: Maya Lekova <mslekova@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56187}
      875480d2
  30. 24 Sep, 2018 1 commit
    • Ross McIlroy's avatar
      [Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher · 31228a69
      Ross McIlroy authored
      Splits background compilation data out of ScriptStreamingData and into
      BackgroundCompileTask. Also makes BackgroundCompileTask no longer a sub-class
      of ScriptStreamingTask, and instead have ScriptStreamingTask delegate to a
      BackgroundCompileTask.
      
      As part of this change, we now create the CharacterStream on the main thread,
      and therefore have to set the (thread-local) runtime_call_stats on the already
      created CharacterStream when the BackgroundCompileTask is run on the background
      thread. As such, changes to CharacterStream were needed to feed the
      runtime_call_stats through appropriately.
      
      Deprecates Source::GetCachedData and StreamedSource::GetCachedData since they are
      no longer used, and the streamed source never has cached data (streaming is
      suppressed if cached data is available). Also removes Utf8ChunkedStream which
      is dead code.
      
      BUG=v8:8041, v8:8015
      TBR=yangguo@chromium.org
      
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      Change-Id: Ifcc723ebf930a1dc01135fcb70929d6168471cb3
      Reviewed-on: https://chromium-review.googlesource.com/1236353
      Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56182}
      31228a69
  31. 17 Sep, 2018 1 commit
  32. 14 Sep, 2018 1 commit
  33. 07 Sep, 2018 1 commit