Commits · a340036e3a921c1d9942a832e2705e02b06216cb · Linshizhi / V8

14 Jun, 2013 23 commits

This test fails sometimes on all platforms. · a340036e

machenbach@chromium.org authored Jun 14, 2013

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/17030010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15163 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a340036e

HasUnexpectedOutput() is evaluated two times for each test run. · 6a6790be

machenbach@chromium.org authored Jun 14, 2013

This fix removes the redundant call to allow heavy text comparisons through overwriting of that method.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/17089003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15162 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6a6790be

Make MathFloorOfDiv optimization trigger more often · de71923b

jkummerow@chromium.org authored Jun 14, 2013

BUG=v8:2205
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/16973002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15161 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

de71923b

Reland "Make more GCs in idle notification handler." · f751e894

ulan@chromium.org authored Jun 14, 2013

Fix performance regression on benchmarks by filtering out short idle
notifications.

R=hpayer@chromium.org
BUG=241815

Review URL: https://chromiumcodereview.appspot.com/17005005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15160 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f751e894

When HBranch sees Smi, it sees Smi. · 7cebf3f6

verwaest@chromium.org authored Jun 14, 2013

R=mvstanton@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17064006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15159 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7cebf3f6

Try convert polymorphic stores into a single monomorphic store. · 773c08c5

verwaest@chromium.org authored Jun 14, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16975006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15158 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

773c08c5

Increase default type info threshold. · af599c83

yangguo@chromium.org authored Jun 14, 2013

R=jkummerow@chromium.org
BUG=v8:2730

Review URL: https://chromiumcodereview.appspot.com/17074002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15157 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

af599c83

Only infer int32 in HBoundsCheck if input is double or int32. · 41c63d88

verwaest@chromium.org authored Jun 14, 2013

R=jkummerow@chromium.org, mmassi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17057004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15156 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

41c63d88

Cleanup RepresentationFromUseRequirements, move it to HValue and use it where relevant · 84759d7e

verwaest@chromium.org authored Jun 14, 2013

BUG=
R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17005004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15155 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

84759d7e

Prepare push to trunk. Now working on version 3.19.17. · 62254ae9

svenpanne@chromium.org authored Jun 14, 2013

R=danno@chromium.org

Review URL: https://codereview.chromium.org/17043003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15152 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

62254ae9

build fix for d8-readline for 15142 · a07b99f3

dcarney@chromium.org authored Jun 14, 2013

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/17028013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15151 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a07b99f3

MIPS: Install a generic handler whenever we fail to update the IC. Ignore... · 7d535460

palfia@homejinni.com authored Jun 14, 2013

MIPS: Install a generic handler whenever we fail to update the IC. Ignore select cases in StoreIC since we don't have premonomorphic.

Port r15145 (e415de7c)

BUG=

Review URL: https://codereview.chromium.org/17086002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15150 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7d535460

webkit build fix for 15142 · eeded306

dcarney@chromium.org authored Jun 14, 2013

TBR=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/17076003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15149 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

eeded306

Decrease size of first page of property cell space. · 08a4a376

hpayer@chromium.org authored Jun 14, 2013

BUG=
R=danno@chromium.org, mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/17027006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

08a4a376

Inhibit OSR for big functions. · b863016d

yangguo@chromium.org authored Jun 14, 2013

R=jkummerow@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/17030008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15147 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b863016d

As a last resort try to allocate out of the smaller size size-class in · 9e70cb84

hpayer@chromium.org authored Jun 14, 2013

the free list allocator.

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/17058002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15146 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9e70cb84

Install a generic handler whenever we fail to update the IC. · 2987b117

verwaest@chromium.org authored Jun 14, 2013

Ignore select cases in StoreIC since we don't have premonomorphic.

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17027007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15145 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2987b117

arm build fix for 15142 · b0860dd2

dcarney@chromium.org authored Jun 14, 2013

TBR=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/17030007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15144 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b0860dd2

build fix for 15142 · 022ee63f

dcarney@chromium.org authored Jun 14, 2013

TBR=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/16942004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15143 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

022ee63f

remove V8_USE_UNSAFE_HANDLES define · a1d359d2

dcarney@chromium.org authored Jun 14, 2013

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/16896004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15142 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a1d359d2

Remove bogus cast in LChunkBuilder::CreateEnvironment. · 4578f634

mstarzinger@chromium.org authored Jun 14, 2013

R=jkummerow@chromium.org
TEST=chromium:content_browsertests

Review URL: https://codereview.chromium.org/17057002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15141 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4578f634

Observe smi as input for HCompareIDAndBranch · cff21dc1

verwaest@chromium.org authored Jun 14, 2013

R=mvstanton@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16994002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15140 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cff21dc1

Reduce the amount of full code generated to fill out array literals. · bcf5912b

svenpanne@chromium.org authored Jun 14, 2013

This is achieved by tuning the calling convention of StoreArrayLiteralStub:

 * The map of the array literal can be loaded in the stub from the
   array literal itself, there is no need to pass it at all.

 * The array literal is already on the stack, so there is no need to
   pass it again via a register.

 * The literal index is unchanged while filling the literal, so we can
   push it on the stack once and avoid passing it every time. Note that
   we need to mirror this change in the stack layout in crankshaft, too.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/16950004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15138 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bcf5912b

13 Jun, 2013 17 commits

Notify CPU profiler when calling native getters · c4224f09

yurys@chromium.org authored Jun 13, 2013

This change modifies code produced by BaseLoadStubCompiler::GenerateLoadCallback so that instead of calling AccessorGetter direcly it calls InvokeAccessorGetter which changes VM state and calls the actual callback. This way CPU profiler knows which external callback is being executed in this case. Indirect call happens only if CpuProfiler::is_profiling() is true.

This is exactly same change as r15116 with a build fix for test-api.cc

BUG=244580
TBR=danno@chromium.org

Review URL: https://codereview.chromium.org/16858013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15135 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c4224f09

MIPS: Only extend storage if FIELD · 6dcc6e27

palfia@homejinni.com authored Jun 13, 2013

Port r15125 (0c202ff0)

BUG=

Review URL: https://codereview.chromium.org/16983002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15134 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6dcc6e27

MIPS: Implement IC support for Constant Function transitions. · ddffbb72

palfia@homejinni.com authored Jun 13, 2013

Port r15124 (6b02a945)

BUG=

Review URL: https://codereview.chromium.org/16984002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15133 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ddffbb72

Reduce usage of AssumeRepresentation · 91eda650

verwaest@chromium.org authored Jun 13, 2013

BUG=
R=mstarzinger@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16871011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15132 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

91eda650

MIPS: Delegating yield does not re-box result objects. · 674d5946

palfia@homejinni.com authored Jun 13, 2013

Port r15113 (9d28761)

Delegating yield (yield*) should just pass on the iterator results it
receives instead of re-boxing them.

TEST=mjsunit/harmony/generators-iteration
BUG=

Review URL: https://codereview.chromium.org/16855009
Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15131 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

674d5946

Remove manual representation annotations for constants. · 1b5835f6

verwaest@chromium.org authored Jun 13, 2013

R=mstarzinger@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16818016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15130 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1b5835f6

Allow allocations in spaces with constant allocation size use the · ce6a0e4d

hpayer@chromium.org authored Jun 13, 2013

smallest possible size-class.

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/16957003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ce6a0e4d

MIPS: Use keyed-call inline caches in delegating yield. · 69b43a07

palfia@homejinni.com authored Jun 13, 2013

Port r15111 (7de1a19)

Original commit message:
Since we can't assume anything about the shape of the iterator in a
yield* (delegating yield), use an IC to do the next() and throw()
iterator method calls.

BUG=v8:2691
TEST=mjsunit/regress/regress-2691

Review URL: https://codereview.chromium.org/16923008
Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15128 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

69b43a07

MIPS: Increase sanity of integer division handling. · 9e1c894a

palfia@homejinni.com authored Jun 13, 2013

Port r15057 (c82c777)

Original commit message:
- In the INT32 BinaryOpStub, fix type feedback collection for DIV,
bringing it in line with other platforms.
- In Lithium codegen, emit proper inlined code, don't call the stub.
- Drive-by fix: assert appropriate CpuFeaturesScope for SDIV.

BUG=

Review URL: https://codereview.chromium.org/16857004
Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15127 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9e1c894a

Refactor turning polymorphic loads into monomorphic loads · 1d74cfaa

verwaest@chromium.org authored Jun 13, 2013

- remove special code for polymorphic loading of array length
- use it in VisitCountOperation

BUG=
R=hpayer@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16948005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15126 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1d74cfaa

Only extend storage if FIELD · 1d5cdf21

verwaest@chromium.org authored Jun 13, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16818014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15125 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1d5cdf21

Implement IC support for Constant Function transitions. · 8bc9d987

verwaest@chromium.org authored Jun 13, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16826016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15124 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8bc9d987

Deprecate several unchecked accessors. · fede5231

mstarzinger@chromium.org authored Jun 13, 2013

R=hpayer@google.com
BUG=v8:1490

Review URL: https://codereview.chromium.org/16663009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15123 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fede5231

Temporarily patch HCompareIDAndBranch to accept Smi. · 4ac1aa53

verwaest@chromium.org authored Jun 13, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16957005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15122 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4ac1aa53

Prepare push to trunk. Now working on version 3.19.16. · 681b10b3

danno@chromium.org authored Jun 13, 2013

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/16924007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15119 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

681b10b3

HCheckFunction is needed to protect new array constructors in · 5b2c1a50

mvstanton@chromium.org authored Jun 13, 2013

crankshafted code.

BUG=
R=danno@chromium.org

Review URL: https://codereview.chromium.org/16944006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15118 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5b2c1a50

Revert "Notify CPU profiler when calling native getters" · 24ec0171

yurys@chromium.org authored Jun 13, 2013

This reverts commit f323d984a73bab345c4eab5c1907552ccfa7ccaa.

Broke compilation on the bots with an error that doesn't occur locally:

  CXX(target) /mnt/data/b/build/slave/v8-linux-debug/build/v8/out/Debug/obj.target/cctest/test/cctest/test-bignum-dtoa.o
../test/cctest/test-api.cc: In function ‘void FastReturnValueCallback(const v8::FunctionCallbackInfo<v8::Value>&) [with T = int]’:
../test/cctest/test-api.cc:1129: error: insufficient contextual information to determine type
../test/cctest/test-api.cc: In function ‘void FastReturnValueCallback(const v8::FunctionCallbackInfo<v8::Value>&) [with T = unsigned int]’:
../test/cctest/test-api.cc:1136: error: insufficient contextual information to determine type
../test/cctest/test-api.cc: In function ‘void FastReturnValueCallback(const v8::FunctionCallbackInfo<v8::Value>&) [with T = double]’:
../test/cctest/test-api.cc:1143: error: insufficient contextual information to determine type
../test/cctest/test-api.cc: In function ‘void FastReturnValueCallback(const v8::FunctionCallbackInfo<v8::Value>&) [with T = bool]’:
../test/cctest/test-api.cc:1150: error: insufficient contextual information to determine type
../test/cctest/test-api.cc: In function ‘void FastReturnValueCallback(const v8::FunctionCallbackInfo<v8::Value>&) [with T = void]’:
../test/cctest/test-api.cc:1157: error: insufficient contextual information to determine type
  CXX(target) /mnt/data/b/build/slave/v8-linux-debug/build/v8/out/Debug/obj.target/cctest/test/cctest/test-circular-queue.o

BUG=None
TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/16838013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15117 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

24ec0171