1. 22 Jun, 2021 1 commit
  2. 18 Jun, 2021 1 commit
  3. 30 Apr, 2021 1 commit
  4. 17 Dec, 2020 1 commit
  5. 22 Aug, 2019 1 commit
  6. 12 Jul, 2019 1 commit
  7. 24 May, 2019 1 commit
  8. 23 May, 2019 2 commits
  9. 22 May, 2019 1 commit
  10. 20 May, 2019 1 commit
  11. 17 May, 2019 3 commits
  12. 16 May, 2019 2 commits
  13. 29 Apr, 2019 1 commit
    • Clemens Hammacher's avatar
      [cleanup] Use Vector::begin instead of Vector::start · 4b0f9c85
      Clemens Hammacher authored
      Our {Vector} template provides both {start} and {begin} methods. They
      return exactly the same value. Since the {begin} method is needed for
      iteration, and is also what standard containers provide, this CL
      switches all uses of the {start} method to use {begin} instead.
      
      Patchset 1 was auto-generated by using this clang AST matcher:
          callExpr(
              callee(
                cxxMethodDecl(
                  hasName("start"),
                  ofClass(hasName("v8::internal::Vector")))
              ),
              argumentCountIs(0))
      
      Patchset 2 was created by running clang-format. Patchset 3 then
      removes the now unused {Vector::start} method.
      
      R=jkummerow@chromium.org
      TBR=mstarzinger@chromium.org,yangguo@chromium.org,verwaest@chromium.org
      
      Bug: v8:9183
      Change-Id: Id9f01c92870872556e2bb3f6d5667463b0e3e5c6
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587381Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61081}
      4b0f9c85
  14. 21 Jan, 2019 1 commit
    • Peter Marshall's avatar
      [logger] Start cleaning up Logger class · 7da7c0bd
      Peter Marshall authored
      - Use unique ptrs for owned objects
      - Remove friendship with CpuProfiler and replace with public API
      - Remove unused method LogFailure()
      - Remove StopProfiler() which was only used by LogFailure() (removed)
        and one test, which can use StopProfilerThread() instead
      - Remove 'paused' state which was only used by the above
      - Remove 'engage' state. There is no reason we need this as along as
        users keep track of Engage/Disengage calls
      
      Drive-by cleanup:
      - Remove import of log.h from profile-generator.h
      - Remove unnecessary includes of log.h
      
      Change-Id: Ifc4ca156bef038c40953f8361ffea17788e3a59b
      Reviewed-on: https://chromium-review.googlesource.com/c/1424338
      Commit-Queue: Peter Marshall <petermarshall@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58957}
      7da7c0bd
  15. 16 Jan, 2019 1 commit
    • Clemens Hammacher's avatar
      [cleanup] Clean up base::EnumSet · 4064757c
      Clemens Hammacher authored
      After moving to its own header, this CL cleans up some parts of the
      interface. It fixes names and const-declarations of simple accessors,
      and adds a named constructor to make it explicit that an EnumSet should
      be constructed from an integral value.
      Also refactor the use in cctest.h to have less statically declared
      constants. Instead, just create the set of extensions in the individual
      tests.
      
      R=titzer@chromium.org
      
      Bug: v8:8562
      Change-Id: I6178d1aba25afa1d7f54c29ccf81505c165e7cd3
      Reviewed-on: https://chromium-review.googlesource.com/c/1409366
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58862}
      4064757c
  16. 08 Dec, 2018 1 commit
  17. 07 Dec, 2018 3 commits
  18. 25 Nov, 2018 1 commit
  19. 23 Jul, 2018 1 commit
  20. 05 Jun, 2018 1 commit
  21. 14 Apr, 2018 1 commit
    • Jakob Kummerow's avatar
      [ubsan] Change Address typedef to uintptr_t · 2459046c
      Jakob Kummerow authored
      The "Address" type is V8's general-purpose type for manipulating memory
      addresses. Per the C++ spec, pointer arithmetic and pointer comparisons
      are undefined behavior except within the same array; since we generally
      don't operate within a C++ array, our general-purpose type shouldn't be
      a pointer type.
      
      Bug: v8:3770
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: Ib96016c24a0f18bcdba916dabd83e3f24a1b5779
      Reviewed-on: https://chromium-review.googlesource.com/988657
      Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52601}
      2459046c
  22. 02 Dec, 2017 1 commit
    • Mathias Bynens's avatar
      Normalize casing of hexadecimal digits · 822be9b2
      Mathias Bynens authored
      This patch normalizes the casing of hexadecimal digits in escape
      sequences of the form `\xNN` and integer literals of the form
      `0xNNNN`.
      
      Previously, the V8 code base used an inconsistent mixture of uppercase
      and lowercase.
      
      Google’s C++ style guide uses uppercase in its examples:
      https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters
      
      Moreover, uppercase letters more clearly stand out from the lowercase
      `x` (or `u`) characters at the start, as well as lowercase letters
      elsewhere in strings.
      
      BUG=v8:7109
      TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org
      NOPRESUBMIT=true
      
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6
      Reviewed-on: https://chromium-review.googlesource.com/804294
      Commit-Queue: Mathias Bynens <mathias@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49810}
      822be9b2
  23. 20 Oct, 2017 1 commit
  24. 14 Aug, 2017 1 commit
  25. 13 Jul, 2017 3 commits
  26. 23 Feb, 2017 1 commit
  27. 27 Oct, 2016 1 commit
  28. 24 Oct, 2016 1 commit
  29. 21 Oct, 2016 1 commit
  30. 20 Oct, 2016 2 commits
  31. 06 Jul, 2016 1 commit
    • lpy's avatar
      Expose TickSample and its APIs in v8-profiler.h · 3172f6a9
      lpy authored
      We want to eventually move the profiling functionality out of V8 as library,
      this patch exposes TickSample and its APIs in v8-profiler.h so that when
      embedders use library, they can have more details.
      
      Minor change: Rename tick-sample.[h|cc] to simulator-helper.[h|cc].
      
      BUG=v8:4789
      LOG=N
      
      Review-Url: https://codereview.chromium.org/2105943002
      Cr-Commit-Position: refs/heads/master@{#37564}
      3172f6a9