1. 02 Aug, 2021 1 commit
  2. 22 Jun, 2021 1 commit
  3. 18 Jun, 2021 1 commit
  4. 20 Jan, 2021 1 commit
  5. 20 Nov, 2020 1 commit
  6. 16 Nov, 2020 1 commit
  7. 24 Sep, 2020 1 commit
  8. 22 Sep, 2020 3 commits
    • Camillo Bruni's avatar
      Reland "[log][d8] Only use d8.log.getAndStop on temporary log file" · 1724c77c
      Camillo Bruni authored
      This is a reland of 21bb43cc
      
      The build failures seems to be an infra flake.
      
      Original change's description:
      > [log][d8] Only use d8.log.getAndStop on temporary log file
      >
      > We run tests in parallel which can cause multiple tests to write to
      > the shared v8.log file. This obviously breaks the simple assertions in
      > mjsunit/tools/log.js.
      >
      > - Use temporary files for log testing with --logfile='+'
      >
      > - Change the symbol from '&' to '+' for using temporary files for
      >   logging with --logfile
      >
      > - Enable skipped log tests again.
      >
      > Bug: v8:10937, chromium:1129854, chromium:1130196
      > Change-Id: I607dc9a9ecc352e58525cdd21c1c93efebf0f09f
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2421826
      > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Reviewed-by: Victor Gomes <victorgomes@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#70071}
      
      Bug: v8:10937
      Bug: chromium:1129854
      Bug: chromium:1130196
      Change-Id: I2ccf7528f35057ef668aa211142e0f1073fc1fc3
      Tbr: verwaest@chromium.org, victorgomes@chromium.org
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424257Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#70076}
      1724c77c
    • Francis McCabe's avatar
      Revert "[log][d8] Only use d8.log.getAndStop on temporary log file" · ec570b8a
      Francis McCabe authored
      This reverts commit 21bb43cc.
      
      Reason for revert: See broken build: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20builder/49882
      
      Original change's description:
      > [log][d8] Only use d8.log.getAndStop on temporary log file
      > 
      > We run tests in parallel which can cause multiple tests to write to
      > the shared v8.log file. This obviously breaks the simple assertions in
      > mjsunit/tools/log.js.
      > 
      > - Use temporary files for log testing with --logfile='+'
      > 
      > - Change the symbol from '&' to '+' for using temporary files for
      >   logging with --logfile
      > 
      > - Enable skipped log tests again.
      > 
      > Bug: v8:10937, chromium:1129854, chromium:1130196
      > Change-Id: I607dc9a9ecc352e58525cdd21c1c93efebf0f09f
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2421826
      > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Reviewed-by: Victor Gomes <victorgomes@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#70071}
      
      TBR=cbruni@chromium.org,verwaest@chromium.org,victorgomes@chromium.org
      
      Change-Id: I5de61792c283139b2a898334e28e1f7b2d7c08f8
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:10937
      Bug: chromium:1129854
      Bug: chromium:1130196
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424625Reviewed-by: 's avatarFrancis McCabe <fgm@chromium.org>
      Commit-Queue: Francis McCabe <fgm@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#70072}
      ec570b8a
    • Camillo Bruni's avatar
      [log][d8] Only use d8.log.getAndStop on temporary log file · 21bb43cc
      Camillo Bruni authored
      We run tests in parallel which can cause multiple tests to write to
      the shared v8.log file. This obviously breaks the simple assertions in
      mjsunit/tools/log.js.
      
      - Use temporary files for log testing with --logfile='+'
      
      - Change the symbol from '&' to '+' for using temporary files for
        logging with --logfile
      
      - Enable skipped log tests again.
      
      Bug: v8:10937, chromium:1129854, chromium:1130196
      Change-Id: I607dc9a9ecc352e58525cdd21c1c93efebf0f09f
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2421826
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Reviewed-by: 's avatarVictor Gomes <victorgomes@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#70071}
      21bb43cc
  9. 18 Sep, 2020 1 commit
  10. 17 Sep, 2020 2 commits
  11. 14 Sep, 2020 1 commit
  12. 09 Sep, 2020 2 commits
    • Sathya Gunasekaran's avatar
      Revert "Reland "[test][d8] Add d8.log.getAndStop helper"" · 92236da2
      Sathya Gunasekaran authored
      This reverts commit 23531d82.
      
      Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/33007?
      
      Original change's description:
      > Reland "[test][d8] Add d8.log.getAndStop helper"
      > 
      > This is a reland of 95aa697b
      > 
      > Original change's description:
      > > [test][d8] Add d8.log.getAndStop helper
      > >
      > > The new helper function allows us to write tests for log parsing
      > > without the need to first generating a log file. This makes it easier
      > > to spot errors when the log format changes.
      > >
      > > - Add d8 global variable
      > > - Add file_name accessor to Logger and Log classes
      > > - Change OS::LogFileOpenMode to w+ / wb+
      > > - Use separate Log::WriteLogHeader method
      > > - Remove unused logger_ instance variable from Log
      > >
      > > Bug: v8:10644
      > > Change-Id: Ifc7e35aa4e91b3f01f0847843263946e085944c3
      > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2387563
      > > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
      > > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > > Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#69715}
      > 
      > Bug: v8:10644
      > 
      > TBR=verwaest@chromium.org
      > 
      > Change-Id: I54741344834d88a376b74e2e3a2047e880a94624
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2396081
      > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
      > Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#69769}
      
      TBR=mlippautz@chromium.org,cbruni@chromium.org,gsathya@chromium.org,verwaest@chromium.org
      
      Change-Id: I493315e0d6498f0fa9bed3409725bb52d554b53a
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:10644
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2400982Reviewed-by: 's avatarSathya Gunasekaran  <gsathya@chromium.org>
      Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#69770}
      92236da2
    • Camillo Bruni's avatar
      Reland "[test][d8] Add d8.log.getAndStop helper" · 23531d82
      Camillo Bruni authored
      This is a reland of 95aa697b
      
      Original change's description:
      > [test][d8] Add d8.log.getAndStop helper
      >
      > The new helper function allows us to write tests for log parsing
      > without the need to first generating a log file. This makes it easier
      > to spot errors when the log format changes.
      >
      > - Add d8 global variable
      > - Add file_name accessor to Logger and Log classes
      > - Change OS::LogFileOpenMode to w+ / wb+
      > - Use separate Log::WriteLogHeader method
      > - Remove unused logger_ instance variable from Log
      >
      > Bug: v8:10644
      > Change-Id: Ifc7e35aa4e91b3f01f0847843263946e085944c3
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2387563
      > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#69715}
      
      Bug: v8:10644
      
      TBR=verwaest@chromium.org
      
      Change-Id: I54741344834d88a376b74e2e3a2047e880a94624
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2396081
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
      Reviewed-by: 's avatarSathya Gunasekaran  <gsathya@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#69769}
      23531d82
  13. 07 Sep, 2020 3 commits
  14. 20 Aug, 2020 1 commit
    • Dominik Inführ's avatar
      [logging] Make Log::IsEnabled() atomic · 41d2e5c9
      Dominik Inführ authored
      With concurrent allocation background threads invoke Log::IsEnabled()
      as well. Fix data race here by making is_enabled_ atomic, such that
      IsEnabled() remains cheap.
      
      After locking the mutex in MessageBuilder, IsEnabled() needs to be
      checked again in case an old value was read. Otherwise we might log
      even though logging was already disabled on another thread.
      
      The other direction where a log message isn't logged is deemed
      acceptable.
      
      Bug: v8:10315
      Change-Id: I32c9dd2e9879fbdb4ca94e080a16ddd875de7c30
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2362948
      Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#69495}
      41d2e5c9
  15. 30 Oct, 2019 1 commit
  16. 14 Sep, 2019 1 commit
  17. 24 May, 2019 1 commit
  18. 23 May, 2019 3 commits
  19. 21 May, 2019 1 commit
  20. 20 May, 2019 1 commit
  21. 17 May, 2019 2 commits
  22. 27 Nov, 2018 1 commit
  23. 10 Aug, 2018 1 commit
    • Bret Sepulveda's avatar
      Escape backslashes when logging. · f642de00
      Bret Sepulveda authored
      Log::MessageBuilder was already escaping most unsafe characters when
      they were being logged, but plain backslashes were not. Merely updating
      the existing escaping path was not sufficient, as recursion would cause
      escape codes to be doubly escaped. This patches refactors the API to
      ensure incoming text is escaped exactly once.
      
      Bug: v8:8039
      Change-Id: Id48aabf29fb6153189ae4a1ad7dfaaf4b41b62ad
      Reviewed-on: https://chromium-review.googlesource.com/1169049Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Commit-Queue: Bret Sepulveda <bsep@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55038}
      f642de00
  24. 05 Jul, 2018 1 commit
  25. 03 May, 2018 2 commits
  26. 20 Dec, 2017 2 commits
  27. 02 Dec, 2017 1 commit
    • Mathias Bynens's avatar
      Normalize casing of hexadecimal digits · 822be9b2
      Mathias Bynens authored
      This patch normalizes the casing of hexadecimal digits in escape
      sequences of the form `\xNN` and integer literals of the form
      `0xNNNN`.
      
      Previously, the V8 code base used an inconsistent mixture of uppercase
      and lowercase.
      
      Google’s C++ style guide uses uppercase in its examples:
      https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters
      
      Moreover, uppercase letters more clearly stand out from the lowercase
      `x` (or `u`) characters at the start, as well as lowercase letters
      elsewhere in strings.
      
      BUG=v8:7109
      TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org
      NOPRESUBMIT=true
      
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6
      Reviewed-on: https://chromium-review.googlesource.com/804294
      Commit-Queue: Mathias Bynens <mathias@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49810}
      822be9b2
  28. 14 Nov, 2017 1 commit
  29. 03 Nov, 2017 1 commit