- 26 Feb, 2019 1 commit
-
-
Sigurd Schneider authored
Change-Id: I4bd02bdb68727b6242b0fe4b81fd522813b13f39 Bug: v8:8834 Reviewed-on: https://chromium-review.googlesource.com/c/1488755Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59875}
-
- 29 Nov, 2018 1 commit
-
-
Ben L. Titzer authored
This CL moves a number of memory-related methods out of utils into its own header, since utils.h is included in many places that do not need these methods. R=clemensh@chromium.org,mstarzinger@chromium.org Change-Id: I5155baf329844784286413408c05c7108b789020 Reviewed-on: https://chromium-review.googlesource.com/c/1354889 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#57948}
-
- 07 Sep, 2018 1 commit
-
-
Ross McIlroy authored
Adds support for zone allocated (off-heap) ConsumedPreParsingScopeData to enable worker-thread access to PreParsingScopeData during parallel IIFE compile tasks. In order to avoid code-duplication, a templated BaseConsumedPreParsingScopeData is added which implements the logic for decoding the bytestream into scope data. Two implementations of this base class are instantiated for each of the underlying serialized scope date: - ZoneConsumedPreParsedScopeData for exposing ZonePreParsedScopeData - OnHeapConsumedPreParsedScopeData for exposing on-heap PreParsedScopeData The interface for each of these classes is the ConsumedPreParsingScopeData, which exposes the methods required by the parser to deserialize the required data. As a side-cleanup, moved Ucs2CharLength and Utf8LengthHelper implementations to cc file so that we don't get a linker error if one of them are unused by the cc file including the header. BUG=v8:8041 Change-Id: Id502312d32fe4a9ddb6f5d2d9d3e3a9d30b9b27d Reviewed-on: https://chromium-review.googlesource.com/1199462 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#55711}
-
- 22 Aug, 2018 2 commits
-
-
Peter Marshall authored
We should probably discourage random access given that it isn't constant time for this data structure. You can always still do it via the Find() function if you really need to - at least the weird interface tells you that something strange is going on. Change-Id: I5e20cf9172afaa9265f1a6e38f619543b65614f2 Reviewed-on: https://chromium-review.googlesource.com/1184916Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#55317}
-
Peter Marshall authored
We would return the wrong chunk for the first element past the chunk boundary, e.g. if the first chunk was size=8, then Find(8) would return an address in the first block rather than the second one. Bug: v8:8077 Change-Id: I90281f853dd7ca68dc065ed773d0ae9787f00988 Reviewed-on: https://chromium-review.googlesource.com/1183483 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55294}
-
- 24 Jul, 2018 1 commit
-
-
Leszek Swirski authored
Replace most uses of ZoneList in the parser with ZoneChunkList, which is more Zone allocation friendly. Includes rewriting some index-based loops as iterator-based, since ZoneChunkList random access isn't constant time. Bug: v8:7754 Change-Id: I49052b8afb90a4f3bfbe4076c2f90505b598e47a Reviewed-on: https://chromium-review.googlesource.com/1145382Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54631}
-
- 23 Jul, 2018 1 commit
-
-
Simon Zünd authored
Drive-by change: Add std::iterator_traits typedefs to ZoneChunkListIterator so we can use <algorithm>. R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: Ib7d1c622fdb761fc99bea373dbdef206f15bd4a0 Reviewed-on: https://chromium-review.googlesource.com/1145075 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54601}
-
- 20 Jul, 2018 1 commit
-
-
Simon Zünd authored
Drive-by change: Add "at" method to ZoneChunkList. R=petermarshall@chromium.org Bug: v8:7754 Change-Id: I75f4e3f786640f2a53b467aab18abe01b4f5b360 Reviewed-on: https://chromium-review.googlesource.com/1144823Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#54569}
-
- 23 Feb, 2018 2 commits
-
-
Marja Hölttä authored
Currently, pop_back() doesn't update size. Fix that. BUG=v8:7489 Change-Id: If11d2ddcaae3223289c168c1e6e1ad94d6775516 Reviewed-on: https://chromium-review.googlesource.com/934456Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#51517}
-
Marja Hölttä authored
BUG=v8:7478 Change-Id: Iad67d49729dfeb89fde26772689a22098f491b8a Reviewed-on: https://chromium-review.googlesource.com/931548 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#51510}
-
- 02 Feb, 2018 1 commit
-
-
jgruber authored
This check verifies that all .h files in the src/ directory have an include guard of the form #ifndef V8_PATH_TO_FILE_H_ #define V8_PATH_TO_FILE_H_ // ... #endif // V8_PATH_TO_FILE_H_ The check can be skipped with a magic comment: // PRESUBMIT_INTENTIONALLY_MISSING_INCLUDE_GUARD Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0a7b96abec289ad60f64ba8418f1892a6969596d Reviewed-on: https://chromium-review.googlesource.com/897487Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#51079}
-
- 18 Jan, 2018 2 commits
-
-
Clemens Hammacher authored
Merge all of them to a single implementation, getting rid of all the duplication. R=marja@chromium.org Change-Id: I5201e81ec64f3d7789df5e72bf58c85231cb348c Reviewed-on: https://chromium-review.googlesource.com/868133 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#50685}
-
Clemens Hammacher authored
With the current attempt, trying to iterate a const ZoneChunkList doesn't even compile. See the bug for more info. R=marja@chromium.org Bug: v8:6473 Change-Id: I8de7e887398be7ba5da14dc540dd40b30df2c3fe Reviewed-on: https://chromium-review.googlesource.com/868332Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50675}
-
- 02 Aug, 2017 1 commit
-
-
Julien Brianceau authored
Bug: chromium:750830 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Icab7b5a1c469d5e77d04df8bfca8319784e92af4 Reviewed-on: https://chromium-review.googlesource.com/595655 Commit-Queue: Julien Brianceau <jbriance@cisco.com> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47072}
-
- 11 Jan, 2017 1 commit
-
-
rmcilroy authored
This CL modifies the ast-numbering phase to collect function literals which should be compiled eagerly. This is then used to eagerly compile the inner functions before compiling the outer function. This will be used to queue compilation jobs on the CompilerDispatcher in a later CL. This CL moves the compilation of eager inner functions out of the GetSharedFunctionInfo function and instead compiles them explicitly. This simplifies GetSharedFunctionInfo and also means there is no need to pass a LazyCompilationMode to the function, so this concept has been removed. BUG=v8:5203,v8:5215 Review-Url: https://codereview.chromium.org/2618553004 Cr-Commit-Position: refs/heads/master@{#42221}
-
- 03 Nov, 2016 1 commit
-
-
heimbuef authored
Exchanged the ZoneList for a ZoneChunkList to avoid unnecessary growing. Review-Url: https://codereview.chromium.org/2468183004 Cr-Commit-Position: refs/heads/master@{#40736}
-
- 26 Oct, 2016 1 commit
-
-
heimbuef authored
Since ZoneLists are essentially non-standard ZoneVectors and have a bad growing behaviour (ZoneList-allocations make up ~50% of website parse zone memory) we should stop using them. The zone-containers are merely a clean-up, with none of them actually better suited to be used with zones. This new datastructure allows most operations of a LinkedList ( except pop_first and insertAt/removeAt) but uses about the same memory as a well-initialized ZoneVector/ZoneList (<3% overhead with reasonably large lists). It also never attempts to free memory again (which would not work in zones anyway). The ZoneChunkList is essentially a doubly-linked-list of arrays of variable size. Some test-results where I tried storing 16k pointers in different list types (lists themselves also zone-allocated): List type Zone memory used Time taken ----------------------------------------------------------------------- Zone array (for comparison) 131072 B Ideally initialized ZoneList 131088 B 0.062ms ChunkZoneList 134744 B 0.052ms <--new thing ZoneDeque 141744 B ZoneLinkedList 393264 B Initially empty ZoneList 524168 B 0.171ms <--right now ChunkZoneList only push_front 524320 B Review-Url: https://codereview.chromium.org/2449383002 Cr-Commit-Position: refs/heads/master@{#40602}
-