Skip to content

V
V8
Switch branch/tag
  1. 10 Aug, 2015 3 commits
  3. 07 Aug, 2015 3 commits
  5. 05 Aug, 2015 1 commit
  7. 04 Aug, 2015 3 commits
  9. 03 Aug, 2015 4 commits
  11. 31 Jul, 2015 1 commit
  13. 30 Jul, 2015 1 commit
  15. 27 Jul, 2015 1 commit
  17. 23 Jul, 2015 1 commit
  19. 21 Jul, 2015 1 commit
  21. 20 Jul, 2015 3 commits
  23. 15 Jul, 2015 1 commit
  25. 13 Jul, 2015 1 commit
    • yangguo's avatar
      Debugger: refactor reloc info. · 198c75f6
      yangguo authored 
      - split relocation info for debug break slots for
  - calls (with call arguments count as data)
  - construct calls
  - normal slots
- renamed DEBUG_BREAK into DEBUGGER_STATEMENT
- removed unused IC state for Debug stubs

R=ulan@chromium.org
BUG=v8:4269
LOG=N

Review URL: https://codereview.chromium.org/1232803002

Cr-Commit-Position: refs/heads/master@{#29603}
      198c75f6
  27. 06 Jul, 2015 1 commit
  29. 03 Jul, 2015 1 commit
  31. 02 Jul, 2015 1 commit
  33. 01 Jul, 2015 4 commits
  35. 30 Jun, 2015 2 commits
  37. 25 Jun, 2015 1 commit
  39. 24 Jun, 2015 1 commit
    • yangguo's avatar
      Serializer: clear next link in weak cells. · f1982eb4
      yangguo authored 
      If we do not clear next links during serialization, the
serializer would simply follow those links and serialize
arbitrary objects held by weak cells. This breaks the
invariant in the code serializer, which crashes if it
sees context-dependent objects.

R=ulan@chromium.org
BUG=chromium:503552
LOG=Y

Review URL: https://codereview.chromium.org/1203973002

Cr-Commit-Position: refs/heads/master@{#29255}
      f1982eb4
  41. 22 Jun, 2015 1 commit
    • mstarzinger's avatar
      Fix terrible interaction with code flushing. · 816abc5e
      mstarzinger authored 
      This fixes a terrible interaction of code flushing and the clearing of
optimized code maps hanging off a SharedFunctionInfo. The following is
what happened:
1) Incremental marking cleared map in SharedFunctionInfo s, however it
   was not enqueued as a flushing candidate because one JSFunction f1
   still had optimized code.
2) Deoptimization of f1 made s eligible for code flushing.
3) Optimization of f2 added new entry to optimized code map of s.
4) The JSFunction f2 became unreachable and hence is never marked.
5) Incremental marking now visits f1, finds it eligible for flushing,
   also s is eligible for flushing, both are enqueued.
6) Marking finishes, code flusher clears f1 and s, but the optimized
   code map of s still contains an entry.
7) Boom!

R=ulan@chromium.org,hpayer@chromium.org
TEST=mjsunit/es6/generators-iteration
BUG=v8:3803
LOG=N

Review URL: https://codereview.chromium.org/1197713004

Cr-Commit-Position: refs/heads/master@{#29177}
      816abc5e
  43. 18 Jun, 2015 1 commit
  45. 17 Jun, 2015 1 commit
  47. 16 Jun, 2015 2 commits
    • yangguo's avatar
      Serializer: support all alignment kinds. · 63f4c751
      yangguo authored 
      We use an alignment prefix for unusual alignment kinds (not kWordAligned).
This will cause new objects to be aligned in ReadObject, and back references
to be aligned to skip padding.

The motivation to change the undefined next sentinel in WeakCell is this:
When the deserializer aligns an object, it requires filler maps to already
exist to create filler objects as padding. However, deserializing the
filler map leads to deserializing NaN, which as heap number is aligned:
filler map > meta map > weak cell cache > undefined > NaN
If we use the-hole instead of undefined as sentinel, it works.

R=jochen@chromium.org,bbudge@chromium.org
BUG=v8:4178
LOG=N

Committed: https://crrev.com/2146ab75387d47eef6582bd8c2d0cfc6c42b68b6
Cr-Commit-Position: refs/heads/master@{#29044}

Review URL: https://codereview.chromium.org/1179873003

Cr-Commit-Position: refs/heads/master@{#29047}
      63f4c751
    • machenbach's avatar
      Revert of Serializer: support all alignment kinds. (patchset #3 id:40001 of... · 33ae0e67
      machenbach authored 
      Revert of Serializer: support all alignment kinds. (patchset #3 id:40001 of https://codereview.chromium.org/1179873003/)

Reason for revert:
[Sheriff] Breaks arm debug compile:
http://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builder/builds/4308

Original issue's description:
> Serializer: support all alignment kinds.
>
> We use an alignment prefix for unusual alignment kinds (not kWordAligned).
> This will cause new objects to be aligned in ReadObject, and back references
> to be aligned to skip padding.
>
> The motivation to change the undefined next sentinel in WeakCell is this:
> When the deserializer aligns an object, it requires filler maps to already
> exist to create filler objects as padding. However, deserializing the
> filler map leads to deserializing NaN, which as heap number is aligned:
> filler map > meta map > weak cell cache > undefined > NaN
> If we use the-hole instead of undefined as sentinel, it works.
>
> R=jochen@chromium.org,bbudge@chromium.org
> BUG=v8:4178
> LOG=N
>
> Committed: https://crrev.com/2146ab75387d47eef6582bd8c2d0cfc6c42b68b6
> Cr-Commit-Position: refs/heads/master@{#29044}

TBR=jochen@chromium.org,bbudge@chromium.org,yangguo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4178

Review URL: https://codereview.chromium.org/1173253006

Cr-Commit-Position: refs/heads/master@{#29045}
      33ae0e67