- 11 Oct, 2017 13 commits
-
-
Leszek Swirski authored
Bug: chromium:770530 Change-Id: I48f4c6968a34e0dce99f72e56302de81bf0f1991 Reviewed-on: https://chromium-review.googlesource.com/709597 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#48446}
-
Tobias Tebbi authored
Constructor inheritance of a templated constructor is causing compilation issues for node.js: https: //github.com/nodejs/node/pull/15362#issue-257007421 Change-Id: I7d099ff5a1a2fd5b19c11112ddef8fe824e509f7 Reviewed-on: https://chromium-review.googlesource.com/707008 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48445}
-
Michal Majewski authored
Skipped the tests that are not suitable for deoptimization fuzzing. regress/regress-2618 test fixed to check kMaybeDeopted flag. Minor code style fix in mjsunit.js. Bug: v8:6900 Change-Id: Icc02a6b99005ae08ee7cb6cf2c1e9137329d79d3 Reviewed-on: https://chromium-review.googlesource.com/708797 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48444}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org Bug: chromium:772816 Change-Id: I40014d381637394057b0646740a2487fef5fe8a6 Reviewed-on: https://chromium-review.googlesource.com/711841Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48443}
-
Ulan Degenbaev authored
This is a reland of f3c8da56 Original change's description: > [heap] Use weak cell in normalized map cache. > > This replaces ad-hoc weakness in normalized map cache with weak cell. > > Bug: chromium:694255 > Change-Id: I6a12301b2176fe3723b56178a65582cfb412f7d2 > Reviewed-on: https://chromium-review.googlesource.com/704834 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48344} Bug: chromium:694255 Change-Id: I181a9c02cc934373e40455f1be02f1caf140639b Reviewed-on: https://chromium-review.googlesource.com/709354Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#48442}
-
Michael Achenbach authored
Bug: chromium:773214 Change-Id: I7ebcbea3152a506e3ed569ef975413321c937dc6 Reviewed-on: https://chromium-review.googlesource.com/708755Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48441}
-
Georg Neis authored
This introduces a ToNumeric conversion to the runtime and interpreter. ToNumeric behaves like ToNumber, except that it also lets BigInts pass. Bug: v8:6791 Change-Id: Idf9d0b5d283638459fe5893de41cc120356247a7 Reviewed-on: https://chromium-review.googlesource.com/707013 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#48440}
-
Michael Achenbach authored
Bug: v8:6566 Change-Id: If48fea99f2b1c8069dd20075bf4d9a6c6282bb7c Reviewed-on: https://chromium-review.googlesource.com/708757Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48439}
-
Michael Achenbach authored
Infra side: https://chromium-review.googlesource.com/c/chromium/tools/build/+/708739 NOTRY=true Bug: chromium:772816 Change-Id: I256807182f52aad4e56684bad607aea1b7dc6c29 Reviewed-on: https://chromium-review.googlesource.com/708758Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48438}
-
Jaroslav Sevcik authored
When starting profiling, we iterate the heap to find all existing code objects and the associated functions. The iteration tried to log the function's code if either the closure's code was optimized-but-not-deoptimized or if the optimized code in its feedback vector was optimized-but-not-deoptimized. That caused some trouble if the function's code was deoptimized but we had a valid optimized code in the feedback vector. In that case we would log the deoptimized code object from the closure, which would later crash when trying to access the deoptimization information (which we clear on deoptimization). This CL just fixes the iteration so that we do not crash. A better fix might be to log the function's code object if not deoptimized *and* the code object in type feedback vector if not not deoptimized. Or perhaps iterate optimized code objects and log those that have deoptimization information. Bug: chromium:763073 Change-Id: Iddee6a1c8b0fe332186ef7af2f3751c8828434b1 Reviewed-on: https://chromium-review.googlesource.com/709116Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#48437}
-
Michael Achenbach authored
This reverts commit cc237d87. Reason for revert: breaks win clang: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang/builds/8538 Original change's description: > Reland "[wasm] trap handlers: fall back on old signal handler" > > This is a reland of ee4fe896 > Original change's description: > > [wasm] trap handlers: fall back on old signal handler > > > > This is primarily needed to test D8 under ASan. ASan installs a signal handler > > early in the process startup to show stack traces from crashes. We need to make > > sure that if V8 does not handle a signal then the existing handler gets a > > chance. > > > > This change only applies when using V8's default signal handler. When > > integrating with the embedder's signal handler the behavior is unchanged. > > > > Bug: chromium:771948 > > Change-Id: Ifd560acf9700ec5f714f009530258fa92c83cabe > > Reviewed-on: https://chromium-review.googlesource.com/705823 > > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > > Commit-Queue: Eric Holk <eholk@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#48429} > > Bug: chromium:771948 > Change-Id: Ide307091c432fd933c48f89c51851b8dce44dd30 > Reviewed-on: https://chromium-review.googlesource.com/710114 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Eric Holk <eholk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48435} TBR=mseaborn@chromium.org,bradnelson@chromium.org,gdeepti@chromium.org,eholk@chromium.org,mark@chromium.org Change-Id: If71f61ae186fc6be2006edeb2dffd7e2b6827d91 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:771948 Reviewed-on: https://chromium-review.googlesource.com/711854Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48436}
-
Eric Holk authored
This is a reland of ee4fe896 Original change's description: > [wasm] trap handlers: fall back on old signal handler > > This is primarily needed to test D8 under ASan. ASan installs a signal handler > early in the process startup to show stack traces from crashes. We need to make > sure that if V8 does not handle a signal then the existing handler gets a > chance. > > This change only applies when using V8's default signal handler. When > integrating with the embedder's signal handler the behavior is unchanged. > > Bug: chromium:771948 > Change-Id: Ifd560acf9700ec5f714f009530258fa92c83cabe > Reviewed-on: https://chromium-review.googlesource.com/705823 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Eric Holk <eholk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48429} Bug: chromium:771948 Change-Id: Ide307091c432fd933c48f89c51851b8dce44dd30 Reviewed-on: https://chromium-review.googlesource.com/710114Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48435}
-
Sathya Gunasekaran authored
This reverts commit ed6f00fb. Reason for revert: tree is broken NOTRY=true NOTREECHECKS=true Original change's description: > [modules] Implement import.meta proposal > > Rewrites references to import.meta to a new GetImportMetaObject runtime > call. Embedders can define a callback for creating the meta object using > v8::Isolate::SetHostGetImportMetaObjectCallback. If no callback has been > provided, an empty object with null prototype is created. > > This adds an example implementation to d8 that sets meta.url. > > Bug: v8:6693 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng > Change-Id: I6871eec79da45bba81bbbc84b1ffff48534c368d > Reviewed-on: https://chromium-review.googlesource.com/707902 > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48433} TBR=adamk@chromium.org,gsathya@chromium.org,jan.krems@groupon.com Change-Id: I908a508d5db84cc8ae60d4fd4a0446bb570c1492 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6693 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/710760Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#48434}
-
- 10 Oct, 2017 23 commits
-
-
Jan Krems authored
Rewrites references to import.meta to a new GetImportMetaObject runtime call. Embedders can define a callback for creating the meta object using v8::Isolate::SetHostGetImportMetaObjectCallback. If no callback has been provided, an empty object with null prototype is created. This adds an example implementation to d8 that sets meta.url. Bug: v8:6693 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I6871eec79da45bba81bbbc84b1ffff48534c368d Reviewed-on: https://chromium-review.googlesource.com/707902 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#48433}
-
Ulan Degenbaev authored
String with pointers should use snapshotting protocol because they can be externalized concurrently. Sequential strings can be turned into thin strings, so we need to cache the length and synchronized of markbits. No-Try: true Bug: v8:6915, chromium:694255 Change-Id: Ibd1f0ead31544f56aa9de9a177bee7e60fbc2e6a Reviewed-on: https://chromium-review.googlesource.com/708761 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#48432}
-
Mike Stanton authored
Bug: v8:6896 Change-Id: I4c54cc114fd2304de121586f6bcbf19957ae55b8 Reviewed-on: https://chromium-review.googlesource.com/708262 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48431}
-
Eric Holk authored
This reverts commit ee4fe896. Reason for revert: <INSERT REASONING HERE> Original change's description: > [wasm] trap handlers: fall back on old signal handler > > This is primarily needed to test D8 under ASan. ASan installs a signal handler > early in the process startup to show stack traces from crashes. We need to make > sure that if V8 does not handle a signal then the existing handler gets a > chance. > > This change only applies when using V8's default signal handler. When > integrating with the embedder's signal handler the behavior is unchanged. > > Bug: chromium:771948 > Change-Id: Ifd560acf9700ec5f714f009530258fa92c83cabe > Reviewed-on: https://chromium-review.googlesource.com/705823 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Eric Holk <eholk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48429} TBR=mseaborn@chromium.org,bradnelson@chromium.org,gdeepti@chromium.org,eholk@chromium.org,mark@chromium.org Change-Id: Ib43b096831b15c312b3b460e59f268d5ea903f21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:771948 Reviewed-on: https://chromium-review.googlesource.com/710034Reviewed-by: Eric Holk <eholk@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48430}
-
Eric Holk authored
This is primarily needed to test D8 under ASan. ASan installs a signal handler early in the process startup to show stack traces from crashes. We need to make sure that if V8 does not handle a signal then the existing handler gets a chance. This change only applies when using V8's default signal handler. When integrating with the embedder's signal handler the behavior is unchanged. Bug: chromium:771948 Change-Id: Ifd560acf9700ec5f714f009530258fa92c83cabe Reviewed-on: https://chromium-review.googlesource.com/705823Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48429}
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org Bug: chromium:769910 No-Try: true No-Tree-Checks: true Change-Id: I541d09bc20aa797b8360362eba12bd00c2148bc2 Reviewed-on: https://chromium-review.googlesource.com/708801 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#48428}
-
jgruber authored
kScratchRegister is not guaranteed to be preserved across calls to RecordWriteField. Bug: v8:6844 Change-Id: I65377852807f52be821be4d5911b07886102c5ee Reviewed-on: https://chromium-review.googlesource.com/709114Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#48427}
-
jgruber authored
The specced semantics of GetSubstitution are expected to change in the case of malformed named references, or named references to nonexistent named groups. The former will evaluate to the identity replacement of '$<', while the latter will result in replacement by the empty string. See also: https://github.com/tc39/proposal-regexp-named-groups/issues/29 Bug: v8:5437, v8:6912 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I879288f775774cb0ec563f9d9129a99710efb77c Reviewed-on: https://chromium-review.googlesource.com/708654 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48426}
-
Andreas Haas authored
R=titzer@chromium.org Change-Id: Ie65c03347b0619a107bc06725ce587e0270fa9a1 Reviewed-on: https://chromium-review.googlesource.com/707102 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48425}
-
Michael Lippautz authored
When hitting objects that are allocated in the most recent lienar allocation area, the concurrent marker currently has to bail out to the main thread. However, we only have to delay processing those objects until we are at a safepoint, e.g. IM::Step(). With this change we flush those on-hold-objects back to the shared queue upon performing an incremental marking step. Bug: chromium:694255 Change-Id: I25647d0fc581a5c4de0346bc394dc51062f65f70 Reviewed-on: https://chromium-review.googlesource.com/707315 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#48424}
-
Caitlin Potter authored
Previously, JS_ASYNC_GENERATOR_OBJECT_TYPE maps led to an UNREACHABLE macro, but are now restored like ordinary JSGeneratorObjects. BUG=chromium:772649, v8:5855 R=adamk@chromium.org, yangguo@chromium.org, verwaest@chromium.org Change-Id: I02e101565625f8a057d0e5b242a5fe0df263df89 Reviewed-on: https://chromium-review.googlesource.com/706780 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48423}
-
Yang Guo authored
Bug: v8:6867 TBR=ofrobots@google.com Change-Id: I0eaebe04863f4cc9152655fedbeb67225a4d8103 Reviewed-on: https://chromium-review.googlesource.com/691722Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48422}
-
Anna Henningsen authored
In Debug mode, V8 disallows executing JavaScript during `ScriptCompiler::CompileUnbound()` calls. This restriction makes sense during compilation, but not really for the post-compile notification, and currently at least one Node.js test (`test/inspector/test-contexts.js`) fails because of this in debug mode. Bug: Change-Id: I930b5f06083c0e87f1613414da3dfe2bcdf0f386 Reviewed-on: https://chromium-review.googlesource.com/706943Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48421}
-
Clemens Hammacher authored
This reverts commit 7c80f9ce. Reason for revert: arm64 msan failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/17455/steps/Check/logs/copy_slots_up Original change's description: > [arm64] Add slot copier to masm and use in builtins > > Abstract some stack slot copies through a macro assembler function. This > eliminates some non-paired stack operations. > > This is a reland of 1cc93be0 with > additional tests, originally reviewed on > https://chromium-review.googlesource.com/685238 and reverted due to an > unrelated intermittent x64 failure. > > Bug: v8:6644 > Change-Id: If22b359dbda4bab1cb83cd8c44a2af5801012c37 > Reviewed-on: https://chromium-review.googlesource.com/707247 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> > Cr-Commit-Position: refs/heads/master@{#48419} TBR=rmcilroy@chromium.org,martyn.capewell@arm.com,bmeurer@chromium.org Change-Id: I8a8aeff89b6995d5fffaab1f2e4e45f478c28bed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6644 Reviewed-on: https://chromium-review.googlesource.com/708814Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48420}
-
Martyn Capewell authored
Abstract some stack slot copies through a macro assembler function. This eliminates some non-paired stack operations. This is a reland of 1cc93be0 with additional tests, originally reviewed on https://chromium-review.googlesource.com/685238 and reverted due to an unrelated intermittent x64 failure. Bug: v8:6644 Change-Id: If22b359dbda4bab1cb83cd8c44a2af5801012c37 Reviewed-on: https://chromium-review.googlesource.com/707247Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Cr-Commit-Position: refs/heads/master@{#48419}
-
Camillo Bruni authored
Bug: v8:6211 Change-Id: Ie838cf118679e12483689e2c223e7ecc8335db18 Reviewed-on: https://chromium-review.googlesource.com/662759Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#48418}
-
Georg Neis authored
R=jkummerow@chromium.org Bug: v8:6791 Change-Id: I9bbb4c6b9b387fa0cd29fa24058ae807157f40de Reviewed-on: https://chromium-review.googlesource.com/707004 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#48417}
-
Michael Lippautz authored
Bug: Change-Id: I1bb6c6e3853317851544ca9f4eba1df76a147bfb Reviewed-on: https://chromium-review.googlesource.com/707317Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#48416}
-
Michael Starzinger authored
This makes sure that frames representing builtin stub continuations not only materialize all stack slots, but also spilled register values. Note that this also applies when the stub frame is not the top-most frame. R=jarin@chromium.org TEST=mjsunit/regress/regress-6907 BUG=v8:6907 Change-Id: I01a2edf5629de6aac61ceea350d1ab5f91dc2dc1 Reviewed-on: https://chromium-review.googlesource.com/707245Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48415}
-
Michael Achenbach authored
The new deopt stress is implemented for x64 only. NOTRY=true TBR=sergiyb@chromium.org Bug: v8:6900 Change-Id: I542cb89de643c477875893f6b0b73ced44108b9e Reviewed-on: https://chromium-review.googlesource.com/708259 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48414}
-
Michael Achenbach authored
Bug: chromium:754168 Change-Id: Ie3c80b7f566f6738893cc30f26b35b7862eccc6c Reviewed-on: https://chromium-review.googlesource.com/706996 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#48413}
-
Alexei Filippov authored
BUG=chromium:760649 TBR=cbruni@chromium.org Change-Id: I9fcd6e25f78f3d6cbd563c77c96a5b175d1ba125 Reviewed-on: https://chromium-review.googlesource.com/707901Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#48412}
-
Eric Holk authored
This flag was originally added as a staging mechanism to let us land and test guard regions without the full trap handler feature landing. Additionally, we thought we might enable guard regions without trap handlers on some systems. Trap handlers are now supported, and there's not a real compelling reason for why we need guard regions without trap handlers. Keeping the separate flag leads to confusion, since some code treats guard regions and trap handlers the same, while other code treats them as independent. Removing this flag and its associated special cases makes everything more uniform and predictable. R=gdeepti@chromium.org Change-Id: Icebab91d1f1e0c55e7a35c75b880085d37fa14ae Reviewed-on: https://chromium-review.googlesource.com/706570Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48411}
-
- 09 Oct, 2017 4 commits
-
-
Toon Verwaest authored
Bug: Change-Id: I0c2dabebbfa709589c19b1c48ec8de4c7f7a3952 Reviewed-on: https://chromium-review.googlesource.com/707151 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#48410}
-
Alexei Filippov authored
The RuntimeCallStats object happen to be created on the main thread, but then got used in a worker. Make sure the thread checks do not fire false positives in this case. BUG=chromium:760649 Change-Id: I8f2a2b4d1da1bc48416987ea378688ec15b9d955 Reviewed-on: https://chromium-review.googlesource.com/706181Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#48409}
-
Eric Holk authored
This was causing trouble with Fuchsia, since mksnapshot was built and run on Linux which supports trap handlers, while Fuchsia does not yet. This change causes the external references to match between Fuchsia and Linux. Bug: chromium:772057 Change-Id: I8e8f3539e3f5c4b798c364101ef2d16b5137f16d Reviewed-on: https://chromium-review.googlesource.com/706109Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48408}
-
Tobias Tebbi authored
This reverts commit 6ddb5e7d. Reason for revert: chromium:772873 chromium:772872 Original change's description: > Reland^2 "[turbofan] eagerly prune None types and deadness from the graph" > > Now, the EffectControlLinearizer connects all occurrences of Unreachable to the > graph end. This fixes issues with later phases running DeadCodeElimination and > introducing new DeadValue nodes when processing uses of Unreachable. > > This is a reland of 3c4bc27f > Original change's description: > > Reland "[turbofan] eagerly prune None types and deadness from the graph" > > > > This is a reland of e1cdda25 > > Original change's description: > > > [turbofan] eagerly prune None types and deadness from the graph > > > > > > In addition to using the {Dead} node to prune dead control nodes and nodes that > > > depend on them, we introduce a {DeadValue} node representing an impossible value > > > that can occur at any position in the graph. The extended {DeadCodeElimination} > > > prunes {DeadValue} and its uses, inserting a crashing {Unreachable} node into > > > the effect chain when possible. The remaining uses of {DeadValue} are handled > > > in {EffectControlLinearizer}, where we always have access to the effect chain. > > > In addition to explicitly introduced {DeadValue} nodes, we consider any value use > > > of a node with type {None} as dead. > > > > > > Bug: chromium:741225 > > > Change-Id: Icc4b636d1d018c452ba1a2fa7cd3e00e522f1655 > > > Reviewed-on: https://chromium-review.googlesource.com/641250 > > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#48208} > > > > Bug: chromium:741225 > > Change-Id: I21316913dae02864f7a6d7c9269405a79f054138 > > Reviewed-on: https://chromium-review.googlesource.com/692034 > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#48232} > > Bug: chromium:741225 > Change-Id: I5702ec34856c075717162153adc765774453c45f > Reviewed-on: https://chromium-review.googlesource.com/702264 > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48366} TBR=jarin@chromium.org,tebbi@chromium.org Change-Id: Ib0f59b8463681abf6a9158112515aefae3c76b5f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:741225 Reviewed-on: https://chromium-review.googlesource.com/707275Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#48407}
-