- 28 Feb, 2017 1 commit
-
-
hpayer authored
BUG=chromium:697049 Review-Url: https://codereview.chromium.org/2723473002 Cr-Commit-Position: refs/heads/master@{#43492}
-
- 13 Feb, 2017 2 commits
-
-
hpayer authored
BUG=chromium:673308,chromium:689555 Review-Url: https://codereview.chromium.org/2694763002 Cr-Commit-Position: refs/heads/master@{#43160}
-
hpayer authored
BUG=chromium:673308 Review-Url: https://codereview.chromium.org/2696563003 Cr-Commit-Position: refs/heads/master@{#43159}
-
- 06 Feb, 2017 1 commit
-
-
hpayer authored
BUG=chromium:673308 Review-Url: https://codereview.chromium.org/2677163002 Cr-Commit-Position: refs/heads/master@{#42962}
-
- 08 Dec, 2016 1 commit
-
-
hpayer authored
BUG=chromium:648568, chromium:669920 Review-Url: https://codereview.chromium.org/2548213004 Cr-Commit-Position: refs/heads/master@{#41592}
-
- 29 Nov, 2016 3 commits
-
-
hpayer authored
This reverts commit 810fcb28. BUG=chromium:648568, chromium:669270 Review-Url: https://codereview.chromium.org/2530383003 Cr-Commit-Position: refs/heads/master@{#41350}
-
machenbach authored
Revert of [heap] Reland: Use store buffer for writes coming from mutator. (patchset #1 id:1 of https://codereview.chromium.org/2529293004/ ) Reason for revert: Suspect for tsan failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/12915 Original issue's description: > [heap] Reland: Use store buffer for writes coming from mutator. > > This reverts commit 061c2ab2. > > BUG=chromium:648568, chromium:669270 > > Committed: https://crrev.com/fa2fdf275197185d9bca9d5e72c16a60722c3893 > Cr-Commit-Position: refs/heads/master@{#41341} TBR=mlippautz@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:648568, chromium:669270 Review-Url: https://codereview.chromium.org/2534803004 Cr-Commit-Position: refs/heads/master@{#41342}
-
hpayer authored
This reverts commit 061c2ab2. BUG=chromium:648568, chromium:669270 Review-Url: https://codereview.chromium.org/2529293004 Cr-Commit-Position: refs/heads/master@{#41341}
-
- 24 Nov, 2016 2 commits
-
-
machenbach authored
Revert of [heap] Use store buffer for writes coming from mutator. (patchset #6 id:100001 of https://codereview.chromium.org/2528563003/ ) Reason for revert: tsan problems: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/12860 Original issue's description: > Store buffer is used for writes that are coming from the mutator. Writes coming from the GC are directly added to the remembered set. > > BUG=chromium:648568 > > Committed: https://crrev.com/c63c34e12e60ac0a19e1338b647882ac61d08741 > Cr-Commit-Position: refs/heads/master@{#41263} TBR=ulan@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2528943002 Cr-Commit-Position: refs/heads/master@{#41265}
-
hpayer authored
Store buffer is used for writes that are coming from the mutator. Writes coming from the GC are directly added to the remembered set. BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2528563003 Cr-Commit-Position: refs/heads/master@{#41263}
-
- 18 Nov, 2016 1 commit
-
-
ulan authored
BUG=v8:5580 Review-Url: https://codereview.chromium.org/2460873003 Cr-Commit-Position: refs/heads/master@{#41095}
-
- 11 Nov, 2016 1 commit
-
-
hpayer authored
BUG=chromium:648973, chromium:648568 Review-Url: https://codereview.chromium.org/2493083003 Cr-Commit-Position: refs/heads/master@{#40928}
-
- 28 Oct, 2016 2 commits
-
-
machenbach authored
Revert of [heap] Concurrent store buffer processing. (patchset #13 id:260001 of https://codereview.chromium.org/2453673003/ ) Reason for revert: Seems to block rolling: https://codereview.chromium.org/2447393005/ Original issue's description: > [heap] Concurrent store buffer processing. > > BUG=chromium:648973, chromium:648568 TBR=ulan@chromium.org,mlippautz@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:648973, chromium:648568 Review-Url: https://codereview.chromium.org/2449853010 Cr-Commit-Position: refs/heads/master@{#40650}
-
hpayer authored
BUG=chromium:648973, chromium:648568 Review-Url: https://codereview.chromium.org/2453673003 Cr-Commit-Position: refs/heads/master@{#40642}
-
- 31 Mar, 2016 2 commits
-
-
ulan authored
This reduces the reserved virtual memory size needed for the store buffer. BUG=chromium:578883 LOG=NO Review URL: https://codereview.chromium.org/1851473002 Cr-Commit-Position: refs/heads/master@{#35174}
-
mlippautz authored
Change x64 to use the external references like all other platforms. BUG=chromium:581076 LOG=N Review URL: https://codereview.chromium.org/1844283002 Cr-Commit-Position: refs/heads/master@{#35160}
-
- 16 Feb, 2016 1 commit
-
-
ulan authored
This new class provides a unified interface for recording and iterating slots in store and slots buffers: RememberedSet<OLD_TO_NEW>::Insert(page, slot); RememberedSet<OLD_TO_OLD>::Insert(page, slot); RememberedSet<OLD_TO_NEW>::Iterate(heap, callback); RememberedSet<OLD_TO_OLD>::Iterate(heap, callback); After this change the store buffer is responsible only for collecting slots from the generated code. Subsequent CLs will remove the slots buffer. BUG=chromium:578883 LOG=NO Review URL: https://codereview.chromium.org/1683653002 Cr-Commit-Position: refs/heads/master@{#34031}
-
- 09 Feb, 2016 1 commit
-
-
ulan authored
BUG=chromium:578883 LOG=NO Review URL: https://codereview.chromium.org/1675163003 Cr-Commit-Position: refs/heads/master@{#33841}
-
- 08 Feb, 2016 1 commit
-
-
ulan authored
This replaces the global remembered set with per-page remembered sets. Each page in the old space, map space, and large object space keeps track of the set of slots in the page pointing to the new space. The data structure for storing slot sets is a two-level bitmap, which allows us to remove the store buffer overflow and SCAN_ON_SCAVENGE logic. Design doc: https://goo.gl/sMKCf7 BUG=chromium:578883 LOG=NO Review URL: https://codereview.chromium.org/1608583002 Cr-Commit-Position: refs/heads/master@{#33806}
-
- 25 Jan, 2016 1 commit
-
-
mlippautz authored
- Completely rely on the concurrent sweeping state for SweepingCompleted() - Rename the state accordingly. CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_asan_rel,v8_linux64_tsan_rel,v8_mac64_asan_rel R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1614953002 Cr-Commit-Position: refs/heads/master@{#33490}
-
- 15 Jan, 2016 1 commit
-
-
mlippautz authored
It is only used locally when exempting pages from the store buffer. This use case can be replaced with a hashmap at the call site. BUG=chromium:524425 LOG=N R=ulan@chromium.org Review URL: https://codereview.chromium.org/1593583002 Cr-Commit-Position: refs/heads/master@{#33324}
-
- 09 Dec, 2015 1 commit
-
-
mlippautz authored
R=hpayer@chromium.org BUG=chromium:524425 LOG=N Review URL: https://codereview.chromium.org/1504773002 Cr-Commit-Position: refs/heads/master@{#32712}
-
- 04 Dec, 2015 1 commit
-
-
mlippautz authored
Fix the missed store buffer entries for live objects on aborted pages. Marking the page as scan_on_scavenge takes care of rebuilding the entries. Note that this requires an additional case in the rebuilding logic as we cannot iterate an aborted pages using the object layout, but rather have to use mark bits for this. BUG=chromium:524425, chromium:564498 LOG=N Review URL: https://codereview.chromium.org/1497883003 Cr-Commit-Position: refs/heads/master@{#32610}
-
- 13 Nov, 2015 2 commits
-
-
ishell authored
This CL introduces the following visitors: 1) RecordMigratedSlotVisitor which simplifies MarkCompactCollector::MigrateObject(). 2) IteratePointersToFromSpaceVisitor which simplifies Heap::IteratePointersToFromSpace(). 3) FindPointersToNewSpaceVisitor which simplifies StoreBuffer::IteratePointersToNewSpace(). These changes make the object's body descriptors the one and only place that knows how to traverse the object. Review URL: https://codereview.chromium.org/1441453002 Cr-Commit-Position: refs/heads/master@{#31992}
-
ishell authored
1) Body descriptors moved to their own header files. 2) Missing body descriptors added. 3) Template versions of HeapObject::Iterate*() methods added. 4) Body descriptors support new kind of queries: IsValidSlot(offset) which can be used for invalid slots filtering. This is a first step towards virtual and static visitors unification and support in-object properties in built-in (sub-)classes. Review URL: https://codereview.chromium.org/1440243002 Cr-Commit-Position: refs/heads/master@{#31980}
-
- 29 Sep, 2015 1 commit
-
-
mstarzinger authored
This prevents the internal incremental-marking.h to be usable outisde of the "heap" directory. The logic inside that component is only useful within the GC and is now properly encapsulated. R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1374203002 Cr-Commit-Position: refs/heads/master@{#31010}
-
- 16 Sep, 2015 1 commit
-
-
fedor authored
ArrayBuffer's backing store is a pointer to external heap, and can't be treated as a heap object. Doing so will result in crashes, when the backing store is unaligned. See: https://github.com/nodejs/node/issues/2791 BUG=chromium:530531 R=mlippautz@chromium.org LOG=N Review URL: https://codereview.chromium.org/1327403002 Cr-Commit-Position: refs/heads/master@{#30771}
-
- 27 Aug, 2015 1 commit
-
-
rmcilroy authored
Adds a (currently unused) constant_pool() field to BytecodeArray objects. This field points to a FixedArray object which will be used to hold constants. The BytecodeArray is now a mixed values object type, with the kConstantPoolOffset object holding a tagged pointer, but the remainder of the object holding raw bytes (which could look like tagged pointers but are not). Modify the BytecodeArray GC visitors to deal with this and test that the field is migrated properly when evacuated. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1314953004 Cr-Commit-Position: refs/heads/master@{#30404}
-
- 25 Aug, 2015 1 commit
-
-
mstarzinger authored
R=mlippautz@chromium.org Review URL: https://codereview.chromium.org/1317553002 Cr-Commit-Position: refs/heads/master@{#30355}
-
- 21 Aug, 2015 1 commit
-
-
mstarzinger authored
R=mlippautz@chromium.org Review URL: https://codereview.chromium.org/1309733002 Cr-Commit-Position: refs/heads/master@{#30304}
-
- 20 Aug, 2015 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1285183010 Cr-Commit-Position: refs/heads/master@{#30263}
-
- 17 Aug, 2015 2 commits
-
-
hpayer authored
This debug check is not needed anymore. This reverts commit ce311ed0. BUG= Review URL: https://codereview.chromium.org/1300663002 Cr-Commit-Position: refs/heads/master@{#30205}
-
mstarzinger authored
R=mlippautz@chromium.org Review URL: https://codereview.chromium.org/1291833003 Cr-Commit-Position: refs/heads/master@{#30195}
-
- 07 Aug, 2015 1 commit
-
-
mstarzinger authored
R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1281903002 Cr-Commit-Position: refs/heads/master@{#30071}
-
- 03 Aug, 2015 3 commits
-
-
hpayer authored
Reland of land concurrent sweeping of code space. (patchset #1 id:1 of https://codereview.chromium.org/1263343002/) Reason for revert: Bogus revert. Original issue's description: > Revert of Reland concurrent sweeping of code space. (patchset #6 id:100001 of https://codereview.chromium.org/1242333002/) > > Reason for revert: > Reverted because 507840 came back on recent Chromecrash. Should not have committed this Cl. > > Original issue's description: > > Reland concurrent sweeping of code space. > > > > BUG= > > > > Committed: https://crrev.com/8516dccf6a561020441773c93c564dd4aa6ee59e > > Cr-Commit-Position: refs/heads/master@{#29967} > > TBR=jochen@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/5c6e7d00438cc82a5584e3178d7dadf36e4a34f8 > Cr-Commit-Position: refs/heads/master@{#29975} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1271773002 Cr-Commit-Position: refs/heads/master@{#29976}
-
hpayer authored
Revert of Reland concurrent sweeping of code space. (patchset #6 id:100001 of https://codereview.chromium.org/1242333002/) Reason for revert: Reverted because 507840 came back on recent Chromecrash. Should not have committed this Cl. Original issue's description: > Reland concurrent sweeping of code space. > > BUG= > > Committed: https://crrev.com/8516dccf6a561020441773c93c564dd4aa6ee59e > Cr-Commit-Position: refs/heads/master@{#29967} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1263343002 Cr-Commit-Position: refs/heads/master@{#29975}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1242333002 Cr-Commit-Position: refs/heads/master@{#29967}
-
- 23 Jul, 2015 1 commit
-
-
hpayer authored
Use a lock in pages to synchronize sweeper threads to allow others to wait on concurrently swept pages. BUG= Review URL: https://codereview.chromium.org/1244353002 Cr-Commit-Position: refs/heads/master@{#29804}
-
- 20 Jul, 2015 2 commits
-
-
hpayer authored
Revert of Reland concurrent sweeping of code space. (patchset #5 id:80001 of https://codereview.chromium.org/1225733002/) Reason for revert: Tests became flaky. Original issue's description: > Reland concurrent sweeping of code space. > > BUG=chromium:506778,chromium:506957,chromium:507211 > LOG=n > > Committed: https://crrev.com/806b81f11e3bfaef0d4330c7669e6934074be9cb > Cr-Commit-Position: refs/heads/master@{#29748} TBR=jochen@chromium.org,mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:506778,chromium:506957,chromium:507211 Review URL: https://codereview.chromium.org/1242743002 Cr-Commit-Position: refs/heads/master@{#29751}
-
hpayer authored
BUG=chromium:506778,chromium:506957,chromium:507211 LOG=n Review URL: https://codereview.chromium.org/1225733002 Cr-Commit-Position: refs/heads/master@{#29748}
-