1. 29 Dec, 2021 1 commit
    • Benedikt Meurer's avatar
      [inspector] Correct location for inline scripts with sourceURL. · a81e8d16
      Benedikt Meurer authored
      Previously the `Debugger.CallFrame`s in `Debugger.paused` events would
      report locations relative to the surrounding document in case of inline
      scripts with `//@ sourceURL` annotations (while `Runtime.CallFrame` was
      already fixed previously as part of crrev.com/c/3069289). With this CL
      the locations in `Debugger.CallFrame` are also appropriately adjusted.
      
      Drive-by-fix: Several inspector tests were (incorrectly) relying on this
      wrong treatment, and were also unnecessarily using //# sourceURL
      annotations. So part of this CL also addresses that problem and makes
      the tests more robust, using addInlineScript() helper.
      
      Fixed: chromium:1283049
      Bug: chromium:1183990, chromium:578269
      Change-Id: I6e3b215d951c3453c0a9cfc9bccf3dc3d5e92fd6
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3359619
      Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#78450}
      a81e8d16
  2. 02 May, 2019 1 commit
  3. 21 Apr, 2017 1 commit
  4. 26 Jan, 2017 2 commits
  5. 25 Jan, 2017 1 commit
  6. 24 Jan, 2017 1 commit
    • kozyatinskiy's avatar
      [inspector] implemented blackboxing inside v8 · ac50c79a
      kozyatinskiy authored
      V8 has internal mechanism to ignore steps and breaks inside internal scripts, in this CL it's reused for blackboxing implementation.
      Advantages:
      - much faster blackboxing implementation (before we at least wrap and collect current call stack for each step),
      - get rid of StepFrame action and potential pause in blackboxed code after N StepFrame steps,
      - simplification of debugger agent logic.
      Disadvtanges:
      - currently when user was paused in blackboxed code (e.g. on breakpoint) and then makes step action, debugger ignores blackboxed state of the script and allows to use step actions as usual - this behavior is regressed, we still able to support it on frontend side.
      
      Current state and proposed changes for blackboxing: https://docs.google.com/document/d/1hnzaXPAN8_QC5ENxIgxgMNDbXLraM_OXT73rAyijTF8/edit?usp=sharing
      
      BUG=v8:5842
      R=yangguo@chromium.org,dgozman@chromium.org,alph@chromium.org
      
      Review-Url: https://codereview.chromium.org/2633803002
      Cr-Commit-Position: refs/heads/master@{#42614}
      ac50c79a