1. 02 May, 2019 1 commit
  2. 24 Apr, 2019 1 commit
  3. 17 Apr, 2019 2 commits
  4. 27 Mar, 2019 1 commit
  5. 14 Feb, 2019 1 commit
  6. 13 Feb, 2019 1 commit
  7. 21 Jan, 2019 4 commits
    • Peter Marshall's avatar
      [cpu-profiler] Remove registration and sampling depth from Sampler · 1f1bd71d
      Peter Marshall authored
      Simplify the internal state of Sampler a bit. There are basically two
      users of Sampler - the CpuSampler used by the CpuProfiler and the
      Ticker used by log.cc. Ticker calls Start/Stop to manage the Sampler
      lifetime, but CpuProfiler does not. This leads to much confusion and
      overlap of functionality.
      
      Fix that here by removing the distinction between active, registered
      and isProfiling states. These are now all the same thing and are
      represented by IsActive(). The state is set to active when Start is
      called, and set inactive when Stop is called. Both users of Sampler
      now call Start and Stop at appropriate times.
      
      The concept of profiling depth was not used - each Sampler would
      only ever have a sampling depth of 1. We still need to call
      SignalHandler::IncreaseSamplerCount(), so we do that in Start
      and the corresponding DecreaseSamplerCount() in Stop.
      
      Change-Id: I16a9435d26169a7dd00b1c7876e66af45f12e4b0
      Reviewed-on: https://chromium-review.googlesource.com/c/1424337
      Commit-Queue: Peter Marshall <petermarshall@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58955}
      1f1bd71d
    • Peter Marshall's avatar
      [cpu-profiler] Cleanup and use std atomics in Sampler · ba565577
      Peter Marshall authored
      There's no reason to use our self-baked atomics anymore. Also
      
      - Changes two boolean values to use a boolean instead of an int
      - Uses a unique ptr for data_
      - Removes has_processing_thread_ which is not used
      - Moves most initialization inline into the class
      - Removes SetUp/TearDown which weren't needed
      
      Change-Id: I8f50133636961502d56351abd2fb17196603a01a
      Reviewed-on: https://chromium-review.googlesource.com/c/1422918
      Commit-Queue: Peter Marshall <petermarshall@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58950}
      ba565577
    • Peter Marshall's avatar
      [cpu-profiler] Add tests for sampler.cc · 5aa361ff
      Peter Marshall authored
      Moved class definitions into header
      
      Change-Id: I2d3e5ec6f8f5068284cdbaa6900797950fc7e01a
      Reviewed-on: https://chromium-review.googlesource.com/c/1422739
      Commit-Queue: Peter Marshall <petermarshall@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58946}
      5aa361ff
    • Peter Marshall's avatar
      [cpu-profiler] Use unordered_map instead of custom hashmap in sampler · 4dbdeea2
      Peter Marshall authored
      There is no reason to use the custom map here anymore. This lets us
      get rid of the custom hash and a lot of casts.
      
      We can also store the SamplerList by value in the map rather than a
      pointer, then we don't have to manage the lifetime explicitly.
      
      Also move the SamplerList typedef inside of SamplerManager because it's
      an internal detail. Remove the include for <map> because we aren't using
      this anywhere anyway.
      
      Change-Id: I787a1b6c3ffc331ec3f36e66d5e07bd115c4cbb4
      Reviewed-on: https://chromium-review.googlesource.com/c/1419317Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Peter Marshall <petermarshall@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58945}
      4dbdeea2
  8. 18 Jan, 2019 2 commits
  9. 16 Jan, 2019 1 commit
  10. 15 Jan, 2019 2 commits
  11. 14 Jan, 2019 2 commits
  12. 02 Jan, 2019 1 commit
  13. 25 Oct, 2018 1 commit
    • Peter Marshall's avatar
      Reland "[cpu-profiler] Fix a bug which caused a pure virtual function call" · 3767ab39
      Peter Marshall authored
      This is a reland of c92a1dda
      
      Original change's description:
      > [cpu-profiler] Fix a bug which caused a pure virtual function call
      >
      > We need to remove each Sampler from the SamplerManager before we call
      > the Sampler destructor. This is because the signal handler can interrupt
      > the destructor, and call DoSampler(), which calls sampler->SampleStack()
      > on the sampler being destructed, causing general unhappiness and
      > "Pure virtual function called!" crashes.
      >
      > Bug: v8:8346, v8:5193
      > Change-Id: Iaa595a196eab33fb1af31584e9a68fd1ce0a18f6
      > Reviewed-on: https://chromium-review.googlesource.com/c/1293949
      > Commit-Queue: Peter Marshall <petermarshall@chromium.org>
      > Reviewed-by: Alexei Filippov <alph@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#56882}
      
      TBR=yangguo@chromium.org
      
      Bug: v8:8346, v8:5193
      Change-Id: I9878f65c868ff1aed6f3a587cba688c4241bad8c
      Reviewed-on: https://chromium-review.googlesource.com/c/1298893Reviewed-by: 's avatarPeter Marshall <petermarshall@chromium.org>
      Commit-Queue: Peter Marshall <petermarshall@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56976}
      3767ab39
  14. 24 Oct, 2018 1 commit
  15. 23 Oct, 2018 4 commits
  16. 18 Oct, 2018 1 commit
  17. 12 Oct, 2018 1 commit
  18. 01 Oct, 2018 1 commit
  19. 14 Sep, 2018 1 commit
  20. 01 Aug, 2018 1 commit
  21. 12 Feb, 2018 1 commit
  22. 08 Feb, 2018 1 commit
  23. 18 Oct, 2017 1 commit
  24. 21 Aug, 2017 1 commit
  25. 14 Jul, 2017 1 commit
  26. 11 Jun, 2017 1 commit
    • scottmg's avatar
      Basic compilation on Fuchsia · c72a6126
      scottmg authored
      Sufficient to compile //v8 in Chrome with target_os="fuchsia". Doesn't
      link yet, due to missing implementations (primarily VirtualMemory, as
      well as a few utility functions).
      
      BUG=chromium:731217
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
      
      Review-Url: https://codereview.chromium.org/2931143002
      Cr-Commit-Position: refs/heads/master@{#45831}
      c72a6126
  27. 30 May, 2017 1 commit
  28. 17 Mar, 2017 1 commit
  29. 10 Nov, 2016 1 commit
  30. 29 Sep, 2016 1 commit
    • leszeks's avatar
      [base] Template MatchFun in TemplateHashMapImpl · 837c91e8
      leszeks authored
      Make MatchFun a template parameter in TemplateHashMapImpl, moving the
      PointersMatch function down to an implementation which extends
      TemplateHashMapImpl to void* key and value (i.e. the same as the current
      HashMap and ZoneHashMap typedefs).
      
      This will allow other instantiations of TemplateHashMapImpl, with
      different MatchFun values, e.g. std::equal_to, to have their key
      equality test inlined, rather than calling a function pointer,
      
      Review-Url: https://codereview.chromium.org/2354593002
      Cr-Commit-Position: refs/heads/master@{#39868}
      837c91e8