- 12 Sep, 2018 6 commits
-
-
Michael Lippautz authored
- Update those counters from space - Add fast path for move memory Fix: - Introduce proper variants for checked arithmetic on atomics. This reverts commit 0c62f5b3. Bug: chromium:845409 Change-Id: I98ad1a7c470c7e7b805e087b4ec74e3451344712 Reviewed-on: https://chromium-review.googlesource.com/1219647Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55815}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I2ac8b12c040af2ad6122ce14eef8b4f8375e46ac Reviewed-on: https://chromium-review.googlesource.com/1219708Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55814}
-
Clemens Hammacher authored
This reverts commit f0f5f877. Reason for revert: Merge conflict (does not compile). Original change's description: > Reland "[Liftoff] Implement f32.copysign and f64.copysign" > > This is a reland of 6afe7d18. > The reason for the revert is fixed in https://crrev.com/c/1219633. > > Original change's description: > > [Liftoff] Implement f32.copysign and f64.copysign > > > > These are two of the few missing instructions. This CL implements them > > for ia32 and x64, and bails out on other platforms. > > On x64, we are using the BTR instruction since we cannot have 64-bit > > immediates. > > > > Drive-by: Fix naming of existing bt/bts instructions on x64. > > > > R=titzer@chromium.org > > > > Bug: v8:6600 > > Change-Id: Ib8532ca811160cd61f4ba7c06b04ce093861c872 > > Reviewed-on: https://chromium-review.googlesource.com/1174383 > > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > > Reviewed-by: Ben Titzer <titzer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#55780} > > Bug: v8:6600 > Change-Id: I4baeec6b02b17450988cfa7fedd5037f9cfe1638 > Reviewed-on: https://chromium-review.googlesource.com/1219508 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55812} TBR=titzer@chromium.org,clemensh@chromium.org Change-Id: Iae075a8f5225f1678691698bf3a304faa5ae2aab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6600 Reviewed-on: https://chromium-review.googlesource.com/1220747Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55813}
-
Clemens Hammacher authored
This is a reland of 6afe7d18. The reason for the revert is fixed in https://crrev.com/c/1219633. Original change's description: > [Liftoff] Implement f32.copysign and f64.copysign > > These are two of the few missing instructions. This CL implements them > for ia32 and x64, and bails out on other platforms. > On x64, we are using the BTR instruction since we cannot have 64-bit > immediates. > > Drive-by: Fix naming of existing bt/bts instructions on x64. > > R=titzer@chromium.org > > Bug: v8:6600 > Change-Id: Ib8532ca811160cd61f4ba7c06b04ce093861c872 > Reviewed-on: https://chromium-review.googlesource.com/1174383 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Ben Titzer <titzer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55780} Bug: v8:6600 Change-Id: I4baeec6b02b17450988cfa7fedd5037f9cfe1638 Reviewed-on: https://chromium-review.googlesource.com/1219508Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55812}
-
Michael Achenbach authored
NOTRY=true TBR=herhut@chromium.org Bug: v8:8164 Change-Id: I6748a6fc58c9910855f018cccc1d93a40d8c32ad Reviewed-on: https://chromium-review.googlesource.com/1219692Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55811}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b34c179..107ec0d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c80faf4..134ee36 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/727453b..0425ebd Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/e9dadb9..f59512e TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7656b828f0cbc6fb6240f898f828b13a9fdb75e8 Reviewed-on: https://chromium-review.googlesource.com/1220889 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#55810}
-
- 11 Sep, 2018 34 commits
-
-
Ali Ijaz Sheikh authored
https://github.com/nodejs/node/issues/21038 Change-Id: Ic4c9f403b5e54a97d3170b2311dd5aab8c8357c8 Reviewed-on: https://chromium-review.googlesource.com/1217726 Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55809}
-
Sathya Gunasekaran authored
This will give us some clusterfuzz coverage. Bug: v8:7869 Change-Id: Ia93b4f4f8b76011a73405788ad940059467d9114 Reviewed-on: https://chromium-review.googlesource.com/1220292Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55808}
-
Deepti Gandluri authored
This reverts commit 9c67143f. Reason for revert: Potential cause of mac gpu failures for the auto roller - https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_optional_gpu_tests_rel/9158 Original change's description: > [heap] Introduce backing store counters on Heap > > - Update those counters from space > - Add fast path for move memory > > Bug: chromium:845409 > Change-Id: Icd72e551df2422a635801fb4e31588073f81544e > Reviewed-on: https://chromium-review.googlesource.com/1219707 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55798} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: Iaa0d375d84f1c559a13dea9b9f1b7f6907cbd768 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1220293Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#55807}
-
Caitlin Potter authored
The CSA implementation is a separate handler so that TF has the opportunity to reduce to a direct call, skipping some of the dispatching in the CloneObjectIC stub. This patch moves the looping over a source object's keys and values into the base CodeStubAssembler, so that it can be shared between ObjectAssignFast and CloneObjectIC_Slow. During each step of the loop, storing is delegated to a new SetPropertyInLiteral helper in KeyedStoreGenericGenerator, which performs a store without consulting the prototype chain, and automatically reconfigures accessors into data properties regardless of their attributes. BUG=v8:8067, v8:7611 R=ishell@chromium.org, jkummerow@chromium.org Change-Id: I06ae89f37e9b4265aab67389cf68a96529f90578 Reviewed-on: https://chromium-review.googlesource.com/1182122 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#55806}
-
Ujjwal Sharma authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I91a7305d82423d3a7b1d2fc44282b6116c4c746c Reviewed-on: https://chromium-review.googlesource.com/1208652 Commit-Queue: Ujjwal Sharma <usharma1998@gmail.com> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55805}
-
Camillo Bruni authored
- Introduce Token::IsLiteral helper - Introduce Token::IsStrictReservedWord helper Drive-by-fix: - Use "token" instead of "tok" as variable name - Keep enum order consistent accross files Change-Id: Ie3b30a62dfbea761a31c32465c0afa681d326710 Reviewed-on: https://chromium-review.googlesource.com/1203952Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55804}
-
Benedikt Meurer authored
We had an optimization in Crankshaft where we would call into the megamorphic handler stub directly if an inline cache was already found to be megamorphic when it hit the optimizing compiler. This way we could avoid the dispatch overhead when we know that there's no point in checking for the other states anyways. However we somehow missed to port this optimization to TurboFan. Now this change introduces support to call into LoadIC_Megamorphic and KeyedLoadIC_Megamorphic directly (plus the trampoline versions), which saves quite a lot of overhead for the cases where the map/name pair is found in the megamorphic stub cache, and it's quite a simple change. We can later extend this to also handle the StoreIC and KeyedStoreIC cases if that turns out to be beneficial. This improves the score on the Octane/TypeScript test by around ~2% and the TypeScript test in the web-tooling-benchmark by around ~4%. On the ARES-6 Air test the steady state mean improves by 2-4%, and on the ARES-6 ML test the steady state mean seems to also improve by 1-2%, but that might be within noise. On a micro-benchmark that just runs `o.x` in a hot loop on a set of 9 different objects, which all have `x` as the first property and are all in fast mode, we improve by around ~30%, and are now almost on par with JavaScriptCore. Bug: v8:6344, v8:6936 Change-Id: Iaa4c6e34c37e78da217ee75f32f6acc95a834250 Reviewed-on: https://chromium-review.googlesource.com/1215623Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55803}
-
Deepti Gandluri authored
This reverts commit ece86adc. Reason for revert: Potential cause of auto-roller breakage https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win10_chromium_x64_rel_ng/91864 Original change's description: > [typedarray] Properly convert hole to undefined in TypedArray.from > > It used to call the old IterableToList, which had the wrong > semantics for holes. > > Bug: v8:8133 > Change-Id: Idd5acd55a155bc43df7552135a44151bb2db38e9 > Reviewed-on: https://chromium-review.googlesource.com/1213204 > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55745} TBR=neis@chromium.org,petermarshall@chromium.org,dhai@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8133 Change-Id: I09b108e7844c598253fbbe02d705699c21308637 Reviewed-on: https://chromium-review.googlesource.com/1220286Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#55802}
-
Florian Sattler authored
Bug: v8:7926 Change-Id: Idfc520b67696c8a838a0ee297ea392d416dd899e Reviewed-on: https://chromium-review.googlesource.com/1206292 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55801}
-
Clemens Hammacher authored
The fallback for {Pinsrd} and {Pextrd} for the non-avx and non-sse variant clobbered the {xmm0} register. This CL fixes this by storing the values on the stack and modifying them there instead. The alternative would have been to pass in a scratch register. But this path is not commonly used and we cannot express in the API whether the scratch register is needed or not. So we would sometimes have to spill a register to pass it as scratch register even though it is then unused. R=titzer@chromium.org CC=mstarzinger@chromium.org Bug: v8:6600 Change-Id: Ieae53b892cc55eed4fcfa3d0e7f82f3e1afe72be Reviewed-on: https://chromium-review.googlesource.com/1219633Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55800}
-
Clemens Hammacher authored
In the CHECK_FLOAT_EQ and CHECK_DOUBLE_EQ wrappers, do also print hex representations on failure. Otherwise, single bit flips might not be visible in the output, like here: Check failed: DoubleWrapper(x) == y (-2e+66 vs. -2e+66). R=titzer@chromium.org Change-Id: I2521706aedc6ff81c0dbb25259230f8e29ce9a3e Reviewed-on: https://chromium-review.googlesource.com/1219630Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55799}
-
Michael Lippautz authored
- Update those counters from space - Add fast path for move memory Bug: chromium:845409 Change-Id: Icd72e551df2422a635801fb4e31588073f81544e Reviewed-on: https://chromium-review.googlesource.com/1219707Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55798}
-
Simon Zünd authored
This CL adds a contextual variable that tracks lint errors and will cause the Torque compiler to abort if there were any. R=tebbi@chromium.org Bug: v8:7793 Change-Id: Ia7c2b5b6c7cb12d489b12596afa84f933fc3f337 Reviewed-on: https://chromium-review.googlesource.com/1219388Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#55797}
-
Clemens Hammacher authored
This improves the error message if we accidentally call this method on a CPU which does not support it. R=mstarzinger@chromium.org Bug: v8:6600 Change-Id: If67bf9e95ab0e71d832a833a70b6ba748b53296e Reviewed-on: https://chromium-review.googlesource.com/1219631Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55796}
-
Michael Achenbach authored
TBR=neis@chromium.org NOTRY=true Bug: chromium:866862 Change-Id: I7c143eb67edcb54ab1fe260d1d7da6eedb44bfc2 Reviewed-on: https://chromium-review.googlesource.com/1219635Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55795}
-
Simon Zünd authored
To make the changes in base.tq work, there were 2 changes needed on the C++ side: - calls to "FromConstexpr" are generated by the compiler for implicit conversions. - type switch is desugared and uses "Cast" R=jgruber@chromium.org, tebbi@chromium.org Change-Id: I085f1a393f93e501e6bbcaeacb0d6568259a4714 Reviewed-on: https://chromium-review.googlesource.com/1219629 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55794}
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Change-Id: I0ee00cccbcfd238a183df53e2d9234e06d5cca51 Reviewed-on: https://chromium-review.googlesource.com/1219634Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55793}
-
Michael Achenbach authored
Bug: v8:8162 Change-Id: Ib3965263a7ef52284a6f08378a76fafc7b18fa42 Reviewed-on: https://chromium-review.googlesource.com/1219506 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#55792}
-
Florian Sattler authored
NOTRY=true Change-Id: If305367e5971a596ea5b3cd665dc5a5771d925bf Reviewed-on: https://chromium-review.googlesource.com/1219628 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55791}
-
Creddy authored
- Rename Runtime_SetProperty to Runtime_SetKeyedProperty - Create Runtime_SetNamedProperty and use it for SetNamed property in one-shot code. - Rename Object::StoreFromKeyed enum to StoreOrigin Bug: v8:8072, chromium:876839 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I22132380ca4b6ce1e0a14a38cca849814559cdcf Reviewed-on: https://chromium-review.googlesource.com/1207870Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Chandan Reddy <chandanreddy@google.com> Cr-Commit-Position: refs/heads/master@{#55790}
-
Michael Starzinger authored
This checks the type signature during import against the expected signature. For this the {WasmExceptionObject} now contains a serialized version of the signature. R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions-import BUG=v8:8091 Change-Id: I5a34ef87eccf4d2ed3a784620796ec009623fd90 Reviewed-on: https://chromium-review.googlesource.com/1219509Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55789}
-
Andreas Haas authored
There was a bug in WebAssembly.instantiate in the case where a CSP disallows WebAssembly compilation. In this case the promise returned by WebAssembly.instantiate was rejected immediately because of the CSP, but then compilation was started anyways, and the promise was resolved after compilation for a second time, which caused the crash. With this CL we do not start compilation if CSP disallows WebAssembly compilation. R=clemensh@chromium.org Bug: chromium:881978 Change-Id: Iffdb3e02c3006eb7f86211ab197f81cf20438f0e Reviewed-on: https://chromium-review.googlesource.com/1219706 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55788}
-
Dan Elphick authored
Use v8_executable instead of executable for bytecode_builtins_list_generator so that coverage link flags should be picked up too. Bug: v8:8068 Change-Id: I260e4de3485a78d3b3a3455441837e1a5936aa25 Reviewed-on: https://chromium-review.googlesource.com/1219326Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#55787}
-
Florian Sattler authored
Change-Id: I6d20cb2febdcf8c937d5b37557a701d9c6c45fd2 Reviewed-on: https://chromium-review.googlesource.com/1177720 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55786}
-
Frank Tang authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;luci.chromium.try:linux_chromium_rel_ng Change-Id: Idf89e9d79e9b063c7d01e2b133826b9127910f4e Reviewed-on: https://chromium-review.googlesource.com/1205835 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55785}
-
Michael Achenbach authored
This enables cctest, unittests, fuzzer and inspector on Android. The cctest suite requires extra resource-fetching logic for the bytecode-generator expectation files. Bug: chromium:866862 Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng Change-Id: If3da853a62c047388476a7f38e32e64e2859f186 Reviewed-on: https://chromium-review.googlesource.com/1213208 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55784}
-
Clemens Hammacher authored
This reverts commit 6afe7d18. Reason for revert: Failures (-2e+66 vs. -2e+66): https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20debug/22148 Original change's description: > [Liftoff] Implement f32.copysign and f64.copysign > > These are two of the few missing instructions. This CL implements them > for ia32 and x64, and bails out on other platforms. > On x64, we are using the BTR instruction since we cannot have 64-bit > immediates. > > Drive-by: Fix naming of existing bt/bts instructions on x64. > > R=titzer@chromium.org > > Bug: v8:6600 > Change-Id: Ib8532ca811160cd61f4ba7c06b04ce093861c872 > Reviewed-on: https://chromium-review.googlesource.com/1174383 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Ben Titzer <titzer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55780} TBR=titzer@chromium.org,clemensh@chromium.org Change-Id: I4377c13346b42b65e8db04cbd15fc2f906113f65 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6600 Reviewed-on: https://chromium-review.googlesource.com/1219446Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55783}
-
Frank Tang authored
Bug: v8:8150 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: If2157d486ac164fcfd0efdc5469357fbad72e0de Reviewed-on: https://chromium-review.googlesource.com/1215271 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55782}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I9734259c9f41378ac216d5a222f0f7c71fcb5fa6 Reviewed-on: https://chromium-review.googlesource.com/1219023Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55781}
-
Clemens Hammacher authored
These are two of the few missing instructions. This CL implements them for ia32 and x64, and bails out on other platforms. On x64, we are using the BTR instruction since we cannot have 64-bit immediates. Drive-by: Fix naming of existing bt/bts instructions on x64. R=titzer@chromium.org Bug: v8:6600 Change-Id: Ib8532ca811160cd61f4ba7c06b04ce093861c872 Reviewed-on: https://chromium-review.googlesource.com/1174383 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55780}
-
Clemens Hammacher authored
The macro has been deprecated since 2016, and it keeps confusing me, so let's just remove it completely from the code base. R=leszeks@chromium.org TBR=mstarzinger@chromium.org, verwaest@chromium.org, jgruber@chromium.org Bug: v8:8015 Change-Id: Ibe1122fd9d2624bc94873d9c51dc8499c54a04fd Reviewed-on: https://chromium-review.googlesource.com/1209322Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55779}
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: I564f340096e64b3d17f9367aea031148a40faf40 Reviewed-on: https://chromium-review.googlesource.com/1218742Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#55778}
-
Michael Starzinger authored
This adds the ability to import exception into a module at instantiation time. Only a {WasmExceptionObject} that has been exported by another module instance can be imported, all other values are rejected. Note that currently there is no signature check being performed to make sure the imported exception matches the expected type. Also the identity of imported exceptions is not yet preserved. Furthermore the engine does not yet match thrown exception objects on a global level across modules. Hence imported exceptions will (wrongly) behave as completely new types within the module. R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions-import,unittests/WasmModuleVerifyTest BUG=v8:8091 Change-Id: If247762b949a1ba4a87d13bc3e790a45dbc67815 Reviewed-on: https://chromium-review.googlesource.com/1216402 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55777}
-
Florian Sattler authored
This patch removes unnecessary copies and adds reserves to vectors that are filled in a loop afterwards. Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I4e13c0445a9760e09ef03a62ae48be622ebecc6b Reviewed-on: https://chromium-review.googlesource.com/1209783Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55776}
-