- 30 Jan, 2015 2 commits
-
-
adamk authored
Also had to split ParseImportsList and ParseExportClause into separate methods as they have different rules about reserved words and arguments/eval. Added lots more test cases, including some export cases that were missed before due to incorrect checking of reserved words. BUG=v8:1569 LOG=n Review URL: https://codereview.chromium.org/887843002 Cr-Commit-Position: refs/heads/master@{#26338}
-
arv authored
For example let and class should only be allowed inside function/block/script. We have to continue to support const in statements in sloppy mode for backwards compatibility. BUG=3831 LOG=Y R=dslomov@chromium.org, adamk Review URL: https://codereview.chromium.org/869293002 Cr-Commit-Position: refs/heads/master@{#26337}
-
- 29 Jan, 2015 8 commits
-
-
arv authored
This removes the duplicate property check from object literals. Instead we repurpose the ObjectLiteralChecker into two cases, implemented by two subclasses to ObjectLiteralCheckerBase called ObjectLiteralChecker and ClassLiteralChecker. The object literal checker now only checks for duplicate __proto__ fields in object literals. The class literal checker checks for duplicate constructors, non constructor fields named constructor as well as static properties named prototype. BUG=v8:3819 LOG=Y R=adamk, dslomov@chromium.org Review URL: https://codereview.chromium.org/873823003 Cr-Commit-Position: refs/heads/master@{#26336}
-
machenbach authored
Revert of Use a WeakCell in the CallIC type vector. (patchset #4 id:80001 of https://codereview.chromium.org/881433002/) Reason for revert: Breaks a regression test on linux isloates, and linux with gcc 4.8. Original issue's description: > Use a WeakCell in the CallIC type vector. > > This allows us to clear the IC on a more sedate schedule, just > like Load and Store ICs. > > R=ulan@chromium.org > BUG= > > Committed: https://crrev.com/bcc79d33ca6d97d9ecfcfcf110a6ea84a0225389 > Cr-Commit-Position: refs/heads/master@{#26332} TBR=ulan@chromium.org,mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/886663004 Cr-Commit-Position: refs/heads/master@{#26334}
-
mvstanton authored
This allows us to clear the IC on a more sedate schedule, just like Load and Store ICs. R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/881433002 Cr-Commit-Position: refs/heads/master@{#26332}
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/884503002 Cr-Commit-Position: refs/heads/master@{#26329}
-
kozyatinskiy authored
In DevTools we need one more flag for script origin - is debugger script. We already have "is shared origin" flag. The new flag added by analogy with the old but new has accessor in script object. R=yurys@chromium.org Review URL: https://codereview.chromium.org/879553002 Cr-Commit-Position: refs/heads/master@{#26324}
-
danno authored
Review URL: https://codereview.chromium.org/882973002 Cr-Commit-Position: refs/heads/master@{#26323}
-
bmeurer authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/883613006 Cr-Commit-Position: refs/heads/master@{#26316}
-
bmeurer authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/885813002 Cr-Commit-Position: refs/heads/master@{#26315}
-
- 28 Jan, 2015 3 commits
-
-
Adam Klein authored
One missing feature: anonymous function & class declarations in "export default". BUG=v8:1569 LOG=n R=arv@chromium.org Review URL: https://codereview.chromium.org/882893002 Cr-Commit-Position: refs/heads/master@{#26313}
-
jarin authored
BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/882063002 Cr-Commit-Position: refs/heads/master@{#26307}
-
jarin authored
This reverts commit 76193749. BUG= Review URL: https://codereview.chromium.org/877643002 Cr-Commit-Position: refs/heads/master@{#26301}
-
- 27 Jan, 2015 6 commits
-
-
adamk authored
The approach taken in this CL is to incrementally move toward the currently-specced version of modules in ES6. The biggest change in this patch is separating the parsing of modules from the parsing of scripts, getting rid of the 'module' keyword and thus disallowing modules-in-scripts as well as modules-in-modules. The syntax supported by import/export declarations has not yet been significantly changed, with the major exception being that import declarations require a string as the 'from' part. Most of the existing tests have been disabled, with a first new test added in cctest/test-parsing. BUG=v8:1569 LOG=n Review URL: https://codereview.chromium.org/881623002 Cr-Commit-Position: refs/heads/master@{#26299}
-
yangguo authored
Review URL: https://codereview.chromium.org/882633002 Cr-Commit-Position: refs/heads/master@{#26296}
-
yangguo authored
R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/875873002 Cr-Commit-Position: refs/heads/master@{#26295}
-
bmeurer authored
Up until now we used a special Terminate node to artifically connect non terminating loops to the End node, but this was kind of adhoc and didn't work for the CFG. So without all kinds of weird hacks, the end block in the CFG will not be connected to NTLs, which makes it impossible to compute post dominance / control dependence in the current setting. So instead of Terminate, we add a special Branch to NTLs, whose condition is the special Always node, which corresponds to True, except that it cannot be folded away. This way we don't need any special machinery in the scheduler, since it's just a regular Branch. R=titzer@chromium.org Review URL: https://codereview.chromium.org/875263004 Cr-Commit-Position: refs/heads/master@{#26294}
-
yangguo authored
Revert of Only use FreeSpace objects in the free list. (patchset #3 id:40001 of https://codereview.chromium.org/876613002/) Reason for revert: Test failures Original issue's description: > Only use FreeSpace objects in the free list. > > This solves an issue with the custom startup snapshot, in cases where > deserializing the isolate requires more than one page per space. > > R=hpayer@chromium.org > > Committed: https://crrev.com/66964395108f03220cb6f45ddc73c5965e2c76a9 > Cr-Commit-Position: refs/heads/master@{#26285} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/882443004 Cr-Commit-Position: refs/heads/master@{#26287}
-
yangguo authored
This solves an issue with the custom startup snapshot, in cases where deserializing the isolate requires more than one page per space. R=hpayer@chromium.org Review URL: https://codereview.chromium.org/876613002 Cr-Commit-Position: refs/heads/master@{#26285}
-
- 26 Jan, 2015 4 commits
-
-
titzer authored
R=mstarzinger@chromium.org BUG=chromium:451958 LOG=Y Review URL: https://codereview.chromium.org/880533002 Cr-Commit-Position: refs/heads/master@{#26276}
-
danno authored
R=mstarzinger@chromium.org LOG=N Review URL: https://codereview.chromium.org/863213003 Cr-Commit-Position: refs/heads/master@{#26267}
-
bmeurer authored
The lowering of intrinsics is therefore now decoupled from the general inlining logic. TEST=cctest,unittests R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/872363002 Cr-Commit-Position: refs/heads/master@{#26263}
-
yangguo authored
Broke after c7b09aac TBR=danno@chromium.org Review URL: https://codereview.chromium.org/875833002 Cr-Commit-Position: refs/heads/master@{#26262}
-
- 23 Jan, 2015 5 commits
-
-
danno authored
Along the way: - Thread isolate parameter explicitly through code that used to rely on getting it from the zone. - Canonicalize the parameter position of isolate and zone for affected code - Change Hydrogen New<> instruction templates to automatically pass isolate R=mstarzinger@chromium.org LOG=N Review URL: https://codereview.chromium.org/868883002 Cr-Commit-Position: refs/heads/master@{#26252}
-
marja authored
BUG= Review URL: https://codereview.chromium.org/871893002 Cr-Commit-Position: refs/heads/master@{#26250}
-
mstarzinger authored
R=ishell@chromium.org TEST=cctest/test-api/SetJitCodeEventHandler Review URL: https://codereview.chromium.org/874493002 Cr-Commit-Position: refs/heads/master@{#26249}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/866413002 Cr-Commit-Position: refs/heads/master@{#26247}
-
erikcorry authored
R=dcarney@chromium.org BUG= Review URL: https://codereview.chromium.org/863443005 Cr-Commit-Position: refs/heads/master@{#26246}
-
- 22 Jan, 2015 7 commits
-
-
mstarzinger authored
R=titzer@chromium.org TEST=cctest/test-run-inlining/InlineLoopGuardedEmpty Review URL: https://codereview.chromium.org/867683002 Cr-Commit-Position: refs/heads/master@{#26228}
-
danno authored
R=bmeurer@chromium.org LOG=n Review URL: https://codereview.chromium.org/867583002 Cr-Commit-Position: refs/heads/master@{#26222}
-
bmeurer authored
- Move unit tests to schedule-unittests.cc. - Remove pre-C++11 cruft. - Fix some include weirdness. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/864293002 Cr-Commit-Position: refs/heads/master@{#26220}
-
yangguo authored
Revert of Change test expectations for test-types/Maybe. (patchset #1 id:1 of https://codereview.chromium.org/862353002/) Reason for revert: Patch causing the failure has been reverted. Original issue's description: > Change test expectations for test-types/Maybe. > > TBR=rossberg@chromium.org > BUG=v8:3840 > LOG=N > > Committed: https://crrev.com/ebab2f12e9a4b421d8467bcf28280f8f64700cef > Cr-Commit-Position: refs/heads/master@{#26212} TBR=rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3840 Review URL: https://codereview.chromium.org/866673002 Cr-Commit-Position: refs/heads/master@{#26216}
-
Yang Guo authored
TBR=rossberg@chromium.org BUG=v8:3840 LOG=N Review URL: https://codereview.chromium.org/862353002 Cr-Commit-Position: refs/heads/master@{#26212}
-
paul.lind authored
Port 9eace97b Port 5d641ec9 BUG= Review URL: https://codereview.chromium.org/867453002 Cr-Commit-Position: refs/heads/master@{#26208}
-
bmeurer authored
Revert of Steps towards unification of number bitset and range types. (patchset #4 id:60001 of https://codereview.chromium.org/837723006/) Reason for revert: Breaks test-types/Maybe, i.e. out/Release/cctest --random-seed=-707413401 test-types/Maybe started failing afterwards Original issue's description: > Steps towards unification of number bitset and range types. > > - New invariant on union types: if the union has a range then the number > bits in the bitset must be cleared. > > - Various tweaks in intersection and union to satisfy the invariant. > > - Exposed and used representation bits in range types (and the Limits > helper class). > > - Implemented Glb for ranges so that the Is predicate handles > ranges correctly. > > - Change typer weakening so that it does not rely on GetRange. > However, the code still seems to be a bit fragile. > > - Removed the Smi types from the type system core, instead introduced > Signed31, Unsigned30 and created constructors for Small(Un)Signed > that point to the right type for the architecture. > > - Punched a hole in the config to be able to get to the isolate so > that it is possible to allocate heap numbers for newly created > ranges. > > Patch by jarin@chromium.prg, original review here: > https://codereview.chromium.org/795713003/ > > TBR=jarin@chromium.org > BUG= > > Committed: https://crrev.com/2764fd8d1a266a9136c987c2483492113b0c8d80 > Cr-Commit-Position: refs/heads/master@{#26197} TBR=jkummerow@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/868583002 Cr-Commit-Position: refs/heads/master@{#26207}
-
- 21 Jan, 2015 5 commits
-
-
mstarzinger authored
R=titzer@chromium.org TEST=cctest/test-api Review URL: https://codereview.chromium.org/860053003 Cr-Commit-Position: refs/heads/master@{#26200}
-
mstarzinger authored
R=bmeurer@chromium.org TEST=cctest,mjsunit/es7/object-observe-debug-event Review URL: https://codereview.chromium.org/790413005 Cr-Commit-Position: refs/heads/master@{#26199}
-
rossberg authored
- New invariant on union types: if the union has a range then the number bits in the bitset must be cleared. - Various tweaks in intersection and union to satisfy the invariant. - Exposed and used representation bits in range types (and the Limits helper class). - Implemented Glb for ranges so that the Is predicate handles ranges correctly. - Change typer weakening so that it does not rely on GetRange. However, the code still seems to be a bit fragile. - Removed the Smi types from the type system core, instead introduced Signed31, Unsigned30 and created constructors for Small(Un)Signed that point to the right type for the architecture. - Punched a hole in the config to be able to get to the isolate so that it is possible to allocate heap numbers for newly created ranges. Patch by jarin@chromium.prg, original review here: https://codereview.chromium.org/795713003/ TBR=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/837723006 Cr-Commit-Position: refs/heads/master@{#26197}
-
bmeurer authored
Use std::numeric_limits<double>::quiet_NaN() and std::numeric_limits<float>::quiet_NaN() instead. Review URL: https://codereview.chromium.org/864803002 Cr-Commit-Position: refs/heads/master@{#26195}
-
mstarzinger authored
R=titzer@chromium.org TEST=cctest/test-js-typed-lowering/JSToNumberOfNumberOrOtherPrimitive Review URL: https://codereview.chromium.org/862963002 Cr-Commit-Position: refs/heads/master@{#26194}
-