1. 02 Jun, 2016 1 commit
  2. 01 Jun, 2016 2 commits
    • machenbach's avatar
      Revert of [crankshaft] Only exclude explicit 'arguments' (and 'this') from... · 8b0a6dd6
      machenbach authored
      Revert of [crankshaft] Only exclude explicit 'arguments' (and 'this') from liveness analysis. (patchset #2 id:20001 of https://codereview.chromium.org/2026173003/ )
      
      Reason for revert:
      Triggers crashes on the deopt fuzzer:
      https://build.chromium.org/p/client.v8/builders/V8%20Deopt%20Fuzzer/builds/10608
      
      Repro:
      out/Release/d8 --test --random-seed=849179141 --deopt-every-n-times 149 --nohard-abort --nodead-code-elimination --nofold-constants --noconcurrent-recompilation test/webkit/resources/standalone-pre.js test/webkit/dfg-arguments-mixed-alias.js test/webkit/resources/standalone-post.js
      
      Original issue's description:
      > [crankshaft] Only exclude explicit 'arguments' (and 'this') from liveness analysis.
      >
      > Currently, we do not emit EnvironmentMarkers if the hydrogen value
      > in the environment is arguments object. As the hydrogen value can change
      > for local variables, we emit only some environment markers. That can
      > cause environment liveness analysis to mark part of live range as live
      > and part as dead. The zapping phase then only inserts zaps in
      > live->dead transitions, potentially zapping a live value.
      >
      > With this CL, we only emit EnvironmentMarkers for 'this' and
      > 'arguments' local variables, disregarding the hydrogen value.
      >
      > BUG=chromium:612146
      > LOG=n
      >
      > Committed: https://crrev.com/1428fbe224dc2df0cb6f59e4959430f7aa614064
      > Cr-Commit-Position: refs/heads/master@{#36641}
      
      TBR=jkummerow@chromium.org,jarin@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=chromium:612146
      
      Review-Url: https://codereview.chromium.org/2029563002
      Cr-Commit-Position: refs/heads/master@{#36644}
      8b0a6dd6
    • jarin's avatar
      [crankshaft] Only exclude explicit 'arguments' (and 'this') from liveness analysis. · 1428fbe2
      jarin authored
      Currently, we do not emit EnvironmentMarkers if the hydrogen value
      in the environment is arguments object. As the hydrogen value can change
      for local variables, we emit only some environment markers. That can
      cause environment liveness analysis to mark part of live range as live
      and part as dead. The zapping phase then only inserts zaps in
      live->dead transitions, potentially zapping a live value.
      
      With this CL, we only emit EnvironmentMarkers for 'this' and
      'arguments' local variables, disregarding the hydrogen value.
      
      BUG=chromium:612146
      LOG=n
      
      Review-Url: https://codereview.chromium.org/2026173003
      Cr-Commit-Position: refs/heads/master@{#36641}
      1428fbe2
  3. 21 Apr, 2016 1 commit
  4. 05 Feb, 2016 1 commit
  5. 15 Jan, 2016 1 commit
  6. 24 Jun, 2014 1 commit
  7. 04 Jun, 2014 1 commit
  8. 03 Apr, 2014 1 commit
  9. 31 Mar, 2014 1 commit
  10. 28 Feb, 2014 3 commits
  11. 25 Feb, 2014 1 commit
  12. 20 Feb, 2014 1 commit
  13. 14 Feb, 2014 1 commit