- 13 Dec, 2018 19 commits
-
-
Sigurd Schneider authored
This is a reland of ed3d6472 This reland fixes that padding at the end of Wasm instruction streams triggered asserts in the code printer. Original change's description: > Reland "[code-comments] Put code comments into the code object" > > This is a reland of e774cffe > > This reland disables a test as v8:8548 is blocking it, which was > broken by a recent CL. CQ did not catch this because the merge-base > CQ used did not yet contain the CL that caused v8:8548. > > Original change's description: > > [code-comments] Put code comments into the code object > > > > Code comments in the snapshot can now be enabled with gn > > arg 'v8_enable_snapshot_code_comments' > > > > Bug: v8:7989 > > Change-Id: I8bd00cafa63132d00d849394c311ba15e6b6daf3 > > Reviewed-on: https://chromium-review.googlesource.com/c/1329173 > > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#58020} > > TBR=mvstanton@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,tebbi@chromium.org > > Bug: v8:7989, v8:8548 > Change-Id: I464fc897205fefdf2dfc2eadc54d699c4e08a0e9 > Reviewed-on: https://chromium-review.googlesource.com/c/1361166 > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58028} Bug: v8:7989, v8:8548 Change-Id: I254f55ff687ad049f8d92b09331ed26a2bd05d7d Reviewed-on: https://chromium-review.googlesource.com/c/1371784 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58221}
-
Clemens Hammacher authored
Different threads check this flag multiple times per function, and currently all of them synchronize on a single mutex. It's not even a reader-writer-lock, hence they might block each other just for checking whether an error has been set. Threads don't rely on precise information here, this is just a check to abort early if compilation failed anyway. Also in the current implementation, no ordering is guaranteed on this error field. We can avoid taking the mutex by turning the field into an atomic pointer. It will be updated at most once, from nullptr to the first error detected. To check whether an error is set, we can even use relaxed memory order, since we won't look into the object behind the pointer. R=titzer@chromium.org Bug: v8:8423 Change-Id: I71354c8d463a57c219eb21e53136556ae787ebd4 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Reviewed-on: https://chromium-review.googlesource.com/c/1375661 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#58220}
-
Tobias Tebbi authored
This enables Turbofan's machine graph constant folding and branch reduction on CSA/Torque code. Bug: v8:7793 Change-Id: I5ada63d0c6d920e5f900b8e9255d884c799a9c1e Reviewed-on: https://chromium-review.googlesource.com/c/1373785 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#58219}
-
Leszek Swirski authored
Change-Id: I71c6e52229cae2aba0a5aec1844c0643484354e5 Reviewed-on: https://chromium-review.googlesource.com/c/1375657Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#58218}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e250719..8ee3e8b Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/6fdf92b..2640923 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/149e7c6..368ebf1 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e760411..7fa4fbc Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/7914672..21261c5 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Icee1968139aefa20bb0416e324b02ac4d594c349 Reviewed-on: https://chromium-review.googlesource.com/c/1375002Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58217}
-
Ross McIlroy authored
BUG=v8:8395 Change-Id: I6e4c7550d71f4fe8b4df36a0a5794f89bf94d70a Reviewed-on: https://chromium-review.googlesource.com/c/1373774Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#58216}
-
Igor Sheludko authored
for accessing compressed on-heap slots with corresponding contents. Bug: v8:7703 Change-Id: Icb314f02f4d5e8d70b997dec02ee9a9568af5d5d Reviewed-on: https://chromium-review.googlesource.com/c/1370040Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#58215}
-
Michael Achenbach authored
This reverts commit 09c49ee0. Reason for revert: Still breaks the node.js bot. Original change's description: > Reland "[build] Pull binutils via DEPS" > > This is a reland of 98bbb636 > > Original change's description: > > [build] Pull binutils via DEPS > > > > This pulls binutils from a subtreed repository of Chromium: > > https://chromium.googlesource.com/chromium/src/third_party/binutils/ > > > > Bug: chromium:718157 > > Change-Id: I532c7e84d83f716728e4f9f715cfdb82ea5d5f98 > > Reviewed-on: https://chromium-review.googlesource.com/c/1370043 > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#58180} > > Bug: chromium:718157, v8:8584 > Change-Id: I1c9773bc5fa0a629e35db5151e535e63839f2801 > Reviewed-on: https://chromium-review.googlesource.com/c/1375655 > Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58213} TBR=machenbach@chromium.org,yangguo@chromium.org,sergiyb@chromium.org Change-Id: I1935f4aef0d6eb4f58e25197d14ccf2c2c645b15 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:718157, v8:8584 Reviewed-on: https://chromium-review.googlesource.com/c/1375659Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58214}
-
Michael Achenbach authored
This is a reland of 98bbb636 Original change's description: > [build] Pull binutils via DEPS > > This pulls binutils from a subtreed repository of Chromium: > https://chromium.googlesource.com/chromium/src/third_party/binutils/ > > Bug: chromium:718157 > Change-Id: I532c7e84d83f716728e4f9f715cfdb82ea5d5f98 > Reviewed-on: https://chromium-review.googlesource.com/c/1370043 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58180} Bug: chromium:718157, v8:8584 Change-Id: I1c9773bc5fa0a629e35db5151e535e63839f2801 Reviewed-on: https://chromium-review.googlesource.com/c/1375655Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58213}
-
Jakob Gruber authored
Post-stub-to-builtin migration, all explicit connection between descriptors and their associated ASM code has been lost. This restores the connection where possible. Builtins without an associated descriptor are marked with the DummyDescriptor. Drive-by: alpha-sort the descriptor list. Drive-by: use Builtins::CallableFor in code factory. Bug: v8:8562, v8:8553 Change-Id: If1f13bbaf7e42453b3235cc97c58ada91b5fa7b8 Reviewed-on: https://chromium-review.googlesource.com/c/1373552Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58212}
-
Sergiy Belozorov authored
The additional variant does not use wrapper disabling phase tests and negated outcome processor. This allows to ensure that tests marked FAIL_PHASE_ONLY, do actually fail without it. R=machenbach@chromium.org Bug: v8:8467 Change-Id: I66e07bd7107520872cc013bf0f33fdc6664baf56 Reviewed-on: https://chromium-review.googlesource.com/c/1361164 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58211}
-
Mythri authored
With V8 lite mode we don't allocate feedback vectors always. This cl adds a new NO_FFEDBACK IC state and uses it use/update feedback only when there is a valid feedback vector. Bug: v8:8394 Change-Id: I9b66ac38c69876e5c1e6eb01ba328a49678c8738 Reviewed-on: https://chromium-review.googlesource.com/c/1365278 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#58210}
-
Alexander Timokhin authored
This is a reland of 2e36e9ea Was reverted because of v8_presubmit.py issue in https://chromium-review.googlesource.com/c/v8/v8/+/1374292 Original change's description: > Don't use |v8_initializers| code in |v8_base| > > Removing |CodeStubAssembler| from |v8_base| source list (see > https://chromium-review.googlesource.com/c/v8/v8/+/1346329) leads to > linkage problems with some build configurations because it was explicitly > and implicitly included in |v8_base| code. > > This CL decouple this code and fixes problems. > > Bug: v8:7777 > Change-Id: I58de5c62914bc77645ed6cc9114409890bc13189 > Reviewed-on: https://chromium-review.googlesource.com/c/1372067 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58200} Bug: v8:7777 Change-Id: Iaa00e73c7dbd8c413fbf15a17709aa12eda9a706 Reviewed-on: https://chromium-review.googlesource.com/c/1375654Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58209}
-
Michael Achenbach authored
This ports: https://crrev.com/c/1374050 TBR=sergiyb@chromium.org Bug: chromium:914712 Change-Id: Ia5eccd9b689ca103d819e65706b4c8ad062a677d Reviewed-on: https://chromium-review.googlesource.com/c/1375653 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58208}
-
Jakob Gruber authored
The disassembler expects the actual instruction area of a code object (i.e. from InstructionStart() to the first embedded metadata section such as the handler table) to contain only valid instructions. This changes asm::DataAlign() to pad with 0xcc bytes, which are int3 instructions on x64 and ia32. Bug: v8:8559 Change-Id: I8a0920a85d4de89194e5c8d3d1a541d8b36fef92 Reviewed-on: https://chromium-review.googlesource.com/c/1375652Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58207}
-
Yang Guo authored
R=machenbach@chromium.org Bug: v8:8584 Change-Id: If7947ef3e06e3808476625690227fe93b7728d7b Reviewed-on: https://chromium-review.googlesource.com/c/1375649Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#58206}
-
Clemens Hammacher authored
Uses of the old API were removed from chromium in https://crrev.com/c/1373749. R=adamk@chromium.org Bug: chromium:912031 Change-Id: I3fed4d72c147ef8e00ec96f869af2134e7ee71c8 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/1373769Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58205}
-
Yutaka Hirano authored
Currently v8::Promise::Then takes only one handler. It should take two handlers, on_fulfilled and on_rejected like ECMAScript Promise. Bug: chromium:912848 Change-Id: I08a20990a27b3f8621225fad42a8de1dad67796f Reviewed-on: https://chromium-review.googlesource.com/c/1375509Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#58204}
-
Frank Tang authored
TBR=jshin@chromium.org Bug: v8:8469 Change-Id: I60f7868a19eec925a597f1355182c2fd8550a2d2 Reviewed-on: https://chromium-review.googlesource.com/c/1374990Reviewed-by: Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#58203}
-
- 12 Dec, 2018 21 commits
-
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/407b393..2823bdd7 https://chromium-review.googlesource.com/c/chromium/src/+/1373009 The following change includes: 2823bdd7 Fix crash of new Intl.DateTimeFormat("ja-u-tz-uslax") Test: v8: intl/regress-8469 Bug: v8:8469 Change-Id: I349402026744cce44269a7ef5a3c6e416a8d9ff6 Reviewed-on: https://chromium-review.googlesource.com/c/1372073 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#58202}
-
Michael Achenbach authored
This reverts commit 2e36e9ea. Reason for revert: Missing explicit include in cc file: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Presubmit/986 Original change's description: > Don't use |v8_initializers| code in |v8_base| > > Removing |CodeStubAssembler| from |v8_base| source list (see > https://chromium-review.googlesource.com/c/v8/v8/+/1346329) leads to > linkage problems with some build configurations because it was explicitly > and implicitly included in |v8_base| code. > > This CL decouple this code and fixes problems. > > Bug: v8:7777 > Change-Id: I58de5c62914bc77645ed6cc9114409890bc13189 > Reviewed-on: https://chromium-review.googlesource.com/c/1372067 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58200} TBR=jkummerow@chromium.org,jgruber@chromium.org,bmeurer@chromium.org,atimoxin@yandex-team.ru Change-Id: I3e41fb5f8a9db6a78c56546a08e55610885d312b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7777 Reviewed-on: https://chromium-review.googlesource.com/c/1374292Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58201}
-
Alexander Timokhin authored
Removing |CodeStubAssembler| from |v8_base| source list (see https://chromium-review.googlesource.com/c/v8/v8/+/1346329) leads to linkage problems with some build configurations because it was explicitly and implicitly included in |v8_base| code. This CL decouple this code and fixes problems. Bug: v8:7777 Change-Id: I58de5c62914bc77645ed6cc9114409890bc13189 Reviewed-on: https://chromium-review.googlesource.com/c/1372067Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58200}
-
Clemens Hammacher authored
This information is already stored in ControlBase::stack_depth. R=titzer@chromium.org Bug: v8:8423 Change-Id: Ie707878b5d7ee5180e44881086d05a590c0dea21 Reviewed-on: https://chromium-review.googlesource.com/c/1373786Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58199}
-
Clemens Hammacher authored
The {last_end_found_} field is redundant. If it's false, there will be a control struct left on the stack. Thus remove that field, and simplify the error detection condition. R=titzer@chromium.org Bug: v8:8423 Change-Id: I16ac4597f229c5e3abd923f8eb504f93afb82eb4 Reviewed-on: https://chromium-review.googlesource.com/c/1373788Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58198}
-
Clemens Hammacher authored
Should be num_locals, and const. R=titzer@chromium.org Bug: v8:8562 Change-Id: I60889c9912ef95d344ede4d7755028116feee47e Reviewed-on: https://chromium-review.googlesource.com/c/1373784Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58197}
-
Ben Smith authored
`memory.init` copies bytes from a passive data segment to linear memory. `memory.drop` is an instruction that informs the wasm VM that the instance no longer needs access to the passive data segment. Information about the passive data segments, including their contents, length, and whether they are dropped, is stored in the `WasmInstanceObject` as primitive arrays. Bug: v8:7747 Change-Id: I1515c8868c9be227743456a539126c15280b5365 Reviewed-on: https://chromium-review.googlesource.com/c/1370691Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#58196}
-
Clemens Hammacher authored
Compilation failures are already stored in the {CompilationState}. We never use the information which individual compilation unit failed. Hence remove that getter, and only check for failure of the overall compilation. R=ahaas@chromium.org Bug: v8:7921, v8:8343 Change-Id: Ibf90be233c9ff576ec8a3413ba5abefe2fdb645e Reviewed-on: https://chromium-review.googlesource.com/c/1373783Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58195}
-
Jakob Gruber authored
There's no reason to restrict off-heap targets to builtin host Code objects during serialization. They can also occur e.g. in irregexp code created by embedded scripts. Drive-by: unify the list of reloc modes that have a target_address_address. Bug: v8:8572,v8:6666 Change-Id: I26dce735463b79677a7b7dcfdb604c5234b5f10b Reviewed-on: https://chromium-review.googlesource.com/c/1371568Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58194}
-
peterwmwong authored
InternalPackedArray now only has one constructor variant that expects no arguments (Chrome's only usage of InternalPackedArray). As such, these TFC builtins are no longer used and were removed: - InternalArrayNoArgumentConstructor_Holey - InternalArraySingleArgumentConstructor_Packed - InternalArraySingleArgumentConstructor_Holey On x64.release, this reduces builtins size by ~1.2KB. Bug: v8:7624 Change-Id: I7316608dc02b1e09e9e414ee1aeb1fb08410c6f6 Reviewed-on: https://chromium-review.googlesource.com/c/1372772 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58193}
-
Tobias Tebbi authored
Bug: v8:8490 Change-Id: Id9b1b1d8a994b6f1fdd6d93355d3f9555710f6ac Reviewed-on: https://chromium-review.googlesource.com/c/1370030Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#58192}
-
Mythri authored
Currently, the runtime IC functions deduce the IC kind and the language mode from the feedback slot kind. To support feedback free execution (for V8 lite mode and lazy allocation of feedback vectors) we need to infer the IC kind even when feedback vectors are not present. To be able to infer the language mode without feedback vectors, this cl forces context allocation in cases where we raise the language mode in the middle of a function. The language mode is the stricter of the language mode on the SFI and the language mode of the current context. This cl updates the bytecode handlers to check for valid feedback vectors and to call into runtime if the feedback vector is not allocated. It also adds new runtime functions to be able to infer the IC kind when there is no feedback vector. Most of the builtins and handlers remain unchanged because they are only used when feedback vector is present. Bug: v8:8394 Change-Id: I1f77740c0d68ddaa0de076597f5f6bcb2e966d70 Reviewed-on: https://chromium-review.googlesource.com/c/1358516 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#58191}
-
Clemens Hammacher authored
Neither the TF backend nor Liftoff use the signature, thus remove it. R=titzer@chromium.org Bug: v8:8423 Change-Id: I909e9a0095cac67aaefaebcb4240f7d9829e4c87 Reviewed-on: https://chromium-review.googlesource.com/c/1373777Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58190}
-
Michael Starzinger authored
This makes sure we properly recognize a newline character as part of semicolon insertion, even if the newline appears after a CPP-style single line comment. The same applies for newlines within C-style multi line comments. R=clemensh@chromium.org TEST=mjsunit/asm/regress-913822 BUG=chromium:913822 Change-Id: I64f098d7e386dea7b7fb6c233c1625425e36bde0 Reviewed-on: https://chromium-review.googlesource.com/c/1373551Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#58189}
-
Max Moroz authored
Bug: chromium:701825, chromium:911856 Change-Id: Ic8d1ea35e0b21b481aab4c87037de6646ddfe450 Reviewed-on: https://chromium-review.googlesource.com/c/1372072 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#58188}
-
Michael Achenbach authored
This reverts commit 98bbb636. Reason for revert: https://crbug.com/v8/8584 Original change's description: > [build] Pull binutils via DEPS > > This pulls binutils from a subtreed repository of Chromium: > https://chromium.googlesource.com/chromium/src/third_party/binutils/ > > Bug: chromium:718157 > Change-Id: I532c7e84d83f716728e4f9f715cfdb82ea5d5f98 > Reviewed-on: https://chromium-review.googlesource.com/c/1370043 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58180} TBR=machenbach@chromium.org,yangguo@chromium.org,sergiyb@chromium.org Change-Id: I43126c54846b14de10a0cd6bdc0b9d6e2e64999c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:718157 Reviewed-on: https://chromium-review.googlesource.com/c/1373780Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58187}
-
Ross McIlroy authored
Bytecode flushing can overwrite a bytecode array with an UncompiledDataWithoutPreParsedScope. Since the bytecode array could be in the LO space, then we also need to allow UncompiledDataWithoutPreParsedScope in the LO space if it has overwritten a large bytecode array. BUG=v8:8395 Change-Id: I1b83b5c7a61830f5576260a4f4f4c0b689818acc Reviewed-on: https://chromium-review.googlesource.com/c/1373775 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#58186}
-
Igor Sheludko authored
and update visitors to not look at raw part. This will allow to have effecient access to embedder data once kTaggedSize is switched to 32-bit value. Bug: v8:8518 Change-Id: Ia1875a5ac5f3fb85df5c5555b970fd88d9e8d7a4 Reviewed-on: https://chromium-review.googlesource.com/c/1369957Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#58185}
-
Andreas Haas authored
To allow any-ref parameters, we have to make sure that any-ref stack parameters get seen by the GC. This CL is a first step into that direction. The goal of this CL is to group any-ref parameters at the stack side of the parameters. This means that in the stack frame iterator we do not need information about where anyref parameters are in the stack frame. We only need information about how many anyref parameters there are at the bottom of the stack frame. R=mstarzinger@chromium.org Also-By: mstarzinger@chromium.org Bug: v8:7581 Change-Id: I3ff7cc38fabed5f8e51b5b990190e35f3ea29803 Reviewed-on: https://chromium-review.googlesource.com/c/1371827 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#58184}
-
Clemens Hammacher authored
Chromium does not use this name any more since https://crrev.com/c/1369854, so we can deprecate it for the 7.3 branch. R=adamk@chromium.org Bug: v8:8238, chromium:912031 Change-Id: I0625f58a893f48d89dec76851af292c9c32af035 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/1370035Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58183}
-
Predrag Rudic authored
Fix cfb5bb72 Change-Id: I2c59cd6716f35ba35dc4417e6b6c2a4588f7acd2 Reviewed-on: https://chromium-review.googlesource.com/c/1370034 Commit-Queue: Predrag Rudic <prudic@wavecomp.com> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58182}
-