- 31 May, 2019 1 commit
-
-
Santiago Aboy Solanes authored
CompressedHeapConstant is used in the DecompressionElimination Reducer to create compressed HeapConstant values. It won't appear in the graph up until that point. This CL enables back the disabled tests in DecompressionElimination, as well as generating the CompressedHeapConstant in that reducer. The RelocInfo has already been added for x64 but not for arm64. Therefore, the x64 version is now doing the mov on 32 bits. The support for ARM will come in a following CL, and for now it is doing the mov in 64 bits. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703, v8:9298 Change-Id: If0ca4f937cfa60501679e66f6fd5ded2df38f605 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632236Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61950}
-
- 28 May, 2019 2 commits
-
-
Santiago Aboy Solanes authored
There were some cases that were not yet contemplated on machine graph verifier. Also, there is some work to be done to create a Compressed HeapConstant. Until that happens, we have to ignore HeapConstants for DecompressionElimination's reductions. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703, v8:9298 Change-Id: I9de8dd4272866830807a8d88e625e863fb5f1d0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632209 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#61892}
-
Santiago Aboy Solanes authored
Reduces compressions of constants, going from Constant <- Compress <- Child to Compressed_Constant <- Child This pattern commonly appeared when the Constant was being used as a Store value (e.g StoreElement's value). Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: I2e71f79ddd2a6fba42cdfe782cc89fff3a8d5ac1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627988 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#61887}
-
- 24 May, 2019 2 commits
-
-
Santiago Aboy Solanes authored
This reduction replaces the Phi's input decompressions with their parent node, if and only if all of the Phi's inputs are Decompress nodes. Also, if we have different Decompress nodes as inputs, we need to use a conservative decompression after the Phi. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: I8cc0264f9d08fe5ad25364f18c9f305afc54529c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624785Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61820}
-
Santiago Aboy Solanes authored
Also adding a pair of valid compress/decompress that was missing. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703, chromium:963759 Change-Id: I668c26e636996e1c7621a23743df33b73e18ae89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624787 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#61816}
-
- 22 May, 2019 2 commits
-
-
Santiago Aboy Solanes authored
Decompressions before TypedStateValues can be safely skipped since TypedStateValues always decompresses values. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: Ic3d43c21183c0decda123cb377706ee5c3c12f87 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617939 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#61738}
-
Santiago Aboy Solanes authored
Adding the case of having a decompress and a constant (both HeapConstant and Int64Constant). Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: Ic9475e9762575e7f6ca2937d832638f7c9897e1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1613253 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#61736}
-
- 20 May, 2019 1 commit
-
-
Santiago Aboy Solanes authored
Added the comparison of two decompresses to the DecompressionElimination AdvancedReducer. Note that it works in the case that lhs is equal to rhs. Also added tests for its implementation. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: I21676a78b592859692768c3499ea11117d3bb5a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1609793 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#61647}
-
- 14 May, 2019 1 commit
-
-
Santiago Aboy Solanes authored
After introducing explicit compress and decompress nodes for each load and store we are left with many nodes that are redundant. This CL aims to eliminate redundant decompressions and compressions in the "direct decompression & compression" category. Also added tests to test the new reducer. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: I93e024d13af34d484086b7983f379265d16ac154 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1602702Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61473}
-