- 21 Sep, 2018 1 commit
-
-
Florian Sattler authored
Fixing clang-tidy warning. Replace 0 with nullptr. Add NOLINT for special cases. Add default/override to methods. Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Iff483356ace471d816051c6dd06ca08809ae1c09 Reviewed-on: https://chromium-review.googlesource.com/1238333Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#56129}
-
- 17 Sep, 2018 1 commit
-
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I7d885f0e2ba3cdf97de190166dc4cdd24dc0c11e Reviewed-on: https://chromium-review.googlesource.com/1224091 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55956}
-
- 23 May, 2018 1 commit
-
-
Jaroslav Sevcik authored
This is based on https://chromium-review.googlesource.com/c/v8/v8/+/940174. It is fine to use the more complex addressing modes here because our poisoning does not poison indexes anymore (it poisons value instead). Bug: chromium:839789 Change-Id: I818a060f835f7dea842cb855d077e871a95b2c01 Reviewed-on: https://chromium-review.googlesource.com/1065773 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53303}
-
- 28 Apr, 2018 1 commit
-
-
Jaroslav Sevcik authored
This is part of the effort to decrease the amount of undefined behavior. that v8 relies on. The main change here is to represent types with class Type rather than with pointer Type*. To make the CL smaller, I used an operator overload hack to separate the change from `->` to `.`. I am working on a CL that will remove the operator and change all those arrows to dots. Bug: v8:3770 Change-Id: I71a197cb739a1467937bc95c2a757fab0469aa22 Reviewed-on: https://chromium-review.googlesource.com/1032551 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#52872}
-
- 05 Mar, 2018 1 commit
-
-
Sigurd Schneider authored
This also introduces FrameStateInfoOf helper. Bug: v8:7517, v8:7310 Change-Id: If2dd1257fb9384fe957a980077a65154cc014d3b Reviewed-on: https://chromium-review.googlesource.com/946009 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#51718}
-
- 13 Feb, 2018 1 commit
-
-
Camillo Bruni authored
FATAL(...) avoid creating literal strings for line number in release mode. Bug: v8:7310 Change-Id: I6a3e329adce36b0efcc240068f6a241d1cca4b6f Reviewed-on: https://chromium-review.googlesource.com/915066Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#51277}
-
- 25 Sep, 2017 1 commit
-
-
Clemens Hammacher authored
Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an embedded comparison. This gives better error messages and also does the right comparison for signed/unsigned mismatches. This will allow us to reenable the readability/check cpplint check. R=jarin@chromium.org Bug: v8:6837 Change-Id: I712580c2a4326e06ee3d6d0eb4ff8c7d24f5fdb9 Reviewed-on: https://chromium-review.googlesource.com/671227 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#48135}
-
- 02 Aug, 2017 1 commit
-
-
Alexandre Talon authored
This CL adds a DCHECK to make the uses() function safer: we store what the next pointer should be to comparing with the next use (from the current element in the linked list). This helps detect code which invalidates the use-list iterator, which would otherwise cause hard-to-debug errors. Bug: Change-Id: I3875361809ffd55fb8be2cbb15af3250e3fd4c12 Reviewed-on: https://chromium-review.googlesource.com/596030Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Alexandre Talon <alexandret@google.com> Cr-Commit-Position: refs/heads/master@{#47074}
-
- 24 Feb, 2017 1 commit
-
-
shiyu.zhang authored
Enable using BaseWithIndexAndDisplacement addressing mode for an address used by multiple load/stores. It can reduce one instruction to calculate the address and one register to store the address. BUG= Review-Url: https://codereview.chromium.org/2620293004 Cr-Commit-Position: refs/heads/master@{#43402}
-
- 10 Jan, 2017 1 commit
-
-
leszeks authored
Node::InputCount() and ::InputAt() have to check for inline/out-of-line inputs every time they are called. The compiler doesn't seem to be very good at caching the result of this check, meaning that it (and all its jumps) would happen for every node access. Previously we would get around this sometimes, by using Node::inputs(), which returned a Node::Inputs iterable over node inputs. However, sometimes node access is more convenient using an index, or we also want to access the count. This patch adds an index accessor and 'count' method to Node::Inputs, and replaces several uses of InputCount and InputAt with this accessor. Review-Url: https://codereview.chromium.org/2617123002 Cr-Commit-Position: refs/heads/master@{#42179}
-
- 03 Jan, 2017 1 commit
-
-
leszeks authored
Changes some for loops to use node->inputs() instead of iterating over InputCount and accessing InputAt(i). This saves some checks for "has_inline_inputs" and so some branches. Review-Url: https://codereview.chromium.org/2585713002 Cr-Commit-Position: refs/heads/master@{#42024}
-
- 20 Dec, 2016 1 commit
-
-
leszeks authored
This simplifies the mark getter enough to generate a branch-free check on many architectures (e.g. using cmov on x64 or csel on ARM). As a drive-by, we can now make the mark access const. Review-Url: https://codereview.chromium.org/2583043004 Cr-Commit-Position: refs/heads/master@{#41833}
-
- 17 Oct, 2016 1 commit
-
-
jochen authored
R=machenbach@chromium.org,titzer@chromium.org,bmeurer@chromium.org,jgruber@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_win_dbg,v8_mac_dbg;master.tryserver.chromium.android:android_arm64_dbg_recipe Review-Url: https://codereview.chromium.org/2416243002 Cr-Commit-Position: refs/heads/master@{#40350}
-
- 20 Sep, 2016 1 commit
-
-
heimbuef authored
This is some initial cleanup to keep /src clean. The AccountingAllocator is actually exclusively used by zones and this common subfolder makes that more clear. BUG=v8:5409 Review-Url: https://codereview.chromium.org/2344143003 Cr-Commit-Position: refs/heads/master@{#39558}
-
- 05 Sep, 2016 1 commit
-
-
mvstanton authored
BUG= Review-Url: https://codereview.chromium.org/2309823002 Cr-Commit-Position: refs/heads/master@{#39181}
-
- 26 Jul, 2016 1 commit
-
-
ishell authored
This is a first step towards a perfect world where a call interface descriptor is the only place that defines calling convention for a particular code stub. Review-Url: https://codereview.chromium.org/2172223002 Cr-Commit-Position: refs/heads/master@{#38059}
-
- 01 Dec, 2015 1 commit
-
-
mtrofin authored
Node has an operator<<, however, constructing an ostream in a debugger session is non-trivial, hence this method. BUG= Review URL: https://codereview.chromium.org/1488953003 Cr-Commit-Position: refs/heads/master@{#32439}
-
- 24 Sep, 2015 1 commit
-
-
mstarzinger authored
This introduces the NodeProperties::ChangeOp helper which guards node operator changes so that additional checking can be done without any additional dependencies being pulled into the Node class. For now only the input count is checked, but additional checking might follow. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1366753003 Cr-Commit-Position: refs/heads/master@{#30916}
-
- 16 Sep, 2015 1 commit
-
-
jarin authored
Review URL: https://codereview.chromium.org/1348073002 Cr-Commit-Position: refs/heads/master@{#30764}
-
- 18 Aug, 2015 1 commit
-
-
jarin authored
BUG= Review URL: https://codereview.chromium.org/1294913003 Cr-Commit-Position: refs/heads/master@{#30212}
-
- 13 Aug, 2015 1 commit
-
-
mstarzinger authored
This tries to remove includes of "-inl.h" headers from normal ".h" headers, thereby reducing the chance of any cyclic dependencies and decreasing the average size of our compilation units. Note that this change still leaves 5 violations of that rule in the code. It only tackles "node.h" including "types-inl.h". R=titzer@chromium.org Review URL: https://codereview.chromium.org/1288053004 Cr-Commit-Position: refs/heads/master@{#30161}
-
- 19 Jun, 2015 1 commit
-
-
bmeurer authored
R=jarin@chromium.org Review URL: https://codereview.chromium.org/1196613003 Cr-Commit-Position: refs/heads/master@{#29149}
-
- 12 Jun, 2015 1 commit
-
-
bmeurer authored
Up until now we used int32_t for NodeId, but that was not ideal because negative values are invalid for NodeId and we use it as an array index for example in the NodeMarker class, where C++ compilers on x64 have to generate code that does proper sign extension for the indices, which is completely unnecessary. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/1178403004 Cr-Commit-Position: refs/heads/master@{#28997}
-
- 22 May, 2015 1 commit
-
-
titzer authored
This reduces the storage per-Node storage from 7 words to 6 and per-edge storage from 6 words to 4. On average this is about 10%-15% space savings over the whole graph. Remove the use of std::deque as the out-of-line storage for inputs. Reduce size of Use links and use pointer arithmetic to find Node from Use. R=mstarzinger@chromium.org,jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/1150923003 Cr-Commit-Position: refs/heads/master@{#28583}
-
- 21 May, 2015 1 commit
-
-
titzer authored
BUG= Review URL: https://codereview.chromium.org/1149563004 Cr-Commit-Position: refs/heads/master@{#28540}
-
- 18 May, 2015 1 commit
-
-
titzer authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1132353004 Cr-Commit-Position: refs/heads/master@{#28452}
-
- 05 May, 2015 1 commit
-
-
bmeurer authored
Tail calls are matched on the graph, with a dedicated tail call optimization that is actually testable. The instruction selection can still fall back to a regular if the platform constraints don't allow to emit a tail call (i.e. the return locations of caller and callee differ or the callee takes non-register parameters, which is a restriction that will be removed in the future). Also explicitly limit tail call optimization to stubs for now and drop the global flag. BUG=v8:4076 LOG=n Review URL: https://codereview.chromium.org/1114163005 Cr-Commit-Position: refs/heads/master@{#28219}
-
- 20 Apr, 2015 1 commit
-
-
Ross McIlroy authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/1088993003 Cr-Commit-Position: refs/heads/master@{#27937}
-
- 24 Mar, 2015 1 commit
-
-
titzer authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1032553006 Cr-Commit-Position: refs/heads/master@{#27401}
-
- 19 Mar, 2015 1 commit
-
-
titzer authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1022783002 Cr-Commit-Position: refs/heads/master@{#27319}
-
- 20 Feb, 2015 1 commit
-
-
bmeurer authored
R=titzer@chromium.org Review URL: https://codereview.chromium.org/940403002 Cr-Commit-Position: refs/heads/master@{#26773}
-
- 20 Jan, 2015 1 commit
-
-
titzer authored
BUG= Review URL: https://codereview.chromium.org/816053002 Cr-Commit-Position: refs/heads/master@{#26149}
-
- 16 Jan, 2015 4 commits
-
-
machenbach authored
Revert of Revert of [turbofan] Improve memory layout of Node class. (patchset #1 id:1 of https://codereview.chromium.org/856813003/) Reason for revert: Revert didn't help. Original issue's description: > Revert of [turbofan] Improve memory layout of Node class. (patchset #1 id:1 of https://codereview.chromium.org/828803004/) > > Reason for revert: > Speculative revert to see if win XP recovers. Will reland if not. > > Original issue's description: > > [turbofan] Improve memory layout of Node class. > > > > Also gets rid of the reinterpret_cast on this. > > > > R=svenpanne@chromium.org > > > > Committed: https://crrev.com/f91e8046fad99365c74ccbb39d42de58398dab57 > > Cr-Commit-Position: refs/heads/master@{#26103} > > TBR=svenpanne@chromium.org,dcarney@chromium.org,bmeurer@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/dc6f34d83650dce8faa3e82e87c050f12732d4b3 > Cr-Commit-Position: refs/heads/master@{#26106} TBR=svenpanne@chromium.org,dcarney@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/855723002 Cr-Commit-Position: refs/heads/master@{#26107}
-
machenbach authored
Revert of [turbofan] Improve memory layout of Node class. (patchset #1 id:1 of https://codereview.chromium.org/828803004/) Reason for revert: Speculative revert to see if win XP recovers. Will reland if not. Original issue's description: > [turbofan] Improve memory layout of Node class. > > Also gets rid of the reinterpret_cast on this. > > R=svenpanne@chromium.org > > Committed: https://crrev.com/f91e8046fad99365c74ccbb39d42de58398dab57 > Cr-Commit-Position: refs/heads/master@{#26103} TBR=svenpanne@chromium.org,dcarney@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/856813003 Cr-Commit-Position: refs/heads/master@{#26106}
-
bmeurer authored
Also gets rid of the reinterpret_cast on this. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/828803004 Cr-Commit-Position: refs/heads/master@{#26103}
-
bmeurer authored
- Make Node::Inputs and Node::Uses mostly STL compliant. - Get rid of some pre-C++11 crappiness. - Start moving unit tests from cctest to unittests. - TrimInputCount() now tries to reserve inputs slots for later appending. - Fix numerous style guide violations. TEST=cctest,unittests R=dcarney@chromium.org Review URL: https://codereview.chromium.org/851263002 Cr-Commit-Position: refs/heads/master@{#26098}
-
- 07 Jan, 2015 1 commit
-
-
bmeurer authored
- Move NodeMarker to its own file, and introduce a non templatized base class. - Cleanup the include hell. - Sanitize the Node construction methods now that we got rid of that GenericNode/GenericGraph stuff. - Protect against NodeId overflow in Graph. - Various minor cleanups. TEST=cctest,mjsunit,unittests Review URL: https://codereview.chromium.org/838783002 Cr-Commit-Position: refs/heads/master@{#25977}
-
- 03 Dec, 2014 1 commit
-
-
bmeurer authored
- Remove use_count_, only used for debug builds and tests. - Use BitField instead of the unreliable C++ bit fields. - Improve memory layout. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/780503002 Cr-Commit-Position: refs/heads/master@{#25632}
-
- 02 Dec, 2014 2 commits
-
-
mstarzinger authored
R=titzer@chromium.org Review URL: https://codereview.chromium.org/760493003 Cr-Commit-Position: refs/heads/master@{#25620}
-
danno authored
- Create a first-class Edge type. - Separate node and edge iterators - Make iterators only responsible for iteration - Make it possible to modify the use edge iterator while iterating. - Add the ability to update inputs to Edges directly. Review URL: https://codereview.chromium.org/765983002 Cr-Commit-Position: refs/heads/master@{#25616}
-