1. 02 Dec, 2017 1 commit
    • Mathias Bynens's avatar
      Normalize casing of hexadecimal digits · 822be9b2
      Mathias Bynens authored
      This patch normalizes the casing of hexadecimal digits in escape
      sequences of the form `\xNN` and integer literals of the form
      `0xNNNN`.
      
      Previously, the V8 code base used an inconsistent mixture of uppercase
      and lowercase.
      
      Google’s C++ style guide uses uppercase in its examples:
      https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters
      
      Moreover, uppercase letters more clearly stand out from the lowercase
      `x` (or `u`) characters at the start, as well as lowercase letters
      elsewhere in strings.
      
      BUG=v8:7109
      TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org
      NOPRESUBMIT=true
      
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6
      Reviewed-on: https://chromium-review.googlesource.com/804294
      Commit-Queue: Mathias Bynens <mathias@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49810}
      822be9b2
  2. 13 Sep, 2017 1 commit
    • Mostyn Bramley-Moore's avatar
      [jumbo] fix arm64 builds · 46000a12
      Mostyn Bramley-Moore authored
      Previously instructions-arm64.h was alternatively defining or declaring
      some constants based on whether or not ARM64_DEFINE_FP_STATICS was defined,
      and it was assumed that exactly one file would include this header with
      the macro defined.
      
      In jumbo builds, the header guards in instructions-arm64.h meant that the
      resulting state of the header file would be whichever of the two cases
      that appeared first in the compilation unit.  This would cause multiple
      definitions in some cases and no definitions in some other cases (or if
      you were really lucky, it would work out ok).
      
      Let's move these constants to a separate source file temporarily, to be
      excluded from jumbo compilation units.  This code should eventually be
      replaced with a cleaner solution.
      
      Bug: chromium:746958
      Change-Id: I7edb1821ef408afd50c6b236d63d3c07f955b58f
      Reviewed-on: https://chromium-review.googlesource.com/663898
      Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#48003}
      46000a12