1. 27 Apr, 2022 1 commit
  2. 10 Mar, 2022 1 commit
  3. 09 Mar, 2022 1 commit
    • Camillo Bruni's avatar
      [runtime] Clean up runtime function Arguments accesses · cead6573
      Camillo Bruni authored
      Replace all CONVERT_XXX_ARG_XXX() macros from runtime-util.h with direct
      calls to Arguments or the fully expanded equivalent.
      
      - This replaces many of the hard CHECKs with DCHECK (as is common
        practice in most V8 code)
      - Instead of relying on verbose comments we now have readable code
      - Rename Arguments.::xxx_at with Arguments::xxx_value_at since these
        methods don't return the Object but rather their double/int value
      
      - Add Oddball::ToBool helper
      - Add and use v8::internal::PropertyAttributesFromInt helper
      - Add stronger DCHECK for PropertyAttributes returned in
        GetPropertyAttributesWithInterceptorInternal
      
      
      
      Bug: v8:11263
      Change-Id: I8d531857e05d19f3198753b05af28d993a391854
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497768Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#79418}
      cead6573
  4. 07 Mar, 2022 1 commit
  5. 17 Nov, 2021 1 commit
    • Leszek Swirski's avatar
      Reland "[runtime] Reset clobbered argument in DefineClass" · 85ab0ad7
      Leszek Swirski authored
      This is a reland of 9b5f3985
      
      Reland fixes:
       * Store a Handle instead of a raw pointer in the scope, to make sure
         the saved object stays alive.
      
      Original change's description:
      > [runtime] Reset clobbered argument in DefineClass
      >
      > The caller of DefineClass may not expect its arguments to be mutated, so
      > add an arguments mutation scope which resets the argument clobbered by
      > DefineClass.
      >
      > Bug: chromium:1268738
      > Change-Id: I03e9cd82535ca1f83353012a92e80f822566e64e
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3283077
      > Auto-Submit: Leszek Swirski <leszeks@chromium.org>
      > Commit-Queue: Igor Sheludko <ishell@chromium.org>
      > Reviewed-by: Igor Sheludko <ishell@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#77921}
      
      Bug: chromium:1268738
      Change-Id: I934ba2063bf2b0e66a3c42f274419ddd178e4b54
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289146
      Auto-Submit: Leszek Swirski <leszeks@chromium.org>
      Commit-Queue: Igor Sheludko <ishell@chromium.org>
      Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#77945}
      85ab0ad7
  6. 16 Nov, 2021 2 commits
  7. 09 Jun, 2021 1 commit
  8. 12 Apr, 2021 1 commit
  9. 14 Oct, 2020 1 commit
  10. 20 Mar, 2020 1 commit
  11. 04 Mar, 2020 1 commit
  12. 26 Feb, 2020 1 commit
  13. 17 Sep, 2019 1 commit
  14. 23 May, 2019 4 commits
  15. 22 May, 2019 1 commit
  16. 21 May, 2019 1 commit
  17. 07 Mar, 2019 1 commit
  18. 18 Jan, 2019 1 commit
  19. 08 Jan, 2019 1 commit
  20. 26 Dec, 2018 1 commit
  21. 18 Dec, 2018 1 commit
  22. 07 Dec, 2018 1 commit
  23. 23 Nov, 2018 1 commit
  24. 07 Nov, 2018 1 commit
  25. 24 Oct, 2018 1 commit
  26. 12 Oct, 2018 1 commit
  27. 11 Sep, 2018 1 commit
  28. 03 Aug, 2018 1 commit
  29. 22 Jun, 2018 1 commit
  30. 30 Nov, 2017 1 commit
  31. 09 Oct, 2017 1 commit
  32. 10 Jul, 2017 1 commit
  33. 13 Feb, 2017 1 commit
  34. 16 Dec, 2016 1 commit
  35. 04 Nov, 2016 1 commit
  36. 03 Nov, 2016 1 commit
    • lpy's avatar
      Revert of [Tracing] Use TracingCategoryObserver in runtime statistics... · 5df5a28f
      lpy authored
      Revert of [Tracing] Use TracingCategoryObserver in runtime statistics (patchset #6 id:140001 of https://codereview.chromium.org/2460973003/ )
      
      Reason for revert:
      Static-Initializers failed on Ubuntu-12.04
      
      Original issue's description:
      > [Tracing] Use TracingCategoryObserver in runtime statistics
      >
      > This patch is a follow-up patch to enable runtime statistics to use
      > TracingCategoryObserver.
      >
      > BUG=v8:5590
      
      TBR=cbruni@chromium.org,fmeawad@chromium.org,alph@chromium.org,bmeurer@chromium.org,mlippautz@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:5590
      
      Review-Url: https://codereview.chromium.org/2469403005
      Cr-Commit-Position: refs/heads/master@{#40743}
      5df5a28f