Skip to content

V
V8
Switch branch/tag
  1. 16 Apr, 2019 1 commit
    • Ben Smith's avatar
      [wasm][bulk-memory] Check segment bounds lazily · 34c8443c
      Ben Smith authored 
      The bulk memory proposal changed behavior of segment initialization
during instantiation. Previously, all segments would be bounds-checked,
after which the segments would be initialized.

The bulk memory proposal removes the up-front check, and always
initializes active segments in order, starting with element segments and
then continuing with data segments. Each active segment is initialized
as-if they were being initialized with the `memory.init` and
`table.init` instructions, so an out-of-bounds initialization may still
modify the memory or table partially.

Bug: v8:8892
Change-Id: I472fca2401e07d60b288f0cc745629a451b31088
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565033
Commit-Queue: Ben Smith <binji@chromium.org>
Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60885}
      34c8443c
  3. 26 Feb, 2019 1 commit
  5. 04 Feb, 2019 1 commit
  7. 10 Jan, 2019 1 commit
  9. 03 Jul, 2018 1 commit
  11. 13 Jun, 2018 1 commit
  13. 12 Jun, 2018 2 commits
  15. 20 Oct, 2017 1 commit
  17. 17 Oct, 2017 1 commit
  19. 26 Sep, 2017 1 commit
  21. 17 Jul, 2017 1 commit
    • Andreas Haas's avatar
      [wasm][ia32] Add an additional stack check for functions with big frames · 2064c1f9
      Andreas Haas authored 
      This is the ia32 implementation of the CL
https://codereview.chromium.org/2763593002

Original message:

[wasm][arm] Add an additional stack check for functions with big frames.

Stack overflow checks are typically implemented as part of the TurboFan
graph of a function. This means that the stack check code is executed
after frame construction. When a frame is too big, though, there may not
be enough space on the stack anymore to throw the stack overflow
exception after frame construction. With this CL we do an additional
stack check before frame construction for functions with big frames.

As discussed offline with mstarzinger, I do this change currently only
for WebAssembly.

This CL contains only the changes for arm. I will do the other platforms
in separate CLs.

Bug:v8:6318

R=neis@chromium.org, titzer@chromium.org

Change-Id: Ibeedc5c4c4571cffd3a9c58016ddc44b64e2bf02
Reviewed-on: https://chromium-review.googlesource.com/568305
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46711}
      2064c1f9
  23. 13 Jul, 2017 1 commit
    • Andreas Haas's avatar
      [wasm][x64] Add an additional stack check for functions with big frames · a03f4451
      Andreas Haas authored 
      This is the x64 implementation of the CL
https://codereview.chromium.org/2763593002

Original message:

[wasm][arm] Add an additional stack check for functions with big frames.

Stack overflow checks are typically implemented as part of the TurboFan
graph of a function. This means that the stack check code is executed
after frame construction. When a frame is too big, though, there may not
be enough space on the stack anymore to throw the stack overflow
exception after frame construction. With this CL we do an additional
stack check before frame construction for functions with big frames.

As discussed offline with mstarzinger, I do this change currently only
for WebAssembly.

This CL contains only the changes for arm. I will do the other platforms
in separate CLs.

R=titzer@chromium.org

Bug: v8:6318
Change-Id: Id4a8ea3ee76c37132e86a7c4e5d05d3bd86df44a
Reviewed-on: https://chromium-review.googlesource.com/565562
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46640}
      a03f4451
  25. 12 Jun, 2017 1 commit
  27. 06 Jun, 2017 1 commit
  29. 22 May, 2017 1 commit
  31. 28 Apr, 2017 1 commit
  33. 27 Apr, 2017 2 commits