- 01 Apr, 2016 1 commit
-
-
jochen authored
We expect that the majority of malloc'd memory held by V8 is allocated in Zone objects. Introduce an Allocator class that is used by Zones to manage memory, and allows for querying the current usage. BUG=none R=titzer@chromium.org,bmeurer@chromium.org,jarin@chromium.org LOG=n TBR=rossberg@chromium.org Review URL: https://codereview.chromium.org/1847543002 Cr-Commit-Position: refs/heads/master@{#35196}
-
- 01 Mar, 2016 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org BUG=v8:3956 LOG=n Review URL: https://codereview.chromium.org/1731063007 Cr-Commit-Position: refs/heads/master@{#34398}
-
- 18 Feb, 2016 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1704353002 Cr-Commit-Position: refs/heads/master@{#34118}
-
- 16 Feb, 2016 2 commits
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1696333002 Cr-Commit-Position: refs/heads/master@{#34035}
-
jarin authored
Review URL: https://codereview.chromium.org/1700923002 Cr-Commit-Position: refs/heads/master@{#34026}
-
- 10 Feb, 2016 1 commit
-
-
yangguo authored
R=jochen@chromium.org, verwaest@chromium.org BUG=chromium:585724 LOG=N Review URL: https://codereview.chromium.org/1681513002 Cr-Commit-Position: refs/heads/master@{#33864}
-
- 26 Jan, 2016 1 commit
-
-
jarin authored
This replace HeapType with a dedicated class that implements just what we need for field type tracking. In the next CL, I plan to remove FieldType::Iterator because FieldType can iterate over at most one map. The ultimate plan is to get rid of templates in types.(h|cc) and remove type-inl.h. TBR=rossberg@chromium.org Review URL: https://codereview.chromium.org/1636013002 Cr-Commit-Position: refs/heads/master@{#33521}
-
- 16 Dec, 2015 1 commit
-
-
yangguo authored
R=jarin@chromium.org Review URL: https://codereview.chromium.org/1529823002 Cr-Commit-Position: refs/heads/master@{#32884}
-
- 26 Nov, 2015 1 commit
-
-
rossberg authored
Moves all files related to AST and scopes into ast/, and all files related to scanner & parser to parsing/. Also eliminates a couple of spurious dependencies. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1481613002 Cr-Commit-Position: refs/heads/master@{#32351}
-
- 30 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
- 27 Aug, 2015 1 commit
-
-
kozyatinskiy authored
If JSON contains SyntaxError then V8 will report exception and won't report compile error. LOG=Y BUG=chromium:515382 R=yangguo@chromium.org,yurys@chromium.org Review URL: https://codereview.chromium.org/1308123006 Cr-Commit-Position: refs/heads/master@{#30426}
-
- 24 Aug, 2015 1 commit
-
-
mstarzinger authored
R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1310253002 Cr-Commit-Position: refs/heads/master@{#30333}
-
- 18 Aug, 2015 1 commit
-
-
mstarzinger authored
R=titzer@chromium.org Review URL: https://codereview.chromium.org/1293053004 Cr-Commit-Position: refs/heads/master@{#30232}
-
- 12 Aug, 2015 1 commit
-
-
mstarzinger authored
This tries to remove includes of "-inl.h" headers from normal ".h" headers, thereby reducing the chance of any cyclic dependencies and decreasing the average size of our compilation units. Note that this change still leaves 7 violations of that rule in the code. However there now is the "tools/check-inline-includes.sh" tool detecting such violations. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1283033003 Cr-Commit-Position: refs/heads/master@{#30125}
-
- 11 Aug, 2015 1 commit
-
-
mstarzinger authored
This is the first step of turning the v8.h file into a normal header instead of an include-the-world header. The new rule is that no other header files are allowed to include v8.h, which is enforced by DEPS. Also the number of includes inside the v8.h file has been drastically reduced. Basically the last missing piece is the inclusion of the big objects-inl.h file. This in turn makes many headers follow the IWYU principle. R=bmeurer@chromium.org,hpayer@chromium.org,titzer@chromium.org Review URL: https://codereview.chromium.org/1282503003 Cr-Commit-Position: refs/heads/master@{#30102}
-
- 10 Aug, 2015 1 commit
-
-
mstarzinger authored
This is a first step towards constraining down the heap interface to just the heap.h file. Note that many includes still leak through that file to the global "src" directory, but there now is a single place controlling which declarations leak that way. Especially inclusion of inline header files within "heap" has been limited drastically. R=hpayer@chromium.org,mlippautz@chromium.org Review URL: https://codereview.chromium.org/1281233003 Cr-Commit-Position: refs/heads/master@{#30092}
-
- 12 Jun, 2015 2 commits
-
-
verwaest authored
Otherwise using Object.defineProperty with window.localStorage will not actually store the value into the database but on the object itself. BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1180073002 Cr-Commit-Position: refs/heads/master@{#29002}
-
verwaest authored
Reland of Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. (patchset #3 id:40001 of https://codereview.chromium.org/1178503004/) BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1180943002 Cr-Commit-Position: refs/heads/master@{#29000}
-
- 11 Jun, 2015 3 commits
-
-
ishell authored
Revert of Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. (patchset #3 id:40001 of https://codereview.chromium.org/1178503004/) Reason for revert: Blocks revert of https://codereview.chromium.org/1175973002 Original issue's description: > Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. > > @yangguo: please look at the debugger part of the CL. > @ishell: please look at the rest. > > Additionally: > - Ensure the LookupIterator for named properties does not accidentally get indexes in. > - Fix the return value for typed array assignments to be the incoming value. > > BUG=v8:4137 > LOG=n > > Committed: https://crrev.com/15aa811f8fe2708a757c3b53ca89db736aa8b222 > Cr-Commit-Position: refs/heads/master@{#28954} TBR=yangguo@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4137 Review URL: https://codereview.chromium.org/1181733002 Cr-Commit-Position: refs/heads/master@{#28957}
-
verwaest authored
@yangguo: please look at the debugger part of the CL. @ishell: please look at the rest. Additionally: - Ensure the LookupIterator for named properties does not accidentally get indexes in. - Fix the return value for typed array assignments to be the incoming value. BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1178503004 Cr-Commit-Position: refs/heads/master@{#28954}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1172683003 Cr-Commit-Position: refs/heads/master@{#28946}
-
- 08 Jun, 2015 1 commit
-
-
conradw authored
Boolean "is_strong" parameters have begun to proliferate across areas where strong mode semantics are different. This CL repurposes the existing ObjectStrength enum as a replacement for them. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1144183004 Cr-Commit-Position: refs/heads/master@{#28839}
-
- 02 Jun, 2015 2 commits
-
-
conradw authored
Copied, with permission, from https://codereview.chromium.org/1151853003/ Initial patch set is an unmodified copy, rebased on top of related fixes from https://codereview.chromium.org/1158933002/ Subsequent patch sets contain fixes for remaining bugs in the CL. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1152093003 Cr-Commit-Position: refs/heads/master@{#28760}
-
verwaest authored
This also fixes issues with - kMaxUint32 being a valid length but not index cornercases - exotic integer objects masking "exotic indexes" even though its in the prototype chain - concating of holey sloppy arguments BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1159433003 Cr-Commit-Position: refs/heads/master@{#28754}
-
- 15 May, 2015 1 commit
-
-
yangguo authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1140053002 Cr-Commit-Position: refs/heads/master@{#28423}
-
- 05 May, 2015 1 commit
-
-
ulan authored
BUG=v8:3925 LOG=NO Review URL: https://codereview.chromium.org/1123013002 Cr-Commit-Position: refs/heads/master@{#28225}
-
- 01 Apr, 2015 2 commits
-
-
erikcorry authored
R=mstarzinger@chromium.org BUG=v8:3976 BUG=472504 LOG=y Review URL: https://codereview.chromium.org/1051833002 Cr-Commit-Position: refs/heads/master@{#27571}
-
erikcorry authored
Revert of Fix JSON parser Handle leak (patchset #3 id:40001 of https://codereview.chromium.org/1041483004/) Reason for revert: Reverting due to JSOn parser failures Original issue's description: > Fix JSON parser Handle leak > > R=verwaest@chromium.org > BUG=v8:3976 > LOG=y > > Committed: https://crrev.com/1ec850383bb82f6d8bebc7416e5f50b649d1eeaa > Cr-Commit-Position: refs/heads/master@{#27512} TBR=verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3976 Review URL: https://codereview.chromium.org/1052593002 Cr-Commit-Position: refs/heads/master@{#27562}
-
- 30 Mar, 2015 1 commit
-
-
erikcorry authored
R=verwaest@chromium.org BUG=v8:3976 LOG=y Review URL: https://codereview.chromium.org/1041483004 Cr-Commit-Position: refs/heads/master@{#27512}
-
- 23 Mar, 2015 1 commit
-
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/1025333002 Cr-Commit-Position: refs/heads/master@{#27375}
-
- 20 Mar, 2015 1 commit
-
-
ulan authored
BUG=v8:3974 LOG=NO Review URL: https://codereview.chromium.org/1021523002 Cr-Commit-Position: refs/heads/master@{#27334}
-
- 06 Mar, 2015 2 commits
-
-
jkummerow authored
Original issue: https://codereview.chromium.org/980573002/ Simple transitions are now stored in a map's "transitions" field (as a WeakCell wrapping the target map); full TransitionArrays are used when that's not sufficient. To encapsulate these storage format implementation details, functions for manipulating and querying transitions have been refactored to be static functions on the TransitionArray class, and take maps as inputs. Review URL: https://codereview.chromium.org/988703002 Cr-Commit-Position: refs/heads/master@{#27044}
-
verwaest authored
Don't double-allocate mutable heap numbers in the json parser. This removes some stupidity when committing state. BUG= Review URL: https://codereview.chromium.org/982793002 Cr-Commit-Position: refs/heads/master@{#27034}
-
- 05 Mar, 2015 3 commits
-
-
jkummerow authored
Revert of Simplify and compact transitions storage (patchset #4 id:80001 of https://codereview.chromium.org/980573002/) Reason for revert: x64 test failures Original issue's description: > Simplify and compact transitions storage > > Simple transitions are now stored in a map's "transitions" field (as a WeakCell wrapping the target map); full TransitionArrays are used when that's not sufficient. > To encapsulate these storage format implementation details, functions for manipulating and querying transitions have been refactored to be static functions on the TransitionArray class, and take maps as inputs. > > Committed: https://crrev.com/45fbef7f2252fce10634931cb103ccc1fc95ae6a > Cr-Commit-Position: refs/heads/master@{#27029} TBR=verwaest@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/982143002 Cr-Commit-Position: refs/heads/master@{#27030}
-
jkummerow authored
Simple transitions are now stored in a map's "transitions" field (as a WeakCell wrapping the target map); full TransitionArrays are used when that's not sufficient. To encapsulate these storage format implementation details, functions for manipulating and querying transitions have been refactored to be static functions on the TransitionArray class, and take maps as inputs. Review URL: https://codereview.chromium.org/980573002 Cr-Commit-Position: refs/heads/master@{#27029}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/974353002 Cr-Commit-Position: refs/heads/master@{#27019}
-
- 24 Feb, 2015 1 commit
-
-
yangguo authored
We no longer expect NewError to return an empty handle to signal termination exception, since TryCall simply requests a new terminate exception interrupt. BUG=chromium:403509 LOG=N Review URL: https://codereview.chromium.org/952483002 Cr-Commit-Position: refs/heads/master@{#26811}
-
- 23 Feb, 2015 1 commit
-
-
verwaest authored
The optimization is invalid as indicated by the test. BUG= TBR=yangguo@chromium.org Review URL: https://codereview.chromium.org/950873003 Cr-Commit-Position: refs/heads/master@{#26799}
-
- 18 Feb, 2015 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/936613006 Cr-Commit-Position: refs/heads/master@{#26725}
-
- 23 Jan, 2015 1 commit
-
-
danno authored
Along the way: - Thread isolate parameter explicitly through code that used to rely on getting it from the zone. - Canonicalize the parameter position of isolate and zone for affected code - Change Hydrogen New<> instruction templates to automatically pass isolate R=mstarzinger@chromium.org LOG=N Review URL: https://codereview.chromium.org/868883002 Cr-Commit-Position: refs/heads/master@{#26252}
-