Commits · 95f0c064cabbd7e9d5585bd319ad4c47d54995d9 · Linshizhi / V8

24 Apr, 2014 34 commits

Fix for build issue on Mac introduced in r20948. · 95f0c064

ishell@chromium.org authored Apr 24, 2014

TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/251363004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20951 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

95f0c064

Dictionary::GenerateNewEnumerationIndices() and Dictionary::EnsureCapacity() handlified. · f8623283

ishell@chromium.org authored Apr 24, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/250013002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20950 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f8623283

Mark the simulate before EnterInlined with BailoutId::None(), and set ReturnId... · a55821ee

verwaest@chromium.org authored Apr 24, 2014

Mark the simulate before EnterInlined with BailoutId::None(), and set ReturnId on EnterInlined. When merging simulates into the simulate before enter-inlined, adopt the last AST id that gets merged into it.

BUG=v8:3282
LOG=n
R=titzer@chromium.org

Review URL: https://codereview.chromium.org/257583004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20949 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a55821ee

Dictionary::Add() handlified. · 2e0c2965

ishell@chromium.org authored Apr 24, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/249723004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20948 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2e0c2965

NameDictionary's key type is now Handle<Name> instead of Name*. · cb46971a

ishell@chromium.org authored Apr 24, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/252383006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20947 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cb46971a

ARM64: Slightly improve MacroAssembler::Allocate. · 1bdc421a

Jacob.Bramley@arm.com authored Apr 24, 2014

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/247533005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20946 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1bdc421a

MIPS: CodeStubs contain their corresponding Isolate* now. (part 2) · 01ef9aef

plind44@gmail.com authored Apr 24, 2014

Port r20940 (a5dde97)

Original commit message:
This CL mechanically removes all useless Isolate* parameters from code
stub functions, making things quite a bit simpler.

BUG=359977
LOG=y
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/251473004

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20945 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

01ef9aef

MIPS: CodeStubs contain their corresponding Isolate* now. (part 1) · bb1abb7f

plind44@gmail.com authored Apr 24, 2014

Port r20919 (aa51355)

Original commit message:
This is a purely mechanical change, adding an Isolate* to the CodeStub
constructor and a corresponding field plus a getter. A few methods in
CodeStub and its subclasses can be simplified now, but this is done in
a separate CL.

The underlying reason apart from simplicity is that deep down in the
call chain we need to detect if the serializer is active or not. This
information will be part of the Isolate, not a global variable with
funky synchronization primitives around it (which is fundamentally
wrong and the underlying cause for race conditions and a catch-22
during initialization).

BUG=359977
LOG=y
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/252383005

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20944 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bb1abb7f

Refactor function.arguments accessor. · 50945297

ulan@chromium.org authored Apr 24, 2014

This prepares for API-style accessor conversion.

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/253453002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20943 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

50945297

Update .gitignore wrt promise test files. · ea0de1e9

yangguo@chromium.org authored Apr 24, 2014

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/259593002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20942 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ea0de1e9

Implement --omit, --raw_[context_]file=... for mksnapshot tool. · 331cc8a2

vogelheim@chromium.org authored Apr 24, 2014

These switches are analogous to --omit and --raw for js2c.py.
The goal it to allow embedders to externally load all (or generate) the V8 startup data.

There's a bit of gratuitous refactoring with the writing logic that helped me understand the code. Let me know if it's not an improvement.

BUG=355539
LOG=N
R=jochen@chromium.org, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/249283002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20941 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

331cc8a2

CodeStubs contain their corresponding Isolate* now. (part 2) · b8d27f9d

svenpanne@chromium.org authored Apr 24, 2014

This CL mechanically removes all useless Isolate* parameters from code
stub functions, making things quite a bit simpler.

BUG=359977
LOG=y
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/255543003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20940 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b8d27f9d

Revert "Some code cleanup, esp. includes and copyright headers." · d699684b

bmeurer@chromium.org authored Apr 24, 2014

This reverts commit r20938 for breaking the windows build.

TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/254463003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20939 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d699684b

Some code cleanup, esp. includes and copyright headers. · 18b07afb

bmeurer@chromium.org authored Apr 24, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/257453003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20938 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

18b07afb

Convert function.length to API-style accessor. · 72358c7f

ulan@chromium.org authored Apr 24, 2014

TEST=mjsunit/function-length-accessor
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/257423009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20937 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

72358c7f

Harden more runtime functions. · 3654b3b2

jkummerow@chromium.org authored Apr 24, 2014

R=dslomov@chromium.org, dslomov@google.com

Review URL: https://codereview.chromium.org/258473004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20936 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3654b3b2

Dictionary::AtPut() handlified. · 34e59aa2

ishell@chromium.org authored Apr 24, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/249883003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20935 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

34e59aa2

Reland r20932: "*NumberDictionary::AtNumberPut() handlified." · c0ff5354

ishell@chromium.org authored Apr 24, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/254593002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20934 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c0ff5354

Revert "*NumberDictionary::AtNumberPut() handlified." · 7e8f5318

ishell@chromium.org authored Apr 24, 2014

This reverts commit r20932 for breaking Mac build.

TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/251383003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20933 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7e8f5318

*NumberDictionary::AtNumberPut() handlified. · b95ffe90

ishell@chromium.org authored Apr 24, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/250003002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20932 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b95ffe90

*NumberDictionary::AddNumberEntry() handlified. · 7e3fafc6

ishell@chromium.org authored Apr 24, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/249993002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20931 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7e3fafc6

Mark test-cpu-profiler/SampleWhenFrameIsNotSetup as flaky. · 484442d1

ulan@chromium.org authored Apr 24, 2014

BUG=v8:3287
LOG=N
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/252493002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20930 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

484442d1

Don't move the object start of objects on non-swept pages. · 738f85c7

hpayer@chromium.org authored Apr 24, 2014

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/255603002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20929 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

738f85c7

ARM64: small fixes for ArgumentAdaptorTrampoline after r20751. · 374799db

ulan@chromium.org authored Apr 24, 2014

BUG=
R=jacob.bramley@arm.com

Review URL: https://codereview.chromium.org/252483002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20928 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

374799db

*NumberDictionary::Set() handlified. · 7c1a0e81

ishell@chromium.org authored Apr 24, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/249973002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20927 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7c1a0e81

Convert function.prototype to API-style accessor. · ec613e22

ulan@chromium.org authored Apr 24, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/246693005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20926 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ec613e22

Tiny cleanup. · e493dc9c

ishell@chromium.org authored Apr 24, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/247953003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20925 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e493dc9c

Re-enable field type tracking by default. · 0b78957d

bmeurer@chromium.org authored Apr 24, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/258443003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20924 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0b78957d

Revert "Add tests for generator/debugger interaction" · f95b815d

bmeurer@chromium.org authored Apr 24, 2014

This reverts commit r20921 for breaking the ARM/ARM64 bots.

TBR=wingo@igalia.com

Review URL: https://codereview.chromium.org/255563003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20923 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f95b815d

Make DescriptorArray::IsMoreGeneralThan() and DescriptorArray::Merge() compatible again. · 052f9e9b

bmeurer@chromium.org authored Apr 24, 2014

BUG=365172
LOG=y
TEST=mjsunit/regress/regress-365172-[1-3]
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/255513005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20922 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

052f9e9b

Add tests for generator/debugger interaction · 9d5d1764

wingo@igalia.com authored Apr 24, 2014

R=yangguo@chromium.org
BUG=

Review URL: https://codereview.chromium.org/247003004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20921 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9d5d1764

Treat FOREIGN_TYPE as internal. · 81578179

bmeurer@chromium.org authored Apr 24, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/257523002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20920 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

81578179

CodeStubs contain their corresponding Isolate* now. (part 1) · dd30db90

svenpanne@chromium.org authored Apr 24, 2014

This is a purely mechanical change, adding an Isolate* to the CodeStub
constructor and a corresponding field plus a getter. A few methods in
CodeStub and its subclasses can be simplified now, but this is done in
a separate CL.

The underlying reason apart from simplicity is that deep down in the
call chain we need to detect if the serializer is active or not. This
information will be part of the Isolate, not a global variable with
funky synchronization primitives around it (which is fundamentally
wrong and the underlying cause for race conditions and a catch-22
during initialization).

BUG=359977
LOG=y
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/246643014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20919 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dd30db90

Fix C++ type of Factory::NewFixedDoubleArray. · 8c57b450

jarin@chromium.org authored Apr 24, 2014

The change fixes the C++ type of Factory::NewFixedDoubleArray to
reflect the empty array case, where we return an empty
FixedArray (rather than FixedDoubleArray).

R=mvstanton@chromium.org
BUG=

Review URL: https://codereview.chromium.org/249593002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20918 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8c57b450

23 Apr, 2014 6 commits

StringTable::LookupKey() and all callers handlified. · 45917718

ishell@chromium.org authored Apr 23, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/249103002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20915 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

45917718

Clean up some uses of Failures and MaybeObjects. · 6d250412

yangguo@chromium.org authored Apr 23, 2014

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/245963007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20914 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6d250412

Move bug 3280 regression test to mjsunit/harmony · 2194f3f8

wingo@igalia.com authored Apr 23, 2014

R=yangguo@chromium.org
BUG=

Review URL: https://codereview.chromium.org/248483004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20913 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2194f3f8

Fix the Array.push simulate for non-effect context. · cd3b9b89

jarin@chromium.org authored Apr 23, 2014

R=danno@google.com, danno@chromium.org
BUG=

Review URL: https://codereview.chromium.org/246543007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20912 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cd3b9b89

Fix deoptimization problem with inlined Array.push() · 2aa8941a

danno@chromium.org authored Apr 23, 2014

R=jarin@chromium.org
LOG=N

Review URL: https://codereview.chromium.org/247573008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20911 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2aa8941a

Allow Object.defineProperty to update value of an API accessor. · 6cae9d1c

ulan@chromium.org authored Apr 23, 2014

This is needed for converting internal accessors to API accessors and can break blink tests.

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/240573004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20910 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6cae9d1c