1. 17 Dec, 2018 1 commit
  2. 26 Nov, 2018 1 commit
  3. 23 Jul, 2018 1 commit
  4. 23 Jun, 2018 1 commit
  5. 09 Apr, 2018 1 commit
  6. 06 Apr, 2018 2 commits
    • Michael Achenbach's avatar
      Revert "[cleanup] Refactor the Factory" · 503e07c3
      Michael Achenbach authored
      This reverts commit f9a2e24b.
      
      Reason for revert: gc stress failures not all fixed by follow up.
      
      Original change's description:
      > [cleanup] Refactor the Factory
      > 
      > There is no good reason to have the meat of most objects' initialization
      > logic in heap.cc, all wrapped by the CALL_HEAP_FUNCTION macro. Instead,
      > this CL changes the protocol between Heap and Factory to be AllocateRaw,
      > and all object initialization work after (possibly retried) successful
      > raw allocation happens in the Factory.
      > 
      > This saves about 20KB of binary size on x64.
      > 
      > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      > Change-Id: Icbfdc4266d7be8b48d2fe085f03411743dc6a0ca
      > Reviewed-on: https://chromium-review.googlesource.com/959533
      > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      > Reviewed-by: Hannes Payer <hpayer@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#52416}
      
      TBR=jkummerow@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,hpayer@chromium.org
      
      Change-Id: Idbbc53478742f3e9525eee83342afc6aedae122f
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/999414Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52420}
      503e07c3
    • Jakob Kummerow's avatar
      [cleanup] Refactor the Factory · f9a2e24b
      Jakob Kummerow authored
      There is no good reason to have the meat of most objects' initialization
      logic in heap.cc, all wrapped by the CALL_HEAP_FUNCTION macro. Instead,
      this CL changes the protocol between Heap and Factory to be AllocateRaw,
      and all object initialization work after (possibly retried) successful
      raw allocation happens in the Factory.
      
      This saves about 20KB of binary size on x64.
      
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Change-Id: Icbfdc4266d7be8b48d2fe085f03411743dc6a0ca
      Reviewed-on: https://chromium-review.googlesource.com/959533
      Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarHannes Payer <hpayer@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52416}
      f9a2e24b
  7. 17 Nov, 2017 1 commit
    • Jakob Kummerow's avatar
      [bigint] Encapsulate internals in MutableBigInt · 977da550
      Jakob Kummerow authored
      This CL creates the invariant that the BigInt class treats
      BigInt objects as immutable. Writing to new BigInt objects
      as part of their construction is done by the MutableBigInt
      helper class, which in turn is hidden as an implementation
      detail in bigint.cc.
      As a side effect, this refactoring enforces right-trimming
      checks for all newly created BigInts, and ensures that all
      BigInt allocations possibly exceeding kMaxLength check for
      this case and throw a RangeError instead of crashing.
      
      Bug: v8:6791
      Tbr: mlippautz@chromium.org
      Change-Id: Id239746108e6b076b47a03ba37462001eb501507
      Reviewed-on: https://chromium-review.googlesource.com/742329
      Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49462}
      977da550
  8. 24 Oct, 2017 1 commit
  9. 11 Sep, 2017 1 commit
  10. 08 Sep, 2017 1 commit
  11. 31 Aug, 2017 1 commit
  12. 14 Aug, 2017 1 commit
  13. 14 Feb, 2017 1 commit
  14. 13 Feb, 2017 4 commits
  15. 09 Jan, 2017 1 commit
  16. 01 Sep, 2016 1 commit
  17. 03 Aug, 2016 1 commit