- 03 Jun, 2015 1 commit
-
-
bmeurer authored
Revert of Embedded constant pools. (patchset #12 id:220001 of https://codereview.chromium.org/1131783003/) Reason for revert: Breaks Linux nosnap cctest/test-api/FastReturnValuesWithProfiler, see http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug%20-%202/builds/609/steps/Check/logs/FastReturnValuesWithP.. Original issue's description: > Add support for Embedded Constant Pools for PPC and Arm > > Embed constant pools within their corresponding Code > objects. > > This removes support for out-of-line constant pools in favor > of the new approach -- the main advantage being that it > eliminates the need to allocate and manage separate constant > pool array objects. > > Currently supported on PPC and ARM. Enabled by default on > PPC only. > > This yields a 6% improvment in Octane on PPC64. > > R=danno@chromium.org, svenpanne@chromium.org, bmeurer@chromium.org, rmcilroy@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com > BUG=chromium:478811 > LOG=Y > > Committed: https://crrev.com/a9404029343d65f146e3443f5280c40a97e736af > Cr-Commit-Position: refs/heads/master@{#28770} TBR=rmcilroy@chromium.org,ishell@chromium.org,rodolph.perfetta@arm.com,mbrandy@us.ibm.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:478811 Review URL: https://codereview.chromium.org/1155703006 Cr-Commit-Position: refs/heads/master@{#28772}
-
- 02 Jun, 2015 1 commit
-
-
mbrandy authored
Embed constant pools within their corresponding Code objects. This removes support for out-of-line constant pools in favor of the new approach -- the main advantage being that it eliminates the need to allocate and manage separate constant pool array objects. Currently supported on PPC and ARM. Enabled by default on PPC only. This yields a 6% improvment in Octane on PPC64. R=danno@chromium.org, svenpanne@chromium.org, bmeurer@chromium.org, rmcilroy@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:478811 LOG=Y Review URL: https://codereview.chromium.org/1131783003 Cr-Commit-Position: refs/heads/master@{#28770}
-
- 01 Jun, 2015 1 commit
-
-
erikcorry authored
When compiling on a laptop I like to concatenate the small test files. This makes a big difference to compile times. These changes make that easier. R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/1163803002 Cr-Commit-Position: refs/heads/master@{#28742}
-
- 21 May, 2015 1 commit
-
-
bbudge authored
Removes EnsureDouble* methods. Adds a RequiredAlignment method. Changes call sites. LOG=N BUG=v8:4124 Review URL: https://codereview.chromium.org/1150953002 Cr-Commit-Position: refs/heads/master@{#28541}
-
- 15 May, 2015 1 commit
-
-
yangguo authored
TBR=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1124403006 Cr-Commit-Position: refs/heads/master@{#28415}
-
- 14 May, 2015 1 commit
-
-
machenbach authored
Revert of Prevent stack overflow in the serializer/deserializer. (patchset #6 id:100001 of https://codereview.chromium.org/1125073004/) Reason for revert: [Sheriff] Breaks msan: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2266 Original issue's description: > Prevent stack overflow in the serializer/deserializer. > > We keep an eye on the recursion depth. Once it exceeds a limit, we serialize > only the object header and size, but defer serializing the object body for > after we have unwound the stack. > > R=mvstanton@chromium.org > > Committed: https://crrev.com/36b4a498d6614243454d5a182e4946b0dad24f0a > Cr-Commit-Position: refs/heads/master@{#28385} TBR=mvstanton@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1139113002 Cr-Commit-Position: refs/heads/master@{#28403}
-
- 13 May, 2015 1 commit
-
-
yangguo authored
We keep an eye on the recursion depth. Once it exceeds a limit, we serialize only the object header and size, but defer serializing the object body for after we have unwound the stack. R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1125073004 Cr-Commit-Position: refs/heads/master@{#28385}
-
- 08 May, 2015 1 commit
-
-
domenic authored
Instead of making them an extra option that gets passed in and compiled at the end of the natives file for a given run of js2c, we now make them a separate run of js2c with a separate natives file output. This natives file output is then compiled in the bootstrapper. It is not part of the snapshot (yet), but instead is treated similar to the experimental natives, just without any of the complexity that comes from tieing the behavior to flags. We also don't need counterparts to InitializeExperimentalGlobal and InstallExperimentalNativeFunctions (yet?). This fixes the issue with https://codereview.chromium.org/1129743003 by making the dummy file that is generated for snapshots with no extras (or no experimental features) nonempty. R=yangguo@chromium.org, jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/1130993003 Cr-Commit-Position: refs/heads/master@{#28311}
-
- 07 May, 2015 2 commits
-
-
domenic authored
Revert of Make V8 extras a separate type of native (patchset #4 id:60001 of https://codereview.chromium.org/1129743003/) Reason for revert: https://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2745 Original issue's description: > Make V8 extras a separate type of native > > Instead of making them an extra option that gets passed in and compiled > at the end of the natives file for a given run of js2c, we now make them a > separate run of js2c with a separate natives file output. > > This natives file output is then compiled in the bootstrapper. It is not part > of the snapshot (yet), but instead is treated similar to the experimental > natives, just without any of the complexity that comes from tieing the > behavior to flags. We also don't add counterparts to > InitializeExperimentalGlobal and InstallExperimentalNativeFunctions, yet. > > R=yangguo@chromium.org, jochen@chromium.org > BUG= > > Committed: https://crrev.com/c93aff4ac63ad9ffb6318e750335208de32b7902 > Cr-Commit-Position: refs/heads/master@{#28296} TBR=jochen@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1131903002 Cr-Commit-Position: refs/heads/master@{#28299}
-
domenic authored
Instead of making them an extra option that gets passed in and compiled at the end of the natives file for a given run of js2c, we now make them a separate run of js2c with a separate natives file output. This natives file output is then compiled in the bootstrapper. It is not part of the snapshot (yet), but instead is treated similar to the experimental natives, just without any of the complexity that comes from tieing the behavior to flags. We also don't add counterparts to InitializeExperimentalGlobal and InstallExperimentalNativeFunctions, yet. R=yangguo@chromium.org, jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/1129743003 Cr-Commit-Position: refs/heads/master@{#28296}
-
- 05 May, 2015 2 commits
-
-
danno authored
Revert of Collect type feedback on result of Math.[round|ceil|floor] (patchset #13 id:230001 of https://codereview.chromium.org/1053143005/) Reason for revert: All sorts of performance regressions Original issue's description: > Collect type feedback on result of Math.[round|ceil|floor] > > By recording invocations of these builtins that can return -0, we now learn to not emit Crankshaft code that only handles integer results, avoiding deopt loops. > > Committed: https://crrev.com/f36ecaf3a4d61568ca50a20718acce7dd5da9a5f > Cr-Commit-Position: refs/heads/master@{#28215} TBR=mvstanton@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1115973005 Cr-Commit-Position: refs/heads/master@{#28237}
-
danno authored
By recording invocations of these builtins that can return -0, we now learn to not emit Crankshaft code that only handles integer results, avoiding deopt loops. Review URL: https://codereview.chromium.org/1053143005 Cr-Commit-Position: refs/heads/master@{#28215}
-
- 30 Apr, 2015 2 commits
-
-
jochen authored
Original issue's description: > Remove the weak list of array buffers > > Instead, collect live array buffers during marking and free pointers we > no longer found. > > BUG=v8:3996 > R=hpayer@chromium.org > LOG=n BUG=v8:3996 TBR=hpayer@chromium.org LOG=n Review URL: https://codereview.chromium.org/1115853004 Cr-Commit-Position: refs/heads/master@{#28156}
-
machenbach authored
Revert of Remove the weak list of array buffers (patchset #8 id:140001 of https://codereview.chromium.org/1114563002/) Reason for revert: [Sheriff] Crashes in layout tests: https://chromegw.corp.google.com/i/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2668 Original issue's description: > Remove the weak list of array buffers > > Instead, collect live array buffers during marking and free pointers we > no longer found. > > BUG=v8:3996 > R=hpayer@chromium.org > LOG=n > > Committed: https://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b > Cr-Commit-Position: refs/heads/master@{#28132} TBR=dslomov@chromium.org,hpayer@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Review URL: https://codereview.chromium.org/1115043005 Cr-Commit-Position: refs/heads/master@{#28148}
-
- 29 Apr, 2015 2 commits
-
-
jochen authored
Instead, collect live array buffers during marking and free pointers we no longer found. BUG=v8:3996 R=hpayer@chromium.org LOG=n Review URL: https://codereview.chromium.org/1114563002 Cr-Commit-Position: refs/heads/master@{#28132}
-
jochen authored
We shouldn't have shared state between isolates by default. The embedder is free to pass the same allocator to all isolates it creates. BUG=none R=dcarney@chromium.org LOG=y Review URL: https://codereview.chromium.org/1116633002 Cr-Commit-Position: refs/heads/master@{#28127}
-
- 28 Apr, 2015 2 commits
-
-
jochen authored
All typed arrays should be allocated through the array buffer allocator BUG=none R=dcarney@chromium.org LOG=n Review URL: https://codereview.chromium.org/1110603005 Cr-Commit-Position: refs/heads/master@{#28105}
-
bmeurer authored
Currently only the Win64 bots report this warnings, which adds quite some overhead to the development process. With this flag we also get compiler warnings about implicit 64bit to 32bit truncations when building with clang on Linux/x64 and Mac/x64. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/1111733002 Cr-Commit-Position: refs/heads/master@{#28093}
-
- 27 Apr, 2015 1 commit
-
-
jochen authored
Original description: > Instead, views have to check their array buffer for whether > it's neutered or not. > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n BUG=v8:3996 R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/1107843002 Cr-Commit-Position: refs/heads/master@{#28060}
-
- 24 Apr, 2015 1 commit
-
-
jochen authored
Revert of Reland "Remove the weak list of views from array buffers" (patchset #2 id:20001 of https://codereview.chromium.org/1093183004/) Reason for revert: still working on perf Original issue's description: > Reland "Remove the weak list of views from array buffers" > > Original description: > > Instead, views have to check their array buffer for whether > > it's neutered or not. > > > > BUG=v8:3996 > > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > > LOG=n > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n > > Committed: https://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f > Cr-Commit-Position: refs/heads/master@{#28029} TBR=dslomov@chromium.org,hpayer@chromium.org,verwaest@chromium.org,dcarney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Review URL: https://codereview.chromium.org/1053203007 Cr-Commit-Position: refs/heads/master@{#28038}
-
- 23 Apr, 2015 1 commit
-
-
jochen authored
Original description: > Instead, views have to check their array buffer for whether > it's neutered or not. > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n BUG=v8:3996 R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/1093183004 Cr-Commit-Position: refs/heads/master@{#28029}
-
- 22 Apr, 2015 3 commits
-
-
jochen authored
Revert of Remove the weak list of views from array buffers (patchset #6 id:100001 of https://codereview.chromium.org/1094863002/) Reason for revert: I'm reverting this while working on the regression fix Original issue's description: > Remove the weak list of views from array buffers > > Instead, views have to check their array buffer for whether > it's neutered or not. > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n > > Committed: https://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c > Cr-Commit-Position: refs/heads/master@{#27995} TBR=dslomov@chromium.org,hpayer@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Review URL: https://codereview.chromium.org/1061753008 Cr-Commit-Position: refs/heads/master@{#28014}
-
jochen authored
Instead, views have to check their array buffer for whether it's neutered or not. BUG=v8:3996 R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/1094863002 Cr-Commit-Position: refs/heads/master@{#27995}
-
yangguo authored
R=ulan@chromium.org BUG=v8:4050 LOG=N Review URL: https://codereview.chromium.org/1099103003 Cr-Commit-Position: refs/heads/master@{#27988}
-
- 20 Apr, 2015 3 commits
-
-
Ross McIlroy authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/1088993003 Cr-Commit-Position: refs/heads/master@{#27937}
-
yangguo authored
R=mvstanton@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1091983002 Cr-Commit-Position: refs/heads/master@{#27933}
-
yangguo authored
External strings are serialized as internal strings. The current way of collecting stats is slightly wrong. We ought to use the map and size passed to SerializePrologue. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1092253003 Cr-Commit-Position: refs/heads/master@{#27931}
-
- 16 Apr, 2015 2 commits
-
-
yangguo authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1081443006 Cr-Commit-Position: refs/heads/master@{#27901}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1086363002 Cr-Commit-Position: refs/heads/master@{#27887}
-
- 14 Apr, 2015 1 commit
-
-
jochen authored
If a major gc happens between allocation and initialization of the buffer, it might be already in old space. Since we need the list of buffers to be sorted from new to old, we keep track of the last buffer and put old buffers to the end BUG=chromium:476032 R=hpayer@chromium.org,dslomov@chromium.org LOG=n Review URL: https://codereview.chromium.org/1079923003 Cr-Commit-Position: refs/heads/master@{#27811}
-
- 13 Apr, 2015 1 commit
-
-
adamk authored
This avoids both a mysterious boolean argument ("insert") and lets non-mutating lookups skip passing an allocator (in one such case, we were passing a scary-looking ZoneAllocationPolicy(NULL)!). Review URL: https://codereview.chromium.org/1074943002 Cr-Commit-Position: refs/heads/master@{#27799}
-
- 10 Apr, 2015 3 commits
-
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1065863003 Cr-Commit-Position: refs/heads/master@{#27760}
-
verwaest authored
This fixes the arm(64) and mips(64) write barriers BUG= Review URL: https://codereview.chromium.org/1073133002 Cr-Commit-Position: refs/heads/master@{#27751}
-
Yang Guo authored
R=machenbach@chromium.org Review URL: https://codereview.chromium.org/1073083002 Cr-Commit-Position: refs/heads/master@{#27735}
-
- 09 Apr, 2015 2 commits
-
-
adamk authored
Revert of Merge cellspace into old pointer space (patchset #8 id:180001 of https://codereview.chromium.org/1010803012/) Reason for revert: Causes test failures on ARM bots related to cells and write barriers. Original issue's description: > Merge cellspace into old pointer space > > BUG= > > Committed: https://crrev.com/4e7163ce05f135918205c7855ae60a48e5d46cc5 > Cr-Commit-Position: refs/heads/master@{#27707} TBR=hpayer@chromium.org,balazs.kilvady@imgtec.com,yangguo@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1053243003 Cr-Commit-Position: refs/heads/master@{#27711}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1010803012 Cr-Commit-Position: refs/heads/master@{#27707}
-
- 07 Apr, 2015 2 commits
-
-
yangguo authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1060683003 Cr-Commit-Position: refs/heads/master@{#27629}
-
hpayer authored
This reverts commit cbfcee55. BUG= Review URL: https://codereview.chromium.org/1051233002 Cr-Commit-Position: refs/heads/master@{#27623}
-
- 02 Apr, 2015 1 commit
-
-
jochen authored
BUG=none R=danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/960903003 Cr-Commit-Position: refs/heads/master@{#27579}
-
- 27 Mar, 2015 1 commit
-
-
yangguo authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/1041743002 Cr-Commit-Position: refs/heads/master@{#27501}
-