- 30 Sep, 2020 2 commits
-
-
Thibaud Michaud authored
Ensure that a valid off-heap trampoline is created for the GenericJSToWasmWrapper builtin by adding it to the list of executable builtins. R=ahaas@chromium.org CC=evih@chromium.org Bug: v8:10701 Change-Id: I49b8144237aca20f5f663c7b32810a16f715ad5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2438415 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#70218}
-
Manos Koukoutos authored
Changes: - Implement WasmExportedFunction::MatchesSignature. - Use it over comparison with == in ResolveWasmImportCall. - Add a test which exposes the existing bug. - Add a few reminder TODOs. Bug: v8:9495 Change-Id: Ibbe31dbf550be212dbf2170ab8cdab9b4b6de734 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2438060 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#70215}
-
- 29 Sep, 2020 4 commits
-
-
Ng Zhi An authored
Bug: v8:10933 Change-Id: I6709dac3598f9dea96fe6f5efec452c1bbdcbc2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2436611Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70208}
-
Ng Zhi An authored
LoadTransform operators contain a LoadKind, which can be unaligned, protected, poisoned, normal. If it is protected, we cannot eliminiate that load, since we rely on the segv signal handling. So, we use partial template specialization on LoadKind::kProtected, and don't set the operator to not be eliminatable. Bug: chromium:1132461 Change-Id: If45fc6562348ffd4dbaa27058e6c5d4242f79abb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2436081 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#70205}
-
Camillo Bruni authored
Allocating the log string causes allocation differences. Skipping test for now. Drive-by-fix: remove two more console.log from test Bug: v8:10966, v8:10668 Change-Id: Ifb93393fb82a983e779246ea728b1f6caf650426 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2436457 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70197}
-
Georg Neis authored
This reverts commit d734bb4c. Reason for revert: Flawed. Original change's description: > [compiler] Check for stack overflow in recursive ReduceJSCall > > Gracefully handle hugely nested JSBoundFunctions. > > Bug: chromium:1125145 > Change-Id: I08f136fa9d35cf16ea8da5132d4d483a75d0ba94 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2418091 > Auto-Submit: Georg Neis <neis@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70164} TBR=neis@chromium.org,mslekova@chromium.org Change-Id: I2d4ed79e2470981dab7ccba8e0c7e1004fe91369 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1125145 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2436342Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#70195}
-
- 28 Sep, 2020 10 commits
-
-
Ng Zhi An authored
The value should be v128 according to https://github.com/WebAssembly/simd/blob/master/proposals/simd/SIMD.md#global-constructor. Change-Id: I9d29905daaaf19cdcaf686991f4887c3e709d2d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2436638Reviewed-by:
-
Michael Achenbach authored
This additionally combines --future with all other standard testing variants. This also enables using concurrent_marking in status files to skip tests in this variant. This also marks a slow test that times out in the new config. Bug: v8:10875 Change-Id: Id904f6a2c51b814eecfccb523a897de2f5d96f56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423719 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Adam Klein authored
This test likely did something in 2013 when we still had legacy const, but now it seems like it's mostly a poor unittest of when optimization/deoptimization happens. Bug: v8:10933 Change-Id: Ib816e0eddf9224a4ad37096591da9032740d5e7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2432313Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#70178}
-
Camillo Bruni authored
Change-Id: Ia55be7d7eda930e6ebf2a0e46c466873006e9d68 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2429264 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#70176}
-
Camillo Bruni authored
Bug: v8:10668 Change-Id: I51f81a66408a4b262f9ac7e6421609c5e485f779 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2435107 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#70174}
-
Camillo Bruni authored
Remove debug code that fails with predictable tests. Bug: chromium:1130673 Change-Id: Ie0009a3b18979057b08c25d22c58c7542dd1db6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2435678Reviewed-by:
-
Georg Neis authored
Gracefully handle hugely nested JSBoundFunctions. Bug: chromium:1125145 Change-Id: I08f136fa9d35cf16ea8da5132d4d483a75d0ba94 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2418091 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#70164}
-
Camillo Bruni authored
This changes all tools to use ES6 modules and proper imports. Step 1: Add converted .mjs files (*this CL*) Step 2: Update node-ci build to use new .mjs files Step 3: Remove outdated .js files Bug: v8:10667, v8:10933 Change-Id: I3e92e66f896d8a9cacaf6d421f8d2c86fb3bc444 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431045 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Camillo Bruni authored
The tool has been outdated for a while and replaced by profview for most use-cases. The last version is still hosted under https://v8.github.io/tools/v8.4/profviz/profviz.html Bug: v8:9260, v8:10667 Change-Id: I54888640a627ee8e4d8ad2ab63bd91e04e6fb98f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2434335Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
evih authored
Currently, the generic wrapper is used for i32, i64, f32 and f64 params and 0 or 1 i32, i64, f32, f64 return value. Bug: v8:10701 Change-Id: I3776de617aa4a384fdff5154ddad8ff405001a33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2429266 Commit-Queue: Eva Herencsárová <evih@google.com> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#70156}
-
- 25 Sep, 2020 5 commits
-
-
Bill Budge authored
Bug: v8:10933 Change-Id: I4db540cf47ce5cfa25757d776a2bf988ce3ed554 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2432072Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#70147}
-
Almothana Athamneh authored
Add opt and noturbo inlining to these tests to ensure that they keep working. Bug: v8:10924 Change-Id: Icdb5ddffad11ea3c2eea723e339d450d8405b6b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2426604 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Gus Caplan authored
This fixes the logic in the desugaring of destructuring assignments. In particular, a spread element would not check if previous `next` results had already been done, and would always call `next()` again. Change-Id: I1bd384678722e6cf51c5777fc3b0dd965360291a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2430488 Commit-Queue: Gus Caplan <snek@chromium.org> Reviewed-by:
-
Adam Klein authored
These instructions were changed from "s8x16" to "i8x16" prefixes in https://github.com/WebAssembly/simd/pull/321. This CL updates all V8 code, including arch-specific code, to match. Bug: v8:10946, v8:10933 Change-Id: I26ef9ad77571f94501d42c1d65f57380fd507f3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2432068Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#70143}
-
Tobias Tebbi authored
Bug: v8:10942 Change-Id: Icbb1d8e054ee924a77f1fbeb9e48cde604ef69b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2422001Reviewed-by:
-
- 24 Sep, 2020 8 commits
-
-
Andreas Haas authored
In atomic.notify we overwrote the register which stored the index, without checking if it was still in use or not. R=clemensb@chromium.org Bug: v8:10898 Change-Id: I59ed7a2c1f1342ff4252e3c4d33822111caee82c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2426616Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#70125}
-
evih authored
When loading from the exported function data without pointer compression, wrong load was used before. Bug: v8:10701, chromium:1130385 Change-Id: If66913bcd5284eeb6fb7b795357f1512682a062f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2426383 Commit-Queue: Eva Herencsárová <evih@google.com> Reviewed-by:
-
Camillo Bruni authored
Bug: chromium:1130673 Change-Id: I78ae388daa1c4c2b594981bdadd201c2dfb39eb0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2426618Reviewed-by:
-
Marja Hölttä authored
The actual fix is in LoadIC::ComputeHandler (checking lookup_start_object == holder instead of receiver == holder) + the LookupIterator changes for preserving lookup_start_object. The rest is renaming / refactoring. Reland: not relying on the prototype validity cell after all Previous version: https://chromium-review.googlesource.com/c/v8/v8/+/2414039 Bug: v8:9237, chromium:1127653 Change-Id: I1949442f8ddcecb776f0c5d2cf737cb75f80e313 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2428588Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#70112}
-
Marja Hölttä authored
This reverts commit ab7e6df0. Reason for revert: Several fuzz bugs: chromium:1131469, chromium:1131525, chromium:1131779 Original change's description: > [super ic] Fix more receiver vs lookup start object vs holder confusion > > The actual fix is in LoadIC::ComputeHandler (checking > lookup_start_object == holder instead of receiver == holder) + the > LookupIterator changes for preserving lookup_start_object. > > The rest is renaming / refactoring. > > Bug: v8:9237, chromium:1127653 > Change-Id: Ieef46fb46ababa79623951c48639429c5b552d2d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2414039 > Commit-Queue: Marja Hölttä <marja@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70045} TBR=marja@chromium.org,ishell@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9237 Bug: chromium:1127653, chromium:1131469, chromium:1131525, chromium:1131779 Change-Id: I1bad5ba1dcfe9a0de8ce775feac2d3bfd7264c8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2426620 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This fixes a case in which we forgot to assign flags to TextNodes created through AddBmpCharacters AddNonBmpSurrogatePairs AddLoneLeadSurrogates AddLoneTrailSurrogates functions. If these initially had a flag (e.g. case-insensitive 'i') set, that information was lost. This bug resulted in missing case folding in no_i18n builds (perhaps other things as well that just aren't covered by our test suite). Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Bug: v8:10131,v8:10120 Change-Id: Icef4f0dbd47971a538e07bab2f1067c383fd59c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423718Reviewed-by:
-
Marja Hölttä authored
Having the web compatibility hack (allowing foo() = 1) enabled for logical assignment was unintentional. Browser compatibility data: https://docs.google.com/document/d/1cGorRZ73KvQqu57tT4ahCjSLncibFMUwlkaL-XIstzI/edit?usp=sharing Bug: v8:10372, v8:10950 Change-Id: I87f6348b75ce72ee5bd5db143f789ceeee596070 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423721Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#70105}
-
Jakob Gruber authored
Bug: v8:10915 Change-Id: I96fb546cea47d382b2ca160bbbf1fb270468e51b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2426617Reviewed-by:
-
- 23 Sep, 2020 5 commits
-
-
Camillo Bruni authored
Avoid --log-all which activates profiling timers that have issues on certain bots. --log-code is good enough to test whether logging works. Bug: v8:10937 Change-Id: I3284801f7b423480756abb0f3c33980a9776575d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424349Reviewed-by:
-
evih authored
Currently, the generic wrapper is used for i32 and i64 params and 0 or 1 i32, i64, f32, f64 return value. Bug: v8:10701 Change-Id: I610172995457354879afd3c9c2c6c2d55c2b700f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2414219Reviewed-by:
-
Michael Achenbach authored
No-Try: true Bug: v8:10952 Change-Id: Iee858419b160a354a4df61f51b18782fcbc4a521 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424155 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Bug: chromium:1129854, v8:10937 Change-Id: I0a9fd3e16a6ae8ea47a7a3f0a9325542d9e46014 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424133Reviewed-by:
-
Martin Bidlingmaier authored
The m (multiline) and s (dotall) flags just needed to be marked as allowed; the required logic was already in the regexp parser. A regexp /<x>/ without the y (sticky) flag is equivalent to the sticky regexp /.*?<x>/y. The interpreter now assumes that every regexp is sticky, and the compiler appends a preamble corresponding to /.*?/ before non-sticky regexps. To reuse existing code for compiling this preamble, the logic for each kind of quantifier is now in a separate function and called from VisitQuantifier and for the preamble. The commit also includes some improvements/fixes for character ranges: - Empty character ranges/disjunctions should never match, but before this commit they would *always* match. - The check of the range bounds in CanBeHandledVisitor was unncessary; without the unicode flag this can't be a range that can't be specified in 2-byte codepoints, and once we support unicode we simply support all codepoints. - The capacity of the list containing the complementary intervals of a character range is now calculated more accurately. Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng Bug: v8:10765 Change-Id: I71a0e07279b4e1140c0ed1651b3714200c801de9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2404766 Commit-Queue: Martin Bidlingmaier <mbid@google.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#70082}
-
- 22 Sep, 2020 6 commits
-
-
Ng Zhi An authored
Rename opcodes based on the renaming in the proposal, https://github.com/WebAssembly/simd/pull/322. Bug: v8:10946 Change-Id: If267d6f8fb1b9deeff64cd9abcd7e4cd64a540a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2422357 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Camillo Bruni authored
This is a reland of 21bb43cc The build failures seems to be an infra flake. Original change's description: > [log][d8] Only use d8.log.getAndStop on temporary log file > > We run tests in parallel which can cause multiple tests to write to > the shared v8.log file. This obviously breaks the simple assertions in > mjsunit/tools/log.js. > > - Use temporary files for log testing with --logfile='+' > > - Change the symbol from '&' to '+' for using temporary files for > logging with --logfile > > - Enable skipped log tests again. > > Bug: v8:10937, chromium:1129854, chromium:1130196 > Change-Id: I607dc9a9ecc352e58525cdd21c1c93efebf0f09f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2421826 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70071} Bug: v8:10937 Bug: chromium:1129854 Bug: chromium:1130196 Change-Id: I2ccf7528f35057ef668aa211142e0f1073fc1fc3 Tbr: verwaest@chromium.org, victorgomes@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424257Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70076}
-
Francis McCabe authored
This reverts commit 21bb43cc. Reason for revert: See broken build: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20builder/49882 Original change's description: > [log][d8] Only use d8.log.getAndStop on temporary log file > > We run tests in parallel which can cause multiple tests to write to > the shared v8.log file. This obviously breaks the simple assertions in > mjsunit/tools/log.js. > > - Use temporary files for log testing with --logfile='+' > > - Change the symbol from '&' to '+' for using temporary files for > logging with --logfile > > - Enable skipped log tests again. > > Bug: v8:10937, chromium:1129854, chromium:1130196 > Change-Id: I607dc9a9ecc352e58525cdd21c1c93efebf0f09f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2421826 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70071} TBR=cbruni@chromium.org,verwaest@chromium.org,victorgomes@chromium.org Change-Id: I5de61792c283139b2a898334e28e1f7b2d7c08f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10937 Bug: chromium:1129854 Bug: chromium:1130196 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424625Reviewed-by:
Francis McCabe <fgm@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#70072}
-
Camillo Bruni authored
We run tests in parallel which can cause multiple tests to write to the shared v8.log file. This obviously breaks the simple assertions in mjsunit/tools/log.js. - Use temporary files for log testing with --logfile='+' - Change the symbol from '&' to '+' for using temporary files for logging with --logfile - Enable skipped log tests again. Bug: v8:10937, chromium:1129854, chromium:1130196 Change-Id: I607dc9a9ecc352e58525cdd21c1c93efebf0f09f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2421826 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#70071}
-
Z Nguyen-Huu authored
Using associative property of addition: (x + A) + B => x + (A + B). Note: A and B need to have the same sign and we need to check that (x + A) isn't used anywhere else. 20% perf improvement of the following function. function f(n) { var c = 0; for (var i = 0; i < n; i++) { c = c + 2 + 3; } return c; } for n = 10_000_000. Before: 7.31s. After: 6.05s. Bug: v8:10305 Change-Id: If45d1cad6128a9a25cb9f43a4828ae28d594a84b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2365221 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by: -
Shu-yu Guo authored
The detach CHECK is currently crashing on a non-TypedArray and non-Array input source to TypedArray#set that detaches the destination TypedArray in its length getter. Bug: v8:10885 Change-Id: I80bcb4ffb4e4122afbff5c412623c008dc9509df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2419655Reviewed-by:
-
