- 29 Oct, 2018 34 commits
-
-
Michael Starzinger authored
This fixes the fall-back case when parsing a multiplicative expression where the lookahead found a '-' token followed by an unsigned token, but no '*' token is following. We cannot rewind both tokens, but still need to make sure that a full multiplicative expression is parsed. R=clemensh@chromium.org TEST=mjsunit/regress/regress-8377 BUG=v8:8377 Change-Id: I20ce6267445b32bdaf03f41f11d9ef4be66cb636 Reviewed-on: https://chromium-review.googlesource.com/c/1304317Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57084}
-
Clemens Hammacher authored
The Counters are not specific to compilation units, they just happen to be used in WasmCompilationUnit::ExecuteCompilation. Remove it from the compilation unit and pass it explicitly where needed. This saves another field on the compilation units. R=titzer@chromium.org Bug: v8:8343 Change-Id: Iad4fd8ae23b022c237535503e0e805db7e67071a Reviewed-on: https://chromium-review.googlesource.com/c/1304297 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#57083}
-
Marja Hölttä authored
The bug was that PreParser detected a stack overflow and an unidentifiable error, and we tried to re-parse the same code. However, the stack overflow flag was still set, and that messed up error handling in the Parser. BUG=chromium:899495 Change-Id: Icdef74bdb8be252d75f245e243e1303ffb822ce2 Reviewed-on: https://chromium-review.googlesource.com/c/1304316Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#57082}
-
Marja Hölttä authored
- Store dirty JSWeakFactories in a heap root (not native context) - during GC there's no native context necessarily. - Schedule one microtask per JSWeakFactory. - Enter the context of the cleanup function before calling it. BUG=v8:8179 Change-Id: Icaa245a08a60dd7325af828858ebe55d842c5bf6 Reviewed-on: https://chromium-review.googlesource.com/c/1298899 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#57081}
-
Clemens Hammacher authored
Move some methods to transitions-inl.h to avoid using methods defined in other inl headers. R=verwaest@chromium.org Bug: v8:7965 Change-Id: I0f5a97ffa4c5faad1687c1586ef2dbf5193939bb Reviewed-on: https://chromium-review.googlesource.com/c/1303299 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
R=jgruber@chromium.org Bug: v8:7965 Change-Id: Icad6d0f2e43d8c5bb62ad160a186b1d3dbd57781 Reviewed-on: https://chromium-review.googlesource.com/c/1303298 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57079}
-
Clemens Hammacher authored
They are only needed in the async DecodeModule step. We can just store a raw pointer to the Counters there. R=mstarzinger@chromium.org Bug: v8:8238 Change-Id: I2b22008fc4cbf6f8f69c9d53822fdb5af7d638f6 Reviewed-on: https://chromium-review.googlesource.com/c/1303302 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57078}
-
Clemens Hammacher authored
R=yangguo@chromium.org Bug: v8:7965 Change-Id: I38d636b29bc6a8eebafc8299b24954bedb3cafec Reviewed-on: https://chromium-review.googlesource.com/c/1303719 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#57077}
-
Clemens Hammacher authored
See discussion after this CL: https://crrev.com/c/1297960 We want to avoid the link from NativeModule to WasmEngine to enforce encapsulation. If someone needs access to the WasmEngine, we should give them a direct pointer. R=titzer@chromium.org Bug: v8:8217 Change-Id: I5bb6f4bf9b56c43085786d7092151d51bd0ff3ca Reviewed-on: https://chromium-review.googlesource.com/c/1304433Reviewed-by:
-
peterwmwong authored
This allows very large arrays being joined to incrementally, on-demand allocate the internal buffer. Previously, join would allocate the buffer upfront and all at once. Large, sparse arrays will use less memory. Bug: chromium:897404 Change-Id: Id914b14a7c55a62834f63ad602bdb45363249075 Reviewed-on: https://chromium-review.googlesource.com/c/1303538 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
-
Igor Sheludko authored
by using C++11's default field initializers. Bug: v8:8238 Change-Id: I3f5f4994114da61efb5b3c22681e6c472cf6e3dc Reviewed-on: https://chromium-review.googlesource.com/c/1302054 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
R=mstarzinger@chromium.org Bug: v8:7965 Change-Id: I26c85e7791550cff269ffc998077501a1eaef3a5 Reviewed-on: https://chromium-review.googlesource.com/c/1303718 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
R=titzer@chromium.org Change-Id: Ib3b1cd479b42865420879bff9f1a83558585eb05 Reviewed-on: https://chromium-review.googlesource.com/c/1303301 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Fix by removing a method with a single user instead of introducing an inl-header. R=mstarzinger@chromium.org Bug: v8:7965 Change-Id: I596a673f36c63197db3e774d24b65abe01e83399 Reviewed-on: https://chromium-review.googlesource.com/c/1303717 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
R=marja@chromium.org Bug: v8:7965 Change-Id: Ifcdaaacebf846673b576e66a242efe727a7f3665 Reviewed-on: https://chromium-review.googlesource.com/c/1303716 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#57070}
-
Clemens Hammacher authored
allocation-builder.h was using methods defined in map-inl.h, which is not allowed. Thus move the respective methods to allocation-builder-inl.h. R=mstarzinger@chromium.org Bug: v8:7965 Change-Id: Idd040f624d7e9491bc3d4bbd1e6ab3e8cf051917 Reviewed-on: https://chromium-review.googlesource.com/c/1303297 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: v8:8238 Change-Id: I4bb14e4457b78b91a960680ab22c808b5f88052c Reviewed-on: https://chromium-review.googlesource.com/c/1302053 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
R=ishell@chromium.org Bug: v8:7965 Change-Id: Ia67e567790f4a5b39e24504c13c472091776ec4f Reviewed-on: https://chromium-review.googlesource.com/c/1303296 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57067}
-
Igor Sheludko authored
and make it Isolate-independent. Bug: v8:8238 Change-Id: I23faae87c302d24877ef001873f673d4a1cdd327 Reviewed-on: https://chromium-review.googlesource.com/c/1301484Reviewed-by:
-
Clemens Hammacher authored
Accidentally introduced in https://crrev.com/c/1293951; they were never needed. R=mstarzinger@chromium.org Change-Id: Idbd06800de3f70d1de7c98cb9a11198a6c814093 Reviewed-on: https://chromium-review.googlesource.com/c/1303300 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Now that embedded builtins are enabled everywhere*, lazy deserialization can be turned off and removed. * Except nosnap builds, on aix and in msvc builds. Bug: v8:6666, v8:6624, v8:7990 Change-Id: Ib5fefe10e7ff35b13a1eb803fbc3736b8851b22b Reviewed-on: https://chromium-review.googlesource.com/c/1288638Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Jakob Gruber authored
While not strictly necessary, this is consistent with how SlowFlagGetter behaves. It adds an additional shift operation (which we could fold into the smi untagging if needed). Drive-by: Typify flag accessors. Bug: chromium:899464 Change-Id: Ib154d626e522ed723e2c19b1ab7f68560ac414bc Reviewed-on: https://chromium-review.googlesource.com/c/1304315Reviewed-by:
Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
-
Clemens Hammacher authored
R=marja@chromium.org Bug: v8:7965 Change-Id: I740f7fa1ec19e269d15358fcf66862b15096e132 Reviewed-on: https://chromium-review.googlesource.com/c/1303295 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Yang Guo authored
Node.js uses the tick processor as well, but wraps the script differently so that `this.arguments` does not work. Also fixed outdated comments. R=petermarshall@chromium.org Change-Id: Ia902962b302ec4aa02d31a6ac31ac20510ddcca7 Reviewed-on: https://chromium-review.googlesource.com/c/1304353Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#57061}
-
Clemens Hammacher authored
R=marja@chromium.org Bug: v8:7965 Change-Id: I596712f55266c245f4df9e2fc7670e518f3e9d52 Reviewed-on: https://chromium-review.googlesource.com/c/1303294Reviewed-by:
-
Benedikt Meurer authored
When replacing a LoadElement with variable index with its known fields, only do it if the types match, otherwise we end up with a graph that representation selection cannot handle. That can only happen in dead code, but TurboFan would nevertheless crash in representation selection. Bug: chromium:893982, chromium:899524, v8:5267, v8:6200 Change-Id: I01e645d5e01bffb911d216d37d923792d9d0beab Reviewed-on: https://chromium-review.googlesource.com/c/1303721Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#57059}
-
Toon Verwaest authored
Bug: chromium:899474, v8:8363, v8:7926 Change-Id: I89680d35ab2557f5a2b2282813362f5f654862a9 Reviewed-on: https://chromium-review.googlesource.com/c/1304314 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit ea8aa6a7. Reason for revert: Breaking V8 Win64 - debug build, see https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20debug/25531 Original change's description: > [parser] Set all tokens to ILLEGAL on parser error > > Otherwise already peeked tokens will possibly pass later checks causing us to > parse more than necessary. Initially we held off on doing this since subsequent > Consume calls would fail after previous checks succeeded; especially in the > case of stack overflow. However, we've previously relaxed that DCHECK to also > pass if the parser has an error. > > Change-Id: I413dffd475982d07299a08270fa94fdc3858e883 > Reviewed-on: https://chromium-review.googlesource.com/c/1304313 > Reviewed-by: Marja Hölttä <marja@chromium.org> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57054} TBR=marja@chromium.org,verwaest@chromium.org Change-Id: Ifddd3cefa3876ec03aa1c137dfa95da3d933532e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1304295Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#57057}
-
Clemens Hammacher authored
These two headers can be included in isolation currently, so no need to exclude them. R=marja@chromium.org Bug: v8:7965 Change-Id: I6250a237e6884bc3f89e666bca5d8f4129472fe6 Reviewed-on: https://chromium-review.googlesource.com/c/1303715Reviewed-by:
-
Benedikt Meurer authored
In order for Error.prepareStackTrace() to be able to reconstruct the same stack frame that the internal mechanism can, we need to also expose the index for the Promise.all() builtin. The newly added CallSite#getPromiseIndex() does exactly that. Bug: v8:7522 Change-Id: I904a4c1005f539536a71926ea1da38b31e2a2e8a Reviewed-on: https://chromium-review.googlesource.com/c/1304293Reviewed-by:
-
Toon Verwaest authored
Otherwise already peeked tokens will possibly pass later checks causing us to parse more than necessary. Initially we held off on doing this since subsequent Consume calls would fail after previous checks succeeded; especially in the case of stack overflow. However, we've previously relaxed that DCHECK to also pass if the parser has an error. Change-Id: I413dffd475982d07299a08270fa94fdc3858e883 Reviewed-on: https://chromium-review.googlesource.com/c/1304313Reviewed-by:
-
Refael Ackermann authored
This blocks building with official clang-cl and Windows SDK Refs: https://github.com/nodejs/node/issues/19630 Change-Id: I41fdf934f486c660df7a9e0dd284f6eb3c294dd4 Reviewed-on: https://chromium-review.googlesource.com/c/1297479 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Daniel Clifford authored
In the process implement TopType to express undefined values and transient types after they no longer are valid, as well as checks to make sure that transtioning callables are transitively marked to express if they or their call chain modify transient types. Bug: v8:7793 Change-Id: Idb237e878d3a511a4f460b6510ffd4876593951d Reviewed-on: https://chromium-review.googlesource.com/c/1297963 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/425295f..c55a0b9 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/2b71832..cb629a4 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I10387d35ae298c7d20bc5eacfb70cff05ecd4052 Reviewed-on: https://chromium-review.googlesource.com/c/1304193 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#57051}
-
- 28 Oct, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/94314f9..425295f TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: If6f2893e829c4f03e52cd869fbb7f261a6aa53c2 Reviewed-on: https://chromium-review.googlesource.com/c/1303539Reviewed-by:
-
- 27 Oct, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/df2e6ae..94314f9 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/687f318..985e130 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Id21b9e29ba5f71ed92390e026e7bd74b9751959f Reviewed-on: https://chromium-review.googlesource.com/c/1303536Reviewed-by:
-
- 26 Oct, 2018 4 commits
-
-
Ross McIlroy authored
This is a reland of 9cde8808 now the the underlying problem in Chromium is fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/1301459 Original change's description: > [Compile] Ensure we don't access the native context during bytecode finalization. > > Resets the isolate's context to nullptr in debug builds during bytecode finalization > to ensure that we don't rely on the native context during context independent > unoptimized compilation. > > BUG=chromium:898076, v8:8041 > > Change-Id: Ifaa5006a7a3d31d7fbd535ebb63f8889c75526c4 > Reviewed-on: https://chromium-review.googlesource.com/c/1297961 > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56979} TBR=leszeks@chromium.org Bug: chromium:898076, v8:8041 Change-Id: I11904e19e843b0eadab698196ac1ef9c7aeec766 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel; luci.chromium.try:linux_chromium_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/1301480Reviewed-by:
-
Frank Tang authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ibceb4412713c0bec82b234e2eea6c86aa0d275f7 Reviewed-on: https://chromium-review.googlesource.com/c/1295932 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57047}
-
Michael Achenbach authored
The builder has shown to be too brittle when run on dirty V8 ToT. TBR=sergiyb@chromium.org NOTRY=true Bug: chromium:898965 Change-Id: I7eb1f54febeebfcc6c385cc1a9d97262f8583103 Reviewed-on: https://chromium-review.googlesource.com/c/1302056Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57046}
-
Toon Verwaest authored
Bug: v8:8363, v8:7926 Change-Id: I19d878139b383799081dea296b951ce6945b05d3 Reviewed-on: https://chromium-review.googlesource.com/c/1301853 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
