- 16 Feb, 2016 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1696333002 Cr-Commit-Position: refs/heads/master@{#34035}
-
- 01 Jun, 2015 1 commit
-
-
erikcorry authored
When compiling on a laptop I like to concatenate the small test files. This makes a big difference to compile times. These changes make that easier. R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/1163803002 Cr-Commit-Position: refs/heads/master@{#28742}
-
- 18 Feb, 2015 2 commits
-
-
verwaest authored
Additionally handlify the "transition" field so that GC can stop caring about it. BUG= Review URL: https://codereview.chromium.org/935033003 Cr-Commit-Position: refs/heads/master@{#26718}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/932533003 Cr-Commit-Position: refs/heads/master@{#26717}
-
- 16 Feb, 2015 1 commit
-
-
ishell authored
Previous approach for property reconfiguration was to create a free-floating map with generalized representations of all fields. This patch does it right. When property is reconfigured either by changing its kind (kData <-> kAccessor) or its attributes it implies creation of a new branch in transition tree. If such a branch already existed before reconfiguration then it should be merged with the old (or source) branch of the transition tree. Merging procedure includes all the heavy machinery such as property location changes (kDescriptor -> kField), field representation/field type generalization, map deprecation, etc. Review URL: https://codereview.chromium.org/888623002 Cr-Commit-Position: refs/heads/master@{#26667}
-
- 19 Jan, 2015 1 commit
-
-
ishell authored
PropertyKind: DATA -> kData ACCESSOR -> kAccessor PropertyType: FIELD -> DATA CONSTANT -> DATA_CONSTANT ACCESSOR_FIELD -> ACCESSOR CALLBACKS -> ACCESSOR_CONSTANT PropertyLocation: IN_OBJECT -> kField IN_DESCRIPTOR -> kDescriptor StoreMode: FORCE_IN_OBJECT -> FORCE_FIELD FieldDescriptor -> DataDescriptor ConstantDescriptor -> DataConstantDescriptor CallbacksDescriptor -> AccessorConstantDescriptor Review URL: https://codereview.chromium.org/856503002 Cr-Commit-Position: refs/heads/master@{#26146}
-
- 16 Dec, 2014 1 commit
-
-
ishell authored
Review URL: https://codereview.chromium.org/805453002 Cr-Commit-Position: refs/heads/master@{#25842}
-
- 12 Dec, 2014 1 commit
-
-
ishell authored
Review URL: https://codereview.chromium.org/801783002 Cr-Commit-Position: refs/heads/master@{#25797}
-
- 24 Nov, 2014 1 commit
-
-
ishell authored
BUG=chromium:435974 LOG=N Review URL: https://codereview.chromium.org/755583003 Cr-Commit-Position: refs/heads/master@{#25484}
-
- 19 Nov, 2014 1 commit
-
-
ishell authored
First step towards replacing PropertyType with two enums: {DATA,ACCESSOR} x {CONST,WRITABLE}. Review URL: https://codereview.chromium.org/733253004 Cr-Commit-Position: refs/heads/master@{#25417}
-
- 23 Oct, 2014 1 commit
-
-
ishell@chromium.org authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/659363002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24837 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Sep, 2014 1 commit
-
-
bmeurer@chromium.org authored
Review URL: https://codereview.chromium.org/618643002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24319 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Sep, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/553843002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23767 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Aug, 2014 1 commit
-
-
verwaest@chromium.org authored
BUG= R=yangguo@chromium.org Review URL: https://codereview.chromium.org/504183002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23414 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Aug, 2014 1 commit
-
-
verwaest@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/492433005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23260 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Aug, 2014 1 commit
-
-
verwaest@chromium.org authored
This breaks fetching name of the constructor property of "Object"-labeled values in the heap-snapshot-generator until that's handlified and can be moved over to the LookupIterator. BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/480823004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23226 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jul, 2014 1 commit
-
-
danno@chromium.org authored
R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/426233002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22709 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Jul, 2014 1 commit
-
-
svenpanne@chromium.org authored
This is a mostly mechanical CL (more than 90% Emacs macros and query-replace-regexp) moving FILE*/StringStream*-based APIs to OStream-based APIs. There are a few places where this had to stop, otherwise the CL would be even bigger, but this can easily and incrementally cleaned up later. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/363323003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22232 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jul, 2014 1 commit
-
-
svenpanne@chromium.org authored
Note that until everything is OStream-based, there are a few places where we have to do some impedance matching. A few accessors had to be const-corrected on the way. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/334763003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22179 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Jun, 2014 2 commits
-
-
danno@chromium.org authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/300283002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21746 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
danno@chromium.org authored
Due to assorted failures R=mstarzinger@chromium.org TBR=mstarzginer@chromium.org Review URL: https://codereview.chromium.org/329463005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21732 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 Jun, 2014 1 commit
-
-
danno@chromium.org authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/300283002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21720 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
This is an initial step towards tracking the exact types instead of just the representations of fields. It adds support to track up to one map of heap object field values, eliminating various map checks on values loaded from such fields, at the cost of making stores to such fields slightly more expensive. Issues with transitioning stores and fast object literals in Crankshaft fixed. TEST=mjsunit/field-type-tracking R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/238773002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20746 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Apr, 2014 2 commits
-
-
jarin@chromium.org authored
Revert r20701. TBR=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/236843002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20704 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
This is an initial step towards tracking the exact types instead of just the representations of fields. It adds support to track up to one map of heap object field values, eliminating various map checks on values loaded from such fields, at the cost of making stores to such fields slightly more expensive. TEST=mjsunit/field-type-tracking R=verwaest@chromium.org Review URL: https://codereview.chromium.org/167303005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20701 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/223193005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20494 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/218683008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20391 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Feb, 2014 1 commit
-
-
verwaest@chromium.org authored
BUG=chromium:343964 LOG=N R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/170343003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19440 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Jul, 2013 1 commit
-
-
verwaest@chromium.org authored
R=yangguo@chromium.org Review URL: https://chromiumcodereview.appspot.com/19485008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15858 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 May, 2013 1 commit
-
-
verwaest@chromium.org authored
The descriptors are nowadays ordered in order of addition, so that info was duplicated. Review URL: https://chromiumcodereview.appspot.com/14622005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14571 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Nov, 2012 1 commit
-
-
mmassi@chromium.org authored
BUG= Review URL: https://chromiumcodereview.appspot.com/11365221 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12944 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Aug, 2012 1 commit
-
-
verwaest@chromium.org authored
The order by name is maintained as secondary order by using unused bits in the property details. This is preliminary work towards sharing descriptors arrays. The change allows us - to get rid of the LastAdded bits in the map, binding it to the number of valid descriptors for the given map - to avoid resorting by enumeration index to create the cache - (maybe in the future, depending on performance) to get rid of the enumeration cache altogether. Although generally the number_of_descriptors equals the NumberOfOwnDescriptors in the current version, this is preliminary work towards sharing descriptors, where maps may have more descriptors than are valid for the map. Review URL: https://chromiumcodereview.appspot.com/10879013 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12385 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Jul, 2012 1 commit
-
-
verwaest@chromium.org authored
In this design maps contain descriptor arrays, which in turn can contain transition arrays. If transitions are needed when no descriptor array is present, a descriptor array without real descriptors is inserted just so it can point at the transition array. The transition array does not contain details about the field it transitions to. In order to weed out transitions to FIELDs from CONSTANT_FUNCTION (what used to be MAP_TRANSITION vs CONSTANT_TRANSITION), the transition needs to be followed and the details need to be looked up in the target map. CALLBACKS transitions are still easy to recognize since the transition targets are stored as an AccessorPair containing the maps, rather than the maps directly. Currently AccessorPairs containing a transition and an accessor are shared between the descriptor array and the transition array. This simplifies lookup since we only have to look in one of both arrays. This will change in subsequent revisions, when descriptor arrays will become shared between multiple maps, since transitions cannot be shared. Review URL: https://chromiumcodereview.appspot.com/10697015 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11994 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Jun, 2012 1 commit
-
-
verwaest@chromium.org authored
Instead of overwriting non-live transitions with NULL_DESCRIPTORs, we remove them from the array by compacting the array (shifting live values to the left) and in-place trimming the array. If the final descriptor array contains no live values (only contained transitions which are now all cleared), we move bit_field3 back from the descriptor array to the map. The descriptor array itself will be collected in the next GC. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10575032 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11922 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Jun, 2012 1 commit
-
-
verwaest@chromium.org authored
This is a first step towards separating all transitions from the property descriptions. If we link the property descriptions from the transition object, this will in allow the descriptor array (property descriptions) to become immutable. Review URL: https://chromiumcodereview.appspot.com/10444055 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11750 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Feb, 2012 1 commit
-
-
svenpanne@chromium.org authored
With the upcoming changes to CALLBACKS properties, a predicate on the transition type alone doesn't make sense anymore: For CALLBACKS one has to look into the property's value to decide, and there is even the possibility of having a an accessor function *and* a transition in the same property. I am not completely happy with some parts of this CL, because they contain redundant code, but given the various representations we currently have for property type/value pairs, I can see no easy way around that. Perhaps one can improve this a bit in a different CL, the current diversity really, really hurts productivity... As a bonus, this CL includes a few minor things: * CaseClause::RecordTypeFeedback has been cleaned up and it handles the NULL_DESCRIPTOR case correctly now. Under some (very unlikely) circumstances, we previously missed some opportunities for monomorphic calls. In general, it is rather unfortunate that NULL_DESCRIPTOR "shines through", it is just a hack for the inability to remove a descriptor entry during GC, something callers shouldn't have to be aware of. * DescriptorArray::CopyInsert has been cleaned up a bit, preparing it for later CALLBACKS-related changes. * LookupResult::Print is now more informative for CONSTANT_TRANSITION. Review URL: https://chromiumcodereview.appspot.com/9320066 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10600 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Oct, 2011 1 commit
-
-
kmillikin@chromium.org authored
The LookupResult utility class is used in handlified code, but it can contain a raw pointer to the lookup's holder object. Create a per-thread stack of live LookupResults and iterate all the live ones on GC. R=vegorov@chromium.org,erik.corry@gmail.com BUG= TEST= Review URL: http://codereview.chromium.org/8341009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Sep, 2011 1 commit
-
-
danno@chromium.org authored
R=jkummrow@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/7787007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9214 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 May, 2011 1 commit
-
-
rossberg@chromium.org authored
TODO: reflective Object methods not handled yet. BUG= TEST= Review URL: http://codereview.chromium.org/7035007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7902 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-