1. 23 Apr, 2020 1 commit
    • Leszek Swirski's avatar
      [compile] Add an UnoptimizedCompileState class · 6458a529
      Leszek Swirski authored
      Move the persistent compilation state and Isolate inputs (such as the
      allocator, shared AST constants, hash seed, logger, etc.) which survives
      across both parse and compile, out of ParseInfo and into a new
      UnoptimizedCompileState class. Also add UnoptimizedCompilePerThreadState
      for per-thread state such as stack limit and RCS.
      
      In particular, this new state survives the ParseInfo being destructed,
      which means it is available after off-thread finalization. This allows a
      followup to access the PendingCompilationErrorHandler after finalization
      and report errors on merge.
      
      Bug: v8:10314
      Change-Id: Ia186bc0f267c704efd771aa1895f50a4525a8364
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2105636
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#67329}
      6458a529
  2. 13 Dec, 2019 1 commit
  3. 27 Nov, 2019 1 commit
  4. 25 Nov, 2019 2 commits
    • Dan Elphick's avatar
      Delete redundant code in OptimizingCompileDispatcher::Stop · ead247c1
      Dan Elphick authored
      Removes job queue flushing in OptimizingCompileDispatcher::Stop when
      FLAG_concurrent_recompilation_delay is set. Before this explicit
      flushing was run, there was already a wait-loop which ensured the queue
      was always empty.
      
      Bug: v8:9810
      Change-Id: I620bac9c9d73aead671b178c9450bdd25e6761b1
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1934332
      Commit-Queue: Dan Elphick <delphick@chromium.org>
      Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      Auto-Submit: Dan Elphick <delphick@chromium.org>
      Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65154}
      ead247c1
    • Mythri A's avatar
      [TurboFan] Add RuntimeStats counters for main thread TurboFan phases · 84b35324
      Mythri A authored
      Adds RuntimeStats counters for HeapBrokerInitialization, Serialize,
      SerializeMetadata and Finalization phases. These happen only on main thread.
      In a followup cl we will also add counters for other phases that could happen
      on main thread or background thread.
      
      Earlier RecompileSynchronous was used to measure the time spent in Concurrent,
      non Concurrent and Concurrent finalize phases. This cl replaces them with
      OptimizeConcurrent, OptimizeNonConcurrent and OptimizeConcurrentFinalize
      counters. This cl also renames RecompileConcurrent to OptimizeBackground to
      make it clear this measures the background component of optimization.
      
      This also updates names of trace events to be in-sync with RuntimeStat counters.
      
      Bug: v8:9684
      Change-Id: Ifda81ce7ab1c659c2df53bab924c51c46f46939b
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1924439Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
      Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
      Commit-Queue: Mythri Alle <mythria@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65147}
      84b35324
  5. 10 Sep, 2019 1 commit
  6. 30 May, 2019 1 commit
  7. 27 May, 2019 1 commit
    • Clemens Hammacher's avatar
      [cleanup] Replace simple typedefs by using · a335f2ae
      Clemens Hammacher authored
      This replaces all typedefs that define types and not functions by the
      equivalent "using" declaration.
      
      This was done mostly automatically using this command:
      ag -l '\btypedef\b' src test | xargs -L1 \
           perl -i -p0e 's/typedef ([^*;{}]+) (\w+);/using \2 = \1;/sg'
      
      Patchset 2 then adds some manual changes for typedefs for pointer types,
      where the regular expression did not match.
      
      R=mstarzinger@chromium.org
      TBR=yangguo@chromium.org, jarin@chromium.org
      
      Bug: v8:9183
      Change-Id: I6f6ee28d1793b7ac34a58f980b94babc21874b78
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1631409
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61849}
      a335f2ae
  8. 24 May, 2019 1 commit
  9. 23 May, 2019 4 commits
  10. 22 May, 2019 1 commit
  11. 21 May, 2019 1 commit
  12. 20 May, 2019 1 commit
  13. 17 May, 2019 2 commits
  14. 26 Feb, 2019 1 commit
  15. 15 Feb, 2019 1 commit
  16. 22 Jan, 2019 1 commit
  17. 28 Nov, 2018 1 commit
  18. 13 Nov, 2018 1 commit
  19. 09 Nov, 2018 2 commits
  20. 31 Oct, 2018 3 commits
  21. 18 Oct, 2018 1 commit
  22. 15 Oct, 2018 1 commit
  23. 12 Oct, 2018 3 commits
  24. 09 Oct, 2018 1 commit
  25. 04 Oct, 2018 2 commits
  26. 25 Sep, 2018 1 commit
  27. 20 Sep, 2018 1 commit
    • Ross McIlroy's avatar
      [Compile] Refactor CompilerDispatcher for inner function compilation jobs · 80195fc5
      Ross McIlroy authored
      Refactors the CompilerDispatcher to be able to enqueue eager inner functions
      for off-thread compilation during top-level compilation of a script.
      
      Unoptimized compile jobs are simplified to only have two phases - compile
      and finalization. Only finalization requires heap access (and therefore
      needs to be run on the main thread). The change also introduces a requirement
      to register a SFI with a given compile job after that job is posted, this
      is due to the fact that an SFI won't necessarily exist at the point the job
      is posted, but is created later when top-level compile is being finalized.
      Logic in the compile dispatcher is update to deal with the fact that a job
      may not be able to progress if it doesn't yet have an associated SFI
      registered with it.
      
      BUG=v8:8041
      
      Change-Id: I66cccd626136738304a7cab0e501fc65cf342514
      Reviewed-on: https://chromium-review.googlesource.com/1215782
      Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56088}
      80195fc5
  28. 17 Sep, 2018 1 commit
  29. 14 Sep, 2018 1 commit