- 26 Oct, 2017 1 commit
-
-
Clemens Hammacher authored
This way, we can also check the return code of d8. We currently have a bug (6981) which makes failing tests not being detected, even though the failure message is (sometimes) being printed. After this refactoring, we can write tests for our mjsunit test functions. R=machenbach@chromium.org Bug: v8:6981 Change-Id: I0aa0abcb0f9a4f622a1e1d1a4d826da1e6eb4f07 Reviewed-on: https://chromium-review.googlesource.com/737991Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48951}
-
- 15 Sep, 2016 1 commit
-
-
neis authored
In case of duplicate exports, always report the error for the very last one. (Fixed a bug.) BUG=v8:5358,v8:1569 Review-Url: https://codereview.chromium.org/2340953002 Cr-Commit-Position: refs/heads/master@{#39434}
-
- 14 Sep, 2016 2 commits
-
-
hablich authored
Revert of [modules] Make duplicate export error deterministic. (patchset #2 id:20001 of https://codereview.chromium.org/2331003002/ ) Reason for revert: Seems to break one of our arm64 bots: https://chromegw.corp.google.com/i/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/2303 Original issue's description: > [modules] Make duplicate export error deterministic. > > In case of duplicate exports, always report the error for the very last > one. > > R=adamk@chromium.org > BUG=v8:5358,v8:1569 > > Committed: https://crrev.com/da1f911c4269048d24a3442791b18523455f3b24 > Cr-Commit-Position: refs/heads/master@{#39424} TBR=adamk@chromium.org,neis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5358,v8:1569 Review-Url: https://codereview.chromium.org/2340903002 Cr-Commit-Position: refs/heads/master@{#39430}
-
neis authored
In case of duplicate exports, always report the error for the very last one. R=adamk@chromium.org BUG=v8:5358,v8:1569 Review-Url: https://codereview.chromium.org/2331003002 Cr-Commit-Position: refs/heads/master@{#39424}
-
- 19 Feb, 2015 1 commit
-
-
adamk authored
Add() becomes AddLocalExport, which takes an export_name and a local_name. New parsing tests exercise this. Also start generating exports for default exports (though this doesn't yet handle anonymous default exports). BUG=v8:1569 LOG=n Review URL: https://codereview.chromium.org/934323004 Cr-Commit-Position: refs/heads/master@{#26758}
-