- 13 Dec, 2016 1 commit
-
-
kozyatinskiy authored
BUG=v8:5738 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2574803002 Cr-Commit-Position: refs/heads/master@{#41680}
-
- 07 Dec, 2016 2 commits
-
-
luoe authored
Due to the isOwn check, functions inherited through prototype will not be included in a preview. BUG=645053 Review-Url: https://codereview.chromium.org/2554623003 Cr-Commit-Position: refs/heads/master@{#41566}
-
luoe authored
Getter properties are not currently included in the protocol's Runtime.ObjectPreview. DevTools currently shows getter properties when evaluating arrays in the console, and this CL brings them into the preview generated for RemoteObjects. Corresponding DevTools CL: https://codereview.chromium.org/2521513006/ BUG=666882 Review-Url: https://codereview.chromium.org/2508423002 Cr-Commit-Position: refs/heads/master@{#41565}
-
- 06 Dec, 2016 1 commit
-
-
clemensh authored
*and* report all "virtual" wasm scripts right when the wasm script is registered at the inspector. WasmScript is a subtype of Script, with the cast checking that it is actually a wasm script. This layout makes it quite easy to implement functionality that is only available for wasm scripts, and allows to later directly use the WasmCompiledModule instead of the i::Script for backing the debug::WasmScript. We might also add virtual methods to provide different implementations for GetSourcePosition, Source and others. DisassembleWasmFunction now also becomes a method of this class instead of a static function on the DebugInterface. The WasmTranslation now uses the new WasmScript type instead of the Script wrapper, and also registers all virtual wasm scripts immediately when the wasm script is made public to the inspector (when the wasm module is created). R=yangguo@chromium.org,dgozman@chromium.org,titzer@chromium.org BUG=chromium:613110,chromium:659715 Review-Url: https://codereview.chromium.org/2531163010 Cr-Commit-Position: refs/heads/master@{#41519}
-
- 02 Dec, 2016 1 commit
-
-
luoe authored
Descriptions for (typed)arrays will use parenthesis instead of square brackets "Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions of maps and sets. Related CL for DevTools: https://codereview.chromium.org/2524913002/ BUG=405845 Committed: https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d Review-Url: https://codereview.chromium.org/2521853003 Cr-Original-Commit-Position: refs/heads/master@{#41237} Cr-Commit-Position: refs/heads/master@{#41442}
-
- 01 Dec, 2016 1 commit
-
-
kozyatinskiy authored
If we just call CreateDebugInfo in GetPossibleBreakpoints then we won't call PrepareFunctionForBreakPoints and won't be able to step into this function or pause at breakpoint inside. BUG=v8:5695 R=dgozman@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2540943002 Cr-Commit-Position: refs/heads/master@{#41401}
-
- 29 Nov, 2016 1 commit
-
-
kozyatinskiy authored
BUG=chromium:350797 R=dgozman@chromium.org TBR=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2527473004 Cr-Commit-Position: refs/heads/master@{#41371}
-
- 24 Nov, 2016 4 commits
-
-
yangguo authored
In most cases we can use the debug event listener as alternative. Multithreaded tests are obsolete. R=jgruber@chromium.org BUG=v8:5510 Review-Url: https://codereview.chromium.org/2529883002 Cr-Commit-Position: refs/heads/master@{#41256}
-
jgruber authored
This exposes scopes for suspended generator objects by adding a [[Scopes]] internal property to generator objects, similar to how scopes for functions currently not on the stack are handled. BUG=chromium:667286 Review-Url: https://codereview.chromium.org/2516973003 Cr-Commit-Position: refs/heads/master@{#41244}
-
machenbach authored
Revert of Use parenthesis in descriptions for array/map/set lengths/sizes (patchset #3 id:40001 of https://codereview.chromium.org/2521853003/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/11595 https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > Use parenthesis in descriptions for array/map/set lengths/sizes > > Descriptions for (typed)arrays will use parenthesis instead of square brackets > "Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions > of maps and sets. > > Related CL for DevTools: https://codereview.chromium.org/2524913002/ > > BUG=405845 > > Committed: https://crrev.com/92c77a57390e6a9ef726535b255a24359751992d > Cr-Commit-Position: refs/heads/master@{#41237} TBR=dgozman@chromium.org,kozyatinskiy@chromium.org,luoe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=405845 Review-Url: https://codereview.chromium.org/2530803002 Cr-Commit-Position: refs/heads/master@{#41243}
-
luoe authored
Descriptions for (typed)arrays will use parenthesis instead of square brackets "Array(10)" instead of "Array[10]". This CL also adds size hints to descriptions of maps and sets. Related CL for DevTools: https://codereview.chromium.org/2524913002/ BUG=405845 Review-Url: https://codereview.chromium.org/2521853003 Cr-Commit-Position: refs/heads/master@{#41237}
-
- 23 Nov, 2016 4 commits
-
-
kozyatinskiy authored
New console.assert implementation is faster then custom user implementation. BUG=chromium:663845 R=dgozman@chromium.org Committed: https://crrev.com/f658e41d864267fb9e99ea76faa7758b0b63d5c9 Review-Url: https://codereview.chromium.org/2505493002 Cr-Original-Commit-Position: refs/heads/master@{#41227} Cr-Commit-Position: refs/heads/master@{#41232}
-
machenbach authored
Revert of [inspector] make console.assert much faster (patchset #3 id:40001 of https://codereview.chromium.org/2505493002/ ) Reason for revert: Speculative revert as there seems to be a layout test crash: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/11585 Please reland if it doesn't get green. Original issue's description: > [inspector] make console.assert much faster > > New console.assert implementation is faster then custom user implementation. > > BUG=chromium:663845 > R=dgozman@chromium.org > > Committed: https://crrev.com/f658e41d864267fb9e99ea76faa7758b0b63d5c9 > Cr-Commit-Position: refs/heads/master@{#41227} TBR=dgozman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:663845 Review-Url: https://codereview.chromium.org/2521323005 Cr-Commit-Position: refs/heads/master@{#41231}
-
kozyatinskiy authored
New console.assert implementation is faster then custom user implementation. BUG=chromium:663845 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2505493002 Cr-Commit-Position: refs/heads/master@{#41227}
-
jgruber authored
BUG=v8:5530,chromium:667218 Review-Url: https://codereview.chromium.org/2519773003 Cr-Commit-Position: refs/heads/master@{#41205}
-
- 22 Nov, 2016 1 commit
-
-
clemensh authored
When disassembling functions for the inspector, we used an internal text representation before. This CL implements the official text format like it is understood by the spec interpreter. Example output: func $main (param i32) (result i32) block i32 get_local 0 i32.const 2 i32.lt_u if i32.const -2 return end get_local 0 call_indirect 0 end R=rossberg@chromium.org, titzer@chromium.org BUG=chromium:659715 Review-Url: https://codereview.chromium.org/2520943002 Cr-Commit-Position: refs/heads/master@{#41172}
-
- 21 Nov, 2016 1 commit
-
-
thestig authored
Instead of directly using v8_enable_inspector_override from build_overrides/v8.gni in all the GN configs, set a v8_enable_inspector variable based on v8_enable_inspector_override and use that everywhere. This is the more common pattern seen in over projects, and reduces the need to include //build_overrides/v8.gni in many files. Review-Url: https://codereview.chromium.org/2520683002 Cr-Commit-Position: refs/heads/master@{#41156}
-
- 17 Nov, 2016 4 commits
-
-
eholk authored
With this change, WebAssembly.Memory objects have backing stores allocated as an 8GB region where everything beyond the size of the Wasm heap is inaccessible. GrowMemory is now implemented by changing the protection on the guard regions to make the new portions of the heap accessible. Guard pages are not enabled by default, but this change adds a flag and a test variant to make sure we get test coverage on them. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5277 Review-Url: https://codereview.chromium.org/2396433008 Cr-Commit-Position: refs/heads/master@{#41089}
-
clemensh authored
TBR=ahaas@chromium.org, kozyatinskiy@chromium.org NOTRY=true NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2503213004 Cr-Commit-Position: refs/heads/master@{#41069}
-
clemensh authored
The test just prints the source text of each line on the stack. Look how beautiful it reads \o/ BUG=chromium:659715 R=yangguo@chromium.org, kozyatinskiy@chromium.org CC=titzer@chromium.org Review-Url: https://codereview.chromium.org/2492123003 Cr-Commit-Position: refs/heads/master@{#41068}
-
kozyatinskiy authored
Inspector uses this type for all internal scripts, e.g. injected-script-source.js. Scripts with new type are not reported by remote debugging protocol, frames from them are ignored. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel BUG=none R=yangguo@chromium.org,dgozman@chromium.org Review-Url: https://codereview.chromium.org/2499273003 Cr-Commit-Position: refs/heads/master@{#41056}
-
- 16 Nov, 2016 1 commit
-
-
clemensh authored
This allows to show wasm source (disassembled wasm code) in DevTools. See design doc for details. More tests for the disassembly will have to follow. Also, the text format (generated by V8) will be changed. BUG=chromium:659715 R=yangguo@chromium.org, kozyatinskiy@chromium.org, titzer@chromium.org, dgozman@chromium.org Review-Url: https://codereview.chromium.org/2493773003 Cr-Commit-Position: refs/heads/master@{#41055}
-
- 15 Nov, 2016 1 commit
-
-
clemensh authored
Before, we allocated one script per function per instance, and each script referenced the wasm instance and the function index. Now we only allocate one script per compiled wasm module, so the script also only references this WasmCompiledModule, which causes changes to many interfaces. Instead of fixing the disassemble API only used via debug.js, I decided to drop it for now. Some later CL will reintroduce it via DebugInterface. BUG=v8:5530,chromium:659715 R=yangguo@chromium.org, titzer@chromium.org CC=jgruber@chromium.org Review-Url: https://codereview.chromium.org/2493823003 Cr-Commit-Position: refs/heads/master@{#41004}
-
- 14 Nov, 2016 1 commit
-
-
yangguo authored
We are removing use of the debugger context. When the debugger triggers compilation, we may not have a context from which to create a JSArray. R=ishell@chromium.org BUG=chromium:664577 Review-Url: https://codereview.chromium.org/2479123002 Cr-Commit-Position: refs/heads/master@{#40956}
-
- 11 Nov, 2016 1 commit
-
-
yangguo authored
R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2492713005 Cr-Commit-Position: refs/heads/master@{#40934}
-
- 10 Nov, 2016 3 commits
-
-
yangguo authored
Revert of Compiling an array literal should be context-independent. (patchset #5 id:80001 of https://codereview.chromium.org/2479123002/ ) Reason for revert: speculative revert to fix https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Mac%20GC%20Stress/builds/9646/steps/Mjsunit%20%28flakes%29/logs/debug-scopes Original issue's description: > Compiling an array literal should be context-independent. > > We are removing use of the debugger context. When the debugger triggers > compilation, we may not have a context from which to create a JSArray. > > R=ishell@chromium.org TBR=ishell@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2481363009 Cr-Commit-Position: refs/heads/master@{#40906}
-
yangguo authored
We are removing use of the debugger context. When the debugger triggers compilation, we may not have a context from which to create a JSArray. R=ishell@chromium.org Review-Url: https://codereview.chromium.org/2479123002 Cr-Commit-Position: refs/heads/master@{#40884}
-
jgruber authored
This adds information about an exception's caught/uncaught status to the Runtime.paused event in the data parameter: { "method": "Debugger.paused", "params": { "callFrames": [ [...] ], "data": { "description": "666", "type": "number", "uncaught": true, <--- "value": 666 }, "hitBreakpoints": [], "reason": "exception" } } BUG=v8:5530 Review-Url: https://codereview.chromium.org/2488733003 Cr-Commit-Position: refs/heads/master@{#40875}
-
- 09 Nov, 2016 1 commit
-
-
kozyatinskiy authored
Currently function like "() => 239" contains offset 3 as begin of function and 8 as end of function. This CL changes this to 6 and 9 respectively. BUG=chromium:566801 R=yangguo@chromium.org,dgozman@chromium.org TBR=adamk@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2488493003 Cr-Commit-Position: refs/heads/master@{#40864}
-
- 04 Nov, 2016 4 commits
-
-
kozyatinskiy authored
This method iterates through all shared function info which are related to passed script, compiles debug code for SFI in range if needed and returns possible break locations. BUG=chromium:566801 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2465553003 Cr-Commit-Position: refs/heads/master@{#40783}
-
yangguo authored
The old code path is going to be removed with the debug context api. R=kozyatinskiy@chromium.org Review-Url: https://codereview.chromium.org/2465833002 Cr-Commit-Position: refs/heads/master@{#40768}
-
machenbach authored
Revert of [debugger] simplify fetching scripts for inspector. (patchset #6 id:100001 of https://codereview.chromium.org/2465833002/ ) Reason for revert: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/11118 Rule of thumb: As long as the tests have not migrated yet, you most certainly need a blink rebase whenever you change expectations. Original issue's description: > [debugger] simplify fetching scripts for inspector. > > The old code path is going to be removed with the debug context api. > > R=kozyatinskiy@chromium.org TBR=kozyatinskiy@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2473273005 Cr-Commit-Position: refs/heads/master@{#40764}
-
yangguo authored
The old code path is going to be removed with the debug context api. R=kozyatinskiy@chromium.org Review-Url: https://codereview.chromium.org/2465833002 Cr-Commit-Position: refs/heads/master@{#40759}
-
- 01 Nov, 2016 1 commit
-
-
kozyatinskiy authored
This roll includes one change: "[inspector_protocol] support fall through and moveable Maybe" [1]. [1] https://codereview.chromium.org/2468923002/ BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2469063002 Cr-Commit-Position: refs/heads/master@{#40687}
-
- 29 Oct, 2016 1 commit
-
-
kozyatinskiy authored
* Introduced DebugInterface::Script - native wrapper on internal::Script. * Migrated getCompildScripts and scriptParsed to native wrapper. BUG=chromium:652939, v8:5510 R=yangguo@chromium.org,dgozman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2449213002 Cr-Commit-Position: refs/heads/master@{#40660}
-
- 28 Oct, 2016 1 commit
-
-
clemensh authored
In the asm.js to wasm pipeline, we generate an entry function with BUILTIN code, but still attached to a TYPE_NORMAL script. This fix avoids trying to set a breakpoint there, resulting in a crash on DCHECK(shared->HasDebugInfo()). Also add two inspector tests to track regressions. BUG=v8:5568 R=titzer@chromium.org,mstarzinger@chromium.org Review-Url: https://codereview.chromium.org/2457433002 Cr-Commit-Position: refs/heads/master@{#40633}
-
- 26 Oct, 2016 1 commit
-
-
rob authored
BUG=657568 TEST=Manually, see bug report Review-Url: https://codereview.chromium.org/2432163004 Cr-Commit-Position: refs/heads/master@{#40605}
-
- 25 Oct, 2016 1 commit
-
-
kozyatinskiy authored
To achieve this: - fixed crash on windows - String16::fromInteger used "%zu" which doesn't support by VS2013 compiler, wrapped with ifdef else. - fixed asan for d8 - unique_ptr on array has single element type. - force Debugger.disable at the end of test. BUG=chromium:635948 R=dgozman@chromium.org,yangguo@chromium.org,machenbach@chromium.org Review-Url: https://codereview.chromium.org/2450653002 Cr-Commit-Position: refs/heads/master@{#40546}
-
- 24 Oct, 2016 1 commit
-
-
yangguo authored
R=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2424313004 Cr-Commit-Position: refs/heads/master@{#40528}
-
- 20 Oct, 2016 1 commit
-
-
hablich authored
Revert of [inspector] align console implementation with spec (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/2428473003/ ) Reason for revert: Breaks roll: https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/164610 See https://chromiumcodereview.appspot.com/2434733002/ for more context Original issue's description: > [inspector] align console implementation with spec > > console should be non enumerable. > > BUG=chromium:656826 > R=dgozman@chromium.org TBR=dgozman@chromium.org,kozyatinskiy@chromium.org NOTRY=true BUG=chromium:656826 Review-Url: https://chromiumcodereview.appspot.com/2435013002 Cr-Commit-Position: refs/heads/master@{#40464}
-