1. 13 Dec, 2016 1 commit
  2. 07 Dec, 2016 2 commits
  3. 06 Dec, 2016 1 commit
    • clemensh's avatar
      [inspector] Introduce debug::WasmScript · 12cdb31b
      clemensh authored
      *and* report all "virtual" wasm scripts right when the wasm script is
      registered at the inspector.
      
      WasmScript is a subtype of Script, with the cast checking that it is
      actually a wasm script.
      This layout makes it quite easy to implement functionality that is only
      available for wasm scripts, and allows to later directly use the
      WasmCompiledModule instead of the i::Script for backing the
      debug::WasmScript. We might also add virtual methods to
      provide different implementations for GetSourcePosition, Source and
      others.
      
      DisassembleWasmFunction now also becomes a method of this class instead
      of a static function on the DebugInterface.
      
      The WasmTranslation now uses the new WasmScript type instead of the
      Script wrapper, and also registers all virtual wasm scripts immediately
      when the wasm script is made public to the inspector (when the wasm
      module is created).
      
      R=yangguo@chromium.org,dgozman@chromium.org,titzer@chromium.org
      BUG=chromium:613110,chromium:659715
      
      Review-Url: https://codereview.chromium.org/2531163010
      Cr-Commit-Position: refs/heads/master@{#41519}
      12cdb31b
  4. 02 Dec, 2016 1 commit
  5. 01 Dec, 2016 1 commit
  6. 29 Nov, 2016 1 commit
  7. 24 Nov, 2016 4 commits
  8. 23 Nov, 2016 4 commits
  9. 22 Nov, 2016 1 commit
    • clemensh's avatar
      [wasm] Implement official wasm text format · 172f5012
      clemensh authored
      When disassembling functions for the inspector, we used an internal
      text representation before. This CL implements the official text
      format like it is understood by the spec interpreter.
      
      Example output:
      func $main (param i32) (result i32)
      block i32
        get_local 0
        i32.const 2
        i32.lt_u
        if
          i32.const -2
          return
        end
        get_local 0
        call_indirect 0
      end
      
      R=rossberg@chromium.org, titzer@chromium.org
      BUG=chromium:659715
      
      Review-Url: https://codereview.chromium.org/2520943002
      Cr-Commit-Position: refs/heads/master@{#41172}
      172f5012
  10. 21 Nov, 2016 1 commit
    • thestig's avatar
      Properly define v8_enable_inspector and its override in GN. · ae0e9221
      thestig authored
      Instead of directly using v8_enable_inspector_override from
      build_overrides/v8.gni in all the GN configs, set a v8_enable_inspector
      variable based on v8_enable_inspector_override and use that everywhere.
      This is the more common pattern seen in over projects, and reduces the
      need to include //build_overrides/v8.gni in many files.
      
      Review-Url: https://codereview.chromium.org/2520683002
      Cr-Commit-Position: refs/heads/master@{#41156}
      ae0e9221
  11. 17 Nov, 2016 4 commits
  12. 16 Nov, 2016 1 commit
    • clemensh's avatar
      [inspector] Introduce translation of wasm frames · d4a42a5f
      clemensh authored
      This allows to show wasm source (disassembled wasm code) in DevTools.
      See design doc for details.
      
      More tests for the disassembly will have to follow. Also, the text
      format (generated by V8) will be changed.
      
      BUG=chromium:659715
      R=yangguo@chromium.org, kozyatinskiy@chromium.org, titzer@chromium.org, dgozman@chromium.org
      
      Review-Url: https://codereview.chromium.org/2493773003
      Cr-Commit-Position: refs/heads/master@{#41055}
      d4a42a5f
  13. 15 Nov, 2016 1 commit
    • clemensh's avatar
      [wasm] Allocate a single script per wasm module · 32077e01
      clemensh authored
      Before, we allocated one script per function per instance, and each
      script referenced the wasm instance and the function index. Now we only
      allocate one script per compiled wasm module, so the script also only
      references this WasmCompiledModule, which causes changes to many interfaces.
      
      Instead of fixing the disassemble API only used via debug.js, I decided
      to drop it for now. Some later CL will reintroduce it via
      DebugInterface.
      
      BUG=v8:5530,chromium:659715
      R=yangguo@chromium.org, titzer@chromium.org
      CC=jgruber@chromium.org
      
      Review-Url: https://codereview.chromium.org/2493823003
      Cr-Commit-Position: refs/heads/master@{#41004}
      32077e01
  14. 14 Nov, 2016 1 commit
  15. 11 Nov, 2016 1 commit
  16. 10 Nov, 2016 3 commits
  17. 09 Nov, 2016 1 commit
  18. 04 Nov, 2016 4 commits
  19. 01 Nov, 2016 1 commit
  20. 29 Oct, 2016 1 commit
  21. 28 Oct, 2016 1 commit
    • clemensh's avatar
      Fix detection of BUILTIN functions · 1cac34ed
      clemensh authored
      In the asm.js to wasm pipeline, we generate an entry function with
      BUILTIN code, but still attached to a TYPE_NORMAL script.
      This fix avoids trying to set a breakpoint there, resulting in a crash
      on DCHECK(shared->HasDebugInfo()).
      
      Also add two inspector tests to track regressions.
      
      BUG=v8:5568
      R=titzer@chromium.org,mstarzinger@chromium.org
      
      Review-Url: https://codereview.chromium.org/2457433002
      Cr-Commit-Position: refs/heads/master@{#40633}
      1cac34ed
  22. 26 Oct, 2016 1 commit
  23. 25 Oct, 2016 1 commit
    • kozyatinskiy's avatar
      [inspector] enable inspector by default · d7a18896
      kozyatinskiy authored
      To achieve this:
      - fixed crash on windows - String16::fromInteger used "%zu" which doesn't support by VS2013 compiler, wrapped with ifdef else.
      - fixed asan for d8 - unique_ptr on array has single element type.
      - force Debugger.disable at the end of test.
      
      BUG=chromium:635948
      R=dgozman@chromium.org,yangguo@chromium.org,machenbach@chromium.org
      
      Review-Url: https://codereview.chromium.org/2450653002
      Cr-Commit-Position: refs/heads/master@{#40546}
      d7a18896
  24. 24 Oct, 2016 1 commit
  25. 20 Oct, 2016 1 commit