1. 29 Apr, 2019 1 commit
    • Clemens Hammacher's avatar
      [cleanup] Use Vector::begin instead of Vector::start · 4b0f9c85
      Clemens Hammacher authored
      Our {Vector} template provides both {start} and {begin} methods. They
      return exactly the same value. Since the {begin} method is needed for
      iteration, and is also what standard containers provide, this CL
      switches all uses of the {start} method to use {begin} instead.
      
      Patchset 1 was auto-generated by using this clang AST matcher:
          callExpr(
              callee(
                cxxMethodDecl(
                  hasName("start"),
                  ofClass(hasName("v8::internal::Vector")))
              ),
              argumentCountIs(0))
      
      Patchset 2 was created by running clang-format. Patchset 3 then
      removes the now unused {Vector::start} method.
      
      R=jkummerow@chromium.org
      TBR=mstarzinger@chromium.org,yangguo@chromium.org,verwaest@chromium.org
      
      Bug: v8:9183
      Change-Id: Id9f01c92870872556e2bb3f6d5667463b0e3e5c6
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587381Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61081}
      4b0f9c85
  2. 27 Feb, 2019 1 commit
  3. 15 Feb, 2019 1 commit
    • Toon Verwaest's avatar
      [parser] Fix escaped contextual keyword handling · a94c91ca
      Toon Verwaest authored
      Escaped contextual keywords are simply valid identifiers if they do not occur
      in the context where they are a keyword. Escape sequences of the form \uNNNN
      or \u{NNNNNN} must be consumed as part of the identifier.
      
      If such escaped contextual keywords do occur in a context where they are a
      keyword, they are a syntax error. In that case we manually check locally
      whether they are escaped.
      
      Bug: v8:6543, v8:6541
      
      Change-Id: I7e1557963883e722310b9078d7d7636ec94aa603
      Reviewed-on: https://chromium-review.googlesource.com/c/1473293Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Commit-Queue: Toon Verwaest <verwaest@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59628}
      a94c91ca
  4. 26 Nov, 2018 2 commits
  5. 23 Nov, 2018 1 commit
  6. 22 Nov, 2018 1 commit
  7. 21 Nov, 2018 1 commit
    • Toon Verwaest's avatar
      Revert "[parser] Use memcmp for keyword checks" · 8da2afaa
      Toon Verwaest authored
      This reverts commit 5616f91a.
      
      Reason for revert: Tanks performance on codeload/ia32 by >1%
      
      Original change's description:
      > [parser] Use memcmp for keyword checks
      > 
      > Small readability increase for the keyword check magic, using memcmp
      > instead of a chain of raw comparisons. Could allow better codegen for
      > memcmp-aware compilers, though in practice seems to have little effect
      > on generated code.
      > 
      > Change-Id: I91020fe67cebc9270c61c4c678e15217e436afff
      > Reviewed-on: https://chromium-review.googlesource.com/c/1340291
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#57595}
      
      TBR=leszeks@chromium.org,verwaest@chromium.org
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Change-Id: Ifd4070efb3e692eb70e5d8b3adb04d7d7e45ef0e
      Reviewed-on: https://chromium-review.googlesource.com/c/1345994Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Commit-Queue: Toon Verwaest <verwaest@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57665}
      8da2afaa
  8. 20 Nov, 2018 1 commit
  9. 19 Nov, 2018 1 commit
  10. 14 Nov, 2018 5 commits
  11. 13 Nov, 2018 8 commits
  12. 12 Nov, 2018 1 commit
  13. 09 Nov, 2018 2 commits
  14. 29 Oct, 2018 1 commit
  15. 22 Oct, 2018 1 commit
  16. 04 Sep, 2018 1 commit
  17. 03 Sep, 2018 1 commit
    • Yang Guo's avatar
      Revert "[scanner] Inlining ScanIdentifier and Token check" · 29e1d399
      Yang Guo authored
      This reverts commit 5bbd1921.
      
      Reason for revert: Tentative revert for crbug.com/879988
      
      TBR=sattlerf@chromium.org,verwaest@chromium.org
      
      Original change's description:
      > [scanner] Inlining ScanIdentifier and Token check
      >
      > This improves parse time for code-load and other benchmarks.
      >
      > Bug: v8:7926
      > Change-Id: I9c8017f2e7f73dd952c025db5abe8e4062e6ef9b
      > Reviewed-on: https://chromium-review.googlesource.com/1196506
      > Commit-Queue: Florian Sattler <sattlerf@google.com>
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#55521}
      
      TBR=marja@chromium.org,verwaest@chromium.org,sattlerf@google.com
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: v8:7926, chromium:879988
      Change-Id: Ic71d9cf63b69c0f9560851259f434b02cc082417
      Reviewed-on: https://chromium-review.googlesource.com/1202086
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55592}
      29e1d399
  18. 30 Aug, 2018 2 commits
  19. 29 Aug, 2018 3 commits
  20. 28 Aug, 2018 2 commits
  21. 24 Aug, 2018 1 commit
  22. 21 Aug, 2018 1 commit
    • Toon Verwaest's avatar
      [scanner] Go back to untemplatized scanning with buffering · fcfd995a
      Toon Verwaest authored
      This reverts the following 3 CLs:
      
      Revert "[scanner] Templatize scan functions by encoding"
      Revert "[asm] Remove invalid static cast of character stream"
      Revert "[scanner] Prepare CharacterStreams for specializing scanner and parser by character type"
      
      The original idea behind this work was to avoid copying, converting and
      buffering characters to be scanned by specializing the scanner functions. The
      additional benefit was for scanner functions to have a bigger window over the
      input. Even though we can get a pretty nice speedup from having a larger
      window, in practice this rarely helps. The cost is a larger binary.
      
      Since we can't eagerly convert utf8 to utf16 due to memory overhead, we'd also
      need to have a specialized version of the scanner just for utf8. That's pretty
      complex, and likely won't be better than simply bulk converting and buffering
      utf8 as utf16.
      
      Change-Id: Ic3564683932a0097e3f9f51cd88f62c6ac879dcb
      Reviewed-on: https://chromium-review.googlesource.com/1183190Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
      Commit-Queue: Toon Verwaest <verwaest@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55258}
      fcfd995a
  23. 20 Aug, 2018 1 commit