- 27 Sep, 2017 7 commits
-
-
Clemens Hammacher authored
There was an issue with passing float32 parameters, if the value was spilled on the stack and passed as stack parameter. First, we sometimes reduced the stack pointer by 8 bytes instead of 4, and second, there was a mismatch between movsd and movss. R=titzer@chromium.org Bug: chromium:718858 Change-Id: Ia884df369ddd95adeff3733f9715f589996f0b65 Also-By: ahaas@chromium.org Reviewed-on: https://chromium-review.googlesource.com/684738Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48181}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I03fb9ae37a7950fdb8a819383b114dfc2c13d618 Reviewed-on: https://chromium-review.googlesource.com/686914Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48180}
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org Bug: 747960 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: I0cab4da0bb6070e43e636fe9b5f2991f31b93d35 Reviewed-on: https://chromium-review.googlesource.com/686815 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#48179}
-
Michael Starzinger authored
This reverts commit 9d3c4b4b. Reason for revert: Breaks cctest/test-debug/NoBreakWhenBootstrapping in no-snap mode. Original change's description: > [turbofan] Implement lowering of {JSCreateClosure}. > > This adds support for inline allocation of {JSFunction} objects as part > of closures instantiation for {JSCreateClosure} nodes. The lowering is > limited to instantiation sites which have already seen more than one > previous instantiation, this avoids the need to increment the respective > counter. > > R=jarin@chromium.org > > Change-Id: I462c557453fe58bc5f09020a3d5ebdf11c2ea68b > Reviewed-on: https://chromium-review.googlesource.com/594287 > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48176} TBR=mstarzinger@chromium.org,jarin@chromium.org Change-Id: Id52281f6a3c0b7c2603053ecf002777d5b0d6f1f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/686534Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48178}
-
Martyn Capewell authored
Abstract some stack slot copies through a macro assembler function. This eliminates some non-paired stack operations. Bug: v8:6644 Change-Id: Icaa3ebb1bec42587ad461bd548a4225c7b4e5d15 Reviewed-on: https://chromium-review.googlesource.com/685238Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Cr-Commit-Position: refs/heads/master@{#48177}
-
Michael Starzinger authored
This adds support for inline allocation of {JSFunction} objects as part of closures instantiation for {JSCreateClosure} nodes. The lowering is limited to instantiation sites which have already seen more than one previous instantiation, this avoids the need to increment the respective counter. R=jarin@chromium.org Change-Id: I462c557453fe58bc5f09020a3d5ebdf11c2ea68b Reviewed-on: https://chromium-review.googlesource.com/594287 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#48176}
-
Benedikt Meurer authored
Bug: chromium:768367, v8:6819, v8:6820, v8:6831 Change-Id: I90538217f794c91a83ae5cfb12e0d0347d5f8574 Reviewed-on: https://chromium-review.googlesource.com/685240Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48175}
-
- 26 Sep, 2017 23 commits
-
-
Jakob Kummerow authored
- Move things to conversions.cc that don't need to be in headers - Turn InternalStringToInt into a subclassable helper class so we can re-use it for BigInt.parseInt - Bonus: play a round of IWYU with all the .cc files who thought that #including conversions-inl.h would give them nice Unicode things Bug: v8:6791 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I64022543a9b83002e2b78416c7e87b40a1a016e6 Reviewed-on: https://chromium-review.googlesource.com/673725 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#48174}
-
Jakob Kummerow authored
This CL teaches the respective bytecode handlers and standalone stubs about BigInts, and collects "kBigInt" feedback for them. However, Turbofan does not yet care about such feedback, so it is simply converted to "any" for now (making TF emit stub calls for BigInt operations). Bug: v8:6791 Change-Id: I6440c108ccd79058d77adc2a6041251db9d5f81d Reviewed-on: https://chromium-review.googlesource.com/683758Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#48173}
-
Jakob Kummerow authored
This is a reland of r48152 / 2f88c9b2, originally reviewed on https://chromium-review.googlesource.com/678037, with a small fix for Clang on Windows. TBR=littledan@chromium.org Bug: v8:6791 Change-Id: I70bc950f82682f40486540d2ac6e10540888d663 Reviewed-on: https://chromium-review.googlesource.com/685255Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#48172}
-
Michael Achenbach authored
This reverts commit e0b76c9a. Reason for revert: Changes layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/18522 See also: https://github.com/v8/v8/wiki/Blink-layout-tests Original change's description: > Add fast path to ObjectGetOwnPropertyDescriptor > > Bug: v8:6557 > Change-Id: I384e9f36058c73d40be1faf5ae1bf8c01d068f0e > Reviewed-on: https://chromium-review.googlesource.com/682059 > Commit-Queue: Maya Lekova <mslekova@google.com> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48166} TBR=ishell@chromium.org,mslekova@google.com Change-Id: I27aa52786f79dd617faea6336df684821c1720d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6557 Reviewed-on: https://chromium-review.googlesource.com/685314Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48171}
-
Clemens Hammacher authored
With --trace-wasm-decoder, we were printing the local variable index for values on the stack generated by get_local instructions. This CL adds the same feature for globals. R=titzer@chromium.org Change-Id: Ie113ebcc2d1abcd67df2d01bf4bdb452635732c8 Reviewed-on: https://chromium-review.googlesource.com/684737Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48170}
-
Michael Starzinger authored
This fixes the signature of "Math.abs" from "(signed) -> signed" to "(signed) -> unsigned" and hence fixes cases where the absolute value would overflow the range of signed 32-bit values. This is in sync with spec erratas (and ECMAScript semantics). Note that this also switches the underlying implementation of the above absolute value function to a branch-free version. R=clemensh@chromium.org TEST=mjsunit/regress/regress-6838-3 BUG=v8:6838 Change-Id: Ib13b7ecd336ae386cbde7c574e727bf52f841e00 Reviewed-on: https://chromium-review.googlesource.com/684181 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48169}
-
Andreas Haas authored
With this CL we use the same optimizations for the trap handler ool code which we already use for trap-if. * Call a builtin instead of calling the runtime directly. * Use one call per ool code instead of a source position parameter. * Do not pass the trap reason as parameter. R=titzer@chromium.org, eholk@chromium.org Change-Id: Ieef6da96f340269c3e91efd21ac24e61a42193f4 Reviewed-on: https://chromium-review.googlesource.com/684436Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#48168}
-
Tobias Tebbi authored
Bug: Change-Id: I52e757aa2de951ff40660545472321c7dec84241 Reviewed-on: https://chromium-review.googlesource.com/632156Reviewed-by: Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#48167}
-
Maya Lekova authored
Bug: v8:6557 Change-Id: I384e9f36058c73d40be1faf5ae1bf8c01d068f0e Reviewed-on: https://chromium-review.googlesource.com/682059 Commit-Queue: Maya Lekova <mslekova@google.com> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#48166}
-
Marja Hölttä authored
Follow up to https://chromium-review.googlesource.com/671020 We still didn't return the correct amount of invalid characters, according to the Encoding spec ( https://encoding.spec.whatwg.org/#utf-8-decoder ), when we saw a byte sequence which was as start of an overlong / invalid sequence, but there weren't enough continuation bytes. A more rigorous test will follow in https://chromium-review.googlesource.com/c/v8/v8/+/681217 BUG=chromium:765608 Change-Id: I535670edc14d3bae144e5a9ca373f12eec78a934 Reviewed-on: https://chromium-review.googlesource.com/681674 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48165}
-
Yang Guo authored
This is a reland of 629406d1 Original change's description: > [snapshot] include version string in the startup snapshot. > > This is to easier diagnose build issues involving the snapshot. > Sample error message for mismatching snapshot: > > # > # Fatal error in ../../src/snapshot/snapshot-common.cc, line 286 > # Version mismatch between V8 binary and snapshot. > # V8 binary version: 6.3.1 (candidate) > # Snapshot version: 6.3.0 (candidate) > # The snapshot consists of 2820444 bytes and contains 1 contexts. > # > > > R=machenbach@chromium.org > > Bug: chromium:764327 > Change-Id: Icdc7aeac77819b113985b424feda814a072d5406 > Reviewed-on: https://chromium-review.googlesource.com/684295 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48161} Bug: chromium:764327 Change-Id: I3721689824e0a6909eede86d0829dc258ae40c4d Reviewed-on: https://chromium-review.googlesource.com/684494Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48164}
-
Tobias Tebbi authored
On big endian 64 bit architectures, kHashFieldOffset is not word-aligned. This breaks the assumption in escape analysis that all fields are word-aligned. Fix this by not dematerializing such objects. Alternative fix for https://chromium-review.googlesource.com/c/v8/v8/+/681335 Change-Id: I7d8e4c7934d9306cc06a614ae110e7cf7235394f Reviewed-on: https://chromium-review.googlesource.com/681714 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#48163}
-
Yang Guo authored
This reverts commit 629406d1. Reason for revert: cross platform builds break. Original change's description: > [snapshot] include version string in the startup snapshot. > > This is to easier diagnose build issues involving the snapshot. > Sample error message for mismatching snapshot: > > # > # Fatal error in ../../src/snapshot/snapshot-common.cc, line 286 > # Version mismatch between V8 binary and snapshot. > # V8 binary version: 6.3.1 (candidate) > # Snapshot version: 6.3.0 (candidate) > # The snapshot consists of 2820444 bytes and contains 1 contexts. > # > > > R=machenbach@chromium.org > > Bug: chromium:764327 > Change-Id: Icdc7aeac77819b113985b424feda814a072d5406 > Reviewed-on: https://chromium-review.googlesource.com/684295 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48161} TBR=machenbach@chromium.org,yangguo@chromium.org Change-Id: I35a9b575e4f7fe5c45c9dc6f9e774c3e6d30049c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:764327 Reviewed-on: https://chromium-review.googlesource.com/684315Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48162}
-
Yang Guo authored
This is to easier diagnose build issues involving the snapshot. Sample error message for mismatching snapshot: # # Fatal error in ../../src/snapshot/snapshot-common.cc, line 286 # Version mismatch between V8 binary and snapshot. # V8 binary version: 6.3.1 (candidate) # Snapshot version: 6.3.0 (candidate) # The snapshot consists of 2820444 bytes and contains 1 contexts. # R=machenbach@chromium.org Bug: chromium:764327 Change-Id: Icdc7aeac77819b113985b424feda814a072d5406 Reviewed-on: https://chromium-review.googlesource.com/684295Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48161}
-
Yang Guo authored
- Add kProduceExhaustiveCodeCache to v8::ScriptCompiler::CompileOptions to request eager compilation to add as much as possible to the code cache for the script. - Repurpose ParseInfo::kLazy flag. - Remove ParseInfo::kDebug flag. - Remove --serialize-toplevel as it has become obsolete. R=marja@chromium.org Bug: chromium:768705 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ife14f7a1d1c02e525f0b9dbfd2452013d67c7167 Reviewed-on: https://chromium-review.googlesource.com/684019 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#48160}
-
Andreas Haas authored
NOTRY=true R=clemensh@chromium.org Change-Id: I1d4d2eee771103a91f0b4878056b8cd72e06337c Reviewed-on: https://chromium-review.googlesource.com/684077Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#48159}
-
Andreas Haas authored
In the test-run-wasm and test-run-wasm-64 cctests it is not possible to call runtime functions. To test traps in these cctests we therefore replace the runtime call with a call to a c-callback, followed by a return. This CL fixes the problem that the return did not clean up stack parameters. This CL unblocks https://chromium-review.googlesource.com/c/v8/v8/+/671008. Originally I wanted to mitigate the problem in that CL by defining an additional parameter register for arm. However, adding additional parameter registers lets other tests fail. R=titzer@chromium.org, rodolph.perfetta@arm.com CC=enricobacis@google.com Bug: v8:6858 Change-Id: Ia8de73b70a0677ca4d379ed5b16272faee92a78d Reviewed-on: https://chromium-review.googlesource.com/684017Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#48158}
-
Michael Achenbach authored
This reverts commit 2f88c9b2. Reason for revert: Specualtive, seems to break win clang compilation: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang/builds/8318 Original change's description: > [bigint] Implement Divide and Remainder > > Bug: v8:6791 > Change-Id: I5ab97feeb25da29bc76cd28088836b4f12d1d916 > Reviewed-on: https://chromium-review.googlesource.com/678037 > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Daniel Ehrenberg <littledan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48152} TBR=jkummerow@chromium.org,jarin@chromium.org,littledan@chromium.org Change-Id: I400beee84782d0ff7fa972e4188a6d2b6d39bb96 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6791 Reviewed-on: https://chromium-review.googlesource.com/684075Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48157}
-
Michael Achenbach authored
This reverts commit daca9078. Reason for revert: https://crbug.com/v8/6857 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/898597f..57716b3 > > Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/cbc33b9..f6d165d > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/e3fe21f..9a255f5 > > Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/cf5e2ed..66be66d > > TBR=machenbach@chromium.org,hablich@chromium.org > > Change-Id: I8c7a9604d7ed71f9580cc17e7c4236348983e0a9 > Reviewed-on: https://chromium-review.googlesource.com/681848 > Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> > Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48150} TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org Bug: v8:6857 Change-Id: I5fc28fb81c5b60fecefbd3324d6b1f1af85f85e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/684215Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48156}
-
Michael Achenbach authored
This reverts commit 5a5783e3. Reason for revert: https://crbug.com/v8/6857 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/57716b3..e7d7f78 > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/9a255f5..852ba76 > > TBR=machenbach@chromium.org,hablich@chromium.org > > Change-Id: I43c0f1d7286ca8ea959f2de4b78337cac9fe3f7d > Reviewed-on: https://chromium-review.googlesource.com/683735 > Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> > Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48153} TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org Bug: v8:6857 Change-Id: I52bc977eacce90247fcf25f1c641402daa940024 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/684214Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48155}
-
Ulan Degenbaev authored
After 52e8d0ab incremental marking observer is invoked ~8 times more often than before. This patch increases the allocation observer threshold for incremental marking and scales the step size based on the number of concurrent marking tasks. Bug: chromium:768664 TBR: mlippautz@chromium.org Change-Id: I0afd5dccd55f32c7f545d9c3a47edc20c6fd83db Reviewed-on: https://chromium-review.googlesource.com/683955Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#48154}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/57716b3..e7d7f78 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/9a255f5..852ba76 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I43c0f1d7286ca8ea959f2de4b78337cac9fe3f7d Reviewed-on: https://chromium-review.googlesource.com/683735Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#48153}
-
Jakob Kummerow authored
Bug: v8:6791 Change-Id: I5ab97feeb25da29bc76cd28088836b4f12d1d916 Reviewed-on: https://chromium-review.googlesource.com/678037 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#48152}
-
- 25 Sep, 2017 10 commits
-
-
Mostyn Bramley-Moore authored
This caused trouble for my downstream CI tests, even though it builds successfully in the canonical v8 tree. To be investigated properly later. Bug: chromium:746958 Change-Id: I180a5ecc51051e4eb6617180ccba787ff80bcf45 Reviewed-on: https://chromium-review.googlesource.com/682695Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com> Cr-Commit-Position: refs/heads/master@{#48151}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/898597f..57716b3 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/cbc33b9..f6d165d Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/e3fe21f..9a255f5 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/cf5e2ed..66be66d TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I8c7a9604d7ed71f9580cc17e7c4236348983e0a9 Reviewed-on: https://chromium-review.googlesource.com/681848Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#48150}
-
Eric Holk authored
Bug: v8:5277 Change-Id: I5887e2ac3742350c6cb4e5780e2c1c5d02baa34d Reviewed-on: https://chromium-review.googlesource.com/673548 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#48149}
-
Karl Schimpf authored
This is a second attempt at landing CL 644866 which was reverted by CL 667019. Extends the current implementation of WASM exceptions to be able to throw exceptions with values (not just tags). A JS typed (uint_16) array is used to hold the thrown values. This allows all WASM types to be stored (i32, i64, f32, and f64) as well as be inspected in JS. The previous CL was reverted because the WASM compiler made calls to run time functions with tagged objects, which must not be done. To fix this, all run time calls use the thread-level isolate to hold the exception being processed. Bug: v8:6577 Change-Id: I4b1ef7e2847b71a2fab8e9934a0531057db9de63 Reviewed-on: https://chromium-review.googlesource.com/677056 Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48148}
-
Mostyn Bramley-Moore authored
There is no jumbo_executable target atm, so split the cctest v8_executable target into cctest and cctest_sources. Bug: chromium:746958 Change-Id: Iec0956234d026039c4d29921170dd2f0955222ca Reviewed-on: https://chromium-review.googlesource.com/680575Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com> Cr-Commit-Position: refs/heads/master@{#48147}
-
Hans Wennborg authored
To unbreak the component build of unittests on Mac after #48124. Bug: chromium:768094 Change-Id: I0e0f4ade0e19a71554f68e7050c525376f125ae5 Reviewed-on: https://chromium-review.googlesource.com/682094Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#48146}
-
Mostyn Bramley-Moore authored
Bug: chromium:746958 Change-Id: Ia251d99ffe142fadb99fc83082683aa87676c47d Reviewed-on: https://chromium-review.googlesource.com/680574Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com> Cr-Commit-Position: refs/heads/master@{#48145}
-
Eric Holk authored
Previously, we would blindly register new handler data, leading to us leaking the old handler data. This meant we could then end up with overlapping handler data where the instruction offset and landing pads didn't line up right. Bug: v8:6841 Change-Id: Iedcd75925b8d9d59c8f9accf288cae954fdc568f Reviewed-on: https://chromium-review.googlesource.com/677632 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#48144}
-
Mostyn Bramley-Moore authored
Bug: chromium:746958 Change-Id: I81ad56e3bfbdc458c3e318927191f6c5e137c448 Reviewed-on: https://chromium-review.googlesource.com/680554Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com> Cr-Commit-Position: refs/heads/master@{#48143}
-
Michael Starzinger authored
This fixes the signatures of "Math.ceil", "Math.floor" and "Math.sqrt" from "(float?) -> float" to "(float?) -> floatish" which avoids using a resulting float value without coercing the value via explicit "fround" annotations. This ensures proper ECMAScript semantics are maintained. R=clemensh@chromium.org TEST=mjsunit/regress/regress-6838-2 BUG=v8:6838 Change-Id: Ib5821641265bc862184adb270e8dbf8c703fdfb0 Reviewed-on: https://chromium-review.googlesource.com/681694Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48142}
-