1. 11 Jun, 2021 1 commit
    • Dan Elphick's avatar
      [build] Reduce size of inline header cycles · c26965bd
      Dan Elphick authored
      This removes/replaces header includes with the aim of shrinking the
      size of the inline header cycle. Specifically before this CL, there was
      a single Strongly-Connected Component comprising 60 header files from
      src/objects and src/heap.
      
      Now there are two 2 SCCs. The src/heap SCC has 6 files and depends on
      the src/objects SCC, which has 50 files. Additionally some previously
      implicit dependencies have been added.
      
      Dependencies calculated using:
      git grep "#include \"" *.h *.cc | sed 's/:#include "/ /;s/".*$//' | \
      awk 'BEGIN {print "digraph deps {" } END {print "}"} {print "\""$1"\" -> \""$2"\""}'
      
      SCCs found using sccmap from graphviz.
      
      Also removes unused Cell::FromValueAddress method.
      
      Change-Id: Ib19d00ccd14e490ee64d57be4d99b1b3686ac32a
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2951734Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Commit-Queue: Dan Elphick <delphick@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#75103}
      c26965bd
  2. 17 Feb, 2020 1 commit
  3. 25 Nov, 2019 3 commits
  4. 22 Nov, 2019 1 commit
    • Clemens Backes's avatar
      Hash all strings as unsigned values · caf005e8
      Clemens Backes authored
      A previous CL (https://crrev.com/c/1926769) changed hashing to always
      treat the input as signed values. This causes problems, since the hash
      of a one-byte string differs the hash of the identical two-byte string.
      Hence this CL switches to treating all values as unsigned in hashing.
      
      The bug cannot easily be reproduced in v8 alone, since we would need to
      create an internalized two-byte string, which contains one-byte data.
      Blink manages to create such a string via external strings.
      
      R=jkummerow@chromium.org
      
      Bug: chromium:1025184, chromium:1027131
      Change-Id: Id41aa0e463691c02099a08c6e9d837a079c872df
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930615Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Commit-Queue: Clemens Backes <clemensb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65113}
      caf005e8
  5. 21 Nov, 2019 1 commit
  6. 18 Nov, 2019 1 commit
  7. 24 Oct, 2019 2 commits
  8. 15 Oct, 2019 1 commit
  9. 08 Oct, 2019 1 commit
  10. 23 May, 2019 2 commits
  11. 21 May, 2019 1 commit
  12. 08 May, 2019 1 commit
  13. 27 Nov, 2018 1 commit
  14. 20 Nov, 2018 1 commit
  15. 19 Nov, 2018 1 commit
  16. 30 Jul, 2018 1 commit
  17. 16 Jul, 2018 1 commit
  18. 07 May, 2018 1 commit
  19. 18 Oct, 2017 1 commit
  20. 13 Jun, 2017 1 commit
  21. 28 Apr, 2017 1 commit