1. 08 Aug, 2022 1 commit
  2. 29 Jul, 2022 1 commit
  3. 06 Jul, 2022 1 commit
  4. 31 May, 2022 1 commit
    • Joyee Cheung's avatar
      Revert "[heap] pre-populate the single_character_string_cache" · 4bdbccc3
      Joyee Cheung authored
      This reverts commit 07e11a64.
      
      Reason for revert: caused regressions and heap verification failures
      
      Bug: chromium:1330410, chromium:1330408, chromium:1330413
      
      Original change's description:
      > [heap] pre-populate the single_character_string_cache
      >
      > This simplifies the code and removes the runtime overhead of
      > spontaneously adding strings to the cache.
      >
      > Bug: v8:12718
      > Change-Id: I2ed49bd82e3baf2563eeb8f463be72c0308c52c5
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3616553
      > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
      > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
      > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
      > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
      > Commit-Queue: Joyee Cheung <joyee@igalia.com>
      > Cr-Commit-Position: refs/heads/main@{#80803}
      
      Bug: v8:12718
      Change-Id: I569fea9e34effd57c9e7c65190cf5b4ec0b0623b
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679680
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Owners-Override: Leszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#80870}
      4bdbccc3
  5. 30 May, 2022 1 commit
  6. 27 Apr, 2022 1 commit
  7. 09 Mar, 2022 1 commit
    • Camillo Bruni's avatar
      [runtime] Clean up runtime function Arguments accesses · cead6573
      Camillo Bruni authored
      Replace all CONVERT_XXX_ARG_XXX() macros from runtime-util.h with direct
      calls to Arguments or the fully expanded equivalent.
      
      - This replaces many of the hard CHECKs with DCHECK (as is common
        practice in most V8 code)
      - Instead of relying on verbose comments we now have readable code
      - Rename Arguments.::xxx_at with Arguments::xxx_value_at since these
        methods don't return the Object but rather their double/int value
      
      - Add Oddball::ToBool helper
      - Add and use v8::internal::PropertyAttributesFromInt helper
      - Add stronger DCHECK for PropertyAttributes returned in
        GetPropertyAttributesWithInterceptorInternal
      
      
      
      Bug: v8:11263
      Change-Id: I8d531857e05d19f3198753b05af28d993a391854
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497768Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#79418}
      cead6573
  8. 08 Nov, 2021 1 commit
  9. 18 Jun, 2021 1 commit
  10. 26 Apr, 2021 1 commit
  11. 01 Feb, 2021 1 commit
    • Peter Wong's avatar
      [torque] Port String.prototype.includes/indexOf and StringIndexOf · 5a2c53f9
      Peter Wong authored
      - Removed no longer used StringBuiltinAssembler methods (DispatchOnStringEncodings, PointerToStringDataAtIndex)
      - Removed no longer used Runtime functions (StringIncludes, StringIndexOf, StringIndexOfUnchecked).
      - Overall builtin code size is reduced (652 bytes on Mac x64.release build), builtin size breakdown:
      
      BEFORE
      ======
      TFS Builtin, StringIndexOf, 1092
      TFJ Builtin, StringPrototypeIncludes, 1784
      TFJ Builtin, StringPrototypeIndexOf, 1536
      Total = 4412
      
      AFTER
      =====
      TFC Builtin, StringIndexOf, 2036 (+944)
      TFJ Builtin, StringPrototypeIncludes, 1072 (-712)
      TFJ Builtin, StringPrototypeIndexOf, 652 (-884)
      Total = 3760 (-652)
      
      
      Bug: v8:8996
      Change-Id: I9a88c095e2097f7d570e58e744d6692dc524ddf4
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2660995
      Commit-Queue: Peter Wong <peter.wm.wong@gmail.com>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#72456}
      5a2c53f9
  12. 08 Dec, 2020 1 commit
  13. 04 Dec, 2020 1 commit
    • Tobias Tebbi's avatar
      [torque] uniform flattening and string access in Torque · 65d2c4b4
      Tobias Tebbi authored
      Port String::Flatten to Torque (using a fast C call for the
      non-allocating part) and provide fast and easy access to sequential
      string data in Torque: GetStringData() flattens if necessary and
      computes slices that allow direct access.
      
      Applications: String.prototype.replaceAll, String.prototype.endsWith,
        and String.prototype.beginsWith now use GetStringData() and direct
        slice access instead of the slow StringCharCodeAt and they no
        longer bail out to the runtime for flattening.
      
      Drive-by changes:
        - Expose String instance type bits as bitfields and enums in Torque.
        - Fix method lookup in Torque to include superclass methods.
        - Use char8 and char16 types in more places.
        - Allow fast C calls with void return type.
        - Add Torque macros to create subslices.
        - Add no-GC scopes to runtime functions loading external string data.
      
      
      Bug: v8:7793
      Change-Id: I763b9b24212770307c9b2fe9f070f21f65d68d58
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565515
      Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#71611}
      65d2c4b4
  14. 24 Nov, 2020 1 commit
  15. 20 Nov, 2020 1 commit
  16. 15 Nov, 2019 1 commit
  17. 17 Jun, 2019 1 commit
    • Jakob Gruber's avatar
      [regexp] Reduce public API surface · c7d57dd3
      Jakob Gruber authored
      This further reduces the number of things declared in the public
      regexp API file, currently still named jsregexp.h.
      
      * Move JSRegExp::Flags convenience functions to regexp-compiler.h.
      * Set RegExpImpl methods private if possible (these will later be
        moved to a new hidden impl class).
      * Merge RegExpEngine::CompilationResult into RegExpCompileData.
      * Move remaining RegExpEngine methods to RegExpImpl and delete
        RegExpEngine.
      * Extract RegExpGlobalCache.
      * Document a few data structures.
      
      Upcoming CLs will rename RegExpImpl to RegExp and jsregexp.h to
      regexp.h. This should then be the only header included from other
      directories.
      
      Bug: v8:9359
      Change-Id: I78c8f4cca495a2b95735a48b6181583bc3310bdf
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1662294Reviewed-by: 's avatarPeter Marshall <petermarshall@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#62218}
      c7d57dd3
  18. 23 May, 2019 2 commits
  19. 22 May, 2019 1 commit
  20. 21 May, 2019 1 commit
  21. 20 May, 2019 1 commit
  22. 17 May, 2019 2 commits
  23. 15 May, 2019 1 commit
  24. 29 Apr, 2019 1 commit
    • Clemens Hammacher's avatar
      [cleanup] Use Vector::begin instead of Vector::start · 4b0f9c85
      Clemens Hammacher authored
      Our {Vector} template provides both {start} and {begin} methods. They
      return exactly the same value. Since the {begin} method is needed for
      iteration, and is also what standard containers provide, this CL
      switches all uses of the {start} method to use {begin} instead.
      
      Patchset 1 was auto-generated by using this clang AST matcher:
          callExpr(
              callee(
                cxxMethodDecl(
                  hasName("start"),
                  ofClass(hasName("v8::internal::Vector")))
              ),
              argumentCountIs(0))
      
      Patchset 2 was created by running clang-format. Patchset 3 then
      removes the now unused {Vector::start} method.
      
      R=jkummerow@chromium.org
      TBR=mstarzinger@chromium.org,yangguo@chromium.org,verwaest@chromium.org
      
      Bug: v8:9183
      Change-Id: Id9f01c92870872556e2bb3f6d5667463b0e3e5c6
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587381Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61081}
      4b0f9c85
  25. 04 Mar, 2019 2 commits
  26. 19 Feb, 2019 1 commit
  27. 15 Feb, 2019 1 commit
  28. 07 Feb, 2019 1 commit
  29. 05 Feb, 2019 1 commit
  30. 18 Jan, 2019 1 commit
  31. 26 Dec, 2018 1 commit
  32. 05 Dec, 2018 1 commit
  33. 04 Dec, 2018 1 commit
  34. 27 Nov, 2018 1 commit
  35. 26 Nov, 2018 1 commit
  36. 25 Nov, 2018 1 commit
  37. 05 Nov, 2018 1 commit