- 25 Jul, 2016 2 commits
-
-
bgeron authored
BUG= R=danno Review-Url: https://codereview.chromium.org/2169023002 Cr-Commit-Position: refs/heads/master@{#38004}
-
bgeron authored
- Remove duplicated CSS. - Expand landing area of upload button. - Give the toolbox a transparent white background. - Make the phase-select box look nicer before file load. - Remove the margin at the top of the screen. The height of the margin was exactly the height of span#graph-toolbox, and due to the semantics of position:relative, space was reserved for it at the top of div#middle. BUG= R=danno Review-Url: https://codereview.chromium.org/2164373002 Cr-Commit-Position: refs/heads/master@{#38003}
-
- 22 Jul, 2016 2 commits
-
-
jochen authored
BUG= R=hpayer@chromium.org Review-Url: https://codereview.chromium.org/2171313002 Cr-Commit-Position: refs/heads/master@{#37979}
-
hablich authored
The auto-tag bot removes the need to handle version changes in each merge individually. As a result this 'feature' is removed. BUG=v8:4408 R=machenbach@chromium.org LOG=N NOTRY=true Review-Url: https://codereview.chromium.org/1398033003 Cr-Commit-Position: refs/heads/master@{#37972}
-
- 21 Jul, 2016 2 commits
-
-
mattloring authored
Update the custom objdump script to handle inline comments starting with '--' or ';;'. Load d8 code.asm file if present. BUG= Review-Url: https://codereview.chromium.org/2159103007 Cr-Commit-Position: refs/heads/master@{#37953}
-
machenbach authored
Helper script to generate gn arguments based on common developer defaults or builder configurations. BUG=chromium:625791 NOTRY=true Review-Url: https://codereview.chromium.org/2138693002 Cr-Commit-Position: refs/heads/master@{#37947}
-
- 20 Jul, 2016 1 commit
-
-
mattloring authored
Allows jitted code to be annotated in perf. To use: 1) Report generated code in code-(pid)-1.asm. perf record -- d8 --print-code --redirect-code-traces script.js 2) Run perf report from the directory containing the above code file. perf report --objdump=v8/tools/objdump-v8 This script supports generated code from both crankshaft or turbofan. BUG= Review-Url: https://codereview.chromium.org/2167553002 Cr-Commit-Position: refs/heads/master@{#37913}
-
- 19 Jul, 2016 1 commit
-
-
klaasb authored
This adds an additional column with percentages to the output of bytecode_dispatch_report.py --top-dispatches-for-bytecode. The percentages always represent the relative number of dispatches to the target bytecode to all dispatches from the source bytecode. The additional flag --sort-sources-relative/-r allows sorting the "Top sources of dispatches to" the given bytecode by this column to more easily find bytecodes that significantly often dispatch to the target. BUG=v8:4899 LOG=N Review-Url: https://codereview.chromium.org/2159683003 Cr-Commit-Position: refs/heads/master@{#37873}
-
- 18 Jul, 2016 1 commit
-
-
bangfu.tao authored
BUG= A bug in android-run.py, which caused the android_arm.release.check throws error: data/local/tmp/v8/test/mjsunit/wasm/function-prototype.js:7: Error loading file load("test/mjsunit/wasm/wasm-constants.js"); Review-Url: https://codereview.chromium.org/2070323002 Cr-Commit-Position: refs/heads/master@{#37825}
-
- 15 Jul, 2016 1 commit
-
-
bgeron authored
With this patch, every node in turbo-*.json has an opcode, a title, and a label. The label field is new; the opcode and title were already there. The title is for the mouseover text. The label is what will be displayed in the graph view, unless it's too long, in which case only the opcode will be displayed. (This is similar to the preexisting behaviour of putting titles in labels, except that the titles were rarely short enough to fit in a label.) With this patch, the labels generated are in practice the same as the titles we had before, except for LoadField and StoreField, which will be rendered as LoadField[[+432]] and StoreField[[+432]] (if 432 was the offset). This diff adds an overloadable method virtual void Operator1<T>::PrintParameter(ostream&, PrintVerbosity) for each type T to Operator1. Its default implementation just uses operator<<(ostream&, T const&) and adds square brackets around it, but it is overridden for FieldAccess to print "[+432]" in the example case. BUG= R=jarin,danno Review-Url: https://codereview.chromium.org/2093013002 Cr-Commit-Position: refs/heads/master@{#37795}
-
- 12 Jul, 2016 2 commits
-
-
mstarzinger authored
R=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2141013002 Cr-Commit-Position: refs/heads/master@{#37678}
-
machenbach authored
The step fails on windows. This'll help investigating why. BUG=chromium:474921 TBR=tandrii@chromium.org, vogelheim@chromium.org, jochen@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2141903002 Cr-Commit-Position: refs/heads/master@{#37675}
-
- 11 Jul, 2016 1 commit
-
-
Alexander.Gilday2 authored
This change analyzes and links the output of --code-comments in the disassembly view within turbolizer with the other views, such that selecting these comments will also select the respective blocks/lines/nodes within the other views. The block start comments (e.g. -- B4 start --) are linked with the blocks in the schedule phase view and vice versa. The source position comments (e.g. -- primes.js:3:10 --) select the respective spans, lines, and nodes in the JavaScript code view, the schedule phase view, and the other compilation phase views respectively, and vice versa. It also modifies the display of the line and column numbers in the source position comments to be offset from 1 instead of 0 and ignore the initial source position of the first line of code (from removal of the function name in the compiler). Also fixed the bug where previous selections weren't being cleared properly across multiple views, adding appropriate clear calls when using the selection broker. Review-Url: https://codereview.chromium.org/2133663002 Cr-Commit-Position: refs/heads/master@{#37627}
-
- 08 Jul, 2016 2 commits
-
-
jbudorick authored
BUG=chromium:617761 NOTRY=true Review-Url: https://codereview.chromium.org/2113453007 Cr-Commit-Position: refs/heads/master@{#37616}
-
ssanfilippo authored
Since Linux 4.1, flag -f became -F, but the long option --flags stayed the same. Using --flags assures compatibility with new and old versions. Also, symbols appear to be reported as name+offset in newer versions even when not requested, so we trim the latter part if present. BUG=v8:4899 LOG=N Review-Url: https://codereview.chromium.org/2134703002 Cr-Commit-Position: refs/heads/master@{#37614}
-
- 06 Jul, 2016 1 commit
-
-
machenbach authored
This version of the isolate_driver includes a feature that automatically derives shared libraries for inclusion. This is needed for GN as the shared library location is different compared to gyp and having different configs would be tedious. This also removes the shared-library-specific configs as they are no longer needed with the new driver. BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2123223002 Cr-Commit-Position: refs/heads/master@{#37555}
-
- 05 Jul, 2016 1 commit
-
-
jochen authored
BUG= R=cbruni@chromium.org Review-Url: https://codereview.chromium.org/2119823002 Cr-Commit-Position: refs/heads/master@{#37534}
-
- 03 Jul, 2016 1 commit
-
-
honggyu.kp authored
Since python3 does not use the old print statement, it may not be able to load gdb-v8-support.py script in gdb as below: (gdb) source tools/gdb-v8-support.py File "tools/gdb-v8-support.py", line 170 print result ^ SyntaxError: Missing parentheses in call to 'print' This fixes print statement for both python2 and python3. R=jochen@chromium.org BUG= Review-Url: https://codereview.chromium.org/2084163004 Cr-Commit-Position: refs/heads/master@{#37488}
-
- 30 Jun, 2016 3 commits
-
-
machenbach authored
Having presubmit called from within the test runner often requires logic to remove the call again. After the GN transition it would be better if presubmit is called by a wrapper script if needed at all. It is run on upload and on the tryservers anyways. BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2114653002 Cr-Commit-Position: refs/heads/master@{#37447}
-
machenbach authored
This executes an action as part of the build, writing a json configuration that includes all build flags relevant to v8 testing. The test runner will derive all build-dependent flags from the file if it detects it. BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2106423002 Cr-Commit-Position: refs/heads/master@{#37446}
-
machenbach authored
BUG=v8:5159 NOTRY=true Review-Url: https://codereview.chromium.org/2111673003 Cr-Commit-Position: refs/heads/master@{#37444}
-
- 29 Jun, 2016 4 commits
-
-
brendan.kirby authored
Occasionally tests output characters that aren't valid unicode UTF-8 characters. This causes the --json-test-results file not to be written. Replace these characters with the UTF-8 invalid character. BUG= Review-Url: https://codereview.chromium.org/2086143003 Cr-Commit-Position: refs/heads/master@{#37404}
-
ishell authored
This CL changed layout of UnseededNumberDictionary: https://codereview.chromium.org/2102073002. Review-Url: https://codereview.chromium.org/2105553006 Cr-Commit-Position: refs/heads/master@{#37398}
-
jochen authored
BUG=none R=ulan@chromium.org Review-Url: https://codereview.chromium.org/2101413002 Cr-Commit-Position: refs/heads/master@{#37365}
-
machenbach authored
TBR=hablich@chromium.org, kbr@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2106053002 Cr-Commit-Position: refs/heads/master@{#37360}
-
- 28 Jun, 2016 1 commit
-
-
machenbach authored
This avoids forgetting to add files for either gyp or gn. While for most executables, this is detected by compilation errors, for test executables, it can lead to tests silently not running. BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2098313002 Cr-Commit-Position: refs/heads/master@{#37331}
-
- 27 Jun, 2016 1 commit
-
-
mythria authored
Removes failure expectation for observer-expectations layout test. BUG=v8:4280,v8:5096 LOG=N Review-Url: https://codereview.chromium.org/2094353002 Cr-Commit-Position: refs/heads/master@{#37298}
-
- 22 Jun, 2016 2 commits
-
-
hlopko authored
BUG= LOG=no Review-Url: https://codereview.chromium.org/2085043005 Cr-Commit-Position: refs/heads/master@{#37192}
-
danno authored
Review-Url: https://codereview.chromium.org/2066313002 Cr-Commit-Position: refs/heads/master@{#37177}
-
- 21 Jun, 2016 2 commits
-
-
bgeron authored
Fixes bug 5128 in product V8. R=danno@chromium.org BUG= Review-Url: https://codereview.chromium.org/2087813002 Cr-Commit-Position: refs/heads/master@{#37146}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#37130}
-
- 16 Jun, 2016 1 commit
-
-
cbruni authored
BUG= Review-Url: https://codereview.chromium.org/2062323003 Cr-Commit-Position: refs/heads/master@{#37025}
-
- 15 Jun, 2016 1 commit
-
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#37009}
-
- 14 Jun, 2016 1 commit
-
-
mstarzinger authored
The pattern of how our source files are listed in GYP files changed, which in turn broke the parsing pattern that GCMole uses to gather a list of files to check. Only 'cctest' file were checked, 'src' files were being ignored. R=cbruni@chromium.org Review-Url: https://codereview.chromium.org/2065933002 Cr-Commit-Position: refs/heads/master@{#36962}
-
- 13 Jun, 2016 2 commits
-
-
danno authored
* The default text (placeholder) in the search box is now present. * All key events handled by turbolizer are not passed through to Chrome. Review-Url: https://codereview.chromium.org/2061713002 Cr-Commit-Position: refs/heads/master@{#36936}
-
danno authored
Fix bugs and add a few small useful features: * Fix Schedule view to properly parse schedule output and respond to switching back to graph views. * Add shorcuts for showing edges of selected nodes. - 'i' shows all inputs - 'o' shows all outputs - '1'-'9' shows all nodes nth input where 1 <= n <= 9 - 'c' shows all control inputs - 'e' shows all effect inputs * Holding the control key down when using a edge-showing shortcut toggles edge state rather the just showing. * 'a' selects all nodes in graph view. * Node selection is preserved between graph views and Schedule views. * Holding control key down when using regular expression search shows currently hidden nodes that match the regex search. * Pane expansion buttons now respond to clicks in entire button area. * Default text in regex search box makes searching more discoverable. Review-Url: https://codereview.chromium.org/2059193002 Cr-Commit-Position: refs/heads/master@{#36932}
-
- 10 Jun, 2016 4 commits
-
-
cbruni authored
BUG= Review-Url: https://codereview.chromium.org/2058003002 Cr-Commit-Position: refs/heads/master@{#36893}
-
rmcilroy authored
Remove expectations which were failing due to eager compilation now that we compile lazily in Ignition, and add intersection-observer/observer-exceptions.html which has recently started failing. BUG=v8:5096 TBR=machenbach@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2053323002 Cr-Commit-Position: refs/heads/master@{#36884}
-
cbruni authored
BUG= Review-Url: https://codereview.chromium.org/2050713002 Cr-Commit-Position: refs/heads/master@{#36883}
-
julien.gilli authored
Some post-mortem metadata constants that are not offsets to objects' properties were incorrectly defined in the accessors table. This change fixes it by moving them from the accessors table to the constants table. More background is available at https://github.com/nodejs/post-mortem/issues/27. R=danno@chromium.org,bmeurer@chromium.org BUG= Review-Url: https://codereview.chromium.org/2051563003 Cr-Commit-Position: refs/heads/master@{#36878}
-